* [PATCH] drm/i915/gt: Update PMINTRMSK holding fw
@ 2020-04-15 7:50 ` Chris Wilson
0 siblings, 0 replies; 13+ messages in thread
From: Chris Wilson @ 2020-04-15 7:50 UTC (permalink / raw)
To: intel-gfx
Cc: Chris Wilson, Francisco Jerez, Mika Kuoppala, Andi Shyti, stable
If we use a non-forcewaked write to PMINTRMSK, it does not take effect
until much later, if at all, causing a loss of RPS interrupts and no GPU
reclocking, leaving the GPU running at the wrong frequency for long
periods of time.
Reported-by: Francisco Jerez <currojerez@riseup.net>
Suggested-by: Francisco Jerez <currojerez@riseup.net>
Fixes: 35cc7f32c298 ("drm/i915/gt: Use non-forcewake writes for RPS")
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Francisco Jerez <currojerez@riseup.net>
Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Cc: Andi Shyti <andi.shyti@intel.com>
Cc: <stable@vger.kernel.org> # v5.6+
---
drivers/gpu/drm/i915/gt/intel_rps.c | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/gt/intel_rps.c b/drivers/gpu/drm/i915/gt/intel_rps.c
index 86110458e2a7..6a3505467406 100644
--- a/drivers/gpu/drm/i915/gt/intel_rps.c
+++ b/drivers/gpu/drm/i915/gt/intel_rps.c
@@ -81,13 +81,14 @@ static void rps_enable_interrupts(struct intel_rps *rps)
events = (GEN6_PM_RP_UP_THRESHOLD |
GEN6_PM_RP_DOWN_THRESHOLD |
GEN6_PM_RP_DOWN_TIMEOUT);
-
WRITE_ONCE(rps->pm_events, events);
+
spin_lock_irq(>->irq_lock);
gen6_gt_pm_enable_irq(gt, rps->pm_events);
spin_unlock_irq(>->irq_lock);
- set(gt->uncore, GEN6_PMINTRMSK, rps_pm_mask(rps, rps->cur_freq));
+ intel_uncore_write(gt->uncore,
+ GEN6_PMINTRMSK, rps_pm_mask(rps, rps->last_freq));
}
static void gen6_rps_reset_interrupts(struct intel_rps *rps)
@@ -120,7 +121,9 @@ static void rps_disable_interrupts(struct intel_rps *rps)
struct intel_gt *gt = rps_to_gt(rps);
WRITE_ONCE(rps->pm_events, 0);
- set(gt->uncore, GEN6_PMINTRMSK, rps_pm_sanitize_mask(rps, ~0u));
+
+ intel_uncore_write(gt->uncore,
+ GEN6_PMINTRMSK, rps_pm_sanitize_mask(rps, ~0u));
spin_lock_irq(>->irq_lock);
gen6_gt_pm_disable_irq(gt, GEN6_PM_RPS_EVENTS);
--
2.20.1
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [Intel-gfx] [PATCH] drm/i915/gt: Update PMINTRMSK holding fw
@ 2020-04-15 7:50 ` Chris Wilson
0 siblings, 0 replies; 13+ messages in thread
From: Chris Wilson @ 2020-04-15 7:50 UTC (permalink / raw)
To: intel-gfx; +Cc: stable, Chris Wilson
If we use a non-forcewaked write to PMINTRMSK, it does not take effect
until much later, if at all, causing a loss of RPS interrupts and no GPU
reclocking, leaving the GPU running at the wrong frequency for long
periods of time.
Reported-by: Francisco Jerez <currojerez@riseup.net>
Suggested-by: Francisco Jerez <currojerez@riseup.net>
Fixes: 35cc7f32c298 ("drm/i915/gt: Use non-forcewake writes for RPS")
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Francisco Jerez <currojerez@riseup.net>
Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Cc: Andi Shyti <andi.shyti@intel.com>
Cc: <stable@vger.kernel.org> # v5.6+
---
drivers/gpu/drm/i915/gt/intel_rps.c | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/gt/intel_rps.c b/drivers/gpu/drm/i915/gt/intel_rps.c
index 86110458e2a7..6a3505467406 100644
--- a/drivers/gpu/drm/i915/gt/intel_rps.c
+++ b/drivers/gpu/drm/i915/gt/intel_rps.c
@@ -81,13 +81,14 @@ static void rps_enable_interrupts(struct intel_rps *rps)
events = (GEN6_PM_RP_UP_THRESHOLD |
GEN6_PM_RP_DOWN_THRESHOLD |
GEN6_PM_RP_DOWN_TIMEOUT);
-
WRITE_ONCE(rps->pm_events, events);
+
spin_lock_irq(>->irq_lock);
gen6_gt_pm_enable_irq(gt, rps->pm_events);
spin_unlock_irq(>->irq_lock);
- set(gt->uncore, GEN6_PMINTRMSK, rps_pm_mask(rps, rps->cur_freq));
+ intel_uncore_write(gt->uncore,
+ GEN6_PMINTRMSK, rps_pm_mask(rps, rps->last_freq));
}
static void gen6_rps_reset_interrupts(struct intel_rps *rps)
@@ -120,7 +121,9 @@ static void rps_disable_interrupts(struct intel_rps *rps)
struct intel_gt *gt = rps_to_gt(rps);
WRITE_ONCE(rps->pm_events, 0);
- set(gt->uncore, GEN6_PMINTRMSK, rps_pm_sanitize_mask(rps, ~0u));
+
+ intel_uncore_write(gt->uncore,
+ GEN6_PMINTRMSK, rps_pm_sanitize_mask(rps, ~0u));
spin_lock_irq(>->irq_lock);
gen6_gt_pm_disable_irq(gt, GEN6_PM_RPS_EVENTS);
--
2.20.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/gt: Update PMINTRMSK holding fw
2020-04-15 7:50 ` [Intel-gfx] " Chris Wilson
(?)
@ 2020-04-15 8:32 ` Patchwork
-1 siblings, 0 replies; 13+ messages in thread
From: Patchwork @ 2020-04-15 8:32 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/gt: Update PMINTRMSK holding fw
URL : https://patchwork.freedesktop.org/series/75958/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
3f39dd53bc11 drm/i915/gt: Update PMINTRMSK holding fw
-:37: ERROR:CODE_INDENT: code indent should use tabs where possible
#37: FILE: drivers/gpu/drm/i915/gt/intel_rps.c:91:
+ GEN6_PMINTRMSK, rps_pm_mask(rps, rps->last_freq));$
-:37: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#37: FILE: drivers/gpu/drm/i915/gt/intel_rps.c:91:
+ intel_uncore_write(gt->uncore,
+ GEN6_PMINTRMSK, rps_pm_mask(rps, rps->last_freq));
-:37: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#37: FILE: drivers/gpu/drm/i915/gt/intel_rps.c:91:
+ GEN6_PMINTRMSK, rps_pm_mask(rps, rps->last_freq));$
-:48: ERROR:CODE_INDENT: code indent should use tabs where possible
#48: FILE: drivers/gpu/drm/i915/gt/intel_rps.c:126:
+ GEN6_PMINTRMSK, rps_pm_sanitize_mask(rps, ~0u));$
-:48: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#48: FILE: drivers/gpu/drm/i915/gt/intel_rps.c:126:
+ intel_uncore_write(gt->uncore,
+ GEN6_PMINTRMSK, rps_pm_sanitize_mask(rps, ~0u));
-:48: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#48: FILE: drivers/gpu/drm/i915/gt/intel_rps.c:126:
+ GEN6_PMINTRMSK, rps_pm_sanitize_mask(rps, ~0u));$
total: 2 errors, 2 warnings, 2 checks, 26 lines checked
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/i915/gt: Update PMINTRMSK holding fw
2020-04-15 7:50 ` [Intel-gfx] " Chris Wilson
(?)
(?)
@ 2020-04-15 8:48 ` Patchwork
-1 siblings, 0 replies; 13+ messages in thread
From: Patchwork @ 2020-04-15 8:48 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/gt: Update PMINTRMSK holding fw
URL : https://patchwork.freedesktop.org/series/75958/
State : warning
== Summary ==
$ make htmldocs 2>&1 > /dev/null | grep i915
/home/cidrm/kernel/Documentation/gpu/i915.rst:610: WARNING: duplicate label gpu/i915:layout, other instance in /home/cidrm/kernel/Documentation/gpu/i915.rst
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gt: Update PMINTRMSK holding fw
2020-04-15 7:50 ` [Intel-gfx] " Chris Wilson
` (2 preceding siblings ...)
(?)
@ 2020-04-15 8:55 ` Patchwork
-1 siblings, 0 replies; 13+ messages in thread
From: Patchwork @ 2020-04-15 8:55 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/gt: Update PMINTRMSK holding fw
URL : https://patchwork.freedesktop.org/series/75958/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8298 -> Patchwork_17305
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17305/index.html
Known issues
------------
Here are the changes found in Patchwork_17305 that come from known issues:
### IGT changes ###
#### Warnings ####
* igt@i915_pm_rpm@module-reload:
- fi-kbl-x1275: [SKIP][1] ([fdo#109271]) -> [FAIL][2] ([i915#62])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8298/fi-kbl-x1275/igt@i915_pm_rpm@module-reload.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17305/fi-kbl-x1275/igt@i915_pm_rpm@module-reload.html
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62
Participating hosts (48 -> 43)
------------------------------
Missing (5): fi-tgl-u fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-byt-clapper
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_8298 -> Patchwork_17305
CI-20190529: 20190529
CI_DRM_8298: 17f82f0c2857d0b442adbdb62eb44b61d0f5b775 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5589: 31962324ac86f029e2841e56e97c42cf9d572956 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_17305: 3f39dd53bc11120951a053fe97f7db5abed3a3c4 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
3f39dd53bc11 drm/i915/gt: Update PMINTRMSK holding fw
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17305/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] drm/i915/gt: Update PMINTRMSK holding fw
2020-04-15 7:50 ` [Intel-gfx] " Chris Wilson
@ 2020-04-15 11:09 ` Mika Kuoppala
-1 siblings, 0 replies; 13+ messages in thread
From: Mika Kuoppala @ 2020-04-15 11:09 UTC (permalink / raw)
To: Chris Wilson, intel-gfx; +Cc: Chris Wilson, Francisco Jerez, Andi Shyti, stable
Chris Wilson <chris@chris-wilson.co.uk> writes:
> If we use a non-forcewaked write to PMINTRMSK, it does not take effect
> until much later, if at all, causing a loss of RPS interrupts and no GPU
> reclocking, leaving the GPU running at the wrong frequency for long
> periods of time.
>
> Reported-by: Francisco Jerez <currojerez@riseup.net>
> Suggested-by: Francisco Jerez <currojerez@riseup.net>
> Fixes: 35cc7f32c298 ("drm/i915/gt: Use non-forcewake writes for RPS")
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Francisco Jerez <currojerez@riseup.net>
> Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
> Cc: Andi Shyti <andi.shyti@intel.com>
> Cc: <stable@vger.kernel.org> # v5.6+
Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/gt/intel_rps.c | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/intel_rps.c b/drivers/gpu/drm/i915/gt/intel_rps.c
> index 86110458e2a7..6a3505467406 100644
> --- a/drivers/gpu/drm/i915/gt/intel_rps.c
> +++ b/drivers/gpu/drm/i915/gt/intel_rps.c
> @@ -81,13 +81,14 @@ static void rps_enable_interrupts(struct intel_rps *rps)
> events = (GEN6_PM_RP_UP_THRESHOLD |
> GEN6_PM_RP_DOWN_THRESHOLD |
> GEN6_PM_RP_DOWN_TIMEOUT);
> -
> WRITE_ONCE(rps->pm_events, events);
> +
> spin_lock_irq(>->irq_lock);
> gen6_gt_pm_enable_irq(gt, rps->pm_events);
> spin_unlock_irq(>->irq_lock);
>
> - set(gt->uncore, GEN6_PMINTRMSK, rps_pm_mask(rps, rps->cur_freq));
> + intel_uncore_write(gt->uncore,
> + GEN6_PMINTRMSK, rps_pm_mask(rps, rps->last_freq));
> }
>
> static void gen6_rps_reset_interrupts(struct intel_rps *rps)
> @@ -120,7 +121,9 @@ static void rps_disable_interrupts(struct intel_rps *rps)
> struct intel_gt *gt = rps_to_gt(rps);
>
> WRITE_ONCE(rps->pm_events, 0);
> - set(gt->uncore, GEN6_PMINTRMSK, rps_pm_sanitize_mask(rps, ~0u));
> +
> + intel_uncore_write(gt->uncore,
> + GEN6_PMINTRMSK, rps_pm_sanitize_mask(rps, ~0u));
>
> spin_lock_irq(>->irq_lock);
> gen6_gt_pm_disable_irq(gt, GEN6_PM_RPS_EVENTS);
> --
> 2.20.1
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/gt: Update PMINTRMSK holding fw
@ 2020-04-15 11:09 ` Mika Kuoppala
0 siblings, 0 replies; 13+ messages in thread
From: Mika Kuoppala @ 2020-04-15 11:09 UTC (permalink / raw)
To: Chris Wilson, intel-gfx; +Cc: stable, Chris Wilson
Chris Wilson <chris@chris-wilson.co.uk> writes:
> If we use a non-forcewaked write to PMINTRMSK, it does not take effect
> until much later, if at all, causing a loss of RPS interrupts and no GPU
> reclocking, leaving the GPU running at the wrong frequency for long
> periods of time.
>
> Reported-by: Francisco Jerez <currojerez@riseup.net>
> Suggested-by: Francisco Jerez <currojerez@riseup.net>
> Fixes: 35cc7f32c298 ("drm/i915/gt: Use non-forcewake writes for RPS")
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Francisco Jerez <currojerez@riseup.net>
> Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
> Cc: Andi Shyti <andi.shyti@intel.com>
> Cc: <stable@vger.kernel.org> # v5.6+
Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/gt/intel_rps.c | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/intel_rps.c b/drivers/gpu/drm/i915/gt/intel_rps.c
> index 86110458e2a7..6a3505467406 100644
> --- a/drivers/gpu/drm/i915/gt/intel_rps.c
> +++ b/drivers/gpu/drm/i915/gt/intel_rps.c
> @@ -81,13 +81,14 @@ static void rps_enable_interrupts(struct intel_rps *rps)
> events = (GEN6_PM_RP_UP_THRESHOLD |
> GEN6_PM_RP_DOWN_THRESHOLD |
> GEN6_PM_RP_DOWN_TIMEOUT);
> -
> WRITE_ONCE(rps->pm_events, events);
> +
> spin_lock_irq(>->irq_lock);
> gen6_gt_pm_enable_irq(gt, rps->pm_events);
> spin_unlock_irq(>->irq_lock);
>
> - set(gt->uncore, GEN6_PMINTRMSK, rps_pm_mask(rps, rps->cur_freq));
> + intel_uncore_write(gt->uncore,
> + GEN6_PMINTRMSK, rps_pm_mask(rps, rps->last_freq));
> }
>
> static void gen6_rps_reset_interrupts(struct intel_rps *rps)
> @@ -120,7 +121,9 @@ static void rps_disable_interrupts(struct intel_rps *rps)
> struct intel_gt *gt = rps_to_gt(rps);
>
> WRITE_ONCE(rps->pm_events, 0);
> - set(gt->uncore, GEN6_PMINTRMSK, rps_pm_sanitize_mask(rps, ~0u));
> +
> + intel_uncore_write(gt->uncore,
> + GEN6_PMINTRMSK, rps_pm_sanitize_mask(rps, ~0u));
>
> spin_lock_irq(>->irq_lock);
> gen6_gt_pm_disable_irq(gt, GEN6_PM_RPS_EVENTS);
> --
> 2.20.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] drm/i915/gt: Update PMINTRMSK holding fw
2020-04-15 7:50 ` [Intel-gfx] " Chris Wilson
@ 2020-04-15 11:24 ` Andi Shyti
-1 siblings, 0 replies; 13+ messages in thread
From: Andi Shyti @ 2020-04-15 11:24 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx, Francisco Jerez, Mika Kuoppala, stable
Hi Chris,
On Wed, Apr 15, 2020 at 08:50:18AM +0100, Chris Wilson wrote:
> If we use a non-forcewaked write to PMINTRMSK, it does not take effect
> until much later, if at all, causing a loss of RPS interrupts and no GPU
> reclocking, leaving the GPU running at the wrong frequency for long
> periods of time.
>
> Reported-by: Francisco Jerez <currojerez@riseup.net>
> Suggested-by: Francisco Jerez <currojerez@riseup.net>
> Fixes: 35cc7f32c298 ("drm/i915/gt: Use non-forcewake writes for RPS")
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Francisco Jerez <currojerez@riseup.net>
> Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
> Cc: Andi Shyti <andi.shyti@intel.com>
> Cc: <stable@vger.kernel.org> # v5.6+
Reviewed-by: Andi Shyti <andi.shyti@intel.com>
Andi
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/gt: Update PMINTRMSK holding fw
@ 2020-04-15 11:24 ` Andi Shyti
0 siblings, 0 replies; 13+ messages in thread
From: Andi Shyti @ 2020-04-15 11:24 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx, stable
Hi Chris,
On Wed, Apr 15, 2020 at 08:50:18AM +0100, Chris Wilson wrote:
> If we use a non-forcewaked write to PMINTRMSK, it does not take effect
> until much later, if at all, causing a loss of RPS interrupts and no GPU
> reclocking, leaving the GPU running at the wrong frequency for long
> periods of time.
>
> Reported-by: Francisco Jerez <currojerez@riseup.net>
> Suggested-by: Francisco Jerez <currojerez@riseup.net>
> Fixes: 35cc7f32c298 ("drm/i915/gt: Use non-forcewake writes for RPS")
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Francisco Jerez <currojerez@riseup.net>
> Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
> Cc: Andi Shyti <andi.shyti@intel.com>
> Cc: <stable@vger.kernel.org> # v5.6+
Reviewed-by: Andi Shyti <andi.shyti@intel.com>
Andi
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] drm/i915/gt: Update PMINTRMSK holding fw
2020-04-15 7:50 ` [Intel-gfx] " Chris Wilson
@ 2020-04-15 19:14 ` Francisco Jerez
-1 siblings, 0 replies; 13+ messages in thread
From: Francisco Jerez @ 2020-04-15 19:14 UTC (permalink / raw)
To: Chris Wilson, intel-gfx; +Cc: Chris Wilson, Mika Kuoppala, Andi Shyti, stable
[-- Attachment #1.1: Type: text/plain, Size: 2218 bytes --]
Chris Wilson <chris@chris-wilson.co.uk> writes:
> If we use a non-forcewaked write to PMINTRMSK, it does not take effect
> until much later, if at all, causing a loss of RPS interrupts and no GPU
> reclocking, leaving the GPU running at the wrong frequency for long
> periods of time.
>
> Reported-by: Francisco Jerez <currojerez@riseup.net>
> Suggested-by: Francisco Jerez <currojerez@riseup.net>
> Fixes: 35cc7f32c298 ("drm/i915/gt: Use non-forcewake writes for RPS")
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Francisco Jerez <currojerez@riseup.net>
> Cc: Francisco Jerez <currojerez@riseup.net>
> Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
> Cc: Andi Shyti <andi.shyti@intel.com>
> Cc: <stable@vger.kernel.org> # v5.6+
> ---
> drivers/gpu/drm/i915/gt/intel_rps.c | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/intel_rps.c b/drivers/gpu/drm/i915/gt/intel_rps.c
> index 86110458e2a7..6a3505467406 100644
> --- a/drivers/gpu/drm/i915/gt/intel_rps.c
> +++ b/drivers/gpu/drm/i915/gt/intel_rps.c
> @@ -81,13 +81,14 @@ static void rps_enable_interrupts(struct intel_rps *rps)
> events = (GEN6_PM_RP_UP_THRESHOLD |
> GEN6_PM_RP_DOWN_THRESHOLD |
> GEN6_PM_RP_DOWN_TIMEOUT);
> -
> WRITE_ONCE(rps->pm_events, events);
> +
> spin_lock_irq(>->irq_lock);
> gen6_gt_pm_enable_irq(gt, rps->pm_events);
> spin_unlock_irq(>->irq_lock);
>
> - set(gt->uncore, GEN6_PMINTRMSK, rps_pm_mask(rps, rps->cur_freq));
> + intel_uncore_write(gt->uncore,
> + GEN6_PMINTRMSK, rps_pm_mask(rps, rps->last_freq));
> }
>
> static void gen6_rps_reset_interrupts(struct intel_rps *rps)
> @@ -120,7 +121,9 @@ static void rps_disable_interrupts(struct intel_rps *rps)
> struct intel_gt *gt = rps_to_gt(rps);
>
> WRITE_ONCE(rps->pm_events, 0);
> - set(gt->uncore, GEN6_PMINTRMSK, rps_pm_sanitize_mask(rps, ~0u));
> +
> + intel_uncore_write(gt->uncore,
> + GEN6_PMINTRMSK, rps_pm_sanitize_mask(rps, ~0u));
>
> spin_lock_irq(>->irq_lock);
> gen6_gt_pm_disable_irq(gt, GEN6_PM_RPS_EVENTS);
> --
> 2.20.1
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 227 bytes --]
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/gt: Update PMINTRMSK holding fw
@ 2020-04-15 19:14 ` Francisco Jerez
0 siblings, 0 replies; 13+ messages in thread
From: Francisco Jerez @ 2020-04-15 19:14 UTC (permalink / raw)
To: Chris Wilson, intel-gfx; +Cc: stable, Chris Wilson
[-- Attachment #1.1.1: Type: text/plain, Size: 2218 bytes --]
Chris Wilson <chris@chris-wilson.co.uk> writes:
> If we use a non-forcewaked write to PMINTRMSK, it does not take effect
> until much later, if at all, causing a loss of RPS interrupts and no GPU
> reclocking, leaving the GPU running at the wrong frequency for long
> periods of time.
>
> Reported-by: Francisco Jerez <currojerez@riseup.net>
> Suggested-by: Francisco Jerez <currojerez@riseup.net>
> Fixes: 35cc7f32c298 ("drm/i915/gt: Use non-forcewake writes for RPS")
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Francisco Jerez <currojerez@riseup.net>
> Cc: Francisco Jerez <currojerez@riseup.net>
> Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
> Cc: Andi Shyti <andi.shyti@intel.com>
> Cc: <stable@vger.kernel.org> # v5.6+
> ---
> drivers/gpu/drm/i915/gt/intel_rps.c | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/intel_rps.c b/drivers/gpu/drm/i915/gt/intel_rps.c
> index 86110458e2a7..6a3505467406 100644
> --- a/drivers/gpu/drm/i915/gt/intel_rps.c
> +++ b/drivers/gpu/drm/i915/gt/intel_rps.c
> @@ -81,13 +81,14 @@ static void rps_enable_interrupts(struct intel_rps *rps)
> events = (GEN6_PM_RP_UP_THRESHOLD |
> GEN6_PM_RP_DOWN_THRESHOLD |
> GEN6_PM_RP_DOWN_TIMEOUT);
> -
> WRITE_ONCE(rps->pm_events, events);
> +
> spin_lock_irq(>->irq_lock);
> gen6_gt_pm_enable_irq(gt, rps->pm_events);
> spin_unlock_irq(>->irq_lock);
>
> - set(gt->uncore, GEN6_PMINTRMSK, rps_pm_mask(rps, rps->cur_freq));
> + intel_uncore_write(gt->uncore,
> + GEN6_PMINTRMSK, rps_pm_mask(rps, rps->last_freq));
> }
>
> static void gen6_rps_reset_interrupts(struct intel_rps *rps)
> @@ -120,7 +121,9 @@ static void rps_disable_interrupts(struct intel_rps *rps)
> struct intel_gt *gt = rps_to_gt(rps);
>
> WRITE_ONCE(rps->pm_events, 0);
> - set(gt->uncore, GEN6_PMINTRMSK, rps_pm_sanitize_mask(rps, ~0u));
> +
> + intel_uncore_write(gt->uncore,
> + GEN6_PMINTRMSK, rps_pm_sanitize_mask(rps, ~0u));
>
> spin_lock_irq(>->irq_lock);
> gen6_gt_pm_disable_irq(gt, GEN6_PM_RPS_EVENTS);
> --
> 2.20.1
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 227 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/gt: Update PMINTRMSK holding fw
2020-04-15 7:50 ` [Intel-gfx] " Chris Wilson
` (6 preceding siblings ...)
(?)
@ 2020-04-16 1:40 ` Patchwork
-1 siblings, 0 replies; 13+ messages in thread
From: Patchwork @ 2020-04-16 1:40 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/gt: Update PMINTRMSK holding fw
URL : https://patchwork.freedesktop.org/series/75958/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_8298_full -> Patchwork_17305_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_17305_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_17305_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_17305_full:
### IGT changes ###
#### Possible regressions ####
* igt@perf_pmu@cpu-hotplug:
- shard-tglb: NOTRUN -> [INCOMPLETE][1]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17305/shard-tglb1/igt@perf_pmu@cpu-hotplug.html
New tests
---------
New tests have been introduced between CI_DRM_8298_full and Patchwork_17305_full:
### New IGT tests (27) ###
* igt@kms_plane_cursor@pipe-a-overlay-size-128:
- Statuses : 7 pass(s)
- Exec time: [1.65, 3.64] s
* igt@kms_plane_cursor@pipe-a-overlay-size-256:
- Statuses : 8 pass(s)
- Exec time: [1.65, 3.66] s
* igt@kms_plane_cursor@pipe-a-overlay-size-64:
- Statuses : 8 pass(s)
- Exec time: [1.65, 3.67] s
* igt@kms_plane_cursor@pipe-a-primary-size-128:
- Statuses : 8 pass(s)
- Exec time: [1.64, 3.44] s
* igt@kms_plane_cursor@pipe-a-primary-size-256:
- Statuses : 8 pass(s)
- Exec time: [1.63, 3.45] s
* igt@kms_plane_cursor@pipe-a-primary-size-64:
- Statuses : 8 pass(s)
- Exec time: [1.63, 3.43] s
* igt@kms_plane_cursor@pipe-a-viewport-size-128:
- Statuses : 8 pass(s)
- Exec time: [1.65, 3.70] s
* igt@kms_plane_cursor@pipe-a-viewport-size-256:
- Statuses : 7 pass(s)
- Exec time: [2.19, 3.69] s
* igt@kms_plane_cursor@pipe-a-viewport-size-64:
- Statuses : 8 pass(s)
- Exec time: [1.65, 3.61] s
* igt@kms_plane_cursor@pipe-b-overlay-size-128:
- Statuses : 8 pass(s)
- Exec time: [2.22, 4.87] s
* igt@kms_plane_cursor@pipe-b-overlay-size-256:
- Statuses : 8 pass(s)
- Exec time: [2.22, 4.85] s
* igt@kms_plane_cursor@pipe-b-overlay-size-64:
- Statuses : 8 pass(s)
- Exec time: [2.22, 4.83] s
* igt@kms_plane_cursor@pipe-b-primary-size-128:
- Statuses : 8 pass(s)
- Exec time: [2.21, 4.67] s
* igt@kms_plane_cursor@pipe-b-primary-size-256:
- Statuses : 8 pass(s)
- Exec time: [2.20, 4.70] s
* igt@kms_plane_cursor@pipe-b-primary-size-64:
- Statuses : 8 pass(s)
- Exec time: [2.21, 4.61] s
* igt@kms_plane_cursor@pipe-b-viewport-size-128:
- Statuses :
- Exec time: [None] s
* igt@kms_plane_cursor@pipe-b-viewport-size-256:
- Statuses : 8 pass(s)
- Exec time: [2.22, 4.88] s
* igt@kms_plane_cursor@pipe-b-viewport-size-64:
- Statuses : 8 pass(s)
- Exec time: [2.22, 4.92] s
* igt@kms_plane_cursor@pipe-c-overlay-size-128:
- Statuses : 7 pass(s) 1 skip(s)
- Exec time: [0.0, 4.92] s
* igt@kms_plane_cursor@pipe-c-overlay-size-256:
- Statuses : 7 pass(s) 1 skip(s)
- Exec time: [0.0, 4.91] s
* igt@kms_plane_cursor@pipe-c-overlay-size-64:
- Statuses : 7 pass(s) 1 skip(s)
- Exec time: [0.0, 4.91] s
* igt@kms_plane_cursor@pipe-c-primary-size-128:
- Statuses : 7 pass(s) 1 skip(s)
- Exec time: [0.0, 4.56] s
* igt@kms_plane_cursor@pipe-c-primary-size-256:
- Statuses : 7 pass(s) 1 skip(s)
- Exec time: [0.0, 4.68] s
* igt@kms_plane_cursor@pipe-c-primary-size-64:
- Statuses : 6 pass(s) 1 skip(s)
- Exec time: [0.0, 2.77] s
* igt@kms_plane_cursor@pipe-c-viewport-size-128:
- Statuses : 7 pass(s) 1 skip(s)
- Exec time: [0.0, 4.87] s
* igt@kms_plane_cursor@pipe-c-viewport-size-256:
- Statuses : 6 pass(s) 1 skip(s)
- Exec time: [0.0, 4.83] s
* igt@kms_plane_cursor@pipe-c-viewport-size-64:
- Statuses : 7 pass(s) 1 skip(s)
- Exec time: [0.0, 4.84] s
Known issues
------------
Here are the changes found in Patchwork_17305_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_balancer@semaphore:
- shard-glk: [PASS][2] -> [INCOMPLETE][3] ([i915#58] / [k.org#198133])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8298/shard-glk6/igt@gem_exec_balancer@semaphore.html
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17305/shard-glk1/igt@gem_exec_balancer@semaphore.html
* igt@gem_exec_create@madvise:
- shard-hsw: [PASS][4] -> [INCOMPLETE][5] ([i915#61])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8298/shard-hsw1/igt@gem_exec_create@madvise.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17305/shard-hsw4/igt@gem_exec_create@madvise.html
* igt@gem_workarounds@suspend-resume-context:
- shard-apl: [PASS][6] -> [DMESG-WARN][7] ([i915#180]) +2 similar issues
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8298/shard-apl1/igt@gem_workarounds@suspend-resume-context.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17305/shard-apl1/igt@gem_workarounds@suspend-resume-context.html
* igt@i915_pm_dc@dc5-psr:
- shard-skl: [PASS][8] -> [INCOMPLETE][9] ([i915#198])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8298/shard-skl9/igt@i915_pm_dc@dc5-psr.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17305/shard-skl4/igt@i915_pm_dc@dc5-psr.html
* igt@i915_pm_dc@dc6-psr:
- shard-iclb: [PASS][10] -> [FAIL][11] ([i915#454])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8298/shard-iclb5/igt@i915_pm_dc@dc6-psr.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17305/shard-iclb2/igt@i915_pm_dc@dc6-psr.html
* igt@i915_pm_rpm@system-suspend-execbuf:
- shard-skl: [PASS][12] -> [INCOMPLETE][13] ([i915#151] / [i915#69])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8298/shard-skl6/igt@i915_pm_rpm@system-suspend-execbuf.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17305/shard-skl6/igt@i915_pm_rpm@system-suspend-execbuf.html
* igt@i915_suspend@debugfs-reader:
- shard-kbl: [PASS][14] -> [DMESG-WARN][15] ([i915#180])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8298/shard-kbl7/igt@i915_suspend@debugfs-reader.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17305/shard-kbl1/igt@i915_suspend@debugfs-reader.html
* igt@kms_cursor_legacy@all-pipes-torture-move:
- shard-snb: [PASS][16] -> [DMESG-WARN][17] ([i915#128])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8298/shard-snb2/igt@kms_cursor_legacy@all-pipes-torture-move.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17305/shard-snb1/igt@kms_cursor_legacy@all-pipes-torture-move.html
* igt@kms_cursor_legacy@cursora-vs-flipb-toggle:
- shard-hsw: [PASS][18] -> [SKIP][19] ([fdo#109271]) +1 similar issue
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8298/shard-hsw6/igt@kms_cursor_legacy@cursora-vs-flipb-toggle.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17305/shard-hsw2/igt@kms_cursor_legacy@cursora-vs-flipb-toggle.html
* igt@kms_flip@plain-flip-fb-recreate:
- shard-skl: [PASS][20] -> [FAIL][21] ([i915#34])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8298/shard-skl8/igt@kms_flip@plain-flip-fb-recreate.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17305/shard-skl7/igt@kms_flip@plain-flip-fb-recreate.html
* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes:
- shard-apl: [PASS][22] -> [DMESG-WARN][23] ([i915#180] / [i915#95])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8298/shard-apl1/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17305/shard-apl6/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes.html
* igt@kms_plane_alpha_blend@pipe-b-coverage-7efc:
- shard-skl: [PASS][24] -> [FAIL][25] ([fdo#108145] / [i915#265]) +1 similar issue
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8298/shard-skl3/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17305/shard-skl3/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html
* igt@kms_psr@psr2_primary_page_flip:
- shard-iclb: [PASS][26] -> [SKIP][27] ([fdo#109441])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8298/shard-iclb2/igt@kms_psr@psr2_primary_page_flip.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17305/shard-iclb4/igt@kms_psr@psr2_primary_page_flip.html
#### Possible fixes ####
* igt@gem_exec_params@invalid-bsd-ring:
- shard-iclb: [SKIP][28] ([fdo#109276]) -> [PASS][29]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8298/shard-iclb7/igt@gem_exec_params@invalid-bsd-ring.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17305/shard-iclb4/igt@gem_exec_params@invalid-bsd-ring.html
* {igt@gem_wait@write-wait@all}:
- shard-skl: [FAIL][30] ([i915#1676]) -> [PASS][31]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8298/shard-skl2/igt@gem_wait@write-wait@all.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17305/shard-skl9/igt@gem_wait@write-wait@all.html
* igt@gen9_exec_parse@allowed-all:
- shard-apl: [DMESG-WARN][32] ([i915#716]) -> [PASS][33]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8298/shard-apl3/igt@gen9_exec_parse@allowed-all.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17305/shard-apl7/igt@gen9_exec_parse@allowed-all.html
* igt@kms_cursor_legacy@2x-long-flip-vs-cursor-legacy:
- shard-glk: [FAIL][34] ([i915#72]) -> [PASS][35]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8298/shard-glk6/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-legacy.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17305/shard-glk1/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-legacy.html
* igt@kms_flip@flip-vs-expired-vblank:
- shard-skl: [FAIL][36] ([i915#79]) -> [PASS][37]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8298/shard-skl8/igt@kms_flip@flip-vs-expired-vblank.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17305/shard-skl5/igt@kms_flip@flip-vs-expired-vblank.html
* igt@kms_hdr@bpc-switch-dpms:
- shard-skl: [FAIL][38] ([i915#1188]) -> [PASS][39]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8298/shard-skl10/igt@kms_hdr@bpc-switch-dpms.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17305/shard-skl7/igt@kms_hdr@bpc-switch-dpms.html
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
- shard-kbl: [DMESG-WARN][40] ([i915#180]) -> [PASS][41] +3 similar issues
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8298/shard-kbl7/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17305/shard-kbl1/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html
* igt@kms_psr@psr2_sprite_plane_move:
- shard-iclb: [SKIP][42] ([fdo#109441]) -> [PASS][43] +1 similar issue
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8298/shard-iclb5/igt@kms_psr@psr2_sprite_plane_move.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17305/shard-iclb2/igt@kms_psr@psr2_sprite_plane_move.html
* igt@kms_vblank@pipe-b-ts-continuation-suspend:
- shard-apl: [DMESG-WARN][44] ([i915#180]) -> [PASS][45] +3 similar issues
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8298/shard-apl4/igt@kms_vblank@pipe-b-ts-continuation-suspend.html
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17305/shard-apl1/igt@kms_vblank@pipe-b-ts-continuation-suspend.html
* {igt@sysfs_heartbeat_interval@mixed@vcs0}:
- shard-skl: [INCOMPLETE][46] ([i915#198]) -> [PASS][47]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8298/shard-skl7/igt@sysfs_heartbeat_interval@mixed@vcs0.html
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17305/shard-skl5/igt@sysfs_heartbeat_interval@mixed@vcs0.html
#### Warnings ####
* igt@i915_pm_dc@dc6-psr:
- shard-tglb: [FAIL][48] ([i915#454]) -> [SKIP][49] ([i915#468])
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8298/shard-tglb5/igt@i915_pm_dc@dc6-psr.html
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17305/shard-tglb2/igt@i915_pm_dc@dc6-psr.html
* igt@kms_fbcon_fbt@fbc-suspend:
- shard-kbl: [DMESG-FAIL][50] ([i915#180] / [i915#95]) -> [FAIL][51] ([i915#93] / [i915#95])
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8298/shard-kbl6/igt@kms_fbcon_fbt@fbc-suspend.html
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17305/shard-kbl3/igt@kms_fbcon_fbt@fbc-suspend.html
* igt@kms_plane_alpha_blend@pipe-b-constant-alpha-max:
- shard-apl: [FAIL][52] ([fdo#108145] / [i915#265] / [i915#95]) -> [FAIL][53] ([fdo#108145] / [i915#265]) +1 similar issue
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8298/shard-apl1/igt@kms_plane_alpha_blend@pipe-b-constant-alpha-max.html
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17305/shard-apl2/igt@kms_plane_alpha_blend@pipe-b-constant-alpha-max.html
* igt@kms_plane_alpha_blend@pipe-c-alpha-7efc:
- shard-kbl: [FAIL][54] ([fdo#108145] / [i915#265] / [i915#93] / [i915#95]) -> [FAIL][55] ([fdo#108145] / [i915#265])
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8298/shard-kbl2/igt@kms_plane_alpha_blend@pipe-c-alpha-7efc.html
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17305/shard-kbl2/igt@kms_plane_alpha_blend@pipe-c-alpha-7efc.html
* igt@runner@aborted:
- shard-apl: ([FAIL][56], [FAIL][57]) ([i915#1423] / [i915#716]) -> [FAIL][58] ([i915#1423])
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8298/shard-apl3/igt@runner@aborted.html
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8298/shard-apl3/igt@runner@aborted.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17305/shard-apl8/igt@runner@aborted.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188
[i915#128]: https://gitlab.freedesktop.org/drm/intel/issues/128
[i915#1423]: https://gitlab.freedesktop.org/drm/intel/issues/1423
[i915#151]: https://gitlab.freedesktop.org/drm/intel/issues/151
[i915#1676]: https://gitlab.freedesktop.org/drm/intel/issues/1676
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#198]: https://gitlab.freedesktop.org/drm/intel/issues/198
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#34]: https://gitlab.freedesktop.org/drm/intel/issues/34
[i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
[i915#468]: https://gitlab.freedesktop.org/drm/intel/issues/468
[i915#58]: https://gitlab.freedesktop.org/drm/intel/issues/58
[i915#61]: https://gitlab.freedesktop.org/drm/intel/issues/61
[i915#69]: https://gitlab.freedesktop.org/drm/intel/issues/69
[i915#716]: https://gitlab.freedesktop.org/drm/intel/issues/716
[i915#72]: https://gitlab.freedesktop.org/drm/intel/issues/72
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#93]: https://gitlab.freedesktop.org/drm/intel/issues/93
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
[k.org#198133]: https://bugzilla.kernel.org/show_bug.cgi?id=198133
Participating hosts (10 -> 10)
------------------------------
No changes in participating hosts
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_8298 -> Patchwork_17305
CI-20190529: 20190529
CI_DRM_8298: 17f82f0c2857d0b442adbdb62eb44b61d0f5b775 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5589: 31962324ac86f029e2841e56e97c42cf9d572956 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_17305: 3f39dd53bc11120951a053fe97f7db5abed3a3c4 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17305/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH] drm/i915/gt: Update PMINTRMSK holding fw
@ 2020-04-27 20:26 Chris Wilson
0 siblings, 0 replies; 13+ messages in thread
From: Chris Wilson @ 2020-04-27 20:26 UTC (permalink / raw)
To: stable
Cc: Chris Wilson, Francisco Jerez, Mika Kuoppala, Andi Shyti, Rodrigo Vivi
Upstream commit e1eb075c5051987fbbadbc0fb8211679df657721.
If we use a non-forcewaked write to PMINTRMSK, it does not take effect
until much later, if at all, causing a loss of RPS interrupts and no GPU
reclocking, leaving the GPU running at the wrong frequency for long
periods of time.
Reported-by: Francisco Jerez <currojerez@riseup.net>
Suggested-by: Francisco Jerez <currojerez@riseup.net>
Fixes: 35cc7f32c298 ("drm/i915/gt: Use non-forcewake writes for RPS")
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Francisco Jerez <currojerez@riseup.net>
Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Cc: Andi Shyti <andi.shyti@intel.com>
Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Reviewed-by: Andi Shyti <andi.shyti@intel.com>
Reviewed-by: Francisco Jerez <currojerez@riseup.net>
Cc: <stable@vger.kernel.org> # v5.6+
Link: https://patchwork.freedesktop.org/patch/msgid/20200415170318.16771-2-chris@chris-wilson.co.uk
(cherry picked from commit a080bd994c4023042a2b605c65fa10a25933f636)
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
(cherry picked from commit e1eb075c5051987fbbadbc0fb8211679df657721)
---
drivers/gpu/drm/i915/gt/intel_rps.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/gt/intel_rps.c b/drivers/gpu/drm/i915/gt/intel_rps.c
index b2d245963d9f..8accea06185b 100644
--- a/drivers/gpu/drm/i915/gt/intel_rps.c
+++ b/drivers/gpu/drm/i915/gt/intel_rps.c
@@ -83,7 +83,8 @@ static void rps_enable_interrupts(struct intel_rps *rps)
gen6_gt_pm_enable_irq(gt, rps->pm_events);
spin_unlock_irq(>->irq_lock);
- set(gt->uncore, GEN6_PMINTRMSK, rps_pm_mask(rps, rps->cur_freq));
+ intel_uncore_write(gt->uncore,
+ GEN6_PMINTRMSK, rps_pm_mask(rps, rps->last_freq));
}
static void gen6_rps_reset_interrupts(struct intel_rps *rps)
@@ -117,7 +118,8 @@ static void rps_disable_interrupts(struct intel_rps *rps)
rps->pm_events = 0;
- set(gt->uncore, GEN6_PMINTRMSK, rps_pm_sanitize_mask(rps, ~0u));
+ intel_uncore_write(gt->uncore,
+ GEN6_PMINTRMSK, rps_pm_sanitize_mask(rps, ~0u));
spin_lock_irq(>->irq_lock);
gen6_gt_pm_disable_irq(gt, GEN6_PM_RPS_EVENTS);
--
2.26.2
^ permalink raw reply related [flat|nested] 13+ messages in thread
end of thread, other threads:[~2020-04-27 20:27 UTC | newest]
Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-15 7:50 [PATCH] drm/i915/gt: Update PMINTRMSK holding fw Chris Wilson
2020-04-15 7:50 ` [Intel-gfx] " Chris Wilson
2020-04-15 8:32 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2020-04-15 8:48 ` [Intel-gfx] ✗ Fi.CI.DOCS: " Patchwork
2020-04-15 8:55 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-04-15 11:09 ` [PATCH] " Mika Kuoppala
2020-04-15 11:09 ` [Intel-gfx] " Mika Kuoppala
2020-04-15 11:24 ` Andi Shyti
2020-04-15 11:24 ` [Intel-gfx] " Andi Shyti
2020-04-15 19:14 ` Francisco Jerez
2020-04-15 19:14 ` [Intel-gfx] " Francisco Jerez
2020-04-16 1:40 ` [Intel-gfx] ✗ Fi.CI.IGT: failure for " Patchwork
2020-04-27 20:26 [PATCH] " Chris Wilson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.