* [PATCH] i2c: i2c-stm32f7: improve nack debug message
@ 2020-03-19 18:21 ` Alain Volmat
0 siblings, 0 replies; 10+ messages in thread
From: Alain Volmat @ 2020-03-19 18:21 UTC (permalink / raw)
To: wsa, pierre-yves.mordret
Cc: alain.volmat, alexandre.torgue, linux-i2c, linux-stm32,
linux-arm-kernel, linux-kernel, fabrice.gasnier
From: Fabrice Gasnier <fabrice.gasnier@st.com>
Add information on slave addr in the nack debug message.
Signed-off-by: Fabrice Gasnier <fabrice.gasnier@st.com>
Signed-off-by: Alain Volmat <alain.volmat@st.com>
---
drivers/i2c/busses/i2c-stm32f7.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/i2c/busses/i2c-stm32f7.c b/drivers/i2c/busses/i2c-stm32f7.c
index 378956ac6d1d..78d40a4cc282 100644
--- a/drivers/i2c/busses/i2c-stm32f7.c
+++ b/drivers/i2c/busses/i2c-stm32f7.c
@@ -1431,7 +1431,8 @@ static irqreturn_t stm32f7_i2c_isr_event(int irq, void *data)
/* NACK received */
if (status & STM32F7_I2C_ISR_NACKF) {
- dev_dbg(i2c_dev->dev, "<%s>: Receive NACK\n", __func__);
+ dev_dbg(i2c_dev->dev, "<%s>: Receive NACK (addr %x)\n",
+ __func__, f7_msg->addr);
writel_relaxed(STM32F7_I2C_ICR_NACKCF, base + STM32F7_I2C_ICR);
f7_msg->result = -ENXIO;
}
--
2.7.4
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH] i2c: i2c-stm32f7: improve nack debug message
@ 2020-03-19 18:21 ` Alain Volmat
0 siblings, 0 replies; 10+ messages in thread
From: Alain Volmat @ 2020-03-19 18:21 UTC (permalink / raw)
To: wsa, pierre-yves.mordret
Cc: alain.volmat, alexandre.torgue, linux-i2c, linux-stm32,
linux-arm-kernel, linux-kernel, fabrice.gasnier
From: Fabrice Gasnier <fabrice.gasnier@st.com>
Add information on slave addr in the nack debug message.
Signed-off-by: Fabrice Gasnier <fabrice.gasnier@st.com>
Signed-off-by: Alain Volmat <alain.volmat@st.com>
---
drivers/i2c/busses/i2c-stm32f7.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/i2c/busses/i2c-stm32f7.c b/drivers/i2c/busses/i2c-stm32f7.c
index 378956ac6d1d..78d40a4cc282 100644
--- a/drivers/i2c/busses/i2c-stm32f7.c
+++ b/drivers/i2c/busses/i2c-stm32f7.c
@@ -1431,7 +1431,8 @@ static irqreturn_t stm32f7_i2c_isr_event(int irq, void *data)
/* NACK received */
if (status & STM32F7_I2C_ISR_NACKF) {
- dev_dbg(i2c_dev->dev, "<%s>: Receive NACK\n", __func__);
+ dev_dbg(i2c_dev->dev, "<%s>: Receive NACK (addr %x)\n",
+ __func__, f7_msg->addr);
writel_relaxed(STM32F7_I2C_ICR_NACKCF, base + STM32F7_I2C_ICR);
f7_msg->result = -ENXIO;
}
--
2.7.4
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH] i2c: i2c-stm32f7: improve nack debug message
@ 2020-03-19 18:21 ` Alain Volmat
0 siblings, 0 replies; 10+ messages in thread
From: Alain Volmat @ 2020-03-19 18:21 UTC (permalink / raw)
To: wsa, pierre-yves.mordret
Cc: alexandre.torgue, linux-kernel, alain.volmat, linux-i2c,
fabrice.gasnier, linux-stm32, linux-arm-kernel
From: Fabrice Gasnier <fabrice.gasnier@st.com>
Add information on slave addr in the nack debug message.
Signed-off-by: Fabrice Gasnier <fabrice.gasnier@st.com>
Signed-off-by: Alain Volmat <alain.volmat@st.com>
---
drivers/i2c/busses/i2c-stm32f7.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/i2c/busses/i2c-stm32f7.c b/drivers/i2c/busses/i2c-stm32f7.c
index 378956ac6d1d..78d40a4cc282 100644
--- a/drivers/i2c/busses/i2c-stm32f7.c
+++ b/drivers/i2c/busses/i2c-stm32f7.c
@@ -1431,7 +1431,8 @@ static irqreturn_t stm32f7_i2c_isr_event(int irq, void *data)
/* NACK received */
if (status & STM32F7_I2C_ISR_NACKF) {
- dev_dbg(i2c_dev->dev, "<%s>: Receive NACK\n", __func__);
+ dev_dbg(i2c_dev->dev, "<%s>: Receive NACK (addr %x)\n",
+ __func__, f7_msg->addr);
writel_relaxed(STM32F7_I2C_ICR_NACKCF, base + STM32F7_I2C_ICR);
f7_msg->result = -ENXIO;
}
--
2.7.4
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH] i2c: i2c-stm32f7: improve nack debug message
2020-03-19 18:21 ` Alain Volmat
(?)
@ 2020-03-30 8:41 ` Pierre Yves MORDRET
-1 siblings, 0 replies; 10+ messages in thread
From: Pierre Yves MORDRET @ 2020-03-30 8:41 UTC (permalink / raw)
To: Alain Volmat, wsa
Cc: alexandre.torgue, linux-i2c, linux-stm32, linux-arm-kernel,
linux-kernel, fabrice.gasnier
Hello guys !
Reviewed-by: Pierre-Yves MORDRET <pierre-yves.mordret@st.com>
Thanks
On 3/19/20 7:21 PM, Alain Volmat wrote:
> From: Fabrice Gasnier <fabrice.gasnier@st.com>
>
> Add information on slave addr in the nack debug message.
>
> Signed-off-by: Fabrice Gasnier <fabrice.gasnier@st.com>
> Signed-off-by: Alain Volmat <alain.volmat@st.com>
> ---
> drivers/i2c/busses/i2c-stm32f7.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/busses/i2c-stm32f7.c b/drivers/i2c/busses/i2c-stm32f7.c
> index 378956ac6d1d..78d40a4cc282 100644
> --- a/drivers/i2c/busses/i2c-stm32f7.c
> +++ b/drivers/i2c/busses/i2c-stm32f7.c
> @@ -1431,7 +1431,8 @@ static irqreturn_t stm32f7_i2c_isr_event(int irq, void *data)
>
> /* NACK received */
> if (status & STM32F7_I2C_ISR_NACKF) {
> - dev_dbg(i2c_dev->dev, "<%s>: Receive NACK\n", __func__);
> + dev_dbg(i2c_dev->dev, "<%s>: Receive NACK (addr %x)\n",
> + __func__, f7_msg->addr);
> writel_relaxed(STM32F7_I2C_ICR_NACKCF, base + STM32F7_I2C_ICR);
> f7_msg->result = -ENXIO;
> }
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] i2c: i2c-stm32f7: improve nack debug message
@ 2020-03-30 8:41 ` Pierre Yves MORDRET
0 siblings, 0 replies; 10+ messages in thread
From: Pierre Yves MORDRET @ 2020-03-30 8:41 UTC (permalink / raw)
To: Alain Volmat, wsa
Cc: alexandre.torgue, linux-i2c, linux-stm32, linux-arm-kernel,
linux-kernel, fabrice.gasnier
Hello guys !
Reviewed-by: Pierre-Yves MORDRET <pierre-yves.mordret@st.com>
Thanks
On 3/19/20 7:21 PM, Alain Volmat wrote:
> From: Fabrice Gasnier <fabrice.gasnier@st.com>
>
> Add information on slave addr in the nack debug message.
>
> Signed-off-by: Fabrice Gasnier <fabrice.gasnier@st.com>
> Signed-off-by: Alain Volmat <alain.volmat@st.com>
> ---
> drivers/i2c/busses/i2c-stm32f7.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/busses/i2c-stm32f7.c b/drivers/i2c/busses/i2c-stm32f7.c
> index 378956ac6d1d..78d40a4cc282 100644
> --- a/drivers/i2c/busses/i2c-stm32f7.c
> +++ b/drivers/i2c/busses/i2c-stm32f7.c
> @@ -1431,7 +1431,8 @@ static irqreturn_t stm32f7_i2c_isr_event(int irq, void *data)
>
> /* NACK received */
> if (status & STM32F7_I2C_ISR_NACKF) {
> - dev_dbg(i2c_dev->dev, "<%s>: Receive NACK\n", __func__);
> + dev_dbg(i2c_dev->dev, "<%s>: Receive NACK (addr %x)\n",
> + __func__, f7_msg->addr);
> writel_relaxed(STM32F7_I2C_ICR_NACKCF, base + STM32F7_I2C_ICR);
> f7_msg->result = -ENXIO;
> }
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] i2c: i2c-stm32f7: improve nack debug message
@ 2020-03-30 8:41 ` Pierre Yves MORDRET
0 siblings, 0 replies; 10+ messages in thread
From: Pierre Yves MORDRET @ 2020-03-30 8:41 UTC (permalink / raw)
To: Alain Volmat, wsa
Cc: alexandre.torgue, linux-kernel, linux-i2c, fabrice.gasnier,
linux-stm32, linux-arm-kernel
Hello guys !
Reviewed-by: Pierre-Yves MORDRET <pierre-yves.mordret@st.com>
Thanks
On 3/19/20 7:21 PM, Alain Volmat wrote:
> From: Fabrice Gasnier <fabrice.gasnier@st.com>
>
> Add information on slave addr in the nack debug message.
>
> Signed-off-by: Fabrice Gasnier <fabrice.gasnier@st.com>
> Signed-off-by: Alain Volmat <alain.volmat@st.com>
> ---
> drivers/i2c/busses/i2c-stm32f7.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/busses/i2c-stm32f7.c b/drivers/i2c/busses/i2c-stm32f7.c
> index 378956ac6d1d..78d40a4cc282 100644
> --- a/drivers/i2c/busses/i2c-stm32f7.c
> +++ b/drivers/i2c/busses/i2c-stm32f7.c
> @@ -1431,7 +1431,8 @@ static irqreturn_t stm32f7_i2c_isr_event(int irq, void *data)
>
> /* NACK received */
> if (status & STM32F7_I2C_ISR_NACKF) {
> - dev_dbg(i2c_dev->dev, "<%s>: Receive NACK\n", __func__);
> + dev_dbg(i2c_dev->dev, "<%s>: Receive NACK (addr %x)\n",
> + __func__, f7_msg->addr);
> writel_relaxed(STM32F7_I2C_ICR_NACKCF, base + STM32F7_I2C_ICR);
> f7_msg->result = -ENXIO;
> }
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] i2c: i2c-stm32f7: improve nack debug message
2020-03-19 18:21 ` Alain Volmat
@ 2020-04-15 11:01 ` Wolfram Sang
-1 siblings, 0 replies; 10+ messages in thread
From: Wolfram Sang @ 2020-04-15 11:01 UTC (permalink / raw)
To: Alain Volmat
Cc: pierre-yves.mordret, alexandre.torgue, linux-i2c, linux-stm32,
linux-arm-kernel, linux-kernel, fabrice.gasnier
[-- Attachment #1: Type: text/plain, Size: 395 bytes --]
On Thu, Mar 19, 2020 at 07:21:55PM +0100, Alain Volmat wrote:
> From: Fabrice Gasnier <fabrice.gasnier@st.com>
>
> Add information on slave addr in the nack debug message.
>
> Signed-off-by: Fabrice Gasnier <fabrice.gasnier@st.com>
> Signed-off-by: Alain Volmat <alain.volmat@st.com>
Applied to for-next, thanks! (I'd drop the __func__, though; doesn't
add information, does it?)
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] i2c: i2c-stm32f7: improve nack debug message
@ 2020-04-15 11:01 ` Wolfram Sang
0 siblings, 0 replies; 10+ messages in thread
From: Wolfram Sang @ 2020-04-15 11:01 UTC (permalink / raw)
To: Alain Volmat
Cc: alexandre.torgue, linux-kernel, pierre-yves.mordret, linux-i2c,
fabrice.gasnier, linux-stm32, linux-arm-kernel
[-- Attachment #1.1: Type: text/plain, Size: 395 bytes --]
On Thu, Mar 19, 2020 at 07:21:55PM +0100, Alain Volmat wrote:
> From: Fabrice Gasnier <fabrice.gasnier@st.com>
>
> Add information on slave addr in the nack debug message.
>
> Signed-off-by: Fabrice Gasnier <fabrice.gasnier@st.com>
> Signed-off-by: Alain Volmat <alain.volmat@st.com>
Applied to for-next, thanks! (I'd drop the __func__, though; doesn't
add information, does it?)
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] i2c: i2c-stm32f7: improve nack debug message
2020-04-15 11:01 ` Wolfram Sang
@ 2020-04-15 11:35 ` Alain Volmat
-1 siblings, 0 replies; 10+ messages in thread
From: Alain Volmat @ 2020-04-15 11:35 UTC (permalink / raw)
To: Wolfram Sang
Cc: pierre-yves.mordret, alexandre.torgue, linux-i2c, linux-stm32,
linux-arm-kernel, linux-kernel, fabrice.gasnier
On Wed, Apr 15, 2020 at 01:01:01PM +0200, Wolfram Sang wrote:
> On Thu, Mar 19, 2020 at 07:21:55PM +0100, Alain Volmat wrote:
> > From: Fabrice Gasnier <fabrice.gasnier@st.com>
> >
> > Add information on slave addr in the nack debug message.
> >
> > Signed-off-by: Fabrice Gasnier <fabrice.gasnier@st.com>
> > Signed-off-by: Alain Volmat <alain.volmat@st.com>
>
> Applied to for-next, thanks! (I'd drop the __func__, though; doesn't
> add information, does it?)
In fact similar message is displayed in 2 places. One in case of master mode
isr and the other one in case of slave isr. This message is adding slave
address to the master mode isr. It only makes it more clear on first sight
but indeed displaying the slave address obviously means this is master mode.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] i2c: i2c-stm32f7: improve nack debug message
@ 2020-04-15 11:35 ` Alain Volmat
0 siblings, 0 replies; 10+ messages in thread
From: Alain Volmat @ 2020-04-15 11:35 UTC (permalink / raw)
To: Wolfram Sang
Cc: alexandre.torgue, linux-kernel, pierre-yves.mordret, linux-i2c,
fabrice.gasnier, linux-stm32, linux-arm-kernel
On Wed, Apr 15, 2020 at 01:01:01PM +0200, Wolfram Sang wrote:
> On Thu, Mar 19, 2020 at 07:21:55PM +0100, Alain Volmat wrote:
> > From: Fabrice Gasnier <fabrice.gasnier@st.com>
> >
> > Add information on slave addr in the nack debug message.
> >
> > Signed-off-by: Fabrice Gasnier <fabrice.gasnier@st.com>
> > Signed-off-by: Alain Volmat <alain.volmat@st.com>
>
> Applied to for-next, thanks! (I'd drop the __func__, though; doesn't
> add information, does it?)
In fact similar message is displayed in 2 places. One in case of master mode
isr and the other one in case of slave isr. This message is adding slave
address to the master mode isr. It only makes it more clear on first sight
but indeed displaying the slave address obviously means this is master mode.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2020-04-15 13:11 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-19 18:21 [PATCH] i2c: i2c-stm32f7: improve nack debug message Alain Volmat
2020-03-19 18:21 ` Alain Volmat
2020-03-19 18:21 ` Alain Volmat
2020-03-30 8:41 ` Pierre Yves MORDRET
2020-03-30 8:41 ` Pierre Yves MORDRET
2020-03-30 8:41 ` Pierre Yves MORDRET
2020-04-15 11:01 ` Wolfram Sang
2020-04-15 11:01 ` Wolfram Sang
2020-04-15 11:35 ` Alain Volmat
2020-04-15 11:35 ` Alain Volmat
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.