[PATCH] scripts: documentation-file-ref-check: Add line break before exit

[PATCH] scripts: documentation-file-ref-check: Add line break before exit

[Tiezhu Yang]

If execute ./scripts/documentation-file-ref-check in a directory which is
not a git tree, it will exit without a line break, fix it.

Without this patch:

[loongson@localhost linux-5.7-rc1]$ ./scripts/documentation-file-ref-check
Warning: can't check if file exists, as this is not a git tree[loongson@localhost linux-5.7-rc1]$

With this patch:

[loongson@localhost linux-5.7-rc1]$ ./scripts/documentation-file-ref-check
Warning: can't check if file exists, as this is not a git tree
[loongson@localhost linux-5.7-rc1]$

Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
---
 scripts/documentation-file-ref-check | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/documentation-file-ref-check b/scripts/documentation-file-ref-check
index 9a8cc10..c71832b 100755
--- a/scripts/documentation-file-ref-check
+++ b/scripts/documentation-file-ref-check
@@ -25,7 +25,7 @@ my $fix = 0;
 my $warn = 0;
 
 if (! -d ".git") {
-	printf "Warning: can't check if file exists, as this is not a git tree";
+	printf "Warning: can't check if file exists, as this is not a git tree\n";
 	exit 0;
 }
 
-- 
2.1.0

Re: [PATCH] scripts: documentation-file-ref-check: Add line break before exit

[Mauro Carvalho Chehab]

Em Tue, 14 Apr 2020 17:41:48 +0800
Tiezhu Yang <yangtiezhu@loongson.cn> escreveu:

> If execute ./scripts/documentation-file-ref-check in a directory which is
> not a git tree, it will exit without a line break, fix it.
> 
> Without this patch:
> 
> [loongson@localhost linux-5.7-rc1]$ ./scripts/documentation-file-ref-check
> Warning: can't check if file exists, as this is not a git tree[loongson@localhost linux-5.7-rc1]$
> 
> With this patch:
> 
> [loongson@localhost linux-5.7-rc1]$ ./scripts/documentation-file-ref-check
> Warning: can't check if file exists, as this is not a git tree
> [loongson@localhost linux-5.7-rc1]$
> 
> Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>

Reviewed-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>

> ---
>  scripts/documentation-file-ref-check | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/documentation-file-ref-check b/scripts/documentation-file-ref-check
> index 9a8cc10..c71832b 100755
> --- a/scripts/documentation-file-ref-check
> +++ b/scripts/documentation-file-ref-check
> @@ -25,7 +25,7 @@ my $fix = 0;
>  my $warn = 0;
>  
>  if (! -d ".git") {
> -	printf "Warning: can't check if file exists, as this is not a git tree";
> +	printf "Warning: can't check if file exists, as this is not a git tree\n";
>  	exit 0;
>  }
>  



Thanks,
Mauro

Re: [PATCH] scripts: documentation-file-ref-check: Add line break before exit

[Jonathan Corbet]

On Tue, 14 Apr 2020 17:41:48 +0800
Tiezhu Yang <yangtiezhu@loongson.cn> wrote:

> If execute ./scripts/documentation-file-ref-check in a directory which is
> not a git tree, it will exit without a line break, fix it.
> 
> Without this patch:
> 
> [loongson@localhost linux-5.7-rc1]$ ./scripts/documentation-file-ref-check
> Warning: can't check if file exists, as this is not a git tree[loongson@localhost linux-5.7-rc1]$
> 
> With this patch:
> 
> [loongson@localhost linux-5.7-rc1]$ ./scripts/documentation-file-ref-check
> Warning: can't check if file exists, as this is not a git tree
> [loongson@localhost linux-5.7-rc1]$
> 
> Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>

Applied, thanks.

jon