Re: [kernel.org users] b4 auto-thankanator landed in master

["Konstantin Ryabitsev" <konstantin@linuxfoundation.org>]

On Wed, Apr 15, 2020 at 04:00:00PM +0100, Mark Brown wrote:
> On Fri, Apr 10, 2020 at 05:00:56PM -0400, Konstantin Ryabitsev wrote:
> 
> > Based on your feedback, I added an "auto-thankanator" mode to b4, which 
> > will track your use of "b4 am" and "b4 pr" and create convenient 
> > templated thank-you replies when you run "b4 ty".
> 
> Nice, this solves some problems I've been having with my scripts since
> converting to b4!

Thanks for testing it out! I'm sure there will be quite a few iterations 
before I get the b4 ty workflow to the stage that is useful to most 
maintainers.

> It seems like this relies on git branch --show-current which isn't
> supported by the git in Debian stable, 2.20.1. 

Bah, I should check manpages more carefully. I switched to a more 
generic alternative:

git rev-parse --abbrev-ref HEAD

> The documentation also says that
> 
>    b4 ty -s all
> 
> will send everything but it looks like that just lists all the tracked
> patches instead (possibly because of the above, I didn't check). 

I think I just forgot to add "all" handling to -s. :) It's fixed now.

> I'm
> not sure what it's looking at the current branch for but if it's doing
> that it'd be good to be able to tell it to look at a specific branch
> instead - 

You can already do this by passing -b to "b4 ty":

b4 ty -b branchname

> > Since it's an experimental feature, we just save a .thanks file instead
> > of sending it outright -- at least until there's a lot more testing.
> 
> It would be good if there was an explicit command for this, it'd be
> useful when scripting stuff I think and also when testing things out.

Eventually, the plan is to look into gitconfig for "sendemail" 
configuration and use that for sending out email directly. For the 
moment, you can achieve similar results by passing "--confirm=never" to 
git send-email, which should just send the emails out.

I found a few more problems while testing things out, which highlighted 
the need to use more forgiving patch hashing routines. Since I was 
planning on integrating b4 with some of the patchwork automation 
functionality in the near future anyway, I switched the tracking 
routines to use patchwork-compatible patch hashes. Unfortunately, this 
means that --auto will fail to properly work (since we changed the 
hashes we use to track them). Things should still work with "b4 ty -s", 
as we do matching by subject there when exact patch hashes fail.

Please update to the latest master and see if you have an easier time 
with this feature.

Thanks again,
-K