Re: [kernel.org users] b4 auto-thankanator landed in master

["Konstantin Ryabitsev" <konstantin@linuxfoundation.org>]

On Wed, Apr 15, 2020 at 09:12:22PM +0100, Mark Brown wrote:
> > Yes, we always expect there to be a N,N in that output, which isn't 
> > true in a number of scenarios (like a commit that creates a new file 
> > with only one line).
> 
> > The latest master should properly deal with this situation (as well as 
> > when a patch deletes all lines from a file).
> 
> Did you forget to push...

Haha, classic. Yes, it should be there now.

> I also noticed a couple of other issues.
> 
> One is that if I try to specify a remote branch with 'b4 ty -s all -b
> remote/foo' or whatever b4 doesn't think the branch exists.  I'm doing
> this because I want to be sure I only send out thank you mails for
> things that actually got pushed successfully (in the past I've found
> people get confused if the thanks arrives and they can't see the
> published commit).  It needs a --remote on the git branch command line.

Right, we're only paying attention to local branches right now. I'll 
poke to see what needs to happen to work for remotes.

> The other is that if I don't apply all of a series then b4 ty will
> refuse to generate anything with no way I can see to override. 

I think the master has a change for that as well -- try that out.

> This
> happens a fair amount when people do things like send a new driver along
> with a DT update.  Perhaps an option to allow partial lists (though I
> think that might need more complex templating), or one to generate
> per-patch thanks messages?

I think we can do --partial. Let me ponder how that can be done best.

Thanks,
-K