All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] serial: sh-sci: Drop unused include
@ 2020-04-15 18:02 Linus Walleij
  2020-04-16  8:12 ` Geert Uytterhoeven
  0 siblings, 1 reply; 2+ messages in thread
From: Linus Walleij @ 2020-04-15 18:02 UTC (permalink / raw)
  To: linux-serial, Greg Kroah-Hartman
  Cc: Linus Walleij, George G . Davis, Geert Uytterhoeven

The sh-sci.h file includes the legacy <linux/gpio.h> header
but the driver is actually migrated to use the mctrl_gpio
library so this is not needed.

Cc: George G. Davis <george_davis@mentor.com>
Cc: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
 drivers/tty/serial/sh-sci.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/tty/serial/sh-sci.h b/drivers/tty/serial/sh-sci.h
index 0b9e804e61a9..c0dfe4382898 100644
--- a/drivers/tty/serial/sh-sci.h
+++ b/drivers/tty/serial/sh-sci.h
@@ -2,7 +2,6 @@
 #include <linux/bitops.h>
 #include <linux/serial_core.h>
 #include <linux/io.h>
-#include <linux/gpio.h>
 
 #define SCI_MAJOR		204
 #define SCI_MINOR_START		8
-- 
2.25.2


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] serial: sh-sci: Drop unused include
  2020-04-15 18:02 [PATCH] serial: sh-sci: Drop unused include Linus Walleij
@ 2020-04-16  8:12 ` Geert Uytterhoeven
  0 siblings, 0 replies; 2+ messages in thread
From: Geert Uytterhoeven @ 2020-04-16  8:12 UTC (permalink / raw)
  To: Linus Walleij
  Cc: open list:SERIAL DRIVERS, Greg Kroah-Hartman, George G . Davis,
	Geert Uytterhoeven

On Wed, Apr 15, 2020 at 8:04 PM Linus Walleij <linus.walleij@linaro.org> wrote:
> The sh-sci.h file includes the legacy <linux/gpio.h> header
> but the driver is actually migrated to use the mctrl_gpio
> library so this is not needed.
>
> Cc: George G. Davis <george_davis@mentor.com>
> Cc: Geert Uytterhoeven <geert+renesas@glider.be>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-04-16  8:12 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-15 18:02 [PATCH] serial: sh-sci: Drop unused include Linus Walleij
2020-04-16  8:12 ` Geert Uytterhoeven

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.