* [PATCH] EDAC: remove defined but not used 'bridge_str'
@ 2020-04-15 8:50 Jason Yan
2020-04-15 21:19 ` Robert Richter
2020-04-24 7:31 ` Borislav Petkov
0 siblings, 2 replies; 3+ messages in thread
From: Jason Yan @ 2020-04-15 8:50 UTC (permalink / raw)
To: bp, mchehab, tony.luck, james.morse, rrichter, linux-edac, linux-kernel
Cc: Jason Yan, Hulk Robot
Fix the following gcc warning:
drivers/edac/amd8131_edac.c:47:21: warning: ‘bridge_str’ defined but not
used [-Wunused-const-variable=]
static char * const bridge_str[] = {
^~~~~~~~~~
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Jason Yan <yanaijie@huawei.com>
---
drivers/edac/amd8131_edac.c | 8 --------
1 file changed, 8 deletions(-)
diff --git a/drivers/edac/amd8131_edac.c b/drivers/edac/amd8131_edac.c
index 93c82bc17493..169353710982 100644
--- a/drivers/edac/amd8131_edac.c
+++ b/drivers/edac/amd8131_edac.c
@@ -44,14 +44,6 @@ static void edac_pci_write_dword(struct pci_dev *dev, int reg, u32 val32)
" PCI Access Write Error at 0x%x\n", reg);
}
-static char * const bridge_str[] = {
- [NORTH_A] = "NORTH A",
- [NORTH_B] = "NORTH B",
- [SOUTH_A] = "SOUTH A",
- [SOUTH_B] = "SOUTH B",
- [NO_BRIDGE] = "NO BRIDGE",
-};
-
/* Support up to two AMD8131 chipsets on a platform */
static struct amd8131_dev_info amd8131_devices[] = {
{
--
2.21.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] EDAC: remove defined but not used 'bridge_str'
2020-04-15 8:50 [PATCH] EDAC: remove defined but not used 'bridge_str' Jason Yan
@ 2020-04-15 21:19 ` Robert Richter
2020-04-24 7:31 ` Borislav Petkov
1 sibling, 0 replies; 3+ messages in thread
From: Robert Richter @ 2020-04-15 21:19 UTC (permalink / raw)
To: Jason Yan
Cc: bp, mchehab, tony.luck, james.morse, linux-edac, linux-kernel,
Hulk Robot
On 15.04.20 16:50:06, Jason Yan wrote:
> Fix the following gcc warning:
>
> drivers/edac/amd8131_edac.c:47:21: warning: ‘bridge_str’ defined but not
> used [-Wunused-const-variable=]
> static char * const bridge_str[] = {
> ^~~~~~~~~~
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Jason Yan <yanaijie@huawei.com>
Reviewed-by: Robert Richter <rrichter@marvell.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] EDAC: remove defined but not used 'bridge_str'
2020-04-15 8:50 [PATCH] EDAC: remove defined but not used 'bridge_str' Jason Yan
2020-04-15 21:19 ` Robert Richter
@ 2020-04-24 7:31 ` Borislav Petkov
1 sibling, 0 replies; 3+ messages in thread
From: Borislav Petkov @ 2020-04-24 7:31 UTC (permalink / raw)
To: Jason Yan
Cc: mchehab, tony.luck, james.morse, rrichter, linux-edac,
linux-kernel, Hulk Robot
On Wed, Apr 15, 2020 at 04:50:06PM +0800, Jason Yan wrote:
> Fix the following gcc warning:
>
> drivers/edac/amd8131_edac.c:47:21: warning: ‘bridge_str’ defined but not
> used [-Wunused-const-variable=]
> static char * const bridge_str[] = {
> ^~~~~~~~~~
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Jason Yan <yanaijie@huawei.com>
> ---
> drivers/edac/amd8131_edac.c | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/drivers/edac/amd8131_edac.c b/drivers/edac/amd8131_edac.c
> index 93c82bc17493..169353710982 100644
> --- a/drivers/edac/amd8131_edac.c
> +++ b/drivers/edac/amd8131_edac.c
> @@ -44,14 +44,6 @@ static void edac_pci_write_dword(struct pci_dev *dev, int reg, u32 val32)
> " PCI Access Write Error at 0x%x\n", reg);
> }
>
> -static char * const bridge_str[] = {
> - [NORTH_A] = "NORTH A",
> - [NORTH_B] = "NORTH B",
> - [SOUTH_A] = "SOUTH A",
> - [SOUTH_B] = "SOUTH B",
> - [NO_BRIDGE] = "NO BRIDGE",
> -};
> -
> /* Support up to two AMD8131 chipsets on a platform */
> static struct amd8131_dev_info amd8131_devices[] = {
> {
> --
Applied, thanks.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-04-24 7:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-15 8:50 [PATCH] EDAC: remove defined but not used 'bridge_str' Jason Yan
2020-04-15 21:19 ` Robert Richter
2020-04-24 7:31 ` Borislav Petkov
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.