* [PULL 0/1] Linux user for 5.0 patches
@ 2020-04-16 15:28 Laurent Vivier
2020-04-16 15:28 ` [PULL 1/1] linux-user/syscall.c: add target-to-host mapping for epoll_create1() Laurent Vivier
2020-04-16 16:03 ` [PULL 0/1] Linux user for 5.0 patches Peter Maydell
0 siblings, 2 replies; 7+ messages in thread
From: Laurent Vivier @ 2020-04-16 15:28 UTC (permalink / raw)
To: qemu-devel; +Cc: Riku Voipio, Laurent Vivier
The following changes since commit 20038cd7a8412feeb49c01f6ede89e36c8995472:
Update version for v5.0.0-rc3 release (2020-04-15 20:51:54 +0100)
are available in the Git repository at:
git://github.com/vivier/qemu.git tags/linux-user-for-5.0-pull-request
for you to fetch changes up to 386d38656889a40d29b514ee6f34997ca18f741e:
linux-user/syscall.c: add target-to-host mapping for epoll_create1() (2020-04-16 09:24:22 +0200)
----------------------------------------------------------------
Fix epoll_create1() for qemu-alpha
----------------------------------------------------------------
Sergei Trofimovich (1):
linux-user/syscall.c: add target-to-host mapping for epoll_create1()
linux-user/syscall.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--
2.25.2
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PULL 1/1] linux-user/syscall.c: add target-to-host mapping for epoll_create1()
2020-04-16 15:28 [PULL 0/1] Linux user for 5.0 patches Laurent Vivier
@ 2020-04-16 15:28 ` Laurent Vivier
2020-04-16 16:03 ` [PULL 0/1] Linux user for 5.0 patches Peter Maydell
1 sibling, 0 replies; 7+ messages in thread
From: Laurent Vivier @ 2020-04-16 15:28 UTC (permalink / raw)
To: qemu-devel; +Cc: Riku Voipio, Laurent Vivier, Sergei Trofimovich
From: Sergei Trofimovich <slyfox@gentoo.org>
Noticed by Barnabás Virágh as a python-3.7 failue on qemu-alpha.
The bug shows up on alpha as it's one of the targets where
EPOLL_CLOEXEC differs from other targets:
sysdeps/unix/sysv/linux/alpha/bits/epoll.h: EPOLL_CLOEXEC = 01000000
sysdeps/unix/sysv/linux/bits/epoll.h: EPOLL_CLOEXEC = 02000000
Bug: https://bugs.gentoo.org/717548
Reported-by: Barnabás Virágh
Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>
CC: Riku Voipio <riku.voipio@iki.fi>
CC: Laurent Vivier <laurent@vivier.eu>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
Message-Id: <20200415220508.5044-1-slyfox@gentoo.org>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
---
linux-user/syscall.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index 674f70e70a56..05f03919ff07 100644
--- a/linux-user/syscall.c
+++ b/linux-user/syscall.c
@@ -12012,7 +12012,7 @@ static abi_long do_syscall1(void *cpu_env, int num, abi_long arg1,
#endif
#if defined(TARGET_NR_epoll_create1) && defined(CONFIG_EPOLL_CREATE1)
case TARGET_NR_epoll_create1:
- return get_errno(epoll_create1(arg1));
+ return get_errno(epoll_create1(target_to_host_bitmask(arg1, fcntl_flags_tbl)));
#endif
#if defined(TARGET_NR_epoll_ctl)
case TARGET_NR_epoll_ctl:
--
2.25.2
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PULL 0/1] Linux user for 5.0 patches
2020-04-16 15:28 [PULL 0/1] Linux user for 5.0 patches Laurent Vivier
2020-04-16 15:28 ` [PULL 1/1] linux-user/syscall.c: add target-to-host mapping for epoll_create1() Laurent Vivier
@ 2020-04-16 16:03 ` Peter Maydell
2020-04-16 17:16 ` Laurent Vivier
1 sibling, 1 reply; 7+ messages in thread
From: Peter Maydell @ 2020-04-16 16:03 UTC (permalink / raw)
To: Laurent Vivier; +Cc: Riku Voipio, QEMU Developers
On Thu, 16 Apr 2020 at 16:29, Laurent Vivier <laurent@vivier.eu> wrote:
>
> The following changes since commit 20038cd7a8412feeb49c01f6ede89e36c8995472:
>
> Update version for v5.0.0-rc3 release (2020-04-15 20:51:54 +0100)
>
> are available in the Git repository at:
>
> git://github.com/vivier/qemu.git tags/linux-user-for-5.0-pull-request
>
> for you to fetch changes up to 386d38656889a40d29b514ee6f34997ca18f741e:
>
> linux-user/syscall.c: add target-to-host mapping for epoll_create1() (2020-04-16 09:24:22 +0200)
>
> ----------------------------------------------------------------
> Fix epoll_create1() for qemu-alpha
>
> ----------------------------------------------------------------
How critical is this bug fix? After rc3, I really don't want
to have to create an rc4 unless it's unavoidable...
thanks
-- PMM
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PULL 0/1] Linux user for 5.0 patches
2020-04-16 16:03 ` [PULL 0/1] Linux user for 5.0 patches Peter Maydell
@ 2020-04-16 17:16 ` Laurent Vivier
2020-04-16 19:08 ` Peter Maydell
0 siblings, 1 reply; 7+ messages in thread
From: Laurent Vivier @ 2020-04-16 17:16 UTC (permalink / raw)
To: Peter Maydell; +Cc: Riku Voipio, QEMU Developers
Le 16/04/2020 à 18:03, Peter Maydell a écrit :
> On Thu, 16 Apr 2020 at 16:29, Laurent Vivier <laurent@vivier.eu> wrote:
>>
>> The following changes since commit 20038cd7a8412feeb49c01f6ede89e36c8995472:
>>
>> Update version for v5.0.0-rc3 release (2020-04-15 20:51:54 +0100)
>>
>> are available in the Git repository at:
>>
>> git://github.com/vivier/qemu.git tags/linux-user-for-5.0-pull-request
>>
>> for you to fetch changes up to 386d38656889a40d29b514ee6f34997ca18f741e:
>>
>> linux-user/syscall.c: add target-to-host mapping for epoll_create1() (2020-04-16 09:24:22 +0200)
>>
>> ----------------------------------------------------------------
>> Fix epoll_create1() for qemu-alpha
>>
>> ----------------------------------------------------------------
>
> How critical is this bug fix? After rc3, I really don't want
> to have to create an rc4 unless it's unavoidable...
See the launchpad bug (https://bugs.gentoo.org/717548): on alpha, it
prevents the use of python3 in gentoo chroot, and thus we can't use
emerge to install packages. It also impacts cmake on debian (see
https://bugs.launchpad.net/bugs/1860553).
But it's not a regression, so up to you to reject it. It appears now
because most of the distro have switched from python2 to python3.
It's a low risk change, only in linux-user and for archs that have a
different EPOLL_CLOEXEC value.
Thanks,
Laurent
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PULL 0/1] Linux user for 5.0 patches
2020-04-16 17:16 ` Laurent Vivier
@ 2020-04-16 19:08 ` Peter Maydell
2020-04-16 19:15 ` Laurent Vivier
2020-04-20 18:55 ` Peter Maydell
0 siblings, 2 replies; 7+ messages in thread
From: Peter Maydell @ 2020-04-16 19:08 UTC (permalink / raw)
To: Laurent Vivier; +Cc: Riku Voipio, QEMU Developers
On Thu, 16 Apr 2020 at 18:16, Laurent Vivier <laurent@vivier.eu> wrote:
>
> Le 16/04/2020 à 18:03, Peter Maydell a écrit :
> > On Thu, 16 Apr 2020 at 16:29, Laurent Vivier <laurent@vivier.eu> wrote:
> >>
> >> The following changes since commit 20038cd7a8412feeb49c01f6ede89e36c8995472:
> >>
> >> Update version for v5.0.0-rc3 release (2020-04-15 20:51:54 +0100)
> >>
> >> are available in the Git repository at:
> >>
> >> git://github.com/vivier/qemu.git tags/linux-user-for-5.0-pull-request
> >>
> >> for you to fetch changes up to 386d38656889a40d29b514ee6f34997ca18f741e:
> >>
> >> linux-user/syscall.c: add target-to-host mapping for epoll_create1() (2020-04-16 09:24:22 +0200)
> >>
> >> ----------------------------------------------------------------
> >> Fix epoll_create1() for qemu-alpha
> >>
> >> ----------------------------------------------------------------
> >
> > How critical is this bug fix? After rc3, I really don't want
> > to have to create an rc4 unless it's unavoidable...
>
> See the launchpad bug (https://bugs.gentoo.org/717548): on alpha, it
> prevents the use of python3 in gentoo chroot, and thus we can't use
> emerge to install packages. It also impacts cmake on debian (see
> https://bugs.launchpad.net/bugs/1860553).
>
> But it's not a regression, so up to you to reject it. It appears now
> because most of the distro have switched from python2 to python3.
>
> It's a low risk change, only in linux-user and for archs that have a
> different EPOLL_CLOEXEC value.
Thanks for the explanation. I think that I'll put it to one
side and if we need an rc4 for some other reason it can go in,
but it's not sufficiently major to merit an rc4 by itself.
-- PMM
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PULL 0/1] Linux user for 5.0 patches
2020-04-16 19:08 ` Peter Maydell
@ 2020-04-16 19:15 ` Laurent Vivier
2020-04-20 18:55 ` Peter Maydell
1 sibling, 0 replies; 7+ messages in thread
From: Laurent Vivier @ 2020-04-16 19:15 UTC (permalink / raw)
To: Peter Maydell; +Cc: Riku Voipio, QEMU Developers
Le 16/04/2020 à 21:08, Peter Maydell a écrit :
> On Thu, 16 Apr 2020 at 18:16, Laurent Vivier <laurent@vivier.eu> wrote:
>>
>> Le 16/04/2020 à 18:03, Peter Maydell a écrit :
>>> On Thu, 16 Apr 2020 at 16:29, Laurent Vivier <laurent@vivier.eu> wrote:
>>>>
>>>> The following changes since commit 20038cd7a8412feeb49c01f6ede89e36c8995472:
>>>>
>>>> Update version for v5.0.0-rc3 release (2020-04-15 20:51:54 +0100)
>>>>
>>>> are available in the Git repository at:
>>>>
>>>> git://github.com/vivier/qemu.git tags/linux-user-for-5.0-pull-request
>>>>
>>>> for you to fetch changes up to 386d38656889a40d29b514ee6f34997ca18f741e:
>>>>
>>>> linux-user/syscall.c: add target-to-host mapping for epoll_create1() (2020-04-16 09:24:22 +0200)
>>>>
>>>> ----------------------------------------------------------------
>>>> Fix epoll_create1() for qemu-alpha
>>>>
>>>> ----------------------------------------------------------------
>>>
>>> How critical is this bug fix? After rc3, I really don't want
>>> to have to create an rc4 unless it's unavoidable...
>>
>> See the launchpad bug (https://bugs.gentoo.org/717548): on alpha, it
>> prevents the use of python3 in gentoo chroot, and thus we can't use
>> emerge to install packages. It also impacts cmake on debian (see
>> https://bugs.launchpad.net/bugs/1860553).
>>
>> But it's not a regression, so up to you to reject it. It appears now
>> because most of the distro have switched from python2 to python3.
>>
>> It's a low risk change, only in linux-user and for archs that have a
>> different EPOLL_CLOEXEC value.
>
> Thanks for the explanation. I think that I'll put it to one
> side and if we need an rc4 for some other reason it can go in,
> but it's not sufficiently major to merit an rc4 by itself.
>
Thank you, I agree.
Laurent
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PULL 0/1] Linux user for 5.0 patches
2020-04-16 19:08 ` Peter Maydell
2020-04-16 19:15 ` Laurent Vivier
@ 2020-04-20 18:55 ` Peter Maydell
1 sibling, 0 replies; 7+ messages in thread
From: Peter Maydell @ 2020-04-20 18:55 UTC (permalink / raw)
To: Laurent Vivier; +Cc: Riku Voipio, QEMU Developers
On Thu, 16 Apr 2020 at 20:08, Peter Maydell <peter.maydell@linaro.org> wrote:
>
> On Thu, 16 Apr 2020 at 18:16, Laurent Vivier <laurent@vivier.eu> wrote:
> >
> > Le 16/04/2020 à 18:03, Peter Maydell a écrit :
> > > On Thu, 16 Apr 2020 at 16:29, Laurent Vivier <laurent@vivier.eu> wrote:
> > >>
> > >> The following changes since commit 20038cd7a8412feeb49c01f6ede89e36c8995472:
> > >>
> > >> Update version for v5.0.0-rc3 release (2020-04-15 20:51:54 +0100)
> > >>
> > >> are available in the Git repository at:
> > >>
> > >> git://github.com/vivier/qemu.git tags/linux-user-for-5.0-pull-request
> > >>
> > >> for you to fetch changes up to 386d38656889a40d29b514ee6f34997ca18f741e:
> > >>
> > >> linux-user/syscall.c: add target-to-host mapping for epoll_create1() (2020-04-16 09:24:22 +0200)
> > >>
> > >> ----------------------------------------------------------------
> > >> Fix epoll_create1() for qemu-alpha
> > >>
> > >> ----------------------------------------------------------------
> > >
> > > How critical is this bug fix? After rc3, I really don't want
> > > to have to create an rc4 unless it's unavoidable...
> >
> > See the launchpad bug (https://bugs.gentoo.org/717548): on alpha, it
> > prevents the use of python3 in gentoo chroot, and thus we can't use
> > emerge to install packages. It also impacts cmake on debian (see
> > https://bugs.launchpad.net/bugs/1860553).
> >
> > But it's not a regression, so up to you to reject it. It appears now
> > because most of the distro have switched from python2 to python3.
> >
> > It's a low risk change, only in linux-user and for archs that have a
> > different EPOLL_CLOEXEC value.
>
> Thanks for the explanation. I think that I'll put it to one
> side and if we need an rc4 for some other reason it can go in,
> but it's not sufficiently major to merit an rc4 by itself.
We needed an rc4 for the iscsi fix, so I have applied this pullreq.
thanks
-- PMM
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2020-04-20 18:57 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-16 15:28 [PULL 0/1] Linux user for 5.0 patches Laurent Vivier
2020-04-16 15:28 ` [PULL 1/1] linux-user/syscall.c: add target-to-host mapping for epoll_create1() Laurent Vivier
2020-04-16 16:03 ` [PULL 0/1] Linux user for 5.0 patches Peter Maydell
2020-04-16 17:16 ` Laurent Vivier
2020-04-16 19:08 ` Peter Maydell
2020-04-16 19:15 ` Laurent Vivier
2020-04-20 18:55 ` Peter Maydell
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.