From: Will Deacon <will@kernel.org>
To: Matthew Wilcox <willy@infradead.org>
Cc: linux-mm@kvack.org, linux-fsdevel@vger.kernel.org,
William Kucharski <william.kucharski@oracle.com>
Subject: Re: [PATCH v2 1/5] mm: Remove definition of clear_bit_unlock_is_negative_byte
Date: Thu, 16 Apr 2020 18:02:24 +0100 [thread overview]
Message-ID: <20200416170224.GB32685@willie-the-truck> (raw)
In-Reply-To: <20200416154606.306-2-willy@infradead.org>
On Thu, Apr 16, 2020 at 08:46:02AM -0700, Matthew Wilcox wrote:
> From: "Matthew Wilcox (Oracle)" <willy@infradead.org>
>
> This local definition hasn't been used since commit 84c6591103db
> ("locking/atomics, asm-generic/bitops/lock.h: Rewrite using
> atomic_fetch_*()") which provided a default definition.
>
> Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
> Reviewed-by: William Kucharski <william.kucharski@oracle.com>
> Cc: Will Deacon <will@kernel.org>
> ---
> mm/filemap.c | 23 -----------------------
> 1 file changed, 23 deletions(-)
Ok, for my own curiosity I tried building for Alpha because I couldn't for
the life of me figure it out, and behold:
mm/filemap.c: In function 'unlock_page':
mm/filemap.c:1271:6: error: implicit declaration of function 'clear_bit_unlock_is_negative_byte' [-Werror=implicit-function-declaration]
if (clear_bit_unlock_is_negative_byte(PG_locked, &page->flags))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
make[1]: *** [scripts/Makefile.build:267: mm/filemap.o] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:1722: mm] Error 2
make: *** Waiting for unfinished jobs....
I had to enable CONFIG_SMP, so maybe the robot doesn't do that?
Anyway, it's somewhat reassuring that it broke, if not unfortunate at the same
time!
Will
next prev parent reply other threads:[~2020-04-16 17:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-16 15:46 [PATCH v2 0/5] Make PageWriteback use the PageLocked optimisation Matthew Wilcox
2020-04-16 15:46 ` [PATCH v2 1/5] mm: Remove definition of clear_bit_unlock_is_negative_byte Matthew Wilcox
2020-04-16 17:02 ` Will Deacon [this message]
2020-04-16 17:13 ` Matthew Wilcox
2020-04-16 15:46 ` [PATCH v2 2/5] mm: Move PG_writeback into the bottom byte Matthew Wilcox
2020-04-16 15:46 ` [PATCH v2 3/5] mm: Convert writeback BUG to WARN_ON Matthew Wilcox
2020-04-16 15:46 ` [PATCH v2 4/5] mm: Use clear_bit_unlock_is_negative_byte for PageWriteback Matthew Wilcox
2020-04-16 15:46 ` [PATCH v2 5/5] mm: Remove TestClearPageWriteback Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200416170224.GB32685@willie-the-truck \
--to=will@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=william.kucharski@oracle.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.