* [PATCH v1 PATCH v1 0/1] tests: machine-none-test: Enable MicroBlaze testing @ 2020-04-16 19:33 Edgar E. Iglesias 2020-04-16 19:33 ` [PATCH v1 PATCH v1 1/1] " Edgar E. Iglesias 0 siblings, 1 reply; 3+ messages in thread From: Edgar E. Iglesias @ 2020-04-16 19:33 UTC (permalink / raw) To: qemu-devel; +Cc: lvivier, pbonzini, thuth, edgar.iglesias From: "Edgar E. Iglesias" <edgar.iglesias@xilinx.com> This is to re-enable machine-none MicroBlaze testing. Cheers, Edgar Edgar E. Iglesias (1): tests: machine-none-test: Enable MicroBlaze testing tests/qtest/machine-none-test.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) -- 2.20.1 ^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH v1 PATCH v1 1/1] tests: machine-none-test: Enable MicroBlaze testing 2020-04-16 19:33 [PATCH v1 PATCH v1 0/1] tests: machine-none-test: Enable MicroBlaze testing Edgar E. Iglesias @ 2020-04-16 19:33 ` Edgar E. Iglesias 2020-04-25 10:56 ` Paolo Bonzini 0 siblings, 1 reply; 3+ messages in thread From: Edgar E. Iglesias @ 2020-04-16 19:33 UTC (permalink / raw) To: qemu-devel; +Cc: lvivier, pbonzini, thuth, edgar.iglesias From: "Edgar E. Iglesias" <edgar.iglesias@xilinx.com> Enable MicroBlaze testing. Signed-off-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com> --- tests/qtest/machine-none-test.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/tests/qtest/machine-none-test.c b/tests/qtest/machine-none-test.c index 8bb54a6360..209d86eb57 100644 --- a/tests/qtest/machine-none-test.c +++ b/tests/qtest/machine-none-test.c @@ -33,8 +33,8 @@ static struct arch2cpu cpus_map[] = { { "cris", "crisv32" }, { "lm32", "lm32-full" }, { "m68k", "m5206" }, - /* FIXME: { "microblaze", "any" }, doesn't work with -M none -cpu any */ - /* FIXME: { "microblazeel", "any" }, doesn't work with -M none -cpu any */ + { "microblaze", "any" }, + { "microblazeel", "any" }, { "mips", "4Kc" }, { "mipsel", "I7200" }, { "mips64", "20Kc" }, @@ -79,10 +79,8 @@ static void test_machine_cpu_cli(void) QTestState *qts; if (!cpu_model) { - if (!(!strcmp(arch, "microblaze") || !strcmp(arch, "microblazeel"))) { - fprintf(stderr, "WARNING: cpu name for target '%s' isn't defined," - " add it to cpus_map\n", arch); - } + fprintf(stderr, "WARNING: cpu name for target '%s' isn't defined," + " add it to cpus_map\n", arch); return; /* TODO: die here to force all targets have a test */ } qts = qtest_initf("-machine none -cpu '%s'", cpu_model); -- 2.20.1 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v1 PATCH v1 1/1] tests: machine-none-test: Enable MicroBlaze testing 2020-04-16 19:33 ` [PATCH v1 PATCH v1 1/1] " Edgar E. Iglesias @ 2020-04-25 10:56 ` Paolo Bonzini 0 siblings, 0 replies; 3+ messages in thread From: Paolo Bonzini @ 2020-04-25 10:56 UTC (permalink / raw) To: Edgar E. Iglesias, qemu-devel; +Cc: lvivier, edgar.iglesias, thuth On 16/04/20 21:33, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" <edgar.iglesias@xilinx.com> > > Enable MicroBlaze testing. > > Signed-off-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com> > --- > tests/qtest/machine-none-test.c | 10 ++++------ > 1 file changed, 4 insertions(+), 6 deletions(-) > > diff --git a/tests/qtest/machine-none-test.c b/tests/qtest/machine-none-test.c > index 8bb54a6360..209d86eb57 100644 > --- a/tests/qtest/machine-none-test.c > +++ b/tests/qtest/machine-none-test.c > @@ -33,8 +33,8 @@ static struct arch2cpu cpus_map[] = { > { "cris", "crisv32" }, > { "lm32", "lm32-full" }, > { "m68k", "m5206" }, > - /* FIXME: { "microblaze", "any" }, doesn't work with -M none -cpu any */ > - /* FIXME: { "microblazeel", "any" }, doesn't work with -M none -cpu any */ > + { "microblaze", "any" }, > + { "microblazeel", "any" }, > { "mips", "4Kc" }, > { "mipsel", "I7200" }, > { "mips64", "20Kc" }, > @@ -79,10 +79,8 @@ static void test_machine_cpu_cli(void) > QTestState *qts; > > if (!cpu_model) { > - if (!(!strcmp(arch, "microblaze") || !strcmp(arch, "microblazeel"))) { > - fprintf(stderr, "WARNING: cpu name for target '%s' isn't defined," > - " add it to cpus_map\n", arch); > - } > + fprintf(stderr, "WARNING: cpu name for target '%s' isn't defined," > + " add it to cpus_map\n", arch); > return; /* TODO: die here to force all targets have a test */ > } > qts = qtest_initf("-machine none -cpu '%s'", cpu_model); > Queued, thanks. Paolo ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-04-25 10:57 UTC | newest] Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2020-04-16 19:33 [PATCH v1 PATCH v1 0/1] tests: machine-none-test: Enable MicroBlaze testing Edgar E. Iglesias 2020-04-16 19:33 ` [PATCH v1 PATCH v1 1/1] " Edgar E. Iglesias 2020-04-25 10:56 ` Paolo Bonzini
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.