* [linux-next:master 2421/2766] drivers/net/ethernet/intel/iavf/iavf_adminq.c:554:18-26: Unneeded variable: "ret_code". Return "0" on line 562
@ 2020-04-16 14:29 kbuild test robot
2020-04-16 14:29 ` [PATCH] media: cec: fix returnvar.cocci warnings kbuild test robot
0 siblings, 1 reply; 2+ messages in thread
From: kbuild test robot @ 2020-04-16 14:29 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 940 bytes --]
CC: kbuild-all(a)lists.01.org
TO: Mauro Carvalho Chehab <mchehab@kernel.org>
CC: linux-media(a)vger.kernel.org
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: a3ca59b9af21e68069555ffff1ad89bd2a7c40fc
commit: df823a8208c434eee6e4e9aa016c956d0968e2e2 [2421/2766] media: cec: rename CEC platform drivers config options
:::::: branch date: 10 hours ago
:::::: commit date: 28 hours ago
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@intel.com>
Reported-by: Julia Lawall <julia.lawall@lip6.fr>
coccinelle warnings: (new ones prefixed by >>)
>> drivers/net/ethernet/intel/iavf/iavf_adminq.c:554:18-26: Unneeded variable: "ret_code". Return "0" on line 562
Please review and possibly fold the followup patch.
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH] media: cec: fix returnvar.cocci warnings
2020-04-16 14:29 [linux-next:master 2421/2766] drivers/net/ethernet/intel/iavf/iavf_adminq.c:554:18-26: Unneeded variable: "ret_code". Return "0" on line 562 kbuild test robot
@ 2020-04-16 14:29 ` kbuild test robot
0 siblings, 0 replies; 2+ messages in thread
From: kbuild test robot @ 2020-04-16 14:29 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 1420 bytes --]
CC: kbuild-all(a)lists.01.org
TO: Mauro Carvalho Chehab <mchehab@kernel.org>
CC: linux-media(a)vger.kernel.org
From: kbuild test robot <lkp@intel.com>
drivers/net/ethernet/intel/iavf/iavf_adminq.c:554:18-26: Unneeded variable: "ret_code". Return "0" on line 562
Remove unneeded variable used to store return value.
Generated by: scripts/coccinelle/misc/returnvar.cocci
Fixes: df823a8208c4 ("media: cec: rename CEC platform drivers config options")
Signed-off-by: kbuild test robot <lkp@intel.com>
---
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: a3ca59b9af21e68069555ffff1ad89bd2a7c40fc
commit: df823a8208c434eee6e4e9aa016c956d0968e2e2 [2421/2766] media: cec: rename CEC platform drivers config options
:::::: branch date: 10 hours ago
:::::: commit date: 28 hours ago
Please take the patch only if it's a positive warning. Thanks!
iavf_adminq.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
--- a/drivers/net/ethernet/intel/iavf/iavf_adminq.c
+++ b/drivers/net/ethernet/intel/iavf/iavf_adminq.c
@@ -551,15 +551,13 @@ init_adminq_exit:
**/
enum iavf_status iavf_shutdown_adminq(struct iavf_hw *hw)
{
- enum iavf_status ret_code = 0;
-
if (iavf_check_asq_alive(hw))
iavf_aq_queue_shutdown(hw, true);
iavf_shutdown_asq(hw);
iavf_shutdown_arq(hw);
- return ret_code;
+ return 0;
}
/**
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-04-16 14:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-16 14:29 [linux-next:master 2421/2766] drivers/net/ethernet/intel/iavf/iavf_adminq.c:554:18-26: Unneeded variable: "ret_code". Return "0" on line 562 kbuild test robot
2020-04-16 14:29 ` [PATCH] media: cec: fix returnvar.cocci warnings kbuild test robot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.