From: "Michael S. Tsirkin" <mst@redhat.com> To: David Hildenbrand <david@redhat.com> Cc: Alexander Duyck <alexander.duyck@gmail.com>, Jason Wang <jasowang@redhat.com>, virtio-dev@lists.oasis-open.org, virtualization@lists.linux-foundation.org Subject: Re: Re: [PATCH] virtio-balloon: Disable free page hinting/reporting if page poison is disabled Date: Fri, 17 Apr 2020 06:29:19 -0400 [thread overview] Message-ID: <20200417062804-mutt-send-email-mst@kernel.org> (raw) In-Reply-To: <34f46dfc-be16-d057-0760-3cb7c1d1288a@redhat.com> On Fri, Apr 17, 2020 at 12:26:24PM +0200, David Hildenbrand wrote: > On 17.04.20 12:19, Michael S. Tsirkin wrote: > > On Fri, Apr 17, 2020 at 12:09:38PM +0200, David Hildenbrand wrote: > >> > What do you call "hinting ends" though? The fact we put > >>> a page in the VQ is not a guarantee that it's been consumed > >>> by the hypervisor. > >>> > >> > >> I'd say hinting ends once the hypervisor sets FREE_PAGE_REPORT_S_DONE. > > > > Can't find that one anywhere. what did I miss? > > Sorry, the QEMU implementation is confusing. FREE_PAGE_REPORT_S_DONE is > translated to VIRTIO_BALLOON_CMD_ID_DONE Well VIRTIO_BALLOON_CMD_ID_DONE just means "don't give me any more hints, I finished migration". Guest will stop hinting even without that once it scans all free memory. > QEMU: > > hw/virtio/virtio-balloon.c:virtio_balloon_free_page_report_notify() > -> virtio_balloon_free_page_done(dev) > -> s->free_page_report_status = FREE_PAGE_REPORT_S_DONE; > virtio_notify_config(vdev); > > When the guest reads the config > hw/virtio/virtio-balloon.c:virtio_balloon_get_config() > -> if (dev->free_page_report_status == FREE_PAGE_REPORT_S_DONE) > -> config.free_page_report_cmd_id = ... VIRTIO_BALLOON_CMD_ID_DONE > > > Linux: > > drivers/virtio/virtio_balloon.c:report_free_page_func() > -> if (cmd_id_received == VIRTIO_BALLOON_CMD_ID_DONE) { > -> return_free_pages_to_mm() > > > So it's VIRTIO_BALLOON_CMD_ID_DONE. > > > -- > Thanks, > > David / dhildenb
WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com> To: David Hildenbrand <david@redhat.com> Cc: Alexander Duyck <alexander.duyck@gmail.com>, Jason Wang <jasowang@redhat.com>, virtio-dev@lists.oasis-open.org, virtualization@lists.linux-foundation.org Subject: Re: [virtio-dev] Re: [PATCH] virtio-balloon: Disable free page hinting/reporting if page poison is disabled Date: Fri, 17 Apr 2020 06:29:19 -0400 [thread overview] Message-ID: <20200417062804-mutt-send-email-mst@kernel.org> (raw) In-Reply-To: <34f46dfc-be16-d057-0760-3cb7c1d1288a@redhat.com> On Fri, Apr 17, 2020 at 12:26:24PM +0200, David Hildenbrand wrote: > On 17.04.20 12:19, Michael S. Tsirkin wrote: > > On Fri, Apr 17, 2020 at 12:09:38PM +0200, David Hildenbrand wrote: > >> > What do you call "hinting ends" though? The fact we put > >>> a page in the VQ is not a guarantee that it's been consumed > >>> by the hypervisor. > >>> > >> > >> I'd say hinting ends once the hypervisor sets FREE_PAGE_REPORT_S_DONE. > > > > Can't find that one anywhere. what did I miss? > > Sorry, the QEMU implementation is confusing. FREE_PAGE_REPORT_S_DONE is > translated to VIRTIO_BALLOON_CMD_ID_DONE Well VIRTIO_BALLOON_CMD_ID_DONE just means "don't give me any more hints, I finished migration". Guest will stop hinting even without that once it scans all free memory. > QEMU: > > hw/virtio/virtio-balloon.c:virtio_balloon_free_page_report_notify() > -> virtio_balloon_free_page_done(dev) > -> s->free_page_report_status = FREE_PAGE_REPORT_S_DONE; > virtio_notify_config(vdev); > > When the guest reads the config > hw/virtio/virtio-balloon.c:virtio_balloon_get_config() > -> if (dev->free_page_report_status == FREE_PAGE_REPORT_S_DONE) > -> config.free_page_report_cmd_id = ... VIRTIO_BALLOON_CMD_ID_DONE > > > Linux: > > drivers/virtio/virtio_balloon.c:report_free_page_func() > -> if (cmd_id_received == VIRTIO_BALLOON_CMD_ID_DONE) { > -> return_free_pages_to_mm() > > > So it's VIRTIO_BALLOON_CMD_ID_DONE. > > > -- > Thanks, > > David / dhildenb --------------------------------------------------------------------- To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
next prev parent reply other threads:[~2020-04-17 10:29 UTC|newest] Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-04-16 19:30 [PATCH] virtio-balloon: Disable free page hinting/reporting if page poison is disabled Alexander Duyck 2020-04-16 19:30 ` [virtio-dev] " Alexander Duyck 2020-04-16 22:13 ` Michael S. Tsirkin 2020-04-16 22:13 ` [virtio-dev] " Michael S. Tsirkin 2020-04-16 23:52 ` Alexander Duyck 2020-04-16 23:52 ` [virtio-dev] " Alexander Duyck 2020-04-17 6:28 ` Michael S. Tsirkin 2020-04-17 6:28 ` [virtio-dev] " Michael S. Tsirkin 2020-04-17 7:49 ` David Hildenbrand 2020-04-17 7:49 ` David Hildenbrand 2020-04-17 8:50 ` Michael S. Tsirkin 2020-04-17 8:50 ` [virtio-dev] " Michael S. Tsirkin 2020-04-17 9:07 ` David Hildenbrand 2020-04-17 9:07 ` [virtio-dev] " David Hildenbrand 2020-04-17 9:21 ` Michael S. Tsirkin 2020-04-17 9:21 ` [virtio-dev] " Michael S. Tsirkin 2020-04-17 9:51 ` David Hildenbrand 2020-04-17 9:51 ` [virtio-dev] " David Hildenbrand 2020-04-17 9:59 ` Michael S. Tsirkin 2020-04-17 9:59 ` [virtio-dev] " Michael S. Tsirkin 2020-04-17 10:09 ` David Hildenbrand 2020-04-17 10:09 ` [virtio-dev] " David Hildenbrand 2020-04-17 10:19 ` Michael S. Tsirkin 2020-04-17 10:19 ` Michael S. Tsirkin 2020-04-17 10:26 ` David Hildenbrand 2020-04-17 10:26 ` [virtio-dev] " David Hildenbrand 2020-04-17 10:29 ` Michael S. Tsirkin [this message] 2020-04-17 10:29 ` Michael S. Tsirkin 2020-04-17 10:31 ` David Hildenbrand 2020-04-17 10:31 ` [virtio-dev] " David Hildenbrand 2020-04-17 11:02 ` Michael S. Tsirkin 2020-04-17 11:02 ` [virtio-dev] " Michael S. Tsirkin 2020-04-17 11:18 ` David Hildenbrand 2020-04-17 11:18 ` [virtio-dev] " David Hildenbrand 2020-04-17 16:22 ` Alexander Duyck 2020-04-17 16:22 ` [virtio-dev] " Alexander Duyck 2020-04-20 13:28 ` David Hildenbrand 2020-04-20 13:28 ` [virtio-dev] " David Hildenbrand 2020-04-20 18:32 ` Alexander Duyck 2020-04-20 18:32 ` [virtio-dev] " Alexander Duyck 2020-04-21 7:29 ` David Hildenbrand 2020-04-21 7:29 ` [virtio-dev] " David Hildenbrand 2020-04-21 15:05 ` Alexander Duyck 2020-04-21 15:05 ` [virtio-dev] " Alexander Duyck 2020-04-21 15:18 ` David Hildenbrand 2020-04-21 15:18 ` David Hildenbrand 2020-04-21 15:50 ` Alexander Duyck 2020-04-21 15:50 ` [virtio-dev] " Alexander Duyck 2020-04-22 10:24 ` David Hildenbrand 2020-04-22 10:24 ` [virtio-dev] " David Hildenbrand 2020-04-22 15:49 ` Alexander Duyck 2020-04-22 15:49 ` [virtio-dev] " Alexander Duyck 2020-04-17 7:46 ` David Hildenbrand 2020-04-17 7:46 ` [virtio-dev] " David Hildenbrand
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200417062804-mutt-send-email-mst@kernel.org \ --to=mst@redhat.com \ --cc=alexander.duyck@gmail.com \ --cc=david@redhat.com \ --cc=jasowang@redhat.com \ --cc=virtio-dev@lists.oasis-open.org \ --cc=virtualization@lists.linux-foundation.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.