From: Wang Wenhu <wenhu.wang@vivo.com> To: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, robh@kernel.org, oss@buserror.net, christophe.leroy@c-s.fr, linuxppc-dev@lists.ozlabs.org Cc: kernel@vivo.com, Wang Wenhu <wenhu.wang@vivo.com>, Michael Ellerman <mpe@ellerman.id.au> Subject: [PATCH v5,3/4] powerpc: sysdev: fix compile warning for fsl_85xx_cache_sram Date: Fri, 17 Apr 2020 00:16:15 -0700 [thread overview] Message-ID: <20200417071616.44598-4-wenhu.wang@vivo.com> (raw) In-Reply-To: <20200417071616.44598-1-wenhu.wang@vivo.com> Function instantiate_cache_sram should not be linked into the init section for its caller mpc85xx_l2ctlr_of_probe is none-__init. Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: Christophe Leroy <christophe.leroy@c-s.fr> Cc: Scott Wood <oss@buserror.net> Cc: Michael Ellerman <mpe@ellerman.id.au> Cc: linuxppc-dev@lists.ozlabs.org Fixes: 6db92cc9d07d ("powerpc/85xx: add cache-sram support") Reviewed-by: Christophe Leroy <christophe.leroy@c-s.fr> Signed-off-by: Wang Wenhu <wenhu.wang@vivo.com> Warning information: MODPOST vmlinux.o WARNING: modpost: vmlinux.o(.text+0x1e540): Section mismatch in reference from the function mpc85xx_l2ctlr_of_probe() to the function .init.text:instantiate_cache_sram() The function mpc85xx_l2ctlr_of_probe() references the function __init instantiate_cache_sram(). This is often because mpc85xx_l2ctlr_of_probe lacks a __init annotation or the annotation of instantiate_cache_sram is wrong. --- Changes since v1: * None Changes since v2: * None Changes since v3: * None Changes since v4: * None --- arch/powerpc/sysdev/fsl_85xx_cache_sram.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/sysdev/fsl_85xx_cache_sram.c b/arch/powerpc/sysdev/fsl_85xx_cache_sram.c index be3aef4229d7..3de5ac8382c0 100644 --- a/arch/powerpc/sysdev/fsl_85xx_cache_sram.c +++ b/arch/powerpc/sysdev/fsl_85xx_cache_sram.c @@ -68,7 +68,7 @@ void mpc85xx_cache_sram_free(void *ptr) } EXPORT_SYMBOL(mpc85xx_cache_sram_free); -int __init instantiate_cache_sram(struct platform_device *dev, +int instantiate_cache_sram(struct platform_device *dev, struct sram_parameters sram_params) { int ret = 0; -- 2.17.1
WARNING: multiple messages have this Message-ID (diff)
From: Wang Wenhu <wenhu.wang@vivo.com> To: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, robh@kernel.org, oss@buserror.net, christophe.leroy@c-s.fr, linuxppc-dev@lists.ozlabs.org Cc: kernel@vivo.com, Wang Wenhu <wenhu.wang@vivo.com> Subject: [PATCH v5, 3/4] powerpc: sysdev: fix compile warning for fsl_85xx_cache_sram Date: Fri, 17 Apr 2020 00:16:15 -0700 [thread overview] Message-ID: <20200417071616.44598-4-wenhu.wang@vivo.com> (raw) In-Reply-To: <20200417071616.44598-1-wenhu.wang@vivo.com> Function instantiate_cache_sram should not be linked into the init section for its caller mpc85xx_l2ctlr_of_probe is none-__init. Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: Christophe Leroy <christophe.leroy@c-s.fr> Cc: Scott Wood <oss@buserror.net> Cc: Michael Ellerman <mpe@ellerman.id.au> Cc: linuxppc-dev@lists.ozlabs.org Fixes: 6db92cc9d07d ("powerpc/85xx: add cache-sram support") Reviewed-by: Christophe Leroy <christophe.leroy@c-s.fr> Signed-off-by: Wang Wenhu <wenhu.wang@vivo.com> Warning information: MODPOST vmlinux.o WARNING: modpost: vmlinux.o(.text+0x1e540): Section mismatch in reference from the function mpc85xx_l2ctlr_of_probe() to the function .init.text:instantiate_cache_sram() The function mpc85xx_l2ctlr_of_probe() references the function __init instantiate_cache_sram(). This is often because mpc85xx_l2ctlr_of_probe lacks a __init annotation or the annotation of instantiate_cache_sram is wrong. --- Changes since v1: * None Changes since v2: * None Changes since v3: * None Changes since v4: * None --- arch/powerpc/sysdev/fsl_85xx_cache_sram.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/sysdev/fsl_85xx_cache_sram.c b/arch/powerpc/sysdev/fsl_85xx_cache_sram.c index be3aef4229d7..3de5ac8382c0 100644 --- a/arch/powerpc/sysdev/fsl_85xx_cache_sram.c +++ b/arch/powerpc/sysdev/fsl_85xx_cache_sram.c @@ -68,7 +68,7 @@ void mpc85xx_cache_sram_free(void *ptr) } EXPORT_SYMBOL(mpc85xx_cache_sram_free); -int __init instantiate_cache_sram(struct platform_device *dev, +int instantiate_cache_sram(struct platform_device *dev, struct sram_parameters sram_params) { int ret = 0; -- 2.17.1
next prev parent reply other threads:[~2020-04-17 7:17 UTC|newest] Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-04-17 7:16 [PATCH v5,0/4] drivers: uio: new driver uio_fsl_85xx_cache_sram Wang Wenhu 2020-04-17 7:16 ` [PATCH v5,1/4] powerpc: sysdev: fix compile error for fsl_85xx_l2ctlr Wang Wenhu 2020-04-17 7:16 ` [PATCH v5, 1/4] " Wang Wenhu 2020-04-17 7:16 ` [PATCH v5,2/4] powerpc: sysdev: fix compile error for fsl_85xx_cache_sram Wang Wenhu 2020-04-17 7:16 ` [PATCH v5, 2/4] " Wang Wenhu 2020-04-17 7:16 ` Wang Wenhu [this message] 2020-04-17 7:16 ` [PATCH v5, 3/4] powerpc: sysdev: fix compile warning " Wang Wenhu 2020-04-17 7:16 ` [PATCH v5,4/4] drivers: uio: new driver " Wang Wenhu 2020-04-17 7:16 ` Wang Wenhu 2020-04-17 7:42 ` 王文虎 2020-04-17 7:42 ` 王文虎
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200417071616.44598-4-wenhu.wang@vivo.com \ --to=wenhu.wang@vivo.com \ --cc=christophe.leroy@c-s.fr \ --cc=gregkh@linuxfoundation.org \ --cc=kernel@vivo.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linuxppc-dev@lists.ozlabs.org \ --cc=mpe@ellerman.id.au \ --cc=oss@buserror.net \ --cc=robh@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.