[PATCH] pinctrl: rza1: fix wrong array assignment of rza1l_swio_entries

[PATCH] pinctrl: rza1: fix wrong array assignment of rza1l_swio_entries

[Jason Yan]

The rza1l_swio_entries refered to the wrong array rza1h_swio_pins, which
was intended to be rza1l_swio_pins. So let's fix it.

This is detected by the following gcc warning:

drivers/pinctrl/pinctrl-rza1.c:401:35: warning: ‘rza1l_swio_pins’
defined but not used [-Wunused-const-variable=]
 static const struct rza1_swio_pin rza1l_swio_pins[] = {
                                   ^~~~~~~~~~~~~~~

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Jason Yan <yanaijie@huawei.com>
---
 drivers/pinctrl/pinctrl-rza1.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pinctrl/pinctrl-rza1.c b/drivers/pinctrl/pinctrl-rza1.c
index da2d8365c690..ff4a7fb518bb 100644
--- a/drivers/pinctrl/pinctrl-rza1.c
+++ b/drivers/pinctrl/pinctrl-rza1.c
@@ -418,7 +418,7 @@ static const struct rza1_bidir_entry rza1l_bidir_entries[RZA1_NPORTS] = {
 };
 
 static const struct rza1_swio_entry rza1l_swio_entries[] = {
-	[0] = { ARRAY_SIZE(rza1h_swio_pins), rza1h_swio_pins },
+	[0] = { ARRAY_SIZE(rza1l_swio_pins), rza1l_swio_pins },
 };
 
 /* RZ/A1L (r7s72102x) pinmux flags table */
-- 
2.21.1

Re: [PATCH] pinctrl: rza1: fix wrong array assignment of rza1l_swio_entries

[Geert Uytterhoeven]

On Fri, Apr 17, 2020 at 12:50 PM Jason Yan <yanaijie@huawei.com> wrote:
> The rza1l_swio_entries refered to the wrong array rza1h_swio_pins, which
> was intended to be rza1l_swio_pins. So let's fix it.
>
> This is detected by the following gcc warning:
>
> drivers/pinctrl/pinctrl-rza1.c:401:35: warning: ‘rza1l_swio_pins’
> defined but not used [-Wunused-const-variable=]
>  static const struct rza1_swio_pin rza1l_swio_pins[] = {
>                                    ^~~~~~~~~~~~~~~
>
> Reported-by: Hulk Robot <hulkci@huawei.com>

Fixes: 039bc58e73b77723 ("pinctrl: rza1: Add support for RZ/A1L")

> Signed-off-by: Jason Yan <yanaijie@huawei.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
i.e. will queue in sh-pfc-for-v5.8.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds