* [PATCH v1 0/1] hw/arm: versal: Setup the ADMA with 128bit bus-width
@ 2020-04-17 15:37 Edgar E. Iglesias
2020-04-17 15:38 ` [PATCH v1 1/1] " Edgar E. Iglesias
2020-04-20 9:02 ` [PATCH v1 0/1] " Peter Maydell
0 siblings, 2 replies; 5+ messages in thread
From: Edgar E. Iglesias @ 2020-04-17 15:37 UTC (permalink / raw)
To: qemu-devel
Cc: figlesia, peter.maydell, sstabellini, edgar.iglesias,
sai.pavan.boddu, frasse.iglesias, alistair, richard.henderson,
frederic.konrad, qemu-arm, philmd, luc.michel
From: "Edgar E. Iglesias" <edgar.iglesias@xilinx.com>
Running more testcases on the upstream models I noticed that the
ADMA was not setup for 128bit bus-width causing some tests to
fail. This fixes that.
Cheers,
Edgar
Edgar E. Iglesias (1):
hw/arm: versal: Setup the ADMA with 128bit bus-width
hw/arm/xlnx-versal.c | 2 ++
1 file changed, 2 insertions(+)
--
2.20.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v1 1/1] hw/arm: versal: Setup the ADMA with 128bit bus-width
2020-04-17 15:37 [PATCH v1 0/1] hw/arm: versal: Setup the ADMA with 128bit bus-width Edgar E. Iglesias
@ 2020-04-17 15:38 ` Edgar E. Iglesias
2020-04-17 15:41 ` Alistair Francis
2020-04-19 19:03 ` Luc Michel
2020-04-20 9:02 ` [PATCH v1 0/1] " Peter Maydell
1 sibling, 2 replies; 5+ messages in thread
From: Edgar E. Iglesias @ 2020-04-17 15:38 UTC (permalink / raw)
To: qemu-devel
Cc: figlesia, peter.maydell, sstabellini, edgar.iglesias,
sai.pavan.boddu, frasse.iglesias, alistair, richard.henderson,
frederic.konrad, qemu-arm, philmd, luc.michel
From: "Edgar E. Iglesias" <edgar.iglesias@xilinx.com>
Setup the ADMA with 128bit bus-width. This matters when
FIXED BURST mode is used.
Signed-off-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
---
hw/arm/xlnx-versal.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/hw/arm/xlnx-versal.c b/hw/arm/xlnx-versal.c
index cb0122a3a6..94460f2343 100644
--- a/hw/arm/xlnx-versal.c
+++ b/hw/arm/xlnx-versal.c
@@ -205,6 +205,8 @@ static void versal_create_admas(Versal *s, qemu_irq *pic)
dev = qdev_create(NULL, "xlnx.zdma");
s->lpd.iou.adma[i] = SYS_BUS_DEVICE(dev);
+ object_property_set_int(OBJECT(s->lpd.iou.adma[i]), 128, "bus-width",
+ &error_abort);
object_property_add_child(OBJECT(s), name, OBJECT(dev), &error_fatal);
qdev_init_nofail(dev);
--
2.20.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH v1 1/1] hw/arm: versal: Setup the ADMA with 128bit bus-width
2020-04-17 15:38 ` [PATCH v1 1/1] " Edgar E. Iglesias
@ 2020-04-17 15:41 ` Alistair Francis
2020-04-19 19:03 ` Luc Michel
1 sibling, 0 replies; 5+ messages in thread
From: Alistair Francis @ 2020-04-17 15:41 UTC (permalink / raw)
To: Edgar E. Iglesias
Cc: figlesia, Peter Maydell, Edgar Iglesias, Sai Pavan Boddu,
Francisco Iglesias, Alistair Francis, Richard Henderson,
qemu-devel@nongnu.org Developers, KONRAD Frederic,
Stefano Stabellini, qemu-arm, Philippe Mathieu-Daudé,
Luc Michel
On Fri, Apr 17, 2020 at 8:38 AM Edgar E. Iglesias
<edgar.iglesias@gmail.com> wrote:
>
> From: "Edgar E. Iglesias" <edgar.iglesias@xilinx.com>
>
> Setup the ADMA with 128bit bus-width. This matters when
> FIXED BURST mode is used.
>
> Signed-off-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Alistair
> ---
> hw/arm/xlnx-versal.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/hw/arm/xlnx-versal.c b/hw/arm/xlnx-versal.c
> index cb0122a3a6..94460f2343 100644
> --- a/hw/arm/xlnx-versal.c
> +++ b/hw/arm/xlnx-versal.c
> @@ -205,6 +205,8 @@ static void versal_create_admas(Versal *s, qemu_irq *pic)
>
> dev = qdev_create(NULL, "xlnx.zdma");
> s->lpd.iou.adma[i] = SYS_BUS_DEVICE(dev);
> + object_property_set_int(OBJECT(s->lpd.iou.adma[i]), 128, "bus-width",
> + &error_abort);
> object_property_add_child(OBJECT(s), name, OBJECT(dev), &error_fatal);
> qdev_init_nofail(dev);
>
> --
> 2.20.1
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v1 1/1] hw/arm: versal: Setup the ADMA with 128bit bus-width
2020-04-17 15:38 ` [PATCH v1 1/1] " Edgar E. Iglesias
2020-04-17 15:41 ` Alistair Francis
@ 2020-04-19 19:03 ` Luc Michel
1 sibling, 0 replies; 5+ messages in thread
From: Luc Michel @ 2020-04-19 19:03 UTC (permalink / raw)
To: Edgar E. Iglesias, qemu-devel
Cc: figlesia, peter.maydell, sstabellini, edgar.iglesias,
sai.pavan.boddu, frasse.iglesias, alistair, richard.henderson,
frederic.konrad, qemu-arm, philmd
On 4/17/20 5:38 PM, Edgar E. Iglesias wrote:
> From: "Edgar E. Iglesias" <edgar.iglesias@xilinx.com>
>
> Setup the ADMA with 128bit bus-width. This matters when
> FIXED BURST mode is used.
>
> Signed-off-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
Reviewed-by: Luc Michel <luc.michel@greensocs.com>
> ---
> hw/arm/xlnx-versal.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/hw/arm/xlnx-versal.c b/hw/arm/xlnx-versal.c
> index cb0122a3a6..94460f2343 100644
> --- a/hw/arm/xlnx-versal.c
> +++ b/hw/arm/xlnx-versal.c
> @@ -205,6 +205,8 @@ static void versal_create_admas(Versal *s, qemu_irq *pic)
>
> dev = qdev_create(NULL, "xlnx.zdma");
> s->lpd.iou.adma[i] = SYS_BUS_DEVICE(dev);
> + object_property_set_int(OBJECT(s->lpd.iou.adma[i]), 128, "bus-width",
> + &error_abort);
> object_property_add_child(OBJECT(s), name, OBJECT(dev), &error_fatal);
> qdev_init_nofail(dev);
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v1 0/1] hw/arm: versal: Setup the ADMA with 128bit bus-width
2020-04-17 15:37 [PATCH v1 0/1] hw/arm: versal: Setup the ADMA with 128bit bus-width Edgar E. Iglesias
2020-04-17 15:38 ` [PATCH v1 1/1] " Edgar E. Iglesias
@ 2020-04-20 9:02 ` Peter Maydell
1 sibling, 0 replies; 5+ messages in thread
From: Peter Maydell @ 2020-04-20 9:02 UTC (permalink / raw)
To: Edgar E. Iglesias
Cc: figlesia, Edgar Iglesias, Stefano Stabellini, Sai Pavan Boddu,
Francisco Iglesias, Alistair Francis, Richard Henderson,
QEMU Developers, KONRAD Frederic, qemu-arm,
Philippe Mathieu-Daudé,
Luc Michel
On Fri, 17 Apr 2020 at 16:38, Edgar E. Iglesias
<edgar.iglesias@gmail.com> wrote:
>
> From: "Edgar E. Iglesias" <edgar.iglesias@xilinx.com>
>
> Running more testcases on the upstream models I noticed that the
> ADMA was not setup for 128bit bus-width causing some tests to
> fail. This fixes that.
>
> Cheers,
> Edgar
>
> Edgar E. Iglesias (1):
> hw/arm: versal: Setup the ADMA with 128bit bus-width
Applied to target-arm.next for 5.1, thanks.
-- PMM
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-04-20 9:04 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-17 15:37 [PATCH v1 0/1] hw/arm: versal: Setup the ADMA with 128bit bus-width Edgar E. Iglesias
2020-04-17 15:38 ` [PATCH v1 1/1] " Edgar E. Iglesias
2020-04-17 15:41 ` Alistair Francis
2020-04-19 19:03 ` Luc Michel
2020-04-20 9:02 ` [PATCH v1 0/1] " Peter Maydell
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.