* [Buildroot] [PATCH 1/2] package/php: fix zip support
@ 2020-04-18 9:03 Louis Aussedat
2020-04-18 9:03 ` [Buildroot] [PATCH 2/2] package/php: fix gd dependencies Louis Aussedat
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Louis Aussedat @ 2020-04-18 9:03 UTC (permalink / raw)
To: buildroot
since php7.4, --enable-zip becomes --with-zip due to
migration to pkg-config.
Signed-off-by: Louis Aussedat <aussedat.louis@gmail.com>
---
package/php/php.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/package/php/php.mk b/package/php/php.mk
index 91f82dbf31..8282bb1cc7 100644
--- a/package/php/php.mk
+++ b/package/php/php.mk
@@ -113,7 +113,7 @@ PHP_CONF_OPTS += \
$(if $(BR2_PACKAGE_PHP_EXT_SYSVMSG),--enable-sysvmsg) \
$(if $(BR2_PACKAGE_PHP_EXT_SYSVSEM),--enable-sysvsem) \
$(if $(BR2_PACKAGE_PHP_EXT_SYSVSHM),--enable-sysvshm) \
- $(if $(BR2_PACKAGE_PHP_EXT_ZIP),--enable-zip) \
+ $(if $(BR2_PACKAGE_PHP_EXT_ZIP),--with-zip) \
$(if $(BR2_PACKAGE_PHP_EXT_CTYPE),--enable-ctype) \
$(if $(BR2_PACKAGE_PHP_EXT_FILTER),--enable-filter) \
$(if $(BR2_PACKAGE_PHP_EXT_CALENDAR),--enable-calendar) \
--
2.26.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 2/2] package/php: fix gd dependencies
2020-04-18 9:03 [Buildroot] [PATCH 1/2] package/php: fix zip support Louis Aussedat
@ 2020-04-18 9:03 ` Louis Aussedat
2020-04-18 13:26 ` Thomas Petazzoni
2020-05-06 5:28 ` Peter Korsgaard
2020-04-18 13:25 ` [Buildroot] [PATCH 1/2] package/php: fix zip support Thomas Petazzoni
2020-05-06 5:28 ` Peter Korsgaard
2 siblings, 2 replies; 6+ messages in thread
From: Louis Aussedat @ 2020-04-18 9:03 UTC (permalink / raw)
To: buildroot
Due to migration to pkg-config in php 7.4, the detection of
library dependencies has been changed.
source from php.net:
--with-gd becomes --enable-gd
--with-png-dir has been removed. libpng is required.
--with-zlib-dir has been removed. zlib is required.
--with-freetype-dir becomes --with-freetype
--with-jpeg-dir becomes --with-jpeg
Signed-off-by: Louis Aussedat <aussedat.louis@gmail.com>
---
package/php/Config.ext | 1 +
package/php/php.mk | 10 ++++------
2 files changed, 5 insertions(+), 6 deletions(-)
diff --git a/package/php/Config.ext b/package/php/Config.ext
index 193bc1bd03..66ee935cf0 100644
--- a/package/php/Config.ext
+++ b/package/php/Config.ext
@@ -256,6 +256,7 @@ config BR2_PACKAGE_PHP_EXT_GD
select BR2_PACKAGE_FREETYPE
select BR2_PACKAGE_JPEG
select BR2_PACKAGE_LIBPNG
+ select BR2_PACKAGE_ZLIB
help
GD support
diff --git a/package/php/php.mk b/package/php/php.mk
index 8282bb1cc7..4d2f1b8f63 100644
--- a/package/php/php.mk
+++ b/package/php/php.mk
@@ -327,12 +327,10 @@ endif
ifeq ($(BR2_PACKAGE_PHP_EXT_GD),y)
PHP_CONF_OPTS += \
- --with-gd \
- --with-jpeg-dir=$(STAGING_DIR)/usr \
- --with-png-dir=$(STAGING_DIR)/usr \
- --with-zlib-dir=$(STAGING_DIR)/usr \
- --with-freetype-dir=$(STAGING_DIR)/usr
-PHP_DEPENDENCIES += jpeg libpng freetype
+ --enable-gd \
+ --with-jpeg \
+ --with-freetype
+PHP_DEPENDENCIES += jpeg libpng freetype zlib
endif
ifeq ($(BR2_PACKAGE_PHP_SAPI_FPM),y)
--
2.26.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/2] package/php: fix zip support
2020-04-18 9:03 [Buildroot] [PATCH 1/2] package/php: fix zip support Louis Aussedat
2020-04-18 9:03 ` [Buildroot] [PATCH 2/2] package/php: fix gd dependencies Louis Aussedat
@ 2020-04-18 13:25 ` Thomas Petazzoni
2020-05-06 5:28 ` Peter Korsgaard
2 siblings, 0 replies; 6+ messages in thread
From: Thomas Petazzoni @ 2020-04-18 13:25 UTC (permalink / raw)
To: buildroot
On Sat, 18 Apr 2020 11:03:42 +0200
Louis Aussedat <aussedat.louis@gmail.com> wrote:
> since php7.4, --enable-zip becomes --with-zip due to
> migration to pkg-config.
>
> Signed-off-by: Louis Aussedat <aussedat.louis@gmail.com>
> ---
> package/php/php.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 2/2] package/php: fix gd dependencies
2020-04-18 9:03 ` [Buildroot] [PATCH 2/2] package/php: fix gd dependencies Louis Aussedat
@ 2020-04-18 13:26 ` Thomas Petazzoni
2020-05-06 5:28 ` Peter Korsgaard
1 sibling, 0 replies; 6+ messages in thread
From: Thomas Petazzoni @ 2020-04-18 13:26 UTC (permalink / raw)
To: buildroot
Hello Louis,
On Sat, 18 Apr 2020 11:03:43 +0200
Louis Aussedat <aussedat.louis@gmail.com> wrote:
> Due to migration to pkg-config in php 7.4, the detection of
> library dependencies has been changed.
>
> source from php.net:
> --with-gd becomes --enable-gd
> --with-png-dir has been removed. libpng is required.
> --with-zlib-dir has been removed. zlib is required.
> --with-freetype-dir becomes --with-freetype
> --with-jpeg-dir becomes --with-jpeg
>
> Signed-off-by: Louis Aussedat <aussedat.louis@gmail.com>
I've applied. However, we are currently using the bundled libgd source
code that comes from PHP, but it would be good to use an external gd
library from package/gd. This would also allow to make the
freetype/jpeg dependencies optional.
Could you have a look at doing this?
Thanks a lot!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/2] package/php: fix zip support
2020-04-18 9:03 [Buildroot] [PATCH 1/2] package/php: fix zip support Louis Aussedat
2020-04-18 9:03 ` [Buildroot] [PATCH 2/2] package/php: fix gd dependencies Louis Aussedat
2020-04-18 13:25 ` [Buildroot] [PATCH 1/2] package/php: fix zip support Thomas Petazzoni
@ 2020-05-06 5:28 ` Peter Korsgaard
2 siblings, 0 replies; 6+ messages in thread
From: Peter Korsgaard @ 2020-05-06 5:28 UTC (permalink / raw)
To: buildroot
>>>>> "Louis" == Louis Aussedat <aussedat.louis@gmail.com> writes:
> since php7.4, --enable-zip becomes --with-zip due to
> migration to pkg-config.
> Signed-off-by: Louis Aussedat <aussedat.louis@gmail.com>
Committed to 2020.02.x, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 2/2] package/php: fix gd dependencies
2020-04-18 9:03 ` [Buildroot] [PATCH 2/2] package/php: fix gd dependencies Louis Aussedat
2020-04-18 13:26 ` Thomas Petazzoni
@ 2020-05-06 5:28 ` Peter Korsgaard
1 sibling, 0 replies; 6+ messages in thread
From: Peter Korsgaard @ 2020-05-06 5:28 UTC (permalink / raw)
To: buildroot
>>>>> "Louis" == Louis Aussedat <aussedat.louis@gmail.com> writes:
> Due to migration to pkg-config in php 7.4, the detection of
> library dependencies has been changed.
> source from php.net:
> --with-gd becomes --enable-gd
> --with-png-dir has been removed. libpng is required.
> --with-zlib-dir has been removed. zlib is required.
> --with-freetype-dir becomes --with-freetype
> --with-jpeg-dir becomes --with-jpeg
> Signed-off-by: Louis Aussedat <aussedat.louis@gmail.com>
Committed to 2020.02.x, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-05-06 5:28 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-18 9:03 [Buildroot] [PATCH 1/2] package/php: fix zip support Louis Aussedat
2020-04-18 9:03 ` [Buildroot] [PATCH 2/2] package/php: fix gd dependencies Louis Aussedat
2020-04-18 13:26 ` Thomas Petazzoni
2020-05-06 5:28 ` Peter Korsgaard
2020-04-18 13:25 ` [Buildroot] [PATCH 1/2] package/php: fix zip support Thomas Petazzoni
2020-05-06 5:28 ` Peter Korsgaard
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.