From: David Miller <davem@davemloft.net>
To: maz@kernel.org
Cc: netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org, peppe.cavallaro@st.com,
alexandre.torgue@st.com, joabreu@synopsys.com,
khilman@baylibre.com, martin.blumenstingl@googlemail.com,
stable@vger.kernel.org
Subject: Re: [PATCH] net: stmmac: dwmac-meson8b: Add missing boundary to RGMII TX clock array
Date: Mon, 20 Apr 2020 11:11:11 -0700 (PDT) [thread overview]
Message-ID: <20200420.111111.1335274381489892106.davem@davemloft.net> (raw)
In-Reply-To: <20200418181457.3193175-1-maz@kernel.org>
From: Marc Zyngier <maz@kernel.org>
Date: Sat, 18 Apr 2020 19:14:57 +0100
> Running with KASAN on a VIM3L systems leads to the following splat
> when probing the Ethernet device:
>
> ==================================================================
> BUG: KASAN: global-out-of-bounds in _get_maxdiv+0x74/0xd8
> Read of size 4 at addr ffffa000090615f4 by task systemd-udevd/139
> CPU: 1 PID: 139 Comm: systemd-udevd Tainted: G E 5.7.0-rc1-00101-g8624b7577b9c #781
> Hardware name: amlogic w400/w400, BIOS 2020.01-rc5 03/12/2020
...
> Digging into this indeed shows that the clock divider array is
> lacking a final fence, and that the clock subsystems goes in the
> weeds. Oh well.
>
> Let's add the empty structure that indicates the end of the array.
>
> Fixes: bd6f48546b9c ("net: stmmac: dwmac-meson8b: Fix the RGMII TX delay on Meson8b/8m2 SoCs")
> Signed-off-by: Marc Zyngier <maz@kernel.org>
> Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> Cc: stable@vger.kernel.org
Please do not CC: stable@vger.kernel.org for networking changes as per
netdev-FAQ
Applied and queued up for -stable, thanks.
WARNING: multiple messages have this Message-ID (diff)
From: David Miller <davem@davemloft.net>
To: maz@kernel.org
Cc: alexandre.torgue@st.com, martin.blumenstingl@googlemail.com,
netdev@vger.kernel.org, stable@vger.kernel.org,
joabreu@synopsys.com, khilman@baylibre.com,
linux-amlogic@lists.infradead.org, peppe.cavallaro@st.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] net: stmmac: dwmac-meson8b: Add missing boundary to RGMII TX clock array
Date: Mon, 20 Apr 2020 11:11:11 -0700 (PDT) [thread overview]
Message-ID: <20200420.111111.1335274381489892106.davem@davemloft.net> (raw)
In-Reply-To: <20200418181457.3193175-1-maz@kernel.org>
From: Marc Zyngier <maz@kernel.org>
Date: Sat, 18 Apr 2020 19:14:57 +0100
> Running with KASAN on a VIM3L systems leads to the following splat
> when probing the Ethernet device:
>
> ==================================================================
> BUG: KASAN: global-out-of-bounds in _get_maxdiv+0x74/0xd8
> Read of size 4 at addr ffffa000090615f4 by task systemd-udevd/139
> CPU: 1 PID: 139 Comm: systemd-udevd Tainted: G E 5.7.0-rc1-00101-g8624b7577b9c #781
> Hardware name: amlogic w400/w400, BIOS 2020.01-rc5 03/12/2020
...
> Digging into this indeed shows that the clock divider array is
> lacking a final fence, and that the clock subsystems goes in the
> weeds. Oh well.
>
> Let's add the empty structure that indicates the end of the array.
>
> Fixes: bd6f48546b9c ("net: stmmac: dwmac-meson8b: Fix the RGMII TX delay on Meson8b/8m2 SoCs")
> Signed-off-by: Marc Zyngier <maz@kernel.org>
> Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> Cc: stable@vger.kernel.org
Please do not CC: stable@vger.kernel.org for networking changes as per
netdev-FAQ
Applied and queued up for -stable, thanks.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: David Miller <davem@davemloft.net>
To: maz@kernel.org
Cc: alexandre.torgue@st.com, martin.blumenstingl@googlemail.com,
netdev@vger.kernel.org, stable@vger.kernel.org,
joabreu@synopsys.com, khilman@baylibre.com,
linux-amlogic@lists.infradead.org, peppe.cavallaro@st.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] net: stmmac: dwmac-meson8b: Add missing boundary to RGMII TX clock array
Date: Mon, 20 Apr 2020 11:11:11 -0700 (PDT) [thread overview]
Message-ID: <20200420.111111.1335274381489892106.davem@davemloft.net> (raw)
In-Reply-To: <20200418181457.3193175-1-maz@kernel.org>
From: Marc Zyngier <maz@kernel.org>
Date: Sat, 18 Apr 2020 19:14:57 +0100
> Running with KASAN on a VIM3L systems leads to the following splat
> when probing the Ethernet device:
>
> ==================================================================
> BUG: KASAN: global-out-of-bounds in _get_maxdiv+0x74/0xd8
> Read of size 4 at addr ffffa000090615f4 by task systemd-udevd/139
> CPU: 1 PID: 139 Comm: systemd-udevd Tainted: G E 5.7.0-rc1-00101-g8624b7577b9c #781
> Hardware name: amlogic w400/w400, BIOS 2020.01-rc5 03/12/2020
...
> Digging into this indeed shows that the clock divider array is
> lacking a final fence, and that the clock subsystems goes in the
> weeds. Oh well.
>
> Let's add the empty structure that indicates the end of the array.
>
> Fixes: bd6f48546b9c ("net: stmmac: dwmac-meson8b: Fix the RGMII TX delay on Meson8b/8m2 SoCs")
> Signed-off-by: Marc Zyngier <maz@kernel.org>
> Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> Cc: stable@vger.kernel.org
Please do not CC: stable@vger.kernel.org for networking changes as per
netdev-FAQ
Applied and queued up for -stable, thanks.
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2020-04-20 18:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-18 18:14 [PATCH] net: stmmac: dwmac-meson8b: Add missing boundary to RGMII TX clock array Marc Zyngier
2020-04-18 18:14 ` Marc Zyngier
2020-04-18 18:14 ` Marc Zyngier
2020-04-19 16:58 ` Martin Blumenstingl
2020-04-19 16:58 ` Martin Blumenstingl
2020-04-19 16:58 ` Martin Blumenstingl
2020-04-20 18:11 ` David Miller [this message]
2020-04-20 18:11 ` David Miller
2020-04-20 18:11 ` David Miller
2020-04-29 0:21 ` patchwork-bot+linux-amlogic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200420.111111.1335274381489892106.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=alexandre.torgue@st.com \
--cc=joabreu@synopsys.com \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=maz@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.