* [PATCH iproute2] tc: fq_codel: fix class stat deficit is signed int
@ 2020-04-15 4:11 Benjamin Lee
2020-04-20 16:51 ` Stephen Hemminger
0 siblings, 1 reply; 2+ messages in thread
From: Benjamin Lee @ 2020-04-15 4:11 UTC (permalink / raw)
To: netdev; +Cc: Benjamin Lee
The fq_codel class stat deficit is a signed int. This is a regression
from when JSON output was added.
Fixes: 997f2dc19378 ("tc: Add JSON output of fq_codel stats")
Signed-off-by: Benjamin Lee <ben@b1c1l1.com>
---
tc/q_fq_codel.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tc/q_fq_codel.c b/tc/q_fq_codel.c
index efed4d28..1c6cf1e0 100644
--- a/tc/q_fq_codel.c
+++ b/tc/q_fq_codel.c
@@ -264,7 +264,7 @@ static int fq_codel_print_xstats(struct qdisc_util *qu, FILE *f,
st->qdisc_stats.old_flows_len);
}
if (st->type == TCA_FQ_CODEL_XSTATS_CLASS) {
- print_uint(PRINT_ANY, "deficit", " deficit %u",
+ print_int(PRINT_ANY, "deficit", " deficit %d",
st->class_stats.deficit);
print_uint(PRINT_ANY, "count", " count %u",
st->class_stats.count);
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH iproute2] tc: fq_codel: fix class stat deficit is signed int
2020-04-15 4:11 [PATCH iproute2] tc: fq_codel: fix class stat deficit is signed int Benjamin Lee
@ 2020-04-20 16:51 ` Stephen Hemminger
0 siblings, 0 replies; 2+ messages in thread
From: Stephen Hemminger @ 2020-04-20 16:51 UTC (permalink / raw)
To: Benjamin Lee; +Cc: netdev
On Tue, 14 Apr 2020 21:11:12 -0700
Benjamin Lee <ben@b1c1l1.com> wrote:
> The fq_codel class stat deficit is a signed int. This is a regression
> from when JSON output was added.
>
> Fixes: 997f2dc19378 ("tc: Add JSON output of fq_codel stats")
> Signed-off-by: Benjamin Lee <ben@b1c1l1.com>
> ---
Applied, thanks
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-04-20 16:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-15 4:11 [PATCH iproute2] tc: fq_codel: fix class stat deficit is signed int Benjamin Lee
2020-04-20 16:51 ` Stephen Hemminger
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.