* [PATCH v2] of_device: removed #include that caused a recursion in included headers
@ 2020-04-16 9:49 ` Hadar Gat
0 siblings, 0 replies; 25+ messages in thread
From: Hadar Gat @ 2020-04-16 9:49 UTC (permalink / raw)
To: David S. Miller, Greg Kroah-Hartman, Shawn Guo, Sascha Hauer,
Liviu Dudau, Sudeep Holla, Lorenzo Pieralisi, Michael Turquette,
Stephen Boyd, Matthias Brugger, Ludovic Desroches, Vinod Koul,
Maxime Coquelin, Alexandre Torgue, Rob Clark, Sean Paul,
David Airlie, Daniel Vetter, Sandy Huang, Heiko Stübner,
Maxime Ripard, Chen-Yu Tsai, Jonathan Cameron, Thierry Reding,
Joerg Roedel, Jonathan Hunter, Nicolas Ferre, Alexandre Belloni,
Tony Lindgren, Lee Jones, Andy Gross, Bjorn Andersson,
Miquel Raynal, Richard Weinberger, Vignesh Raghavendra,
Giuseppe Cavallaro, Jose Abreu, JC Kuo, Kishon Vijay Abraham I,
Dong Aisheng, Fabio Estevam, Stefan Agner, Linus Walleij,
Kukjin Kim, Krzysztof Kozlowski, Rob Herring, Frank Rowand
Cc: linux-iio, dri-devel, linux-mtd, sparclinux, linux-stm32,
linux-samsung-soc, linux-clk, linux-rockchip, Hadar Gat,
devicetree, linux-arm-msm, linux-gpio, linux-mediatek,
linux-tegra, linux-omap, linux-arm-kernel, Ofir Drang,
Gilad Ben-Yossef, netdev, linux-kernel, iommu, dmaengine,
freedreno
Both of_platform.h and of_device.h were included each other.
In of_device.h, removed unneeded #include to of_platform.h
and added include to of_platform.h in the files that needs it.
Signed-off-by: Hadar Gat <hadar.gat@arm.com>
---
v2: add include to of_platform.h in more files. (reported due other builds)
arch/sparc/mm/io-unit.c | 1 +
arch/sparc/mm/iommu.c | 1 +
drivers/base/platform.c | 1 +
drivers/bus/imx-weim.c | 1 +
drivers/bus/vexpress-config.c | 1 +
drivers/clk/mediatek/clk-mt7622-aud.c | 1 +
drivers/dma/at_hdmac.c | 1 +
drivers/dma/stm32-dmamux.c | 1 +
drivers/dma/ti/dma-crossbar.c | 1 +
drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 1 +
drivers/gpu/drm/msm/hdmi/hdmi.c | 1 +
drivers/gpu/drm/msm/msm_drv.c | 1 +
drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c | 1 +
drivers/gpu/drm/sun4i/sun4i_tcon.c | 1 +
drivers/iio/adc/stm32-adc-core.c | 1 +
drivers/iio/adc/stm32-dfsdm-adc.c | 1 +
drivers/iio/adc/stm32-dfsdm-core.c | 1 +
drivers/iommu/tegra-smmu.c | 1 +
drivers/memory/atmel-ebi.c | 1 +
drivers/mfd/palmas.c | 1 +
drivers/mfd/ssbi.c | 1 +
drivers/mtd/nand/raw/omap2.c | 1 +
drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c | 1 +
drivers/net/ethernet/ti/cpsw.c | 1 +
drivers/phy/tegra/xusb.c | 1 +
drivers/pinctrl/freescale/pinctrl-imx1-core.c | 1 +
drivers/pinctrl/nomadik/pinctrl-nomadik.c | 1 +
drivers/soc/samsung/exynos-pmu.c | 1 +
drivers/soc/sunxi/sunxi_sram.c | 1 +
include/linux/of_device.h | 2 --
lib/genalloc.c | 1 +
31 files changed, 30 insertions(+), 2 deletions(-)
diff --git a/arch/sparc/mm/io-unit.c b/arch/sparc/mm/io-unit.c
index 289276b..5638399 100644
--- a/arch/sparc/mm/io-unit.c
+++ b/arch/sparc/mm/io-unit.c
@@ -15,6 +15,7 @@
#include <linux/dma-mapping.h>
#include <linux/of.h>
#include <linux/of_device.h>
+#include <linux/of_platform.h>
#include <asm/pgalloc.h>
#include <asm/pgtable.h>
diff --git a/arch/sparc/mm/iommu.c b/arch/sparc/mm/iommu.c
index b00dde1..9cbb2e7 100644
--- a/arch/sparc/mm/iommu.c
+++ b/arch/sparc/mm/iommu.c
@@ -16,6 +16,7 @@
#include <linux/dma-mapping.h>
#include <linux/of.h>
#include <linux/of_device.h>
+#include <linux/of_platform.h>
#include <asm/pgalloc.h>
#include <asm/pgtable.h>
diff --git a/drivers/base/platform.c b/drivers/base/platform.c
index 5255550..f549274b 100644
--- a/drivers/base/platform.c
+++ b/drivers/base/platform.c
@@ -12,6 +12,7 @@
#include <linux/string.h>
#include <linux/platform_device.h>
#include <linux/of_device.h>
+#include <linux/of_platform.h>
#include <linux/of_irq.h>
#include <linux/module.h>
#include <linux/init.h>
diff --git a/drivers/bus/imx-weim.c b/drivers/bus/imx-weim.c
index 28bb65a..8c786da 100644
--- a/drivers/bus/imx-weim.c
+++ b/drivers/bus/imx-weim.c
@@ -11,6 +11,7 @@
#include <linux/clk.h>
#include <linux/io.h>
#include <linux/of_device.h>
+#include <linux/of_platform.h>
#include <linux/mfd/syscon.h>
#include <linux/mfd/syscon/imx6q-iomuxc-gpr.h>
#include <linux/regmap.h>
diff --git a/drivers/bus/vexpress-config.c b/drivers/bus/vexpress-config.c
index ff70575..12b8b0b 100644
--- a/drivers/bus/vexpress-config.c
+++ b/drivers/bus/vexpress-config.c
@@ -8,6 +8,7 @@
#include <linux/init.h>
#include <linux/of.h>
#include <linux/of_device.h>
+#include <linux/of_platform.h>
#include <linux/vexpress.h>
diff --git a/drivers/clk/mediatek/clk-mt7622-aud.c b/drivers/clk/mediatek/clk-mt7622-aud.c
index 2bd4295..8cbb68f 100644
--- a/drivers/clk/mediatek/clk-mt7622-aud.c
+++ b/drivers/clk/mediatek/clk-mt7622-aud.c
@@ -9,6 +9,7 @@
#include <linux/of.h>
#include <linux/of_address.h>
#include <linux/of_device.h>
+#include <linux/of_platform.h>
#include <linux/platform_device.h>
#include "clk-mtk.h"
diff --git a/drivers/dma/at_hdmac.c b/drivers/dma/at_hdmac.c
index 73a2078..388f8e10 100644
--- a/drivers/dma/at_hdmac.c
+++ b/drivers/dma/at_hdmac.c
@@ -20,6 +20,7 @@
#include <linux/slab.h>
#include <linux/of.h>
#include <linux/of_device.h>
+#include <linux/of_platform.h>
#include <linux/of_dma.h>
#include "at_hdmac_regs.h"
diff --git a/drivers/dma/stm32-dmamux.c b/drivers/dma/stm32-dmamux.c
index 12f7637..b704896 100644
--- a/drivers/dma/stm32-dmamux.c
+++ b/drivers/dma/stm32-dmamux.c
@@ -16,6 +16,7 @@
#include <linux/init.h>
#include <linux/module.h>
#include <linux/of_device.h>
+#include <linux/of_platform.h>
#include <linux/of_dma.h>
#include <linux/pm_runtime.h>
#include <linux/reset.h>
diff --git a/drivers/dma/ti/dma-crossbar.c b/drivers/dma/ti/dma-crossbar.c
index 4ba8fa5..2c0fd44 100644
--- a/drivers/dma/ti/dma-crossbar.c
+++ b/drivers/dma/ti/dma-crossbar.c
@@ -10,6 +10,7 @@
#include <linux/io.h>
#include <linux/of_address.h>
#include <linux/of_device.h>
+#include <linux/of_platform.h>
#include <linux/of_dma.h>
#define TI_XBAR_DRA7 0
diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c b/drivers/gpu/drm/msm/adreno/a6xx_gmu.c
index c4e71ab..f523254 100644
--- a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c
+++ b/drivers/gpu/drm/msm/adreno/a6xx_gmu.c
@@ -6,6 +6,7 @@
#include <linux/interconnect.h>
#include <linux/pm_domain.h>
#include <linux/pm_opp.h>
+#include <linux/of_platform.h>
#include <soc/qcom/cmd-db.h>
#include "a6xx_gpu.h"
diff --git a/drivers/gpu/drm/msm/hdmi/hdmi.c b/drivers/gpu/drm/msm/hdmi/hdmi.c
index 737453b..5034d40 100644
--- a/drivers/gpu/drm/msm/hdmi/hdmi.c
+++ b/drivers/gpu/drm/msm/hdmi/hdmi.c
@@ -7,6 +7,7 @@
#include <linux/of_irq.h>
#include <linux/of_gpio.h>
+#include <linux/of_platform.h>
#include <sound/hdmi-codec.h>
#include "hdmi.h"
diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c
index 29295de..ddc9e85 100644
--- a/drivers/gpu/drm/msm/msm_drv.c
+++ b/drivers/gpu/drm/msm/msm_drv.c
@@ -8,6 +8,7 @@
#include <linux/dma-mapping.h>
#include <linux/kthread.h>
#include <linux/uaccess.h>
+#include <linux/of_platform.h>
#include <uapi/linux/sched/types.h>
#include <drm/drm_drv.h>
diff --git a/drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c b/drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c
index 6e1270e..d038bae 100644
--- a/drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c
+++ b/drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c
@@ -12,6 +12,7 @@
#include <linux/mfd/syscon.h>
#include <linux/module.h>
#include <linux/of_device.h>
+#include <linux/of_platform.h>
#include <linux/phy/phy.h>
#include <linux/pm_runtime.h>
#include <linux/regmap.h>
diff --git a/drivers/gpu/drm/sun4i/sun4i_tcon.c b/drivers/gpu/drm/sun4i/sun4i_tcon.c
index 624437b..aa35757 100644
--- a/drivers/gpu/drm/sun4i/sun4i_tcon.c
+++ b/drivers/gpu/drm/sun4i/sun4i_tcon.c
@@ -11,6 +11,7 @@
#include <linux/module.h>
#include <linux/of_address.h>
#include <linux/of_device.h>
+#include <linux/of_platform.h>
#include <linux/of_irq.h>
#include <linux/regmap.h>
#include <linux/reset.h>
diff --git a/drivers/iio/adc/stm32-adc-core.c b/drivers/iio/adc/stm32-adc-core.c
index 2df88d2..3dc3453 100644
--- a/drivers/iio/adc/stm32-adc-core.c
+++ b/drivers/iio/adc/stm32-adc-core.c
@@ -17,6 +17,7 @@
#include <linux/mfd/syscon.h>
#include <linux/module.h>
#include <linux/of_device.h>
+#include <linux/of_platform.h>
#include <linux/pm_runtime.h>
#include <linux/regmap.h>
#include <linux/regulator/consumer.h>
diff --git a/drivers/iio/adc/stm32-dfsdm-adc.c b/drivers/iio/adc/stm32-dfsdm-adc.c
index 76a60d9..e83848cb 100644
--- a/drivers/iio/adc/stm32-dfsdm-adc.c
+++ b/drivers/iio/adc/stm32-dfsdm-adc.c
@@ -20,6 +20,7 @@
#include <linux/interrupt.h>
#include <linux/module.h>
#include <linux/of_device.h>
+#include <linux/of_platform.h>
#include <linux/platform_device.h>
#include <linux/regmap.h>
#include <linux/slab.h>
diff --git a/drivers/iio/adc/stm32-dfsdm-core.c b/drivers/iio/adc/stm32-dfsdm-core.c
index 26e2011..f6a53ab 100644
--- a/drivers/iio/adc/stm32-dfsdm-core.c
+++ b/drivers/iio/adc/stm32-dfsdm-core.c
@@ -12,6 +12,7 @@
#include <linux/interrupt.h>
#include <linux/module.h>
#include <linux/of_device.h>
+#include <linux/of_platform.h>
#include <linux/pinctrl/consumer.h>
#include <linux/pm_runtime.h>
#include <linux/regmap.h>
diff --git a/drivers/iommu/tegra-smmu.c b/drivers/iommu/tegra-smmu.c
index 63a147b..3797caa 100644
--- a/drivers/iommu/tegra-smmu.c
+++ b/drivers/iommu/tegra-smmu.c
@@ -10,6 +10,7 @@
#include <linux/kernel.h>
#include <linux/of.h>
#include <linux/of_device.h>
+#include <linux/of_platform.h>
#include <linux/platform_device.h>
#include <linux/slab.h>
#include <linux/dma-mapping.h>
diff --git a/drivers/memory/atmel-ebi.c b/drivers/memory/atmel-ebi.c
index 14386d0..272b1a8 100644
--- a/drivers/memory/atmel-ebi.c
+++ b/drivers/memory/atmel-ebi.c
@@ -13,6 +13,7 @@
#include <linux/mfd/syscon/atmel-smc.h>
#include <linux/init.h>
#include <linux/of_device.h>
+#include <linux/of_platform.h>
#include <linux/regmap.h>
#include <soc/at91/atmel-sfr.h>
diff --git a/drivers/mfd/palmas.c b/drivers/mfd/palmas.c
index f5b3fa9..cca44bc 100644
--- a/drivers/mfd/palmas.c
+++ b/drivers/mfd/palmas.c
@@ -19,6 +19,7 @@
#include <linux/mfd/core.h>
#include <linux/mfd/palmas.h>
#include <linux/of_device.h>
+#include <linux/of_platform.h>
static const struct regmap_config palmas_regmap_config[PALMAS_NUM_CLIENTS] = {
{
diff --git a/drivers/mfd/ssbi.c b/drivers/mfd/ssbi.c
index 94f60df..72cd45a 100644
--- a/drivers/mfd/ssbi.c
+++ b/drivers/mfd/ssbi.c
@@ -20,6 +20,7 @@
#include <linux/module.h>
#include <linux/of.h>
#include <linux/of_device.h>
+#include <linux/of_platform.h>
/* SSBI 2.0 controller registers */
#define SSBI2_CMD 0x0008
diff --git a/drivers/mtd/nand/raw/omap2.c b/drivers/mtd/nand/raw/omap2.c
index ad77c11..d851ec7 100644
--- a/drivers/mtd/nand/raw/omap2.c
+++ b/drivers/mtd/nand/raw/omap2.c
@@ -22,6 +22,7 @@
#include <linux/slab.h>
#include <linux/of.h>
#include <linux/of_device.h>
+#include <linux/of_platform.h>
#include <linux/mtd/nand_bch.h>
#include <linux/platform_data/elm.h>
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c
index 58e0511..d704d57 100644
--- a/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c
+++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c
@@ -12,6 +12,7 @@
#include <linux/mfd/syscon.h>
#include <linux/module.h>
#include <linux/of_device.h>
+#include <linux/of_platform.h>
#include <linux/of_mdio.h>
#include <linux/of_net.h>
#include <linux/phy.h>
diff --git a/drivers/net/ethernet/ti/cpsw.c b/drivers/net/ethernet/ti/cpsw.c
index c2c5bf8..6932945 100644
--- a/drivers/net/ethernet/ti/cpsw.c
+++ b/drivers/net/ethernet/ti/cpsw.c
@@ -28,6 +28,7 @@
#include <linux/of_mdio.h>
#include <linux/of_net.h>
#include <linux/of_device.h>
+#include <linux/of_platform.h>
#include <linux/if_vlan.h>
#include <linux/kmemleak.h>
#include <linux/sys_soc.h>
diff --git a/drivers/phy/tegra/xusb.c b/drivers/phy/tegra/xusb.c
index de4a46f..0eac1b8 100644
--- a/drivers/phy/tegra/xusb.c
+++ b/drivers/phy/tegra/xusb.c
@@ -9,6 +9,7 @@
#include <linux/module.h>
#include <linux/of.h>
#include <linux/of_device.h>
+#include <linux/of_platform.h>
#include <linux/phy/phy.h>
#include <linux/phy/tegra/xusb.h>
#include <linux/platform_device.h>
diff --git a/drivers/pinctrl/freescale/pinctrl-imx1-core.c b/drivers/pinctrl/freescale/pinctrl-imx1-core.c
index c00d002..d1c171e 100644
--- a/drivers/pinctrl/freescale/pinctrl-imx1-core.c
+++ b/drivers/pinctrl/freescale/pinctrl-imx1-core.c
@@ -16,6 +16,7 @@
#include <linux/io.h>
#include <linux/of.h>
#include <linux/of_device.h>
+#include <linux/of_platform.h>
#include <linux/pinctrl/machine.h>
#include <linux/pinctrl/pinconf.h>
#include <linux/pinctrl/pinctrl.h>
diff --git a/drivers/pinctrl/nomadik/pinctrl-nomadik.c b/drivers/pinctrl/nomadik/pinctrl-nomadik.c
index ca7bbe4..44974ac 100644
--- a/drivers/pinctrl/nomadik/pinctrl-nomadik.c
+++ b/drivers/pinctrl/nomadik/pinctrl-nomadik.c
@@ -19,6 +19,7 @@
#include <linux/interrupt.h>
#include <linux/slab.h>
#include <linux/of_device.h>
+#include <linux/of_platform.h>
#include <linux/of_address.h>
#include <linux/bitops.h>
#include <linux/pinctrl/machine.h>
diff --git a/drivers/soc/samsung/exynos-pmu.c b/drivers/soc/samsung/exynos-pmu.c
index 17304fa..25129b0 100644
--- a/drivers/soc/samsung/exynos-pmu.c
+++ b/drivers/soc/samsung/exynos-pmu.c
@@ -8,6 +8,7 @@
#include <linux/of.h>
#include <linux/of_address.h>
#include <linux/of_device.h>
+#include <linux/of_platform.h>
#include <linux/mfd/syscon.h>
#include <linux/platform_device.h>
#include <linux/delay.h>
diff --git a/drivers/soc/sunxi/sunxi_sram.c b/drivers/soc/sunxi/sunxi_sram.c
index 1b0d50f..423cec3 100644
--- a/drivers/soc/sunxi/sunxi_sram.c
+++ b/drivers/soc/sunxi/sunxi_sram.c
@@ -16,6 +16,7 @@
#include <linux/of.h>
#include <linux/of_address.h>
#include <linux/of_device.h>
+#include <linux/of_platform.h>
#include <linux/platform_device.h>
#include <linux/regmap.h>
diff --git a/include/linux/of_device.h b/include/linux/of_device.h
index 8d31e39..752999b 100644
--- a/include/linux/of_device.h
+++ b/include/linux/of_device.h
@@ -4,8 +4,6 @@
#include <linux/cpu.h>
#include <linux/platform_device.h>
-#include <linux/of_platform.h> /* temporary until merge */
-
#include <linux/of.h>
#include <linux/mod_devicetable.h>
diff --git a/lib/genalloc.c b/lib/genalloc.c
index 7f1244b..08e21eeb 100644
--- a/lib/genalloc.c
+++ b/lib/genalloc.c
@@ -33,6 +33,7 @@
#include <linux/interrupt.h>
#include <linux/genalloc.h>
#include <linux/of_device.h>
+#include <linux/of_platform.h>
#include <linux/vmalloc.h>
static inline size_t chunk_size(const struct gen_pool_chunk *chunk)
--
2.7.4
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 25+ messages in thread* [PATCH v2] of_device: removed #include that caused a recursion in included headers
@ 2020-04-16 9:49 ` Hadar Gat
0 siblings, 0 replies; 25+ messages in thread
From: Hadar Gat @ 2020-04-16 9:49 UTC (permalink / raw)
To: David S. Miller, Greg Kroah-Hartman, Shawn Guo, Sascha Hauer,
Liviu Dudau, Sudeep Holla, Lorenzo Pieralisi, Michael Turquette,
Stephen Boyd, Matthias Brugger, Ludovic Desroches, Vinod Koul,
Maxime Coquelin, Alexandre Torgue, Rob Clark, Sean Paul,
David Airlie, Daniel Vetter, Sandy Huang, Heiko Stübner,
Maxime Ripard, Chen-Yu Tsai, Jonathan Cameron, Thierry Reding,
Joerg Roedel, Jonathan Hunter, Nicolas Ferre, Alexandre Belloni,
Tony Lindgren, Lee Jones, Andy Gross, Bjorn Andersson,
Miquel Raynal, Richard Weinberger, Vignesh Raghavendra,
Giuseppe Cavallaro, Jose Abreu, JC Kuo, Kishon Vijay Abraham I,
Dong Aisheng, Fabio Estevam, Stefan Agner, Linus Walleij,
Kukjin Kim, Krzysztof Kozlowski, Rob Herring, Frank Rowand
Cc: linux-iio, dri-devel, linux-mtd, sparclinux, linux-stm32,
linux-samsung-soc, linux-clk, linux-rockchip, Hadar Gat,
devicetree, linux-arm-msm, linux-gpio, linux-mediatek,
linux-tegra, linux-omap, linux-arm-kernel, Ofir Drang,
Gilad Ben-Yossef, netdev, linux-kernel, iommu, dmaengine,
freedreno
Both of_platform.h and of_device.h were included each other.
In of_device.h, removed unneeded #include to of_platform.h
and added include to of_platform.h in the files that needs it.
Signed-off-by: Hadar Gat <hadar.gat@arm.com>
---
v2: add include to of_platform.h in more files. (reported due other builds)
arch/sparc/mm/io-unit.c | 1 +
arch/sparc/mm/iommu.c | 1 +
drivers/base/platform.c | 1 +
drivers/bus/imx-weim.c | 1 +
drivers/bus/vexpress-config.c | 1 +
drivers/clk/mediatek/clk-mt7622-aud.c | 1 +
drivers/dma/at_hdmac.c | 1 +
drivers/dma/stm32-dmamux.c | 1 +
drivers/dma/ti/dma-crossbar.c | 1 +
drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 1 +
drivers/gpu/drm/msm/hdmi/hdmi.c | 1 +
drivers/gpu/drm/msm/msm_drv.c | 1 +
drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c | 1 +
drivers/gpu/drm/sun4i/sun4i_tcon.c | 1 +
drivers/iio/adc/stm32-adc-core.c | 1 +
drivers/iio/adc/stm32-dfsdm-adc.c | 1 +
drivers/iio/adc/stm32-dfsdm-core.c | 1 +
drivers/iommu/tegra-smmu.c | 1 +
drivers/memory/atmel-ebi.c | 1 +
drivers/mfd/palmas.c | 1 +
drivers/mfd/ssbi.c | 1 +
drivers/mtd/nand/raw/omap2.c | 1 +
drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c | 1 +
drivers/net/ethernet/ti/cpsw.c | 1 +
drivers/phy/tegra/xusb.c | 1 +
drivers/pinctrl/freescale/pinctrl-imx1-core.c | 1 +
drivers/pinctrl/nomadik/pinctrl-nomadik.c | 1 +
drivers/soc/samsung/exynos-pmu.c | 1 +
drivers/soc/sunxi/sunxi_sram.c | 1 +
include/linux/of_device.h | 2 --
lib/genalloc.c | 1 +
31 files changed, 30 insertions(+), 2 deletions(-)
diff --git a/arch/sparc/mm/io-unit.c b/arch/sparc/mm/io-unit.c
index 289276b..5638399 100644
--- a/arch/sparc/mm/io-unit.c
+++ b/arch/sparc/mm/io-unit.c
@@ -15,6 +15,7 @@
#include <linux/dma-mapping.h>
#include <linux/of.h>
#include <linux/of_device.h>
+#include <linux/of_platform.h>
#include <asm/pgalloc.h>
#include <asm/pgtable.h>
diff --git a/arch/sparc/mm/iommu.c b/arch/sparc/mm/iommu.c
index b00dde1..9cbb2e7 100644
--- a/arch/sparc/mm/iommu.c
+++ b/arch/sparc/mm/iommu.c
@@ -16,6 +16,7 @@
#include <linux/dma-mapping.h>
#include <linux/of.h>
#include <linux/of_device.h>
+#include <linux/of_platform.h>
#include <asm/pgalloc.h>
#include <asm/pgtable.h>
diff --git a/drivers/base/platform.c b/drivers/base/platform.c
index 5255550..f549274b 100644
--- a/drivers/base/platform.c
+++ b/drivers/base/platform.c
@@ -12,6 +12,7 @@
#include <linux/string.h>
#include <linux/platform_device.h>
#include <linux/of_device.h>
+#include <linux/of_platform.h>
#include <linux/of_irq.h>
#include <linux/module.h>
#include <linux/init.h>
diff --git a/drivers/bus/imx-weim.c b/drivers/bus/imx-weim.c
index 28bb65a..8c786da 100644
--- a/drivers/bus/imx-weim.c
+++ b/drivers/bus/imx-weim.c
@@ -11,6 +11,7 @@
#include <linux/clk.h>
#include <linux/io.h>
#include <linux/of_device.h>
+#include <linux/of_platform.h>
#include <linux/mfd/syscon.h>
#include <linux/mfd/syscon/imx6q-iomuxc-gpr.h>
#include <linux/regmap.h>
diff --git a/drivers/bus/vexpress-config.c b/drivers/bus/vexpress-config.c
index ff70575..12b8b0b 100644
--- a/drivers/bus/vexpress-config.c
+++ b/drivers/bus/vexpress-config.c
@@ -8,6 +8,7 @@
#include <linux/init.h>
#include <linux/of.h>
#include <linux/of_device.h>
+#include <linux/of_platform.h>
#include <linux/vexpress.h>
diff --git a/drivers/clk/mediatek/clk-mt7622-aud.c b/drivers/clk/mediatek/clk-mt7622-aud.c
index 2bd4295..8cbb68f 100644
--- a/drivers/clk/mediatek/clk-mt7622-aud.c
+++ b/drivers/clk/mediatek/clk-mt7622-aud.c
@@ -9,6 +9,7 @@
#include <linux/of.h>
#include <linux/of_address.h>
#include <linux/of_device.h>
+#include <linux/of_platform.h>
#include <linux/platform_device.h>
#include "clk-mtk.h"
diff --git a/drivers/dma/at_hdmac.c b/drivers/dma/at_hdmac.c
index 73a2078..388f8e10 100644
--- a/drivers/dma/at_hdmac.c
+++ b/drivers/dma/at_hdmac.c
@@ -20,6 +20,7 @@
#include <linux/slab.h>
#include <linux/of.h>
#include <linux/of_device.h>
+#include <linux/of_platform.h>
#include <linux/of_dma.h>
#include "at_hdmac_regs.h"
diff --git a/drivers/dma/stm32-dmamux.c b/drivers/dma/stm32-dmamux.c
index 12f7637..b704896 100644
--- a/drivers/dma/stm32-dmamux.c
+++ b/drivers/dma/stm32-dmamux.c
@@ -16,6 +16,7 @@
#include <linux/init.h>
#include <linux/module.h>
#include <linux/of_device.h>
+#include <linux/of_platform.h>
#include <linux/of_dma.h>
#include <linux/pm_runtime.h>
#include <linux/reset.h>
diff --git a/drivers/dma/ti/dma-crossbar.c b/drivers/dma/ti/dma-crossbar.c
index 4ba8fa5..2c0fd44 100644
--- a/drivers/dma/ti/dma-crossbar.c
+++ b/drivers/dma/ti/dma-crossbar.c
@@ -10,6 +10,7 @@
#include <linux/io.h>
#include <linux/of_address.h>
#include <linux/of_device.h>
+#include <linux/of_platform.h>
#include <linux/of_dma.h>
#define TI_XBAR_DRA7 0
diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c b/drivers/gpu/drm/msm/adreno/a6xx_gmu.c
index c4e71ab..f523254 100644
--- a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c
+++ b/drivers/gpu/drm/msm/adreno/a6xx_gmu.c
@@ -6,6 +6,7 @@
#include <linux/interconnect.h>
#include <linux/pm_domain.h>
#include <linux/pm_opp.h>
+#include <linux/of_platform.h>
#include <soc/qcom/cmd-db.h>
#include "a6xx_gpu.h"
diff --git a/drivers/gpu/drm/msm/hdmi/hdmi.c b/drivers/gpu/drm/msm/hdmi/hdmi.c
index 737453b..5034d40 100644
--- a/drivers/gpu/drm/msm/hdmi/hdmi.c
+++ b/drivers/gpu/drm/msm/hdmi/hdmi.c
@@ -7,6 +7,7 @@
#include <linux/of_irq.h>
#include <linux/of_gpio.h>
+#include <linux/of_platform.h>
#include <sound/hdmi-codec.h>
#include "hdmi.h"
diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c
index 29295de..ddc9e85 100644
--- a/drivers/gpu/drm/msm/msm_drv.c
+++ b/drivers/gpu/drm/msm/msm_drv.c
@@ -8,6 +8,7 @@
#include <linux/dma-mapping.h>
#include <linux/kthread.h>
#include <linux/uaccess.h>
+#include <linux/of_platform.h>
#include <uapi/linux/sched/types.h>
#include <drm/drm_drv.h>
diff --git a/drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c b/drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c
index 6e1270e..d038bae 100644
--- a/drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c
+++ b/drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c
@@ -12,6 +12,7 @@
#include <linux/mfd/syscon.h>
#include <linux/module.h>
#include <linux/of_device.h>
+#include <linux/of_platform.h>
#include <linux/phy/phy.h>
#include <linux/pm_runtime.h>
#include <linux/regmap.h>
diff --git a/drivers/gpu/drm/sun4i/sun4i_tcon.c b/drivers/gpu/drm/sun4i/sun4i_tcon.c
index 624437b..aa35757 100644
--- a/drivers/gpu/drm/sun4i/sun4i_tcon.c
+++ b/drivers/gpu/drm/sun4i/sun4i_tcon.c
@@ -11,6 +11,7 @@
#include <linux/module.h>
#include <linux/of_address.h>
#include <linux/of_device.h>
+#include <linux/of_platform.h>
#include <linux/of_irq.h>
#include <linux/regmap.h>
#include <linux/reset.h>
diff --git a/drivers/iio/adc/stm32-adc-core.c b/drivers/iio/adc/stm32-adc-core.c
index 2df88d2..3dc3453 100644
--- a/drivers/iio/adc/stm32-adc-core.c
+++ b/drivers/iio/adc/stm32-adc-core.c
@@ -17,6 +17,7 @@
#include <linux/mfd/syscon.h>
#include <linux/module.h>
#include <linux/of_device.h>
+#include <linux/of_platform.h>
#include <linux/pm_runtime.h>
#include <linux/regmap.h>
#include <linux/regulator/consumer.h>
diff --git a/drivers/iio/adc/stm32-dfsdm-adc.c b/drivers/iio/adc/stm32-dfsdm-adc.c
index 76a60d9..e83848cb 100644
--- a/drivers/iio/adc/stm32-dfsdm-adc.c
+++ b/drivers/iio/adc/stm32-dfsdm-adc.c
@@ -20,6 +20,7 @@
#include <linux/interrupt.h>
#include <linux/module.h>
#include <linux/of_device.h>
+#include <linux/of_platform.h>
#include <linux/platform_device.h>
#include <linux/regmap.h>
#include <linux/slab.h>
diff --git a/drivers/iio/adc/stm32-dfsdm-core.c b/drivers/iio/adc/stm32-dfsdm-core.c
index 26e2011..f6a53ab 100644
--- a/drivers/iio/adc/stm32-dfsdm-core.c
+++ b/drivers/iio/adc/stm32-dfsdm-core.c
@@ -12,6 +12,7 @@
#include <linux/interrupt.h>
#include <linux/module.h>
#include <linux/of_device.h>
+#include <linux/of_platform.h>
#include <linux/pinctrl/consumer.h>
#include <linux/pm_runtime.h>
#include <linux/regmap.h>
diff --git a/drivers/iommu/tegra-smmu.c b/drivers/iommu/tegra-smmu.c
index 63a147b..3797caa 100644
--- a/drivers/iommu/tegra-smmu.c
+++ b/drivers/iommu/tegra-smmu.c
@@ -10,6 +10,7 @@
#include <linux/kernel.h>
#include <linux/of.h>
#include <linux/of_device.h>
+#include <linux/of_platform.h>
#include <linux/platform_device.h>
#include <linux/slab.h>
#include <linux/dma-mapping.h>
diff --git a/drivers/memory/atmel-ebi.c b/drivers/memory/atmel-ebi.c
index 14386d0..272b1a8 100644
--- a/drivers/memory/atmel-ebi.c
+++ b/drivers/memory/atmel-ebi.c
@@ -13,6 +13,7 @@
#include <linux/mfd/syscon/atmel-smc.h>
#include <linux/init.h>
#include <linux/of_device.h>
+#include <linux/of_platform.h>
#include <linux/regmap.h>
#include <soc/at91/atmel-sfr.h>
diff --git a/drivers/mfd/palmas.c b/drivers/mfd/palmas.c
index f5b3fa9..cca44bc 100644
--- a/drivers/mfd/palmas.c
+++ b/drivers/mfd/palmas.c
@@ -19,6 +19,7 @@
#include <linux/mfd/core.h>
#include <linux/mfd/palmas.h>
#include <linux/of_device.h>
+#include <linux/of_platform.h>
static const struct regmap_config palmas_regmap_config[PALMAS_NUM_CLIENTS] = {
{
diff --git a/drivers/mfd/ssbi.c b/drivers/mfd/ssbi.c
index 94f60df..72cd45a 100644
--- a/drivers/mfd/ssbi.c
+++ b/drivers/mfd/ssbi.c
@@ -20,6 +20,7 @@
#include <linux/module.h>
#include <linux/of.h>
#include <linux/of_device.h>
+#include <linux/of_platform.h>
/* SSBI 2.0 controller registers */
#define SSBI2_CMD 0x0008
diff --git a/drivers/mtd/nand/raw/omap2.c b/drivers/mtd/nand/raw/omap2.c
index ad77c11..d851ec7 100644
--- a/drivers/mtd/nand/raw/omap2.c
+++ b/drivers/mtd/nand/raw/omap2.c
@@ -22,6 +22,7 @@
#include <linux/slab.h>
#include <linux/of.h>
#include <linux/of_device.h>
+#include <linux/of_platform.h>
#include <linux/mtd/nand_bch.h>
#include <linux/platform_data/elm.h>
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c
index 58e0511..d704d57 100644
--- a/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c
+++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c
@@ -12,6 +12,7 @@
#include <linux/mfd/syscon.h>
#include <linux/module.h>
#include <linux/of_device.h>
+#include <linux/of_platform.h>
#include <linux/of_mdio.h>
#include <linux/of_net.h>
#include <linux/phy.h>
diff --git a/drivers/net/ethernet/ti/cpsw.c b/drivers/net/ethernet/ti/cpsw.c
index c2c5bf8..6932945 100644
--- a/drivers/net/ethernet/ti/cpsw.c
+++ b/drivers/net/ethernet/ti/cpsw.c
@@ -28,6 +28,7 @@
#include <linux/of_mdio.h>
#include <linux/of_net.h>
#include <linux/of_device.h>
+#include <linux/of_platform.h>
#include <linux/if_vlan.h>
#include <linux/kmemleak.h>
#include <linux/sys_soc.h>
diff --git a/drivers/phy/tegra/xusb.c b/drivers/phy/tegra/xusb.c
index de4a46f..0eac1b8 100644
--- a/drivers/phy/tegra/xusb.c
+++ b/drivers/phy/tegra/xusb.c
@@ -9,6 +9,7 @@
#include <linux/module.h>
#include <linux/of.h>
#include <linux/of_device.h>
+#include <linux/of_platform.h>
#include <linux/phy/phy.h>
#include <linux/phy/tegra/xusb.h>
#include <linux/platform_device.h>
diff --git a/drivers/pinctrl/freescale/pinctrl-imx1-core.c b/drivers/pinctrl/freescale/pinctrl-imx1-core.c
index c00d002..d1c171e 100644
--- a/drivers/pinctrl/freescale/pinctrl-imx1-core.c
+++ b/drivers/pinctrl/freescale/pinctrl-imx1-core.c
@@ -16,6 +16,7 @@
#include <linux/io.h>
#include <linux/of.h>
#include <linux/of_device.h>
+#include <linux/of_platform.h>
#include <linux/pinctrl/machine.h>
#include <linux/pinctrl/pinconf.h>
#include <linux/pinctrl/pinctrl.h>
diff --git a/drivers/pinctrl/nomadik/pinctrl-nomadik.c b/drivers/pinctrl/nomadik/pinctrl-nomadik.c
index ca7bbe4..44974ac 100644
--- a/drivers/pinctrl/nomadik/pinctrl-nomadik.c
+++ b/drivers/pinctrl/nomadik/pinctrl-nomadik.c
@@ -19,6 +19,7 @@
#include <linux/interrupt.h>
#include <linux/slab.h>
#include <linux/of_device.h>
+#include <linux/of_platform.h>
#include <linux/of_address.h>
#include <linux/bitops.h>
#include <linux/pinctrl/machine.h>
diff --git a/drivers/soc/samsung/exynos-pmu.c b/drivers/soc/samsung/exynos-pmu.c
index 17304fa..25129b0 100644
--- a/drivers/soc/samsung/exynos-pmu.c
+++ b/drivers/soc/samsung/exynos-pmu.c
@@ -8,6 +8,7 @@
#include <linux/of.h>
#include <linux/of_address.h>
#include <linux/of_device.h>
+#include <linux/of_platform.h>
#include <linux/mfd/syscon.h>
#include <linux/platform_device.h>
#include <linux/delay.h>
diff --git a/drivers/soc/sunxi/sunxi_sram.c b/drivers/soc/sunxi/sunxi_sram.c
index 1b0d50f..423cec3 100644
--- a/drivers/soc/sunxi/sunxi_sram.c
+++ b/drivers/soc/sunxi/sunxi_sram.c
@@ -16,6 +16,7 @@
#include <linux/of.h>
#include <linux/of_address.h>
#include <linux/of_device.h>
+#include <linux/of_platform.h>
#include <linux/platform_device.h>
#include <linux/regmap.h>
diff --git a/include/linux/of_device.h b/include/linux/of_device.h
index 8d31e39..752999b 100644
--- a/include/linux/of_device.h
+++ b/include/linux/of_device.h
@@ -4,8 +4,6 @@
#include <linux/cpu.h>
#include <linux/platform_device.h>
-#include <linux/of_platform.h> /* temporary until merge */
-
#include <linux/of.h>
#include <linux/mod_devicetable.h>
diff --git a/lib/genalloc.c b/lib/genalloc.c
index 7f1244b..08e21eeb 100644
--- a/lib/genalloc.c
+++ b/lib/genalloc.c
@@ -33,6 +33,7 @@
#include <linux/interrupt.h>
#include <linux/genalloc.h>
#include <linux/of_device.h>
+#include <linux/of_platform.h>
#include <linux/vmalloc.h>
static inline size_t chunk_size(const struct gen_pool_chunk *chunk)
--
2.7.4
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply related [flat|nested] 25+ messages in thread* [PATCH v2] of_device: removed #include that caused a recursion in included headers
@ 2020-04-16 9:49 ` Hadar Gat
0 siblings, 0 replies; 25+ messages in thread
From: Hadar Gat @ 2020-04-16 9:49 UTC (permalink / raw)
To: David S. Miller, Greg Kroah-Hartman, Shawn Guo, Sascha Hauer,
Liviu Dudau, Sudeep Holla, Lorenzo Pieralisi, Michael Turquette,
Stephen Boyd, Matthias Brugger, Ludovic Desroches, Vinod Koul,
Maxime Coquelin, Alexandre Torgue, Rob Clark, Sean Paul,
David Airlie, Daniel Vetter, Sandy Huang, Heiko Stübner,
Maxime Ripard, Chen-Yu Tsai, Jonathan Cameron, Thierry Reding,
Joerg Roedel, Jonathan Hunter, Nicolas Ferre, Alexandre Belloni,
Tony Lindgren, Lee Jones, Andy Gross, Bjorn Andersson,
Miquel Raynal, Richard Weinberger, Vignesh Raghavendra,
Giuseppe Cavallaro, Jose Abreu, JC Kuo, Kishon Vijay Abraham I,
Dong Aisheng, Fabio Estevam, Stefan Agner, Linus Walleij,
Kukjin Kim, Krzysztof Kozlowski, Rob Herring, Frank Rowand
Cc: linux-iio, dri-devel, linux-mtd, sparclinux, linux-stm32,
linux-samsung-soc, linux-clk, linux-rockchip, Hadar Gat,
devicetree, linux-arm-msm, linux-gpio, linux-mediatek,
linux-tegra, linux-omap, linux-arm-kernel, Ofir Drang,
Gilad Ben-Yossef, netdev, linux-kernel, iommu, dmaengine,
freedreno
Both of_platform.h and of_device.h were included each other.
In of_device.h, removed unneeded #include to of_platform.h
and added include to of_platform.h in the files that needs it.
Signed-off-by: Hadar Gat <hadar.gat@arm.com>
---
v2: add include to of_platform.h in more files. (reported due other builds)
arch/sparc/mm/io-unit.c | 1 +
arch/sparc/mm/iommu.c | 1 +
drivers/base/platform.c | 1 +
drivers/bus/imx-weim.c | 1 +
drivers/bus/vexpress-config.c | 1 +
drivers/clk/mediatek/clk-mt7622-aud.c | 1 +
drivers/dma/at_hdmac.c | 1 +
drivers/dma/stm32-dmamux.c | 1 +
drivers/dma/ti/dma-crossbar.c | 1 +
drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 1 +
drivers/gpu/drm/msm/hdmi/hdmi.c | 1 +
drivers/gpu/drm/msm/msm_drv.c | 1 +
drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c | 1 +
drivers/gpu/drm/sun4i/sun4i_tcon.c | 1 +
drivers/iio/adc/stm32-adc-core.c | 1 +
drivers/iio/adc/stm32-dfsdm-adc.c | 1 +
drivers/iio/adc/stm32-dfsdm-core.c | 1 +
drivers/iommu/tegra-smmu.c | 1 +
drivers/memory/atmel-ebi.c | 1 +
drivers/mfd/palmas.c | 1 +
drivers/mfd/ssbi.c | 1 +
drivers/mtd/nand/raw/omap2.c | 1 +
drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c | 1 +
drivers/net/ethernet/ti/cpsw.c | 1 +
drivers/phy/tegra/xusb.c | 1 +
drivers/pinctrl/freescale/pinctrl-imx1-core.c | 1 +
drivers/pinctrl/nomadik/pinctrl-nomadik.c | 1 +
drivers/soc/samsung/exynos-pmu.c | 1 +
drivers/soc/sunxi/sunxi_sram.c | 1 +
include/linux/of_device.h | 2 --
lib/genalloc.c | 1 +
31 files changed, 30 insertions(+), 2 deletions(-)
diff --git a/arch/sparc/mm/io-unit.c b/arch/sparc/mm/io-unit.c
index 289276b..5638399 100644
--- a/arch/sparc/mm/io-unit.c
+++ b/arch/sparc/mm/io-unit.c
@@ -15,6 +15,7 @@
#include <linux/dma-mapping.h>
#include <linux/of.h>
#include <linux/of_device.h>
+#include <linux/of_platform.h>
#include <asm/pgalloc.h>
#include <asm/pgtable.h>
diff --git a/arch/sparc/mm/iommu.c b/arch/sparc/mm/iommu.c
index b00dde1..9cbb2e7 100644
--- a/arch/sparc/mm/iommu.c
+++ b/arch/sparc/mm/iommu.c
@@ -16,6 +16,7 @@
#include <linux/dma-mapping.h>
#include <linux/of.h>
#include <linux/of_device.h>
+#include <linux/of_platform.h>
#include <asm/pgalloc.h>
#include <asm/pgtable.h>
diff --git a/drivers/base/platform.c b/drivers/base/platform.c
index 5255550..f549274b 100644
--- a/drivers/base/platform.c
+++ b/drivers/base/platform.c
@@ -12,6 +12,7 @@
#include <linux/string.h>
#include <linux/platform_device.h>
#include <linux/of_device.h>
+#include <linux/of_platform.h>
#include <linux/of_irq.h>
#include <linux/module.h>
#include <linux/init.h>
diff --git a/drivers/bus/imx-weim.c b/drivers/bus/imx-weim.c
index 28bb65a..8c786da 100644
--- a/drivers/bus/imx-weim.c
+++ b/drivers/bus/imx-weim.c
@@ -11,6 +11,7 @@
#include <linux/clk.h>
#include <linux/io.h>
#include <linux/of_device.h>
+#include <linux/of_platform.h>
#include <linux/mfd/syscon.h>
#include <linux/mfd/syscon/imx6q-iomuxc-gpr.h>
#include <linux/regmap.h>
diff --git a/drivers/bus/vexpress-config.c b/drivers/bus/vexpress-config.c
index ff70575..12b8b0b 100644
--- a/drivers/bus/vexpress-config.c
+++ b/drivers/bus/vexpress-config.c
@@ -8,6 +8,7 @@
#include <linux/init.h>
#include <linux/of.h>
#include <linux/of_device.h>
+#include <linux/of_platform.h>
#include <linux/vexpress.h>
diff --git a/drivers/clk/mediatek/clk-mt7622-aud.c b/drivers/clk/mediatek/clk-mt7622-aud.c
index 2bd4295..8cbb68f 100644
--- a/drivers/clk/mediatek/clk-mt7622-aud.c
+++ b/drivers/clk/mediatek/clk-mt7622-aud.c
@@ -9,6 +9,7 @@
#include <linux/of.h>
#include <linux/of_address.h>
#include <linux/of_device.h>
+#include <linux/of_platform.h>
#include <linux/platform_device.h>
#include "clk-mtk.h"
diff --git a/drivers/dma/at_hdmac.c b/drivers/dma/at_hdmac.c
index 73a2078..388f8e10 100644
--- a/drivers/dma/at_hdmac.c
+++ b/drivers/dma/at_hdmac.c
@@ -20,6 +20,7 @@
#include <linux/slab.h>
#include <linux/of.h>
#include <linux/of_device.h>
+#include <linux/of_platform.h>
#include <linux/of_dma.h>
#include "at_hdmac_regs.h"
diff --git a/drivers/dma/stm32-dmamux.c b/drivers/dma/stm32-dmamux.c
index 12f7637..b704896 100644
--- a/drivers/dma/stm32-dmamux.c
+++ b/drivers/dma/stm32-dmamux.c
@@ -16,6 +16,7 @@
#include <linux/init.h>
#include <linux/module.h>
#include <linux/of_device.h>
+#include <linux/of_platform.h>
#include <linux/of_dma.h>
#include <linux/pm_runtime.h>
#include <linux/reset.h>
diff --git a/drivers/dma/ti/dma-crossbar.c b/drivers/dma/ti/dma-crossbar.c
index 4ba8fa5..2c0fd44 100644
--- a/drivers/dma/ti/dma-crossbar.c
+++ b/drivers/dma/ti/dma-crossbar.c
@@ -10,6 +10,7 @@
#include <linux/io.h>
#include <linux/of_address.h>
#include <linux/of_device.h>
+#include <linux/of_platform.h>
#include <linux/of_dma.h>
#define TI_XBAR_DRA7 0
diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c b/drivers/gpu/drm/msm/adreno/a6xx_gmu.c
index c4e71ab..f523254 100644
--- a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c
+++ b/drivers/gpu/drm/msm/adreno/a6xx_gmu.c
@@ -6,6 +6,7 @@
#include <linux/interconnect.h>
#include <linux/pm_domain.h>
#include <linux/pm_opp.h>
+#include <linux/of_platform.h>
#include <soc/qcom/cmd-db.h>
#include "a6xx_gpu.h"
diff --git a/drivers/gpu/drm/msm/hdmi/hdmi.c b/drivers/gpu/drm/msm/hdmi/hdmi.c
index 737453b..5034d40 100644
--- a/drivers/gpu/drm/msm/hdmi/hdmi.c
+++ b/drivers/gpu/drm/msm/hdmi/hdmi.c
@@ -7,6 +7,7 @@
#include <linux/of_irq.h>
#include <linux/of_gpio.h>
+#include <linux/of_platform.h>
#include <sound/hdmi-codec.h>
#include "hdmi.h"
diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c
index 29295de..ddc9e85 100644
--- a/drivers/gpu/drm/msm/msm_drv.c
+++ b/drivers/gpu/drm/msm/msm_drv.c
@@ -8,6 +8,7 @@
#include <linux/dma-mapping.h>
#include <linux/kthread.h>
#include <linux/uaccess.h>
+#include <linux/of_platform.h>
#include <uapi/linux/sched/types.h>
#include <drm/drm_drv.h>
diff --git a/drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c b/drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c
index 6e1270e..d038bae 100644
--- a/drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c
+++ b/drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c
@@ -12,6 +12,7 @@
#include <linux/mfd/syscon.h>
#include <linux/module.h>
#include <linux/of_device.h>
+#include <linux/of_platform.h>
#include <linux/phy/phy.h>
#include <linux/pm_runtime.h>
#include <linux/regmap.h>
diff --git a/drivers/gpu/drm/sun4i/sun4i_tcon.c b/drivers/gpu/drm/sun4i/sun4i_tcon.c
index 624437b..aa35757 100644
--- a/drivers/gpu/drm/sun4i/sun4i_tcon.c
+++ b/drivers/gpu/drm/sun4i/sun4i_tcon.c
@@ -11,6 +11,7 @@
#include <linux/module.h>
#include <linux/of_address.h>
#include <linux/of_device.h>
+#include <linux/of_platform.h>
#include <linux/of_irq.h>
#include <linux/regmap.h>
#include <linux/reset.h>
diff --git a/drivers/iio/adc/stm32-adc-core.c b/drivers/iio/adc/stm32-adc-core.c
index 2df88d2..3dc3453 100644
--- a/drivers/iio/adc/stm32-adc-core.c
+++ b/drivers/iio/adc/stm32-adc-core.c
@@ -17,6 +17,7 @@
#include <linux/mfd/syscon.h>
#include <linux/module.h>
#include <linux/of_device.h>
+#include <linux/of_platform.h>
#include <linux/pm_runtime.h>
#include <linux/regmap.h>
#include <linux/regulator/consumer.h>
diff --git a/drivers/iio/adc/stm32-dfsdm-adc.c b/drivers/iio/adc/stm32-dfsdm-adc.c
index 76a60d9..e83848cb 100644
--- a/drivers/iio/adc/stm32-dfsdm-adc.c
+++ b/drivers/iio/adc/stm32-dfsdm-adc.c
@@ -20,6 +20,7 @@
#include <linux/interrupt.h>
#include <linux/module.h>
#include <linux/of_device.h>
+#include <linux/of_platform.h>
#include <linux/platform_device.h>
#include <linux/regmap.h>
#include <linux/slab.h>
diff --git a/drivers/iio/adc/stm32-dfsdm-core.c b/drivers/iio/adc/stm32-dfsdm-core.c
index 26e2011..f6a53ab 100644
--- a/drivers/iio/adc/stm32-dfsdm-core.c
+++ b/drivers/iio/adc/stm32-dfsdm-core.c
@@ -12,6 +12,7 @@
#include <linux/interrupt.h>
#include <linux/module.h>
#include <linux/of_device.h>
+#include <linux/of_platform.h>
#include <linux/pinctrl/consumer.h>
#include <linux/pm_runtime.h>
#include <linux/regmap.h>
diff --git a/drivers/iommu/tegra-smmu.c b/drivers/iommu/tegra-smmu.c
index 63a147b..3797caa 100644
--- a/drivers/iommu/tegra-smmu.c
+++ b/drivers/iommu/tegra-smmu.c
@@ -10,6 +10,7 @@
#include <linux/kernel.h>
#include <linux/of.h>
#include <linux/of_device.h>
+#include <linux/of_platform.h>
#include <linux/platform_device.h>
#include <linux/slab.h>
#include <linux/dma-mapping.h>
diff --git a/drivers/memory/atmel-ebi.c b/drivers/memory/atmel-ebi.c
index 14386d0..272b1a8 100644
--- a/drivers/memory/atmel-ebi.c
+++ b/drivers/memory/atmel-ebi.c
@@ -13,6 +13,7 @@
#include <linux/mfd/syscon/atmel-smc.h>
#include <linux/init.h>
#include <linux/of_device.h>
+#include <linux/of_platform.h>
#include <linux/regmap.h>
#include <soc/at91/atmel-sfr.h>
diff --git a/drivers/mfd/palmas.c b/drivers/mfd/palmas.c
index f5b3fa9..cca44bc 100644
--- a/drivers/mfd/palmas.c
+++ b/drivers/mfd/palmas.c
@@ -19,6 +19,7 @@
#include <linux/mfd/core.h>
#include <linux/mfd/palmas.h>
#include <linux/of_device.h>
+#include <linux/of_platform.h>
static const struct regmap_config palmas_regmap_config[PALMAS_NUM_CLIENTS] = {
{
diff --git a/drivers/mfd/ssbi.c b/drivers/mfd/ssbi.c
index 94f60df..72cd45a 100644
--- a/drivers/mfd/ssbi.c
+++ b/drivers/mfd/ssbi.c
@@ -20,6 +20,7 @@
#include <linux/module.h>
#include <linux/of.h>
#include <linux/of_device.h>
+#include <linux/of_platform.h>
/* SSBI 2.0 controller registers */
#define SSBI2_CMD 0x0008
diff --git a/drivers/mtd/nand/raw/omap2.c b/drivers/mtd/nand/raw/omap2.c
index ad77c11..d851ec7 100644
--- a/drivers/mtd/nand/raw/omap2.c
+++ b/drivers/mtd/nand/raw/omap2.c
@@ -22,6 +22,7 @@
#include <linux/slab.h>
#include <linux/of.h>
#include <linux/of_device.h>
+#include <linux/of_platform.h>
#include <linux/mtd/nand_bch.h>
#include <linux/platform_data/elm.h>
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c
index 58e0511..d704d57 100644
--- a/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c
+++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c
@@ -12,6 +12,7 @@
#include <linux/mfd/syscon.h>
#include <linux/module.h>
#include <linux/of_device.h>
+#include <linux/of_platform.h>
#include <linux/of_mdio.h>
#include <linux/of_net.h>
#include <linux/phy.h>
diff --git a/drivers/net/ethernet/ti/cpsw.c b/drivers/net/ethernet/ti/cpsw.c
index c2c5bf8..6932945 100644
--- a/drivers/net/ethernet/ti/cpsw.c
+++ b/drivers/net/ethernet/ti/cpsw.c
@@ -28,6 +28,7 @@
#include <linux/of_mdio.h>
#include <linux/of_net.h>
#include <linux/of_device.h>
+#include <linux/of_platform.h>
#include <linux/if_vlan.h>
#include <linux/kmemleak.h>
#include <linux/sys_soc.h>
diff --git a/drivers/phy/tegra/xusb.c b/drivers/phy/tegra/xusb.c
index de4a46f..0eac1b8 100644
--- a/drivers/phy/tegra/xusb.c
+++ b/drivers/phy/tegra/xusb.c
@@ -9,6 +9,7 @@
#include <linux/module.h>
#include <linux/of.h>
#include <linux/of_device.h>
+#include <linux/of_platform.h>
#include <linux/phy/phy.h>
#include <linux/phy/tegra/xusb.h>
#include <linux/platform_device.h>
diff --git a/drivers/pinctrl/freescale/pinctrl-imx1-core.c b/drivers/pinctrl/freescale/pinctrl-imx1-core.c
index c00d002..d1c171e 100644
--- a/drivers/pinctrl/freescale/pinctrl-imx1-core.c
+++ b/drivers/pinctrl/freescale/pinctrl-imx1-core.c
@@ -16,6 +16,7 @@
#include <linux/io.h>
#include <linux/of.h>
#include <linux/of_device.h>
+#include <linux/of_platform.h>
#include <linux/pinctrl/machine.h>
#include <linux/pinctrl/pinconf.h>
#include <linux/pinctrl/pinctrl.h>
diff --git a/drivers/pinctrl/nomadik/pinctrl-nomadik.c b/drivers/pinctrl/nomadik/pinctrl-nomadik.c
index ca7bbe4..44974ac 100644
--- a/drivers/pinctrl/nomadik/pinctrl-nomadik.c
+++ b/drivers/pinctrl/nomadik/pinctrl-nomadik.c
@@ -19,6 +19,7 @@
#include <linux/interrupt.h>
#include <linux/slab.h>
#include <linux/of_device.h>
+#include <linux/of_platform.h>
#include <linux/of_address.h>
#include <linux/bitops.h>
#include <linux/pinctrl/machine.h>
diff --git a/drivers/soc/samsung/exynos-pmu.c b/drivers/soc/samsung/exynos-pmu.c
index 17304fa..25129b0 100644
--- a/drivers/soc/samsung/exynos-pmu.c
+++ b/drivers/soc/samsung/exynos-pmu.c
@@ -8,6 +8,7 @@
#include <linux/of.h>
#include <linux/of_address.h>
#include <linux/of_device.h>
+#include <linux/of_platform.h>
#include <linux/mfd/syscon.h>
#include <linux/platform_device.h>
#include <linux/delay.h>
diff --git a/drivers/soc/sunxi/sunxi_sram.c b/drivers/soc/sunxi/sunxi_sram.c
index 1b0d50f..423cec3 100644
--- a/drivers/soc/sunxi/sunxi_sram.c
+++ b/drivers/soc/sunxi/sunxi_sram.c
@@ -16,6 +16,7 @@
#include <linux/of.h>
#include <linux/of_address.h>
#include <linux/of_device.h>
+#include <linux/of_platform.h>
#include <linux/platform_device.h>
#include <linux/regmap.h>
diff --git a/include/linux/of_device.h b/include/linux/of_device.h
index 8d31e39..752999b 100644
--- a/include/linux/of_device.h
+++ b/include/linux/of_device.h
@@ -4,8 +4,6 @@
#include <linux/cpu.h>
#include <linux/platform_device.h>
-#include <linux/of_platform.h> /* temporary until merge */
-
#include <linux/of.h>
#include <linux/mod_devicetable.h>
diff --git a/lib/genalloc.c b/lib/genalloc.c
index 7f1244b..08e21eeb 100644
--- a/lib/genalloc.c
+++ b/lib/genalloc.c
@@ -33,6 +33,7 @@
#include <linux/interrupt.h>
#include <linux/genalloc.h>
#include <linux/of_device.h>
+#include <linux/of_platform.h>
#include <linux/vmalloc.h>
static inline size_t chunk_size(const struct gen_pool_chunk *chunk)
--
2.7.4
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
^ permalink raw reply related [flat|nested] 25+ messages in thread* [PATCH v2] of_device: removed #include that caused a recursion in included headers
@ 2020-04-16 9:49 ` Hadar Gat
0 siblings, 0 replies; 25+ messages in thread
From: Hadar Gat @ 2020-04-16 9:49 UTC (permalink / raw)
To: David S. Miller, Greg Kroah-Hartman, Shawn Guo, Sascha Hauer,
Liviu Dudau, Sudeep Holla, Lorenzo Pieralisi, Michael Turquette,
Stephen Boyd, Matthias Brugger, Ludovic Desroches, Vinod Koul,
Maxime Coquelin, Alexandre Torgue, Rob Clark, Sean Paul,
David Airlie, Daniel Vetter, Sandy Huang, Heiko Stübner,
Maxime Ripard, Chen-Yu Tsai, Jonathan Cameron, Thierry Reding,
Joerg Roedel, Jonathan Hunter, Nicolas Ferre, Alexandre Belloni,
Tony Lindgren, Lee Jones, Andy Gross, Bjorn Andersson,
Miquel Raynal, Richard Weinberger, Vignesh Raghavendra,
Giuseppe Cavallaro, Jose Abreu, JC Kuo, Kishon Vijay Abraham I,
Dong Aisheng, Fabio Estevam, Stefan Agner, Linus Walleij,
Kukjin Kim, Krzysztof Kozlowski, Rob Herring, Frank Rowand
Cc: linux-iio, dri-devel, linux-mtd, sparclinux, linux-stm32,
linux-samsung-soc, linux-clk, linux-rockchip, Hadar Gat,
devicetree, linux-arm-msm, linux-gpio, linux-mediatek,
linux-tegra, linux-omap, linux-arm-kernel, Ofir Drang,
Gilad Ben-Yossef, netdev, linux-kernel, iommu, dmaengine,
freedreno
Both of_platform.h and of_device.h were included each other.
In of_device.h, removed unneeded #include to of_platform.h
and added include to of_platform.h in the files that needs it.
Signed-off-by: Hadar Gat <hadar.gat@arm.com>
---
v2: add include to of_platform.h in more files. (reported due other builds)
arch/sparc/mm/io-unit.c | 1 +
arch/sparc/mm/iommu.c | 1 +
drivers/base/platform.c | 1 +
drivers/bus/imx-weim.c | 1 +
drivers/bus/vexpress-config.c | 1 +
drivers/clk/mediatek/clk-mt7622-aud.c | 1 +
drivers/dma/at_hdmac.c | 1 +
drivers/dma/stm32-dmamux.c | 1 +
drivers/dma/ti/dma-crossbar.c | 1 +
drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 1 +
drivers/gpu/drm/msm/hdmi/hdmi.c | 1 +
drivers/gpu/drm/msm/msm_drv.c | 1 +
drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c | 1 +
drivers/gpu/drm/sun4i/sun4i_tcon.c | 1 +
drivers/iio/adc/stm32-adc-core.c | 1 +
drivers/iio/adc/stm32-dfsdm-adc.c | 1 +
drivers/iio/adc/stm32-dfsdm-core.c | 1 +
drivers/iommu/tegra-smmu.c | 1 +
drivers/memory/atmel-ebi.c | 1 +
drivers/mfd/palmas.c | 1 +
drivers/mfd/ssbi.c | 1 +
drivers/mtd/nand/raw/omap2.c | 1 +
drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c | 1 +
drivers/net/ethernet/ti/cpsw.c | 1 +
drivers/phy/tegra/xusb.c | 1 +
drivers/pinctrl/freescale/pinctrl-imx1-core.c | 1 +
drivers/pinctrl/nomadik/pinctrl-nomadik.c | 1 +
drivers/soc/samsung/exynos-pmu.c | 1 +
drivers/soc/sunxi/sunxi_sram.c | 1 +
include/linux/of_device.h | 2 --
lib/genalloc.c | 1 +
31 files changed, 30 insertions(+), 2 deletions(-)
diff --git a/arch/sparc/mm/io-unit.c b/arch/sparc/mm/io-unit.c
index 289276b..5638399 100644
--- a/arch/sparc/mm/io-unit.c
+++ b/arch/sparc/mm/io-unit.c
@@ -15,6 +15,7 @@
#include <linux/dma-mapping.h>
#include <linux/of.h>
#include <linux/of_device.h>
+#include <linux/of_platform.h>
#include <asm/pgalloc.h>
#include <asm/pgtable.h>
diff --git a/arch/sparc/mm/iommu.c b/arch/sparc/mm/iommu.c
index b00dde1..9cbb2e7 100644
--- a/arch/sparc/mm/iommu.c
+++ b/arch/sparc/mm/iommu.c
@@ -16,6 +16,7 @@
#include <linux/dma-mapping.h>
#include <linux/of.h>
#include <linux/of_device.h>
+#include <linux/of_platform.h>
#include <asm/pgalloc.h>
#include <asm/pgtable.h>
diff --git a/drivers/base/platform.c b/drivers/base/platform.c
index 5255550..f549274b 100644
--- a/drivers/base/platform.c
+++ b/drivers/base/platform.c
@@ -12,6 +12,7 @@
#include <linux/string.h>
#include <linux/platform_device.h>
#include <linux/of_device.h>
+#include <linux/of_platform.h>
#include <linux/of_irq.h>
#include <linux/module.h>
#include <linux/init.h>
diff --git a/drivers/bus/imx-weim.c b/drivers/bus/imx-weim.c
index 28bb65a..8c786da 100644
--- a/drivers/bus/imx-weim.c
+++ b/drivers/bus/imx-weim.c
@@ -11,6 +11,7 @@
#include <linux/clk.h>
#include <linux/io.h>
#include <linux/of_device.h>
+#include <linux/of_platform.h>
#include <linux/mfd/syscon.h>
#include <linux/mfd/syscon/imx6q-iomuxc-gpr.h>
#include <linux/regmap.h>
diff --git a/drivers/bus/vexpress-config.c b/drivers/bus/vexpress-config.c
index ff70575..12b8b0b 100644
--- a/drivers/bus/vexpress-config.c
+++ b/drivers/bus/vexpress-config.c
@@ -8,6 +8,7 @@
#include <linux/init.h>
#include <linux/of.h>
#include <linux/of_device.h>
+#include <linux/of_platform.h>
#include <linux/vexpress.h>
diff --git a/drivers/clk/mediatek/clk-mt7622-aud.c b/drivers/clk/mediatek/clk-mt7622-aud.c
index 2bd4295..8cbb68f 100644
--- a/drivers/clk/mediatek/clk-mt7622-aud.c
+++ b/drivers/clk/mediatek/clk-mt7622-aud.c
@@ -9,6 +9,7 @@
#include <linux/of.h>
#include <linux/of_address.h>
#include <linux/of_device.h>
+#include <linux/of_platform.h>
#include <linux/platform_device.h>
#include "clk-mtk.h"
diff --git a/drivers/dma/at_hdmac.c b/drivers/dma/at_hdmac.c
index 73a2078..388f8e10 100644
--- a/drivers/dma/at_hdmac.c
+++ b/drivers/dma/at_hdmac.c
@@ -20,6 +20,7 @@
#include <linux/slab.h>
#include <linux/of.h>
#include <linux/of_device.h>
+#include <linux/of_platform.h>
#include <linux/of_dma.h>
#include "at_hdmac_regs.h"
diff --git a/drivers/dma/stm32-dmamux.c b/drivers/dma/stm32-dmamux.c
index 12f7637..b704896 100644
--- a/drivers/dma/stm32-dmamux.c
+++ b/drivers/dma/stm32-dmamux.c
@@ -16,6 +16,7 @@
#include <linux/init.h>
#include <linux/module.h>
#include <linux/of_device.h>
+#include <linux/of_platform.h>
#include <linux/of_dma.h>
#include <linux/pm_runtime.h>
#include <linux/reset.h>
diff --git a/drivers/dma/ti/dma-crossbar.c b/drivers/dma/ti/dma-crossbar.c
index 4ba8fa5..2c0fd44 100644
--- a/drivers/dma/ti/dma-crossbar.c
+++ b/drivers/dma/ti/dma-crossbar.c
@@ -10,6 +10,7 @@
#include <linux/io.h>
#include <linux/of_address.h>
#include <linux/of_device.h>
+#include <linux/of_platform.h>
#include <linux/of_dma.h>
#define TI_XBAR_DRA7 0
diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c b/drivers/gpu/drm/msm/adreno/a6xx_gmu.c
index c4e71ab..f523254 100644
--- a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c
+++ b/drivers/gpu/drm/msm/adreno/a6xx_gmu.c
@@ -6,6 +6,7 @@
#include <linux/interconnect.h>
#include <linux/pm_domain.h>
#include <linux/pm_opp.h>
+#include <linux/of_platform.h>
#include <soc/qcom/cmd-db.h>
#include "a6xx_gpu.h"
diff --git a/drivers/gpu/drm/msm/hdmi/hdmi.c b/drivers/gpu/drm/msm/hdmi/hdmi.c
index 737453b..5034d40 100644
--- a/drivers/gpu/drm/msm/hdmi/hdmi.c
+++ b/drivers/gpu/drm/msm/hdmi/hdmi.c
@@ -7,6 +7,7 @@
#include <linux/of_irq.h>
#include <linux/of_gpio.h>
+#include <linux/of_platform.h>
#include <sound/hdmi-codec.h>
#include "hdmi.h"
diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c
index 29295de..ddc9e85 100644
--- a/drivers/gpu/drm/msm/msm_drv.c
+++ b/drivers/gpu/drm/msm/msm_drv.c
@@ -8,6 +8,7 @@
#include <linux/dma-mapping.h>
#include <linux/kthread.h>
#include <linux/uaccess.h>
+#include <linux/of_platform.h>
#include <uapi/linux/sched/types.h>
#include <drm/drm_drv.h>
diff --git a/drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c b/drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c
index 6e1270e..d038bae 100644
--- a/drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c
+++ b/drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c
@@ -12,6 +12,7 @@
#include <linux/mfd/syscon.h>
#include <linux/module.h>
#include <linux/of_device.h>
+#include <linux/of_platform.h>
#include <linux/phy/phy.h>
#include <linux/pm_runtime.h>
#include <linux/regmap.h>
diff --git a/drivers/gpu/drm/sun4i/sun4i_tcon.c b/drivers/gpu/drm/sun4i/sun4i_tcon.c
index 624437b..aa35757 100644
--- a/drivers/gpu/drm/sun4i/sun4i_tcon.c
+++ b/drivers/gpu/drm/sun4i/sun4i_tcon.c
@@ -11,6 +11,7 @@
#include <linux/module.h>
#include <linux/of_address.h>
#include <linux/of_device.h>
+#include <linux/of_platform.h>
#include <linux/of_irq.h>
#include <linux/regmap.h>
#include <linux/reset.h>
diff --git a/drivers/iio/adc/stm32-adc-core.c b/drivers/iio/adc/stm32-adc-core.c
index 2df88d2..3dc3453 100644
--- a/drivers/iio/adc/stm32-adc-core.c
+++ b/drivers/iio/adc/stm32-adc-core.c
@@ -17,6 +17,7 @@
#include <linux/mfd/syscon.h>
#include <linux/module.h>
#include <linux/of_device.h>
+#include <linux/of_platform.h>
#include <linux/pm_runtime.h>
#include <linux/regmap.h>
#include <linux/regulator/consumer.h>
diff --git a/drivers/iio/adc/stm32-dfsdm-adc.c b/drivers/iio/adc/stm32-dfsdm-adc.c
index 76a60d9..e83848cb 100644
--- a/drivers/iio/adc/stm32-dfsdm-adc.c
+++ b/drivers/iio/adc/stm32-dfsdm-adc.c
@@ -20,6 +20,7 @@
#include <linux/interrupt.h>
#include <linux/module.h>
#include <linux/of_device.h>
+#include <linux/of_platform.h>
#include <linux/platform_device.h>
#include <linux/regmap.h>
#include <linux/slab.h>
diff --git a/drivers/iio/adc/stm32-dfsdm-core.c b/drivers/iio/adc/stm32-dfsdm-core.c
index 26e2011..f6a53ab 100644
--- a/drivers/iio/adc/stm32-dfsdm-core.c
+++ b/drivers/iio/adc/stm32-dfsdm-core.c
@@ -12,6 +12,7 @@
#include <linux/interrupt.h>
#include <linux/module.h>
#include <linux/of_device.h>
+#include <linux/of_platform.h>
#include <linux/pinctrl/consumer.h>
#include <linux/pm_runtime.h>
#include <linux/regmap.h>
diff --git a/drivers/iommu/tegra-smmu.c b/drivers/iommu/tegra-smmu.c
index 63a147b..3797caa 100644
--- a/drivers/iommu/tegra-smmu.c
+++ b/drivers/iommu/tegra-smmu.c
@@ -10,6 +10,7 @@
#include <linux/kernel.h>
#include <linux/of.h>
#include <linux/of_device.h>
+#include <linux/of_platform.h>
#include <linux/platform_device.h>
#include <linux/slab.h>
#include <linux/dma-mapping.h>
diff --git a/drivers/memory/atmel-ebi.c b/drivers/memory/atmel-ebi.c
index 14386d0..272b1a8 100644
--- a/drivers/memory/atmel-ebi.c
+++ b/drivers/memory/atmel-ebi.c
@@ -13,6 +13,7 @@
#include <linux/mfd/syscon/atmel-smc.h>
#include <linux/init.h>
#include <linux/of_device.h>
+#include <linux/of_platform.h>
#include <linux/regmap.h>
#include <soc/at91/atmel-sfr.h>
diff --git a/drivers/mfd/palmas.c b/drivers/mfd/palmas.c
index f5b3fa9..cca44bc 100644
--- a/drivers/mfd/palmas.c
+++ b/drivers/mfd/palmas.c
@@ -19,6 +19,7 @@
#include <linux/mfd/core.h>
#include <linux/mfd/palmas.h>
#include <linux/of_device.h>
+#include <linux/of_platform.h>
static const struct regmap_config palmas_regmap_config[PALMAS_NUM_CLIENTS] = {
{
diff --git a/drivers/mfd/ssbi.c b/drivers/mfd/ssbi.c
index 94f60df..72cd45a 100644
--- a/drivers/mfd/ssbi.c
+++ b/drivers/mfd/ssbi.c
@@ -20,6 +20,7 @@
#include <linux/module.h>
#include <linux/of.h>
#include <linux/of_device.h>
+#include <linux/of_platform.h>
/* SSBI 2.0 controller registers */
#define SSBI2_CMD 0x0008
diff --git a/drivers/mtd/nand/raw/omap2.c b/drivers/mtd/nand/raw/omap2.c
index ad77c11..d851ec7 100644
--- a/drivers/mtd/nand/raw/omap2.c
+++ b/drivers/mtd/nand/raw/omap2.c
@@ -22,6 +22,7 @@
#include <linux/slab.h>
#include <linux/of.h>
#include <linux/of_device.h>
+#include <linux/of_platform.h>
#include <linux/mtd/nand_bch.h>
#include <linux/platform_data/elm.h>
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c
index 58e0511..d704d57 100644
--- a/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c
+++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c
@@ -12,6 +12,7 @@
#include <linux/mfd/syscon.h>
#include <linux/module.h>
#include <linux/of_device.h>
+#include <linux/of_platform.h>
#include <linux/of_mdio.h>
#include <linux/of_net.h>
#include <linux/phy.h>
diff --git a/drivers/net/ethernet/ti/cpsw.c b/drivers/net/ethernet/ti/cpsw.c
index c2c5bf8..6932945 100644
--- a/drivers/net/ethernet/ti/cpsw.c
+++ b/drivers/net/ethernet/ti/cpsw.c
@@ -28,6 +28,7 @@
#include <linux/of_mdio.h>
#include <linux/of_net.h>
#include <linux/of_device.h>
+#include <linux/of_platform.h>
#include <linux/if_vlan.h>
#include <linux/kmemleak.h>
#include <linux/sys_soc.h>
diff --git a/drivers/phy/tegra/xusb.c b/drivers/phy/tegra/xusb.c
index de4a46f..0eac1b8 100644
--- a/drivers/phy/tegra/xusb.c
+++ b/drivers/phy/tegra/xusb.c
@@ -9,6 +9,7 @@
#include <linux/module.h>
#include <linux/of.h>
#include <linux/of_device.h>
+#include <linux/of_platform.h>
#include <linux/phy/phy.h>
#include <linux/phy/tegra/xusb.h>
#include <linux/platform_device.h>
diff --git a/drivers/pinctrl/freescale/pinctrl-imx1-core.c b/drivers/pinctrl/freescale/pinctrl-imx1-core.c
index c00d002..d1c171e 100644
--- a/drivers/pinctrl/freescale/pinctrl-imx1-core.c
+++ b/drivers/pinctrl/freescale/pinctrl-imx1-core.c
@@ -16,6 +16,7 @@
#include <linux/io.h>
#include <linux/of.h>
#include <linux/of_device.h>
+#include <linux/of_platform.h>
#include <linux/pinctrl/machine.h>
#include <linux/pinctrl/pinconf.h>
#include <linux/pinctrl/pinctrl.h>
diff --git a/drivers/pinctrl/nomadik/pinctrl-nomadik.c b/drivers/pinctrl/nomadik/pinctrl-nomadik.c
index ca7bbe4..44974ac 100644
--- a/drivers/pinctrl/nomadik/pinctrl-nomadik.c
+++ b/drivers/pinctrl/nomadik/pinctrl-nomadik.c
@@ -19,6 +19,7 @@
#include <linux/interrupt.h>
#include <linux/slab.h>
#include <linux/of_device.h>
+#include <linux/of_platform.h>
#include <linux/of_address.h>
#include <linux/bitops.h>
#include <linux/pinctrl/machine.h>
diff --git a/drivers/soc/samsung/exynos-pmu.c b/drivers/soc/samsung/exynos-pmu.c
index 17304fa..25129b0 100644
--- a/drivers/soc/samsung/exynos-pmu.c
+++ b/drivers/soc/samsung/exynos-pmu.c
@@ -8,6 +8,7 @@
#include <linux/of.h>
#include <linux/of_address.h>
#include <linux/of_device.h>
+#include <linux/of_platform.h>
#include <linux/mfd/syscon.h>
#include <linux/platform_device.h>
#include <linux/delay.h>
diff --git a/drivers/soc/sunxi/sunxi_sram.c b/drivers/soc/sunxi/sunxi_sram.c
index 1b0d50f..423cec3 100644
--- a/drivers/soc/sunxi/sunxi_sram.c
+++ b/drivers/soc/sunxi/sunxi_sram.c
@@ -16,6 +16,7 @@
#include <linux/of.h>
#include <linux/of_address.h>
#include <linux/of_device.h>
+#include <linux/of_platform.h>
#include <linux/platform_device.h>
#include <linux/regmap.h>
diff --git a/include/linux/of_device.h b/include/linux/of_device.h
index 8d31e39..752999b 100644
--- a/include/linux/of_device.h
+++ b/include/linux/of_device.h
@@ -4,8 +4,6 @@
#include <linux/cpu.h>
#include <linux/platform_device.h>
-#include <linux/of_platform.h> /* temporary until merge */
-
#include <linux/of.h>
#include <linux/mod_devicetable.h>
diff --git a/lib/genalloc.c b/lib/genalloc.c
index 7f1244b..08e21eeb 100644
--- a/lib/genalloc.c
+++ b/lib/genalloc.c
@@ -33,6 +33,7 @@
#include <linux/interrupt.h>
#include <linux/genalloc.h>
#include <linux/of_device.h>
+#include <linux/of_platform.h>
#include <linux/vmalloc.h>
static inline size_t chunk_size(const struct gen_pool_chunk *chunk)
--
2.7.4
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply related [flat|nested] 25+ messages in thread[parent not found: <1587030553-5990-1-git-send-email-hadar.gat-5wv7dgnIgG8@public.gmane.org>]
* Re: [PATCH v2] of_device: removed #include that caused a recursion in included headers
2020-04-16 9:49 ` Hadar Gat
` (2 preceding siblings ...)
(?)
@ 2020-04-18 15:34 ` Jonathan Cameron
-1 siblings, 0 replies; 25+ messages in thread
From: Jonathan Cameron @ 2020-04-18 15:34 UTC (permalink / raw)
To: Hadar Gat
Cc: Jose Abreu, Alexandre Belloni, Heiko Stübner,
devicetree-u79uwXL29TY76Z2rM5mHXA, David Airlie,
Michael Turquette, Liviu Dudau, Stefan Agner, Nicolas Ferre,
linux-tegra-u79uwXL29TY76Z2rM5mHXA, Thierry Reding,
linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Miquel Raynal,
sparclinux-u79uwXL29TY76Z2rM5mHXA, netdev-u79uwXL29TY76Z2rM5mHXA,
Kishon Vijay Abraham I, Lee Jones,
linux-clk-u79uwXL29TY76Z2rM5mHXA, Vignesh Raghavendra,
linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA, Frank Rowand,
linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
Richard Weinberger, Vinod Koul
On Thu, 16 Apr 2020 12:49:03 +0300
Hadar Gat <hadar.gat-5wv7dgnIgG8@public.gmane.org> wrote:
> Both of_platform.h and of_device.h were included each other.
> In of_device.h, removed unneeded #include to of_platform.h
> and added include to of_platform.h in the files that needs it.
>
> Signed-off-by: Hadar Gat <hadar.gat-5wv7dgnIgG8@public.gmane.org>
Hmm. I guess the chances of this causing merge problems are fairly low so
perhaps not worth doing additions of headers via individual subsystems and
actually dropping the header include after another cycle.
So on that basis
Acked-by: Jonathan Cameron <Jonathan.Cameron-hv44wF8Li93QT0dZR+AlfA@public.gmane.org> #for-iio
> ---
> v2: add include to of_platform.h in more files. (reported due other builds)
>
> arch/sparc/mm/io-unit.c | 1 +
> arch/sparc/mm/iommu.c | 1 +
> drivers/base/platform.c | 1 +
> drivers/bus/imx-weim.c | 1 +
> drivers/bus/vexpress-config.c | 1 +
> drivers/clk/mediatek/clk-mt7622-aud.c | 1 +
> drivers/dma/at_hdmac.c | 1 +
> drivers/dma/stm32-dmamux.c | 1 +
> drivers/dma/ti/dma-crossbar.c | 1 +
> drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 1 +
> drivers/gpu/drm/msm/hdmi/hdmi.c | 1 +
> drivers/gpu/drm/msm/msm_drv.c | 1 +
> drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c | 1 +
> drivers/gpu/drm/sun4i/sun4i_tcon.c | 1 +
> drivers/iio/adc/stm32-adc-core.c | 1 +
> drivers/iio/adc/stm32-dfsdm-adc.c | 1 +
> drivers/iio/adc/stm32-dfsdm-core.c | 1 +
> drivers/iommu/tegra-smmu.c | 1 +
> drivers/memory/atmel-ebi.c | 1 +
> drivers/mfd/palmas.c | 1 +
> drivers/mfd/ssbi.c | 1 +
> drivers/mtd/nand/raw/omap2.c | 1 +
> drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c | 1 +
> drivers/net/ethernet/ti/cpsw.c | 1 +
> drivers/phy/tegra/xusb.c | 1 +
> drivers/pinctrl/freescale/pinctrl-imx1-core.c | 1 +
> drivers/pinctrl/nomadik/pinctrl-nomadik.c | 1 +
> drivers/soc/samsung/exynos-pmu.c | 1 +
> drivers/soc/sunxi/sunxi_sram.c | 1 +
> include/linux/of_device.h | 2 --
> lib/genalloc.c | 1 +
> 31 files changed, 30 insertions(+), 2 deletions(-)
>
> diff --git a/arch/sparc/mm/io-unit.c b/arch/sparc/mm/io-unit.c
> index 289276b..5638399 100644
> --- a/arch/sparc/mm/io-unit.c
> +++ b/arch/sparc/mm/io-unit.c
> @@ -15,6 +15,7 @@
> #include <linux/dma-mapping.h>
> #include <linux/of.h>
> #include <linux/of_device.h>
> +#include <linux/of_platform.h>
>
> #include <asm/pgalloc.h>
> #include <asm/pgtable.h>
> diff --git a/arch/sparc/mm/iommu.c b/arch/sparc/mm/iommu.c
> index b00dde1..9cbb2e7 100644
> --- a/arch/sparc/mm/iommu.c
> +++ b/arch/sparc/mm/iommu.c
> @@ -16,6 +16,7 @@
> #include <linux/dma-mapping.h>
> #include <linux/of.h>
> #include <linux/of_device.h>
> +#include <linux/of_platform.h>
>
> #include <asm/pgalloc.h>
> #include <asm/pgtable.h>
> diff --git a/drivers/base/platform.c b/drivers/base/platform.c
> index 5255550..f549274b 100644
> --- a/drivers/base/platform.c
> +++ b/drivers/base/platform.c
> @@ -12,6 +12,7 @@
> #include <linux/string.h>
> #include <linux/platform_device.h>
> #include <linux/of_device.h>
> +#include <linux/of_platform.h>
> #include <linux/of_irq.h>
> #include <linux/module.h>
> #include <linux/init.h>
> diff --git a/drivers/bus/imx-weim.c b/drivers/bus/imx-weim.c
> index 28bb65a..8c786da 100644
> --- a/drivers/bus/imx-weim.c
> +++ b/drivers/bus/imx-weim.c
> @@ -11,6 +11,7 @@
> #include <linux/clk.h>
> #include <linux/io.h>
> #include <linux/of_device.h>
> +#include <linux/of_platform.h>
> #include <linux/mfd/syscon.h>
> #include <linux/mfd/syscon/imx6q-iomuxc-gpr.h>
> #include <linux/regmap.h>
> diff --git a/drivers/bus/vexpress-config.c b/drivers/bus/vexpress-config.c
> index ff70575..12b8b0b 100644
> --- a/drivers/bus/vexpress-config.c
> +++ b/drivers/bus/vexpress-config.c
> @@ -8,6 +8,7 @@
> #include <linux/init.h>
> #include <linux/of.h>
> #include <linux/of_device.h>
> +#include <linux/of_platform.h>
> #include <linux/vexpress.h>
>
>
> diff --git a/drivers/clk/mediatek/clk-mt7622-aud.c b/drivers/clk/mediatek/clk-mt7622-aud.c
> index 2bd4295..8cbb68f 100644
> --- a/drivers/clk/mediatek/clk-mt7622-aud.c
> +++ b/drivers/clk/mediatek/clk-mt7622-aud.c
> @@ -9,6 +9,7 @@
> #include <linux/of.h>
> #include <linux/of_address.h>
> #include <linux/of_device.h>
> +#include <linux/of_platform.h>
> #include <linux/platform_device.h>
>
> #include "clk-mtk.h"
> diff --git a/drivers/dma/at_hdmac.c b/drivers/dma/at_hdmac.c
> index 73a2078..388f8e10 100644
> --- a/drivers/dma/at_hdmac.c
> +++ b/drivers/dma/at_hdmac.c
> @@ -20,6 +20,7 @@
> #include <linux/slab.h>
> #include <linux/of.h>
> #include <linux/of_device.h>
> +#include <linux/of_platform.h>
> #include <linux/of_dma.h>
>
> #include "at_hdmac_regs.h"
> diff --git a/drivers/dma/stm32-dmamux.c b/drivers/dma/stm32-dmamux.c
> index 12f7637..b704896 100644
> --- a/drivers/dma/stm32-dmamux.c
> +++ b/drivers/dma/stm32-dmamux.c
> @@ -16,6 +16,7 @@
> #include <linux/init.h>
> #include <linux/module.h>
> #include <linux/of_device.h>
> +#include <linux/of_platform.h>
> #include <linux/of_dma.h>
> #include <linux/pm_runtime.h>
> #include <linux/reset.h>
> diff --git a/drivers/dma/ti/dma-crossbar.c b/drivers/dma/ti/dma-crossbar.c
> index 4ba8fa5..2c0fd44 100644
> --- a/drivers/dma/ti/dma-crossbar.c
> +++ b/drivers/dma/ti/dma-crossbar.c
> @@ -10,6 +10,7 @@
> #include <linux/io.h>
> #include <linux/of_address.h>
> #include <linux/of_device.h>
> +#include <linux/of_platform.h>
> #include <linux/of_dma.h>
>
> #define TI_XBAR_DRA7 0
> diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c b/drivers/gpu/drm/msm/adreno/a6xx_gmu.c
> index c4e71ab..f523254 100644
> --- a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c
> +++ b/drivers/gpu/drm/msm/adreno/a6xx_gmu.c
> @@ -6,6 +6,7 @@
> #include <linux/interconnect.h>
> #include <linux/pm_domain.h>
> #include <linux/pm_opp.h>
> +#include <linux/of_platform.h>
> #include <soc/qcom/cmd-db.h>
>
> #include "a6xx_gpu.h"
> diff --git a/drivers/gpu/drm/msm/hdmi/hdmi.c b/drivers/gpu/drm/msm/hdmi/hdmi.c
> index 737453b..5034d40 100644
> --- a/drivers/gpu/drm/msm/hdmi/hdmi.c
> +++ b/drivers/gpu/drm/msm/hdmi/hdmi.c
> @@ -7,6 +7,7 @@
>
> #include <linux/of_irq.h>
> #include <linux/of_gpio.h>
> +#include <linux/of_platform.h>
>
> #include <sound/hdmi-codec.h>
> #include "hdmi.h"
> diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c
> index 29295de..ddc9e85 100644
> --- a/drivers/gpu/drm/msm/msm_drv.c
> +++ b/drivers/gpu/drm/msm/msm_drv.c
> @@ -8,6 +8,7 @@
> #include <linux/dma-mapping.h>
> #include <linux/kthread.h>
> #include <linux/uaccess.h>
> +#include <linux/of_platform.h>
> #include <uapi/linux/sched/types.h>
>
> #include <drm/drm_drv.h>
> diff --git a/drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c b/drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c
> index 6e1270e..d038bae 100644
> --- a/drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c
> +++ b/drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c
> @@ -12,6 +12,7 @@
> #include <linux/mfd/syscon.h>
> #include <linux/module.h>
> #include <linux/of_device.h>
> +#include <linux/of_platform.h>
> #include <linux/phy/phy.h>
> #include <linux/pm_runtime.h>
> #include <linux/regmap.h>
> diff --git a/drivers/gpu/drm/sun4i/sun4i_tcon.c b/drivers/gpu/drm/sun4i/sun4i_tcon.c
> index 624437b..aa35757 100644
> --- a/drivers/gpu/drm/sun4i/sun4i_tcon.c
> +++ b/drivers/gpu/drm/sun4i/sun4i_tcon.c
> @@ -11,6 +11,7 @@
> #include <linux/module.h>
> #include <linux/of_address.h>
> #include <linux/of_device.h>
> +#include <linux/of_platform.h>
> #include <linux/of_irq.h>
> #include <linux/regmap.h>
> #include <linux/reset.h>
> diff --git a/drivers/iio/adc/stm32-adc-core.c b/drivers/iio/adc/stm32-adc-core.c
> index 2df88d2..3dc3453 100644
> --- a/drivers/iio/adc/stm32-adc-core.c
> +++ b/drivers/iio/adc/stm32-adc-core.c
> @@ -17,6 +17,7 @@
> #include <linux/mfd/syscon.h>
> #include <linux/module.h>
> #include <linux/of_device.h>
> +#include <linux/of_platform.h>
> #include <linux/pm_runtime.h>
> #include <linux/regmap.h>
> #include <linux/regulator/consumer.h>
> diff --git a/drivers/iio/adc/stm32-dfsdm-adc.c b/drivers/iio/adc/stm32-dfsdm-adc.c
> index 76a60d9..e83848cb 100644
> --- a/drivers/iio/adc/stm32-dfsdm-adc.c
> +++ b/drivers/iio/adc/stm32-dfsdm-adc.c
> @@ -20,6 +20,7 @@
> #include <linux/interrupt.h>
> #include <linux/module.h>
> #include <linux/of_device.h>
> +#include <linux/of_platform.h>
> #include <linux/platform_device.h>
> #include <linux/regmap.h>
> #include <linux/slab.h>
> diff --git a/drivers/iio/adc/stm32-dfsdm-core.c b/drivers/iio/adc/stm32-dfsdm-core.c
> index 26e2011..f6a53ab 100644
> --- a/drivers/iio/adc/stm32-dfsdm-core.c
> +++ b/drivers/iio/adc/stm32-dfsdm-core.c
> @@ -12,6 +12,7 @@
> #include <linux/interrupt.h>
> #include <linux/module.h>
> #include <linux/of_device.h>
> +#include <linux/of_platform.h>
> #include <linux/pinctrl/consumer.h>
> #include <linux/pm_runtime.h>
> #include <linux/regmap.h>
> diff --git a/drivers/iommu/tegra-smmu.c b/drivers/iommu/tegra-smmu.c
> index 63a147b..3797caa 100644
> --- a/drivers/iommu/tegra-smmu.c
> +++ b/drivers/iommu/tegra-smmu.c
> @@ -10,6 +10,7 @@
> #include <linux/kernel.h>
> #include <linux/of.h>
> #include <linux/of_device.h>
> +#include <linux/of_platform.h>
> #include <linux/platform_device.h>
> #include <linux/slab.h>
> #include <linux/dma-mapping.h>
> diff --git a/drivers/memory/atmel-ebi.c b/drivers/memory/atmel-ebi.c
> index 14386d0..272b1a8 100644
> --- a/drivers/memory/atmel-ebi.c
> +++ b/drivers/memory/atmel-ebi.c
> @@ -13,6 +13,7 @@
> #include <linux/mfd/syscon/atmel-smc.h>
> #include <linux/init.h>
> #include <linux/of_device.h>
> +#include <linux/of_platform.h>
> #include <linux/regmap.h>
> #include <soc/at91/atmel-sfr.h>
>
> diff --git a/drivers/mfd/palmas.c b/drivers/mfd/palmas.c
> index f5b3fa9..cca44bc 100644
> --- a/drivers/mfd/palmas.c
> +++ b/drivers/mfd/palmas.c
> @@ -19,6 +19,7 @@
> #include <linux/mfd/core.h>
> #include <linux/mfd/palmas.h>
> #include <linux/of_device.h>
> +#include <linux/of_platform.h>
>
> static const struct regmap_config palmas_regmap_config[PALMAS_NUM_CLIENTS] = {
> {
> diff --git a/drivers/mfd/ssbi.c b/drivers/mfd/ssbi.c
> index 94f60df..72cd45a 100644
> --- a/drivers/mfd/ssbi.c
> +++ b/drivers/mfd/ssbi.c
> @@ -20,6 +20,7 @@
> #include <linux/module.h>
> #include <linux/of.h>
> #include <linux/of_device.h>
> +#include <linux/of_platform.h>
>
> /* SSBI 2.0 controller registers */
> #define SSBI2_CMD 0x0008
> diff --git a/drivers/mtd/nand/raw/omap2.c b/drivers/mtd/nand/raw/omap2.c
> index ad77c11..d851ec7 100644
> --- a/drivers/mtd/nand/raw/omap2.c
> +++ b/drivers/mtd/nand/raw/omap2.c
> @@ -22,6 +22,7 @@
> #include <linux/slab.h>
> #include <linux/of.h>
> #include <linux/of_device.h>
> +#include <linux/of_platform.h>
>
> #include <linux/mtd/nand_bch.h>
> #include <linux/platform_data/elm.h>
> diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c
> index 58e0511..d704d57 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c
> @@ -12,6 +12,7 @@
> #include <linux/mfd/syscon.h>
> #include <linux/module.h>
> #include <linux/of_device.h>
> +#include <linux/of_platform.h>
> #include <linux/of_mdio.h>
> #include <linux/of_net.h>
> #include <linux/phy.h>
> diff --git a/drivers/net/ethernet/ti/cpsw.c b/drivers/net/ethernet/ti/cpsw.c
> index c2c5bf8..6932945 100644
> --- a/drivers/net/ethernet/ti/cpsw.c
> +++ b/drivers/net/ethernet/ti/cpsw.c
> @@ -28,6 +28,7 @@
> #include <linux/of_mdio.h>
> #include <linux/of_net.h>
> #include <linux/of_device.h>
> +#include <linux/of_platform.h>
> #include <linux/if_vlan.h>
> #include <linux/kmemleak.h>
> #include <linux/sys_soc.h>
> diff --git a/drivers/phy/tegra/xusb.c b/drivers/phy/tegra/xusb.c
> index de4a46f..0eac1b8 100644
> --- a/drivers/phy/tegra/xusb.c
> +++ b/drivers/phy/tegra/xusb.c
> @@ -9,6 +9,7 @@
> #include <linux/module.h>
> #include <linux/of.h>
> #include <linux/of_device.h>
> +#include <linux/of_platform.h>
> #include <linux/phy/phy.h>
> #include <linux/phy/tegra/xusb.h>
> #include <linux/platform_device.h>
> diff --git a/drivers/pinctrl/freescale/pinctrl-imx1-core.c b/drivers/pinctrl/freescale/pinctrl-imx1-core.c
> index c00d002..d1c171e 100644
> --- a/drivers/pinctrl/freescale/pinctrl-imx1-core.c
> +++ b/drivers/pinctrl/freescale/pinctrl-imx1-core.c
> @@ -16,6 +16,7 @@
> #include <linux/io.h>
> #include <linux/of.h>
> #include <linux/of_device.h>
> +#include <linux/of_platform.h>
> #include <linux/pinctrl/machine.h>
> #include <linux/pinctrl/pinconf.h>
> #include <linux/pinctrl/pinctrl.h>
> diff --git a/drivers/pinctrl/nomadik/pinctrl-nomadik.c b/drivers/pinctrl/nomadik/pinctrl-nomadik.c
> index ca7bbe4..44974ac 100644
> --- a/drivers/pinctrl/nomadik/pinctrl-nomadik.c
> +++ b/drivers/pinctrl/nomadik/pinctrl-nomadik.c
> @@ -19,6 +19,7 @@
> #include <linux/interrupt.h>
> #include <linux/slab.h>
> #include <linux/of_device.h>
> +#include <linux/of_platform.h>
> #include <linux/of_address.h>
> #include <linux/bitops.h>
> #include <linux/pinctrl/machine.h>
> diff --git a/drivers/soc/samsung/exynos-pmu.c b/drivers/soc/samsung/exynos-pmu.c
> index 17304fa..25129b0 100644
> --- a/drivers/soc/samsung/exynos-pmu.c
> +++ b/drivers/soc/samsung/exynos-pmu.c
> @@ -8,6 +8,7 @@
> #include <linux/of.h>
> #include <linux/of_address.h>
> #include <linux/of_device.h>
> +#include <linux/of_platform.h>
> #include <linux/mfd/syscon.h>
> #include <linux/platform_device.h>
> #include <linux/delay.h>
> diff --git a/drivers/soc/sunxi/sunxi_sram.c b/drivers/soc/sunxi/sunxi_sram.c
> index 1b0d50f..423cec3 100644
> --- a/drivers/soc/sunxi/sunxi_sram.c
> +++ b/drivers/soc/sunxi/sunxi_sram.c
> @@ -16,6 +16,7 @@
> #include <linux/of.h>
> #include <linux/of_address.h>
> #include <linux/of_device.h>
> +#include <linux/of_platform.h>
> #include <linux/platform_device.h>
> #include <linux/regmap.h>
>
> diff --git a/include/linux/of_device.h b/include/linux/of_device.h
> index 8d31e39..752999b 100644
> --- a/include/linux/of_device.h
> +++ b/include/linux/of_device.h
> @@ -4,8 +4,6 @@
>
> #include <linux/cpu.h>
> #include <linux/platform_device.h>
> -#include <linux/of_platform.h> /* temporary until merge */
> -
> #include <linux/of.h>
> #include <linux/mod_devicetable.h>
>
> diff --git a/lib/genalloc.c b/lib/genalloc.c
> index 7f1244b..08e21eeb 100644
> --- a/lib/genalloc.c
> +++ b/lib/genalloc.c
> @@ -33,6 +33,7 @@
> #include <linux/interrupt.h>
> #include <linux/genalloc.h>
> #include <linux/of_device.h>
> +#include <linux/of_platform.h>
> #include <linux/vmalloc.h>
>
> static inline size_t chunk_size(const struct gen_pool_chunk *chunk)
^ permalink raw reply [flat|nested] 25+ messages in thread* Re: [PATCH v2] of_device: removed #include that caused a recursion in included headers
@ 2020-04-18 15:34 ` Jonathan Cameron
0 siblings, 0 replies; 25+ messages in thread
From: Jonathan Cameron @ 2020-04-18 15:34 UTC (permalink / raw)
To: Hadar Gat
Cc: Jose Abreu, Alexandre Belloni, devicetree, David Airlie,
Michael Turquette, Liviu Dudau, Nicolas Ferre, linux-tegra,
Thierry Reding, linux-mtd, Miquel Raynal, sparclinux, netdev,
Kishon Vijay Abraham I, Lee Jones, linux-clk,
Vignesh Raghavendra, linux-samsung-soc, Lorenzo Pieralisi,
Frank Rowand, linux-rockchip, Richard Weinberger, Joerg Roedel,
Vinod Koul, Krzysztof Kozlowski, Jonathan Hunter, Tony Lindgren,
Ludovic Desroches, Andy Gross, freedreno, Alexandre Torgue,
linux-omap, iommu, linux-arm-msm, Sascha Hauer, Gilad Ben-Yossef,
Rob Herring, linux-mediatek, dri-devel, Matthias Brugger,
Chen-Yu Tsai, Sean Paul, linux-arm-kernel, Ofir Drang,
Dong Aisheng, linux-gpio, Stephen Boyd, Greg Kroah-Hartman,
Giuseppe Cavallaro, linux-stm32, Sandy Huang, linux-iio,
linux-kernel, JC Kuo, Bjorn Andersson, Kukjin Kim,
Maxime Coquelin, Sudeep Holla, dmaengine, Shawn Guo,
David S. Miller
On Thu, 16 Apr 2020 12:49:03 +0300
Hadar Gat <hadar.gat@arm.com> wrote:
> Both of_platform.h and of_device.h were included each other.
> In of_device.h, removed unneeded #include to of_platform.h
> and added include to of_platform.h in the files that needs it.
>
> Signed-off-by: Hadar Gat <hadar.gat@arm.com>
Hmm. I guess the chances of this causing merge problems are fairly low so
perhaps not worth doing additions of headers via individual subsystems and
actually dropping the header include after another cycle.
So on that basis
Acked-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> #for-iio
> ---
> v2: add include to of_platform.h in more files. (reported due other builds)
>
> arch/sparc/mm/io-unit.c | 1 +
> arch/sparc/mm/iommu.c | 1 +
> drivers/base/platform.c | 1 +
> drivers/bus/imx-weim.c | 1 +
> drivers/bus/vexpress-config.c | 1 +
> drivers/clk/mediatek/clk-mt7622-aud.c | 1 +
> drivers/dma/at_hdmac.c | 1 +
> drivers/dma/stm32-dmamux.c | 1 +
> drivers/dma/ti/dma-crossbar.c | 1 +
> drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 1 +
> drivers/gpu/drm/msm/hdmi/hdmi.c | 1 +
> drivers/gpu/drm/msm/msm_drv.c | 1 +
> drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c | 1 +
> drivers/gpu/drm/sun4i/sun4i_tcon.c | 1 +
> drivers/iio/adc/stm32-adc-core.c | 1 +
> drivers/iio/adc/stm32-dfsdm-adc.c | 1 +
> drivers/iio/adc/stm32-dfsdm-core.c | 1 +
> drivers/iommu/tegra-smmu.c | 1 +
> drivers/memory/atmel-ebi.c | 1 +
> drivers/mfd/palmas.c | 1 +
> drivers/mfd/ssbi.c | 1 +
> drivers/mtd/nand/raw/omap2.c | 1 +
> drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c | 1 +
> drivers/net/ethernet/ti/cpsw.c | 1 +
> drivers/phy/tegra/xusb.c | 1 +
> drivers/pinctrl/freescale/pinctrl-imx1-core.c | 1 +
> drivers/pinctrl/nomadik/pinctrl-nomadik.c | 1 +
> drivers/soc/samsung/exynos-pmu.c | 1 +
> drivers/soc/sunxi/sunxi_sram.c | 1 +
> include/linux/of_device.h | 2 --
> lib/genalloc.c | 1 +
> 31 files changed, 30 insertions(+), 2 deletions(-)
>
> diff --git a/arch/sparc/mm/io-unit.c b/arch/sparc/mm/io-unit.c
> index 289276b..5638399 100644
> --- a/arch/sparc/mm/io-unit.c
> +++ b/arch/sparc/mm/io-unit.c
> @@ -15,6 +15,7 @@
> #include <linux/dma-mapping.h>
> #include <linux/of.h>
> #include <linux/of_device.h>
> +#include <linux/of_platform.h>
>
> #include <asm/pgalloc.h>
> #include <asm/pgtable.h>
> diff --git a/arch/sparc/mm/iommu.c b/arch/sparc/mm/iommu.c
> index b00dde1..9cbb2e7 100644
> --- a/arch/sparc/mm/iommu.c
> +++ b/arch/sparc/mm/iommu.c
> @@ -16,6 +16,7 @@
> #include <linux/dma-mapping.h>
> #include <linux/of.h>
> #include <linux/of_device.h>
> +#include <linux/of_platform.h>
>
> #include <asm/pgalloc.h>
> #include <asm/pgtable.h>
> diff --git a/drivers/base/platform.c b/drivers/base/platform.c
> index 5255550..f549274b 100644
> --- a/drivers/base/platform.c
> +++ b/drivers/base/platform.c
> @@ -12,6 +12,7 @@
> #include <linux/string.h>
> #include <linux/platform_device.h>
> #include <linux/of_device.h>
> +#include <linux/of_platform.h>
> #include <linux/of_irq.h>
> #include <linux/module.h>
> #include <linux/init.h>
> diff --git a/drivers/bus/imx-weim.c b/drivers/bus/imx-weim.c
> index 28bb65a..8c786da 100644
> --- a/drivers/bus/imx-weim.c
> +++ b/drivers/bus/imx-weim.c
> @@ -11,6 +11,7 @@
> #include <linux/clk.h>
> #include <linux/io.h>
> #include <linux/of_device.h>
> +#include <linux/of_platform.h>
> #include <linux/mfd/syscon.h>
> #include <linux/mfd/syscon/imx6q-iomuxc-gpr.h>
> #include <linux/regmap.h>
> diff --git a/drivers/bus/vexpress-config.c b/drivers/bus/vexpress-config.c
> index ff70575..12b8b0b 100644
> --- a/drivers/bus/vexpress-config.c
> +++ b/drivers/bus/vexpress-config.c
> @@ -8,6 +8,7 @@
> #include <linux/init.h>
> #include <linux/of.h>
> #include <linux/of_device.h>
> +#include <linux/of_platform.h>
> #include <linux/vexpress.h>
>
>
> diff --git a/drivers/clk/mediatek/clk-mt7622-aud.c b/drivers/clk/mediatek/clk-mt7622-aud.c
> index 2bd4295..8cbb68f 100644
> --- a/drivers/clk/mediatek/clk-mt7622-aud.c
> +++ b/drivers/clk/mediatek/clk-mt7622-aud.c
> @@ -9,6 +9,7 @@
> #include <linux/of.h>
> #include <linux/of_address.h>
> #include <linux/of_device.h>
> +#include <linux/of_platform.h>
> #include <linux/platform_device.h>
>
> #include "clk-mtk.h"
> diff --git a/drivers/dma/at_hdmac.c b/drivers/dma/at_hdmac.c
> index 73a2078..388f8e10 100644
> --- a/drivers/dma/at_hdmac.c
> +++ b/drivers/dma/at_hdmac.c
> @@ -20,6 +20,7 @@
> #include <linux/slab.h>
> #include <linux/of.h>
> #include <linux/of_device.h>
> +#include <linux/of_platform.h>
> #include <linux/of_dma.h>
>
> #include "at_hdmac_regs.h"
> diff --git a/drivers/dma/stm32-dmamux.c b/drivers/dma/stm32-dmamux.c
> index 12f7637..b704896 100644
> --- a/drivers/dma/stm32-dmamux.c
> +++ b/drivers/dma/stm32-dmamux.c
> @@ -16,6 +16,7 @@
> #include <linux/init.h>
> #include <linux/module.h>
> #include <linux/of_device.h>
> +#include <linux/of_platform.h>
> #include <linux/of_dma.h>
> #include <linux/pm_runtime.h>
> #include <linux/reset.h>
> diff --git a/drivers/dma/ti/dma-crossbar.c b/drivers/dma/ti/dma-crossbar.c
> index 4ba8fa5..2c0fd44 100644
> --- a/drivers/dma/ti/dma-crossbar.c
> +++ b/drivers/dma/ti/dma-crossbar.c
> @@ -10,6 +10,7 @@
> #include <linux/io.h>
> #include <linux/of_address.h>
> #include <linux/of_device.h>
> +#include <linux/of_platform.h>
> #include <linux/of_dma.h>
>
> #define TI_XBAR_DRA7 0
> diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c b/drivers/gpu/drm/msm/adreno/a6xx_gmu.c
> index c4e71ab..f523254 100644
> --- a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c
> +++ b/drivers/gpu/drm/msm/adreno/a6xx_gmu.c
> @@ -6,6 +6,7 @@
> #include <linux/interconnect.h>
> #include <linux/pm_domain.h>
> #include <linux/pm_opp.h>
> +#include <linux/of_platform.h>
> #include <soc/qcom/cmd-db.h>
>
> #include "a6xx_gpu.h"
> diff --git a/drivers/gpu/drm/msm/hdmi/hdmi.c b/drivers/gpu/drm/msm/hdmi/hdmi.c
> index 737453b..5034d40 100644
> --- a/drivers/gpu/drm/msm/hdmi/hdmi.c
> +++ b/drivers/gpu/drm/msm/hdmi/hdmi.c
> @@ -7,6 +7,7 @@
>
> #include <linux/of_irq.h>
> #include <linux/of_gpio.h>
> +#include <linux/of_platform.h>
>
> #include <sound/hdmi-codec.h>
> #include "hdmi.h"
> diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c
> index 29295de..ddc9e85 100644
> --- a/drivers/gpu/drm/msm/msm_drv.c
> +++ b/drivers/gpu/drm/msm/msm_drv.c
> @@ -8,6 +8,7 @@
> #include <linux/dma-mapping.h>
> #include <linux/kthread.h>
> #include <linux/uaccess.h>
> +#include <linux/of_platform.h>
> #include <uapi/linux/sched/types.h>
>
> #include <drm/drm_drv.h>
> diff --git a/drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c b/drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c
> index 6e1270e..d038bae 100644
> --- a/drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c
> +++ b/drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c
> @@ -12,6 +12,7 @@
> #include <linux/mfd/syscon.h>
> #include <linux/module.h>
> #include <linux/of_device.h>
> +#include <linux/of_platform.h>
> #include <linux/phy/phy.h>
> #include <linux/pm_runtime.h>
> #include <linux/regmap.h>
> diff --git a/drivers/gpu/drm/sun4i/sun4i_tcon.c b/drivers/gpu/drm/sun4i/sun4i_tcon.c
> index 624437b..aa35757 100644
> --- a/drivers/gpu/drm/sun4i/sun4i_tcon.c
> +++ b/drivers/gpu/drm/sun4i/sun4i_tcon.c
> @@ -11,6 +11,7 @@
> #include <linux/module.h>
> #include <linux/of_address.h>
> #include <linux/of_device.h>
> +#include <linux/of_platform.h>
> #include <linux/of_irq.h>
> #include <linux/regmap.h>
> #include <linux/reset.h>
> diff --git a/drivers/iio/adc/stm32-adc-core.c b/drivers/iio/adc/stm32-adc-core.c
> index 2df88d2..3dc3453 100644
> --- a/drivers/iio/adc/stm32-adc-core.c
> +++ b/drivers/iio/adc/stm32-adc-core.c
> @@ -17,6 +17,7 @@
> #include <linux/mfd/syscon.h>
> #include <linux/module.h>
> #include <linux/of_device.h>
> +#include <linux/of_platform.h>
> #include <linux/pm_runtime.h>
> #include <linux/regmap.h>
> #include <linux/regulator/consumer.h>
> diff --git a/drivers/iio/adc/stm32-dfsdm-adc.c b/drivers/iio/adc/stm32-dfsdm-adc.c
> index 76a60d9..e83848cb 100644
> --- a/drivers/iio/adc/stm32-dfsdm-adc.c
> +++ b/drivers/iio/adc/stm32-dfsdm-adc.c
> @@ -20,6 +20,7 @@
> #include <linux/interrupt.h>
> #include <linux/module.h>
> #include <linux/of_device.h>
> +#include <linux/of_platform.h>
> #include <linux/platform_device.h>
> #include <linux/regmap.h>
> #include <linux/slab.h>
> diff --git a/drivers/iio/adc/stm32-dfsdm-core.c b/drivers/iio/adc/stm32-dfsdm-core.c
> index 26e2011..f6a53ab 100644
> --- a/drivers/iio/adc/stm32-dfsdm-core.c
> +++ b/drivers/iio/adc/stm32-dfsdm-core.c
> @@ -12,6 +12,7 @@
> #include <linux/interrupt.h>
> #include <linux/module.h>
> #include <linux/of_device.h>
> +#include <linux/of_platform.h>
> #include <linux/pinctrl/consumer.h>
> #include <linux/pm_runtime.h>
> #include <linux/regmap.h>
> diff --git a/drivers/iommu/tegra-smmu.c b/drivers/iommu/tegra-smmu.c
> index 63a147b..3797caa 100644
> --- a/drivers/iommu/tegra-smmu.c
> +++ b/drivers/iommu/tegra-smmu.c
> @@ -10,6 +10,7 @@
> #include <linux/kernel.h>
> #include <linux/of.h>
> #include <linux/of_device.h>
> +#include <linux/of_platform.h>
> #include <linux/platform_device.h>
> #include <linux/slab.h>
> #include <linux/dma-mapping.h>
> diff --git a/drivers/memory/atmel-ebi.c b/drivers/memory/atmel-ebi.c
> index 14386d0..272b1a8 100644
> --- a/drivers/memory/atmel-ebi.c
> +++ b/drivers/memory/atmel-ebi.c
> @@ -13,6 +13,7 @@
> #include <linux/mfd/syscon/atmel-smc.h>
> #include <linux/init.h>
> #include <linux/of_device.h>
> +#include <linux/of_platform.h>
> #include <linux/regmap.h>
> #include <soc/at91/atmel-sfr.h>
>
> diff --git a/drivers/mfd/palmas.c b/drivers/mfd/palmas.c
> index f5b3fa9..cca44bc 100644
> --- a/drivers/mfd/palmas.c
> +++ b/drivers/mfd/palmas.c
> @@ -19,6 +19,7 @@
> #include <linux/mfd/core.h>
> #include <linux/mfd/palmas.h>
> #include <linux/of_device.h>
> +#include <linux/of_platform.h>
>
> static const struct regmap_config palmas_regmap_config[PALMAS_NUM_CLIENTS] = {
> {
> diff --git a/drivers/mfd/ssbi.c b/drivers/mfd/ssbi.c
> index 94f60df..72cd45a 100644
> --- a/drivers/mfd/ssbi.c
> +++ b/drivers/mfd/ssbi.c
> @@ -20,6 +20,7 @@
> #include <linux/module.h>
> #include <linux/of.h>
> #include <linux/of_device.h>
> +#include <linux/of_platform.h>
>
> /* SSBI 2.0 controller registers */
> #define SSBI2_CMD 0x0008
> diff --git a/drivers/mtd/nand/raw/omap2.c b/drivers/mtd/nand/raw/omap2.c
> index ad77c11..d851ec7 100644
> --- a/drivers/mtd/nand/raw/omap2.c
> +++ b/drivers/mtd/nand/raw/omap2.c
> @@ -22,6 +22,7 @@
> #include <linux/slab.h>
> #include <linux/of.h>
> #include <linux/of_device.h>
> +#include <linux/of_platform.h>
>
> #include <linux/mtd/nand_bch.h>
> #include <linux/platform_data/elm.h>
> diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c
> index 58e0511..d704d57 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c
> @@ -12,6 +12,7 @@
> #include <linux/mfd/syscon.h>
> #include <linux/module.h>
> #include <linux/of_device.h>
> +#include <linux/of_platform.h>
> #include <linux/of_mdio.h>
> #include <linux/of_net.h>
> #include <linux/phy.h>
> diff --git a/drivers/net/ethernet/ti/cpsw.c b/drivers/net/ethernet/ti/cpsw.c
> index c2c5bf8..6932945 100644
> --- a/drivers/net/ethernet/ti/cpsw.c
> +++ b/drivers/net/ethernet/ti/cpsw.c
> @@ -28,6 +28,7 @@
> #include <linux/of_mdio.h>
> #include <linux/of_net.h>
> #include <linux/of_device.h>
> +#include <linux/of_platform.h>
> #include <linux/if_vlan.h>
> #include <linux/kmemleak.h>
> #include <linux/sys_soc.h>
> diff --git a/drivers/phy/tegra/xusb.c b/drivers/phy/tegra/xusb.c
> index de4a46f..0eac1b8 100644
> --- a/drivers/phy/tegra/xusb.c
> +++ b/drivers/phy/tegra/xusb.c
> @@ -9,6 +9,7 @@
> #include <linux/module.h>
> #include <linux/of.h>
> #include <linux/of_device.h>
> +#include <linux/of_platform.h>
> #include <linux/phy/phy.h>
> #include <linux/phy/tegra/xusb.h>
> #include <linux/platform_device.h>
> diff --git a/drivers/pinctrl/freescale/pinctrl-imx1-core.c b/drivers/pinctrl/freescale/pinctrl-imx1-core.c
> index c00d002..d1c171e 100644
> --- a/drivers/pinctrl/freescale/pinctrl-imx1-core.c
> +++ b/drivers/pinctrl/freescale/pinctrl-imx1-core.c
> @@ -16,6 +16,7 @@
> #include <linux/io.h>
> #include <linux/of.h>
> #include <linux/of_device.h>
> +#include <linux/of_platform.h>
> #include <linux/pinctrl/machine.h>
> #include <linux/pinctrl/pinconf.h>
> #include <linux/pinctrl/pinctrl.h>
> diff --git a/drivers/pinctrl/nomadik/pinctrl-nomadik.c b/drivers/pinctrl/nomadik/pinctrl-nomadik.c
> index ca7bbe4..44974ac 100644
> --- a/drivers/pinctrl/nomadik/pinctrl-nomadik.c
> +++ b/drivers/pinctrl/nomadik/pinctrl-nomadik.c
> @@ -19,6 +19,7 @@
> #include <linux/interrupt.h>
> #include <linux/slab.h>
> #include <linux/of_device.h>
> +#include <linux/of_platform.h>
> #include <linux/of_address.h>
> #include <linux/bitops.h>
> #include <linux/pinctrl/machine.h>
> diff --git a/drivers/soc/samsung/exynos-pmu.c b/drivers/soc/samsung/exynos-pmu.c
> index 17304fa..25129b0 100644
> --- a/drivers/soc/samsung/exynos-pmu.c
> +++ b/drivers/soc/samsung/exynos-pmu.c
> @@ -8,6 +8,7 @@
> #include <linux/of.h>
> #include <linux/of_address.h>
> #include <linux/of_device.h>
> +#include <linux/of_platform.h>
> #include <linux/mfd/syscon.h>
> #include <linux/platform_device.h>
> #include <linux/delay.h>
> diff --git a/drivers/soc/sunxi/sunxi_sram.c b/drivers/soc/sunxi/sunxi_sram.c
> index 1b0d50f..423cec3 100644
> --- a/drivers/soc/sunxi/sunxi_sram.c
> +++ b/drivers/soc/sunxi/sunxi_sram.c
> @@ -16,6 +16,7 @@
> #include <linux/of.h>
> #include <linux/of_address.h>
> #include <linux/of_device.h>
> +#include <linux/of_platform.h>
> #include <linux/platform_device.h>
> #include <linux/regmap.h>
>
> diff --git a/include/linux/of_device.h b/include/linux/of_device.h
> index 8d31e39..752999b 100644
> --- a/include/linux/of_device.h
> +++ b/include/linux/of_device.h
> @@ -4,8 +4,6 @@
>
> #include <linux/cpu.h>
> #include <linux/platform_device.h>
> -#include <linux/of_platform.h> /* temporary until merge */
> -
> #include <linux/of.h>
> #include <linux/mod_devicetable.h>
>
> diff --git a/lib/genalloc.c b/lib/genalloc.c
> index 7f1244b..08e21eeb 100644
> --- a/lib/genalloc.c
> +++ b/lib/genalloc.c
> @@ -33,6 +33,7 @@
> #include <linux/interrupt.h>
> #include <linux/genalloc.h>
> #include <linux/of_device.h>
> +#include <linux/of_platform.h>
> #include <linux/vmalloc.h>
>
> static inline size_t chunk_size(const struct gen_pool_chunk *chunk)
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 25+ messages in thread* Re: [PATCH v2] of_device: removed #include that caused a recursion in included headers
@ 2020-04-18 15:34 ` Jonathan Cameron
0 siblings, 0 replies; 25+ messages in thread
From: Jonathan Cameron @ 2020-04-18 15:34 UTC (permalink / raw)
To: Hadar Gat
Cc: Jose Abreu, Alexandre Belloni, Heiko Stübner, devicetree,
David Airlie, Michael Turquette, Liviu Dudau, Stefan Agner,
Nicolas Ferre, linux-tegra, Thierry Reding, linux-mtd,
Miquel Raynal, sparclinux, netdev, Kishon Vijay Abraham I,
Lee Jones, linux-clk, Vignesh Raghavendra, linux-samsung-soc,
Lorenzo Pieralisi, Frank Rowand, linux-rockchip,
Richard Weinberger, Joerg Roedel, Vinod Koul,
Krzysztof Kozlowski, Jonathan Hunter, Tony Lindgren,
Ludovic Desroches, Andy Gross, Linus Walleij, freedreno,
Alexandre Torgue, linux-omap, iommu, linux-arm-msm, Sascha Hauer,
Maxime Ripard, Gilad Ben-Yossef, Rob Herring, linux-mediatek,
dri-devel, Fabio Estevam, Matthias Brugger, Daniel Vetter,
Chen-Yu Tsai, Sean Paul, linux-arm-kernel, Ofir Drang,
Dong Aisheng, linux-gpio, Stephen Boyd, Greg Kroah-Hartman,
Giuseppe Cavallaro, linux-stm32, Sandy Huang, linux-iio,
linux-kernel, JC Kuo, Rob Clark, Bjorn Andersson, Kukjin Kim,
Maxime Coquelin, Sudeep Holla, dmaengine, Shawn Guo,
David S. Miller
On Thu, 16 Apr 2020 12:49:03 +0300
Hadar Gat <hadar.gat@arm.com> wrote:
> Both of_platform.h and of_device.h were included each other.
> In of_device.h, removed unneeded #include to of_platform.h
> and added include to of_platform.h in the files that needs it.
>
> Signed-off-by: Hadar Gat <hadar.gat@arm.com>
Hmm. I guess the chances of this causing merge problems are fairly low so
perhaps not worth doing additions of headers via individual subsystems and
actually dropping the header include after another cycle.
So on that basis
Acked-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> #for-iio
> ---
> v2: add include to of_platform.h in more files. (reported due other builds)
>
> arch/sparc/mm/io-unit.c | 1 +
> arch/sparc/mm/iommu.c | 1 +
> drivers/base/platform.c | 1 +
> drivers/bus/imx-weim.c | 1 +
> drivers/bus/vexpress-config.c | 1 +
> drivers/clk/mediatek/clk-mt7622-aud.c | 1 +
> drivers/dma/at_hdmac.c | 1 +
> drivers/dma/stm32-dmamux.c | 1 +
> drivers/dma/ti/dma-crossbar.c | 1 +
> drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 1 +
> drivers/gpu/drm/msm/hdmi/hdmi.c | 1 +
> drivers/gpu/drm/msm/msm_drv.c | 1 +
> drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c | 1 +
> drivers/gpu/drm/sun4i/sun4i_tcon.c | 1 +
> drivers/iio/adc/stm32-adc-core.c | 1 +
> drivers/iio/adc/stm32-dfsdm-adc.c | 1 +
> drivers/iio/adc/stm32-dfsdm-core.c | 1 +
> drivers/iommu/tegra-smmu.c | 1 +
> drivers/memory/atmel-ebi.c | 1 +
> drivers/mfd/palmas.c | 1 +
> drivers/mfd/ssbi.c | 1 +
> drivers/mtd/nand/raw/omap2.c | 1 +
> drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c | 1 +
> drivers/net/ethernet/ti/cpsw.c | 1 +
> drivers/phy/tegra/xusb.c | 1 +
> drivers/pinctrl/freescale/pinctrl-imx1-core.c | 1 +
> drivers/pinctrl/nomadik/pinctrl-nomadik.c | 1 +
> drivers/soc/samsung/exynos-pmu.c | 1 +
> drivers/soc/sunxi/sunxi_sram.c | 1 +
> include/linux/of_device.h | 2 --
> lib/genalloc.c | 1 +
> 31 files changed, 30 insertions(+), 2 deletions(-)
>
> diff --git a/arch/sparc/mm/io-unit.c b/arch/sparc/mm/io-unit.c
> index 289276b..5638399 100644
> --- a/arch/sparc/mm/io-unit.c
> +++ b/arch/sparc/mm/io-unit.c
> @@ -15,6 +15,7 @@
> #include <linux/dma-mapping.h>
> #include <linux/of.h>
> #include <linux/of_device.h>
> +#include <linux/of_platform.h>
>
> #include <asm/pgalloc.h>
> #include <asm/pgtable.h>
> diff --git a/arch/sparc/mm/iommu.c b/arch/sparc/mm/iommu.c
> index b00dde1..9cbb2e7 100644
> --- a/arch/sparc/mm/iommu.c
> +++ b/arch/sparc/mm/iommu.c
> @@ -16,6 +16,7 @@
> #include <linux/dma-mapping.h>
> #include <linux/of.h>
> #include <linux/of_device.h>
> +#include <linux/of_platform.h>
>
> #include <asm/pgalloc.h>
> #include <asm/pgtable.h>
> diff --git a/drivers/base/platform.c b/drivers/base/platform.c
> index 5255550..f549274b 100644
> --- a/drivers/base/platform.c
> +++ b/drivers/base/platform.c
> @@ -12,6 +12,7 @@
> #include <linux/string.h>
> #include <linux/platform_device.h>
> #include <linux/of_device.h>
> +#include <linux/of_platform.h>
> #include <linux/of_irq.h>
> #include <linux/module.h>
> #include <linux/init.h>
> diff --git a/drivers/bus/imx-weim.c b/drivers/bus/imx-weim.c
> index 28bb65a..8c786da 100644
> --- a/drivers/bus/imx-weim.c
> +++ b/drivers/bus/imx-weim.c
> @@ -11,6 +11,7 @@
> #include <linux/clk.h>
> #include <linux/io.h>
> #include <linux/of_device.h>
> +#include <linux/of_platform.h>
> #include <linux/mfd/syscon.h>
> #include <linux/mfd/syscon/imx6q-iomuxc-gpr.h>
> #include <linux/regmap.h>
> diff --git a/drivers/bus/vexpress-config.c b/drivers/bus/vexpress-config.c
> index ff70575..12b8b0b 100644
> --- a/drivers/bus/vexpress-config.c
> +++ b/drivers/bus/vexpress-config.c
> @@ -8,6 +8,7 @@
> #include <linux/init.h>
> #include <linux/of.h>
> #include <linux/of_device.h>
> +#include <linux/of_platform.h>
> #include <linux/vexpress.h>
>
>
> diff --git a/drivers/clk/mediatek/clk-mt7622-aud.c b/drivers/clk/mediatek/clk-mt7622-aud.c
> index 2bd4295..8cbb68f 100644
> --- a/drivers/clk/mediatek/clk-mt7622-aud.c
> +++ b/drivers/clk/mediatek/clk-mt7622-aud.c
> @@ -9,6 +9,7 @@
> #include <linux/of.h>
> #include <linux/of_address.h>
> #include <linux/of_device.h>
> +#include <linux/of_platform.h>
> #include <linux/platform_device.h>
>
> #include "clk-mtk.h"
> diff --git a/drivers/dma/at_hdmac.c b/drivers/dma/at_hdmac.c
> index 73a2078..388f8e10 100644
> --- a/drivers/dma/at_hdmac.c
> +++ b/drivers/dma/at_hdmac.c
> @@ -20,6 +20,7 @@
> #include <linux/slab.h>
> #include <linux/of.h>
> #include <linux/of_device.h>
> +#include <linux/of_platform.h>
> #include <linux/of_dma.h>
>
> #include "at_hdmac_regs.h"
> diff --git a/drivers/dma/stm32-dmamux.c b/drivers/dma/stm32-dmamux.c
> index 12f7637..b704896 100644
> --- a/drivers/dma/stm32-dmamux.c
> +++ b/drivers/dma/stm32-dmamux.c
> @@ -16,6 +16,7 @@
> #include <linux/init.h>
> #include <linux/module.h>
> #include <linux/of_device.h>
> +#include <linux/of_platform.h>
> #include <linux/of_dma.h>
> #include <linux/pm_runtime.h>
> #include <linux/reset.h>
> diff --git a/drivers/dma/ti/dma-crossbar.c b/drivers/dma/ti/dma-crossbar.c
> index 4ba8fa5..2c0fd44 100644
> --- a/drivers/dma/ti/dma-crossbar.c
> +++ b/drivers/dma/ti/dma-crossbar.c
> @@ -10,6 +10,7 @@
> #include <linux/io.h>
> #include <linux/of_address.h>
> #include <linux/of_device.h>
> +#include <linux/of_platform.h>
> #include <linux/of_dma.h>
>
> #define TI_XBAR_DRA7 0
> diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c b/drivers/gpu/drm/msm/adreno/a6xx_gmu.c
> index c4e71ab..f523254 100644
> --- a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c
> +++ b/drivers/gpu/drm/msm/adreno/a6xx_gmu.c
> @@ -6,6 +6,7 @@
> #include <linux/interconnect.h>
> #include <linux/pm_domain.h>
> #include <linux/pm_opp.h>
> +#include <linux/of_platform.h>
> #include <soc/qcom/cmd-db.h>
>
> #include "a6xx_gpu.h"
> diff --git a/drivers/gpu/drm/msm/hdmi/hdmi.c b/drivers/gpu/drm/msm/hdmi/hdmi.c
> index 737453b..5034d40 100644
> --- a/drivers/gpu/drm/msm/hdmi/hdmi.c
> +++ b/drivers/gpu/drm/msm/hdmi/hdmi.c
> @@ -7,6 +7,7 @@
>
> #include <linux/of_irq.h>
> #include <linux/of_gpio.h>
> +#include <linux/of_platform.h>
>
> #include <sound/hdmi-codec.h>
> #include "hdmi.h"
> diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c
> index 29295de..ddc9e85 100644
> --- a/drivers/gpu/drm/msm/msm_drv.c
> +++ b/drivers/gpu/drm/msm/msm_drv.c
> @@ -8,6 +8,7 @@
> #include <linux/dma-mapping.h>
> #include <linux/kthread.h>
> #include <linux/uaccess.h>
> +#include <linux/of_platform.h>
> #include <uapi/linux/sched/types.h>
>
> #include <drm/drm_drv.h>
> diff --git a/drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c b/drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c
> index 6e1270e..d038bae 100644
> --- a/drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c
> +++ b/drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c
> @@ -12,6 +12,7 @@
> #include <linux/mfd/syscon.h>
> #include <linux/module.h>
> #include <linux/of_device.h>
> +#include <linux/of_platform.h>
> #include <linux/phy/phy.h>
> #include <linux/pm_runtime.h>
> #include <linux/regmap.h>
> diff --git a/drivers/gpu/drm/sun4i/sun4i_tcon.c b/drivers/gpu/drm/sun4i/sun4i_tcon.c
> index 624437b..aa35757 100644
> --- a/drivers/gpu/drm/sun4i/sun4i_tcon.c
> +++ b/drivers/gpu/drm/sun4i/sun4i_tcon.c
> @@ -11,6 +11,7 @@
> #include <linux/module.h>
> #include <linux/of_address.h>
> #include <linux/of_device.h>
> +#include <linux/of_platform.h>
> #include <linux/of_irq.h>
> #include <linux/regmap.h>
> #include <linux/reset.h>
> diff --git a/drivers/iio/adc/stm32-adc-core.c b/drivers/iio/adc/stm32-adc-core.c
> index 2df88d2..3dc3453 100644
> --- a/drivers/iio/adc/stm32-adc-core.c
> +++ b/drivers/iio/adc/stm32-adc-core.c
> @@ -17,6 +17,7 @@
> #include <linux/mfd/syscon.h>
> #include <linux/module.h>
> #include <linux/of_device.h>
> +#include <linux/of_platform.h>
> #include <linux/pm_runtime.h>
> #include <linux/regmap.h>
> #include <linux/regulator/consumer.h>
> diff --git a/drivers/iio/adc/stm32-dfsdm-adc.c b/drivers/iio/adc/stm32-dfsdm-adc.c
> index 76a60d9..e83848cb 100644
> --- a/drivers/iio/adc/stm32-dfsdm-adc.c
> +++ b/drivers/iio/adc/stm32-dfsdm-adc.c
> @@ -20,6 +20,7 @@
> #include <linux/interrupt.h>
> #include <linux/module.h>
> #include <linux/of_device.h>
> +#include <linux/of_platform.h>
> #include <linux/platform_device.h>
> #include <linux/regmap.h>
> #include <linux/slab.h>
> diff --git a/drivers/iio/adc/stm32-dfsdm-core.c b/drivers/iio/adc/stm32-dfsdm-core.c
> index 26e2011..f6a53ab 100644
> --- a/drivers/iio/adc/stm32-dfsdm-core.c
> +++ b/drivers/iio/adc/stm32-dfsdm-core.c
> @@ -12,6 +12,7 @@
> #include <linux/interrupt.h>
> #include <linux/module.h>
> #include <linux/of_device.h>
> +#include <linux/of_platform.h>
> #include <linux/pinctrl/consumer.h>
> #include <linux/pm_runtime.h>
> #include <linux/regmap.h>
> diff --git a/drivers/iommu/tegra-smmu.c b/drivers/iommu/tegra-smmu.c
> index 63a147b..3797caa 100644
> --- a/drivers/iommu/tegra-smmu.c
> +++ b/drivers/iommu/tegra-smmu.c
> @@ -10,6 +10,7 @@
> #include <linux/kernel.h>
> #include <linux/of.h>
> #include <linux/of_device.h>
> +#include <linux/of_platform.h>
> #include <linux/platform_device.h>
> #include <linux/slab.h>
> #include <linux/dma-mapping.h>
> diff --git a/drivers/memory/atmel-ebi.c b/drivers/memory/atmel-ebi.c
> index 14386d0..272b1a8 100644
> --- a/drivers/memory/atmel-ebi.c
> +++ b/drivers/memory/atmel-ebi.c
> @@ -13,6 +13,7 @@
> #include <linux/mfd/syscon/atmel-smc.h>
> #include <linux/init.h>
> #include <linux/of_device.h>
> +#include <linux/of_platform.h>
> #include <linux/regmap.h>
> #include <soc/at91/atmel-sfr.h>
>
> diff --git a/drivers/mfd/palmas.c b/drivers/mfd/palmas.c
> index f5b3fa9..cca44bc 100644
> --- a/drivers/mfd/palmas.c
> +++ b/drivers/mfd/palmas.c
> @@ -19,6 +19,7 @@
> #include <linux/mfd/core.h>
> #include <linux/mfd/palmas.h>
> #include <linux/of_device.h>
> +#include <linux/of_platform.h>
>
> static const struct regmap_config palmas_regmap_config[PALMAS_NUM_CLIENTS] = {
> {
> diff --git a/drivers/mfd/ssbi.c b/drivers/mfd/ssbi.c
> index 94f60df..72cd45a 100644
> --- a/drivers/mfd/ssbi.c
> +++ b/drivers/mfd/ssbi.c
> @@ -20,6 +20,7 @@
> #include <linux/module.h>
> #include <linux/of.h>
> #include <linux/of_device.h>
> +#include <linux/of_platform.h>
>
> /* SSBI 2.0 controller registers */
> #define SSBI2_CMD 0x0008
> diff --git a/drivers/mtd/nand/raw/omap2.c b/drivers/mtd/nand/raw/omap2.c
> index ad77c11..d851ec7 100644
> --- a/drivers/mtd/nand/raw/omap2.c
> +++ b/drivers/mtd/nand/raw/omap2.c
> @@ -22,6 +22,7 @@
> #include <linux/slab.h>
> #include <linux/of.h>
> #include <linux/of_device.h>
> +#include <linux/of_platform.h>
>
> #include <linux/mtd/nand_bch.h>
> #include <linux/platform_data/elm.h>
> diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c
> index 58e0511..d704d57 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c
> @@ -12,6 +12,7 @@
> #include <linux/mfd/syscon.h>
> #include <linux/module.h>
> #include <linux/of_device.h>
> +#include <linux/of_platform.h>
> #include <linux/of_mdio.h>
> #include <linux/of_net.h>
> #include <linux/phy.h>
> diff --git a/drivers/net/ethernet/ti/cpsw.c b/drivers/net/ethernet/ti/cpsw.c
> index c2c5bf8..6932945 100644
> --- a/drivers/net/ethernet/ti/cpsw.c
> +++ b/drivers/net/ethernet/ti/cpsw.c
> @@ -28,6 +28,7 @@
> #include <linux/of_mdio.h>
> #include <linux/of_net.h>
> #include <linux/of_device.h>
> +#include <linux/of_platform.h>
> #include <linux/if_vlan.h>
> #include <linux/kmemleak.h>
> #include <linux/sys_soc.h>
> diff --git a/drivers/phy/tegra/xusb.c b/drivers/phy/tegra/xusb.c
> index de4a46f..0eac1b8 100644
> --- a/drivers/phy/tegra/xusb.c
> +++ b/drivers/phy/tegra/xusb.c
> @@ -9,6 +9,7 @@
> #include <linux/module.h>
> #include <linux/of.h>
> #include <linux/of_device.h>
> +#include <linux/of_platform.h>
> #include <linux/phy/phy.h>
> #include <linux/phy/tegra/xusb.h>
> #include <linux/platform_device.h>
> diff --git a/drivers/pinctrl/freescale/pinctrl-imx1-core.c b/drivers/pinctrl/freescale/pinctrl-imx1-core.c
> index c00d002..d1c171e 100644
> --- a/drivers/pinctrl/freescale/pinctrl-imx1-core.c
> +++ b/drivers/pinctrl/freescale/pinctrl-imx1-core.c
> @@ -16,6 +16,7 @@
> #include <linux/io.h>
> #include <linux/of.h>
> #include <linux/of_device.h>
> +#include <linux/of_platform.h>
> #include <linux/pinctrl/machine.h>
> #include <linux/pinctrl/pinconf.h>
> #include <linux/pinctrl/pinctrl.h>
> diff --git a/drivers/pinctrl/nomadik/pinctrl-nomadik.c b/drivers/pinctrl/nomadik/pinctrl-nomadik.c
> index ca7bbe4..44974ac 100644
> --- a/drivers/pinctrl/nomadik/pinctrl-nomadik.c
> +++ b/drivers/pinctrl/nomadik/pinctrl-nomadik.c
> @@ -19,6 +19,7 @@
> #include <linux/interrupt.h>
> #include <linux/slab.h>
> #include <linux/of_device.h>
> +#include <linux/of_platform.h>
> #include <linux/of_address.h>
> #include <linux/bitops.h>
> #include <linux/pinctrl/machine.h>
> diff --git a/drivers/soc/samsung/exynos-pmu.c b/drivers/soc/samsung/exynos-pmu.c
> index 17304fa..25129b0 100644
> --- a/drivers/soc/samsung/exynos-pmu.c
> +++ b/drivers/soc/samsung/exynos-pmu.c
> @@ -8,6 +8,7 @@
> #include <linux/of.h>
> #include <linux/of_address.h>
> #include <linux/of_device.h>
> +#include <linux/of_platform.h>
> #include <linux/mfd/syscon.h>
> #include <linux/platform_device.h>
> #include <linux/delay.h>
> diff --git a/drivers/soc/sunxi/sunxi_sram.c b/drivers/soc/sunxi/sunxi_sram.c
> index 1b0d50f..423cec3 100644
> --- a/drivers/soc/sunxi/sunxi_sram.c
> +++ b/drivers/soc/sunxi/sunxi_sram.c
> @@ -16,6 +16,7 @@
> #include <linux/of.h>
> #include <linux/of_address.h>
> #include <linux/of_device.h>
> +#include <linux/of_platform.h>
> #include <linux/platform_device.h>
> #include <linux/regmap.h>
>
> diff --git a/include/linux/of_device.h b/include/linux/of_device.h
> index 8d31e39..752999b 100644
> --- a/include/linux/of_device.h
> +++ b/include/linux/of_device.h
> @@ -4,8 +4,6 @@
>
> #include <linux/cpu.h>
> #include <linux/platform_device.h>
> -#include <linux/of_platform.h> /* temporary until merge */
> -
> #include <linux/of.h>
> #include <linux/mod_devicetable.h>
>
> diff --git a/lib/genalloc.c b/lib/genalloc.c
> index 7f1244b..08e21eeb 100644
> --- a/lib/genalloc.c
> +++ b/lib/genalloc.c
> @@ -33,6 +33,7 @@
> #include <linux/interrupt.h>
> #include <linux/genalloc.h>
> #include <linux/of_device.h>
> +#include <linux/of_platform.h>
> #include <linux/vmalloc.h>
>
> static inline size_t chunk_size(const struct gen_pool_chunk *chunk)
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 25+ messages in thread* Re: [PATCH v2] of_device: removed #include that caused a recursion in included headers
@ 2020-04-18 15:34 ` Jonathan Cameron
0 siblings, 0 replies; 25+ messages in thread
From: Jonathan Cameron @ 2020-04-18 15:34 UTC (permalink / raw)
To: Hadar Gat
Cc: Jose Abreu, Alexandre Belloni, Heiko Stübner, devicetree,
David Airlie, Michael Turquette, Liviu Dudau, Stefan Agner,
Nicolas Ferre, linux-tegra, Thierry Reding, linux-mtd,
Miquel Raynal, sparclinux, netdev, Kishon Vijay Abraham I,
Lee Jones, linux-clk, Vignesh Raghavendra, linux-samsung-soc,
Frank Rowand, linux-rockchip, Richard Weinberger, Vinod Koul,
Krzysztof Kozlowski, Jonathan Hunter, Tony Lindgren,
Ludovic Desroches, Andy Gross, Linus Walleij, freedreno,
Alexandre Torgue, linux-omap, iommu, linux-arm-msm, Sascha Hauer,
Maxime Ripard, Gilad Ben-Yossef, Rob Herring, linux-mediatek,
dri-devel, Fabio Estevam, Matthias Brugger, Daniel Vetter,
Chen-Yu Tsai, Sean Paul, linux-arm-kernel, Ofir Drang,
Dong Aisheng, linux-gpio, Stephen Boyd, Greg Kroah-Hartman,
Giuseppe Cavallaro, linux-stm32, Sandy Huang, linux-iio,
linux-kernel, JC Kuo, Bjorn Andersson, Kukjin Kim,
Maxime Coquelin, Sudeep Holla, dmaengine, Shawn Guo,
David S. Miller
On Thu, 16 Apr 2020 12:49:03 +0300
Hadar Gat <hadar.gat@arm.com> wrote:
> Both of_platform.h and of_device.h were included each other.
> In of_device.h, removed unneeded #include to of_platform.h
> and added include to of_platform.h in the files that needs it.
>
> Signed-off-by: Hadar Gat <hadar.gat@arm.com>
Hmm. I guess the chances of this causing merge problems are fairly low so
perhaps not worth doing additions of headers via individual subsystems and
actually dropping the header include after another cycle.
So on that basis
Acked-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> #for-iio
> ---
> v2: add include to of_platform.h in more files. (reported due other builds)
>
> arch/sparc/mm/io-unit.c | 1 +
> arch/sparc/mm/iommu.c | 1 +
> drivers/base/platform.c | 1 +
> drivers/bus/imx-weim.c | 1 +
> drivers/bus/vexpress-config.c | 1 +
> drivers/clk/mediatek/clk-mt7622-aud.c | 1 +
> drivers/dma/at_hdmac.c | 1 +
> drivers/dma/stm32-dmamux.c | 1 +
> drivers/dma/ti/dma-crossbar.c | 1 +
> drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 1 +
> drivers/gpu/drm/msm/hdmi/hdmi.c | 1 +
> drivers/gpu/drm/msm/msm_drv.c | 1 +
> drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c | 1 +
> drivers/gpu/drm/sun4i/sun4i_tcon.c | 1 +
> drivers/iio/adc/stm32-adc-core.c | 1 +
> drivers/iio/adc/stm32-dfsdm-adc.c | 1 +
> drivers/iio/adc/stm32-dfsdm-core.c | 1 +
> drivers/iommu/tegra-smmu.c | 1 +
> drivers/memory/atmel-ebi.c | 1 +
> drivers/mfd/palmas.c | 1 +
> drivers/mfd/ssbi.c | 1 +
> drivers/mtd/nand/raw/omap2.c | 1 +
> drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c | 1 +
> drivers/net/ethernet/ti/cpsw.c | 1 +
> drivers/phy/tegra/xusb.c | 1 +
> drivers/pinctrl/freescale/pinctrl-imx1-core.c | 1 +
> drivers/pinctrl/nomadik/pinctrl-nomadik.c | 1 +
> drivers/soc/samsung/exynos-pmu.c | 1 +
> drivers/soc/sunxi/sunxi_sram.c | 1 +
> include/linux/of_device.h | 2 --
> lib/genalloc.c | 1 +
> 31 files changed, 30 insertions(+), 2 deletions(-)
>
> diff --git a/arch/sparc/mm/io-unit.c b/arch/sparc/mm/io-unit.c
> index 289276b..5638399 100644
> --- a/arch/sparc/mm/io-unit.c
> +++ b/arch/sparc/mm/io-unit.c
> @@ -15,6 +15,7 @@
> #include <linux/dma-mapping.h>
> #include <linux/of.h>
> #include <linux/of_device.h>
> +#include <linux/of_platform.h>
>
> #include <asm/pgalloc.h>
> #include <asm/pgtable.h>
> diff --git a/arch/sparc/mm/iommu.c b/arch/sparc/mm/iommu.c
> index b00dde1..9cbb2e7 100644
> --- a/arch/sparc/mm/iommu.c
> +++ b/arch/sparc/mm/iommu.c
> @@ -16,6 +16,7 @@
> #include <linux/dma-mapping.h>
> #include <linux/of.h>
> #include <linux/of_device.h>
> +#include <linux/of_platform.h>
>
> #include <asm/pgalloc.h>
> #include <asm/pgtable.h>
> diff --git a/drivers/base/platform.c b/drivers/base/platform.c
> index 5255550..f549274b 100644
> --- a/drivers/base/platform.c
> +++ b/drivers/base/platform.c
> @@ -12,6 +12,7 @@
> #include <linux/string.h>
> #include <linux/platform_device.h>
> #include <linux/of_device.h>
> +#include <linux/of_platform.h>
> #include <linux/of_irq.h>
> #include <linux/module.h>
> #include <linux/init.h>
> diff --git a/drivers/bus/imx-weim.c b/drivers/bus/imx-weim.c
> index 28bb65a..8c786da 100644
> --- a/drivers/bus/imx-weim.c
> +++ b/drivers/bus/imx-weim.c
> @@ -11,6 +11,7 @@
> #include <linux/clk.h>
> #include <linux/io.h>
> #include <linux/of_device.h>
> +#include <linux/of_platform.h>
> #include <linux/mfd/syscon.h>
> #include <linux/mfd/syscon/imx6q-iomuxc-gpr.h>
> #include <linux/regmap.h>
> diff --git a/drivers/bus/vexpress-config.c b/drivers/bus/vexpress-config.c
> index ff70575..12b8b0b 100644
> --- a/drivers/bus/vexpress-config.c
> +++ b/drivers/bus/vexpress-config.c
> @@ -8,6 +8,7 @@
> #include <linux/init.h>
> #include <linux/of.h>
> #include <linux/of_device.h>
> +#include <linux/of_platform.h>
> #include <linux/vexpress.h>
>
>
> diff --git a/drivers/clk/mediatek/clk-mt7622-aud.c b/drivers/clk/mediatek/clk-mt7622-aud.c
> index 2bd4295..8cbb68f 100644
> --- a/drivers/clk/mediatek/clk-mt7622-aud.c
> +++ b/drivers/clk/mediatek/clk-mt7622-aud.c
> @@ -9,6 +9,7 @@
> #include <linux/of.h>
> #include <linux/of_address.h>
> #include <linux/of_device.h>
> +#include <linux/of_platform.h>
> #include <linux/platform_device.h>
>
> #include "clk-mtk.h"
> diff --git a/drivers/dma/at_hdmac.c b/drivers/dma/at_hdmac.c
> index 73a2078..388f8e10 100644
> --- a/drivers/dma/at_hdmac.c
> +++ b/drivers/dma/at_hdmac.c
> @@ -20,6 +20,7 @@
> #include <linux/slab.h>
> #include <linux/of.h>
> #include <linux/of_device.h>
> +#include <linux/of_platform.h>
> #include <linux/of_dma.h>
>
> #include "at_hdmac_regs.h"
> diff --git a/drivers/dma/stm32-dmamux.c b/drivers/dma/stm32-dmamux.c
> index 12f7637..b704896 100644
> --- a/drivers/dma/stm32-dmamux.c
> +++ b/drivers/dma/stm32-dmamux.c
> @@ -16,6 +16,7 @@
> #include <linux/init.h>
> #include <linux/module.h>
> #include <linux/of_device.h>
> +#include <linux/of_platform.h>
> #include <linux/of_dma.h>
> #include <linux/pm_runtime.h>
> #include <linux/reset.h>
> diff --git a/drivers/dma/ti/dma-crossbar.c b/drivers/dma/ti/dma-crossbar.c
> index 4ba8fa5..2c0fd44 100644
> --- a/drivers/dma/ti/dma-crossbar.c
> +++ b/drivers/dma/ti/dma-crossbar.c
> @@ -10,6 +10,7 @@
> #include <linux/io.h>
> #include <linux/of_address.h>
> #include <linux/of_device.h>
> +#include <linux/of_platform.h>
> #include <linux/of_dma.h>
>
> #define TI_XBAR_DRA7 0
> diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c b/drivers/gpu/drm/msm/adreno/a6xx_gmu.c
> index c4e71ab..f523254 100644
> --- a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c
> +++ b/drivers/gpu/drm/msm/adreno/a6xx_gmu.c
> @@ -6,6 +6,7 @@
> #include <linux/interconnect.h>
> #include <linux/pm_domain.h>
> #include <linux/pm_opp.h>
> +#include <linux/of_platform.h>
> #include <soc/qcom/cmd-db.h>
>
> #include "a6xx_gpu.h"
> diff --git a/drivers/gpu/drm/msm/hdmi/hdmi.c b/drivers/gpu/drm/msm/hdmi/hdmi.c
> index 737453b..5034d40 100644
> --- a/drivers/gpu/drm/msm/hdmi/hdmi.c
> +++ b/drivers/gpu/drm/msm/hdmi/hdmi.c
> @@ -7,6 +7,7 @@
>
> #include <linux/of_irq.h>
> #include <linux/of_gpio.h>
> +#include <linux/of_platform.h>
>
> #include <sound/hdmi-codec.h>
> #include "hdmi.h"
> diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c
> index 29295de..ddc9e85 100644
> --- a/drivers/gpu/drm/msm/msm_drv.c
> +++ b/drivers/gpu/drm/msm/msm_drv.c
> @@ -8,6 +8,7 @@
> #include <linux/dma-mapping.h>
> #include <linux/kthread.h>
> #include <linux/uaccess.h>
> +#include <linux/of_platform.h>
> #include <uapi/linux/sched/types.h>
>
> #include <drm/drm_drv.h>
> diff --git a/drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c b/drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c
> index 6e1270e..d038bae 100644
> --- a/drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c
> +++ b/drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c
> @@ -12,6 +12,7 @@
> #include <linux/mfd/syscon.h>
> #include <linux/module.h>
> #include <linux/of_device.h>
> +#include <linux/of_platform.h>
> #include <linux/phy/phy.h>
> #include <linux/pm_runtime.h>
> #include <linux/regmap.h>
> diff --git a/drivers/gpu/drm/sun4i/sun4i_tcon.c b/drivers/gpu/drm/sun4i/sun4i_tcon.c
> index 624437b..aa35757 100644
> --- a/drivers/gpu/drm/sun4i/sun4i_tcon.c
> +++ b/drivers/gpu/drm/sun4i/sun4i_tcon.c
> @@ -11,6 +11,7 @@
> #include <linux/module.h>
> #include <linux/of_address.h>
> #include <linux/of_device.h>
> +#include <linux/of_platform.h>
> #include <linux/of_irq.h>
> #include <linux/regmap.h>
> #include <linux/reset.h>
> diff --git a/drivers/iio/adc/stm32-adc-core.c b/drivers/iio/adc/stm32-adc-core.c
> index 2df88d2..3dc3453 100644
> --- a/drivers/iio/adc/stm32-adc-core.c
> +++ b/drivers/iio/adc/stm32-adc-core.c
> @@ -17,6 +17,7 @@
> #include <linux/mfd/syscon.h>
> #include <linux/module.h>
> #include <linux/of_device.h>
> +#include <linux/of_platform.h>
> #include <linux/pm_runtime.h>
> #include <linux/regmap.h>
> #include <linux/regulator/consumer.h>
> diff --git a/drivers/iio/adc/stm32-dfsdm-adc.c b/drivers/iio/adc/stm32-dfsdm-adc.c
> index 76a60d9..e83848cb 100644
> --- a/drivers/iio/adc/stm32-dfsdm-adc.c
> +++ b/drivers/iio/adc/stm32-dfsdm-adc.c
> @@ -20,6 +20,7 @@
> #include <linux/interrupt.h>
> #include <linux/module.h>
> #include <linux/of_device.h>
> +#include <linux/of_platform.h>
> #include <linux/platform_device.h>
> #include <linux/regmap.h>
> #include <linux/slab.h>
> diff --git a/drivers/iio/adc/stm32-dfsdm-core.c b/drivers/iio/adc/stm32-dfsdm-core.c
> index 26e2011..f6a53ab 100644
> --- a/drivers/iio/adc/stm32-dfsdm-core.c
> +++ b/drivers/iio/adc/stm32-dfsdm-core.c
> @@ -12,6 +12,7 @@
> #include <linux/interrupt.h>
> #include <linux/module.h>
> #include <linux/of_device.h>
> +#include <linux/of_platform.h>
> #include <linux/pinctrl/consumer.h>
> #include <linux/pm_runtime.h>
> #include <linux/regmap.h>
> diff --git a/drivers/iommu/tegra-smmu.c b/drivers/iommu/tegra-smmu.c
> index 63a147b..3797caa 100644
> --- a/drivers/iommu/tegra-smmu.c
> +++ b/drivers/iommu/tegra-smmu.c
> @@ -10,6 +10,7 @@
> #include <linux/kernel.h>
> #include <linux/of.h>
> #include <linux/of_device.h>
> +#include <linux/of_platform.h>
> #include <linux/platform_device.h>
> #include <linux/slab.h>
> #include <linux/dma-mapping.h>
> diff --git a/drivers/memory/atmel-ebi.c b/drivers/memory/atmel-ebi.c
> index 14386d0..272b1a8 100644
> --- a/drivers/memory/atmel-ebi.c
> +++ b/drivers/memory/atmel-ebi.c
> @@ -13,6 +13,7 @@
> #include <linux/mfd/syscon/atmel-smc.h>
> #include <linux/init.h>
> #include <linux/of_device.h>
> +#include <linux/of_platform.h>
> #include <linux/regmap.h>
> #include <soc/at91/atmel-sfr.h>
>
> diff --git a/drivers/mfd/palmas.c b/drivers/mfd/palmas.c
> index f5b3fa9..cca44bc 100644
> --- a/drivers/mfd/palmas.c
> +++ b/drivers/mfd/palmas.c
> @@ -19,6 +19,7 @@
> #include <linux/mfd/core.h>
> #include <linux/mfd/palmas.h>
> #include <linux/of_device.h>
> +#include <linux/of_platform.h>
>
> static const struct regmap_config palmas_regmap_config[PALMAS_NUM_CLIENTS] = {
> {
> diff --git a/drivers/mfd/ssbi.c b/drivers/mfd/ssbi.c
> index 94f60df..72cd45a 100644
> --- a/drivers/mfd/ssbi.c
> +++ b/drivers/mfd/ssbi.c
> @@ -20,6 +20,7 @@
> #include <linux/module.h>
> #include <linux/of.h>
> #include <linux/of_device.h>
> +#include <linux/of_platform.h>
>
> /* SSBI 2.0 controller registers */
> #define SSBI2_CMD 0x0008
> diff --git a/drivers/mtd/nand/raw/omap2.c b/drivers/mtd/nand/raw/omap2.c
> index ad77c11..d851ec7 100644
> --- a/drivers/mtd/nand/raw/omap2.c
> +++ b/drivers/mtd/nand/raw/omap2.c
> @@ -22,6 +22,7 @@
> #include <linux/slab.h>
> #include <linux/of.h>
> #include <linux/of_device.h>
> +#include <linux/of_platform.h>
>
> #include <linux/mtd/nand_bch.h>
> #include <linux/platform_data/elm.h>
> diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c
> index 58e0511..d704d57 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c
> @@ -12,6 +12,7 @@
> #include <linux/mfd/syscon.h>
> #include <linux/module.h>
> #include <linux/of_device.h>
> +#include <linux/of_platform.h>
> #include <linux/of_mdio.h>
> #include <linux/of_net.h>
> #include <linux/phy.h>
> diff --git a/drivers/net/ethernet/ti/cpsw.c b/drivers/net/ethernet/ti/cpsw.c
> index c2c5bf8..6932945 100644
> --- a/drivers/net/ethernet/ti/cpsw.c
> +++ b/drivers/net/ethernet/ti/cpsw.c
> @@ -28,6 +28,7 @@
> #include <linux/of_mdio.h>
> #include <linux/of_net.h>
> #include <linux/of_device.h>
> +#include <linux/of_platform.h>
> #include <linux/if_vlan.h>
> #include <linux/kmemleak.h>
> #include <linux/sys_soc.h>
> diff --git a/drivers/phy/tegra/xusb.c b/drivers/phy/tegra/xusb.c
> index de4a46f..0eac1b8 100644
> --- a/drivers/phy/tegra/xusb.c
> +++ b/drivers/phy/tegra/xusb.c
> @@ -9,6 +9,7 @@
> #include <linux/module.h>
> #include <linux/of.h>
> #include <linux/of_device.h>
> +#include <linux/of_platform.h>
> #include <linux/phy/phy.h>
> #include <linux/phy/tegra/xusb.h>
> #include <linux/platform_device.h>
> diff --git a/drivers/pinctrl/freescale/pinctrl-imx1-core.c b/drivers/pinctrl/freescale/pinctrl-imx1-core.c
> index c00d002..d1c171e 100644
> --- a/drivers/pinctrl/freescale/pinctrl-imx1-core.c
> +++ b/drivers/pinctrl/freescale/pinctrl-imx1-core.c
> @@ -16,6 +16,7 @@
> #include <linux/io.h>
> #include <linux/of.h>
> #include <linux/of_device.h>
> +#include <linux/of_platform.h>
> #include <linux/pinctrl/machine.h>
> #include <linux/pinctrl/pinconf.h>
> #include <linux/pinctrl/pinctrl.h>
> diff --git a/drivers/pinctrl/nomadik/pinctrl-nomadik.c b/drivers/pinctrl/nomadik/pinctrl-nomadik.c
> index ca7bbe4..44974ac 100644
> --- a/drivers/pinctrl/nomadik/pinctrl-nomadik.c
> +++ b/drivers/pinctrl/nomadik/pinctrl-nomadik.c
> @@ -19,6 +19,7 @@
> #include <linux/interrupt.h>
> #include <linux/slab.h>
> #include <linux/of_device.h>
> +#include <linux/of_platform.h>
> #include <linux/of_address.h>
> #include <linux/bitops.h>
> #include <linux/pinctrl/machine.h>
> diff --git a/drivers/soc/samsung/exynos-pmu.c b/drivers/soc/samsung/exynos-pmu.c
> index 17304fa..25129b0 100644
> --- a/drivers/soc/samsung/exynos-pmu.c
> +++ b/drivers/soc/samsung/exynos-pmu.c
> @@ -8,6 +8,7 @@
> #include <linux/of.h>
> #include <linux/of_address.h>
> #include <linux/of_device.h>
> +#include <linux/of_platform.h>
> #include <linux/mfd/syscon.h>
> #include <linux/platform_device.h>
> #include <linux/delay.h>
> diff --git a/drivers/soc/sunxi/sunxi_sram.c b/drivers/soc/sunxi/sunxi_sram.c
> index 1b0d50f..423cec3 100644
> --- a/drivers/soc/sunxi/sunxi_sram.c
> +++ b/drivers/soc/sunxi/sunxi_sram.c
> @@ -16,6 +16,7 @@
> #include <linux/of.h>
> #include <linux/of_address.h>
> #include <linux/of_device.h>
> +#include <linux/of_platform.h>
> #include <linux/platform_device.h>
> #include <linux/regmap.h>
>
> diff --git a/include/linux/of_device.h b/include/linux/of_device.h
> index 8d31e39..752999b 100644
> --- a/include/linux/of_device.h
> +++ b/include/linux/of_device.h
> @@ -4,8 +4,6 @@
>
> #include <linux/cpu.h>
> #include <linux/platform_device.h>
> -#include <linux/of_platform.h> /* temporary until merge */
> -
> #include <linux/of.h>
> #include <linux/mod_devicetable.h>
>
> diff --git a/lib/genalloc.c b/lib/genalloc.c
> index 7f1244b..08e21eeb 100644
> --- a/lib/genalloc.c
> +++ b/lib/genalloc.c
> @@ -33,6 +33,7 @@
> #include <linux/interrupt.h>
> #include <linux/genalloc.h>
> #include <linux/of_device.h>
> +#include <linux/of_platform.h>
> #include <linux/vmalloc.h>
>
> static inline size_t chunk_size(const struct gen_pool_chunk *chunk)
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
^ permalink raw reply [flat|nested] 25+ messages in thread* Re: [PATCH v2] of_device: removed #include that caused a recursion in included headers
@ 2020-04-18 15:34 ` Jonathan Cameron
0 siblings, 0 replies; 25+ messages in thread
From: Jonathan Cameron @ 2020-04-18 15:34 UTC (permalink / raw)
To: Hadar Gat
Cc: Jose Abreu, Alexandre Belloni, Heiko Stübner, devicetree,
David Airlie, Michael Turquette, Liviu Dudau, Stefan Agner,
Nicolas Ferre, linux-tegra, Thierry Reding, linux-mtd,
Miquel Raynal, sparclinux, netdev, Kishon Vijay Abraham I,
Lee Jones, linux-clk, Vignesh Raghavendra, linux-samsung-soc,
Lorenzo Pieralisi, Frank Rowand, linux-rockchip,
Richard Weinberger, Joerg Roedel, Vinod Koul,
Krzysztof Kozlowski, Jonathan Hunter, Tony Lindgren,
Ludovic Desroches, Andy Gross, Linus Walleij, freedreno,
Alexandre Torgue, linux-omap, iommu, linux-arm-msm, Sascha Hauer,
Maxime Ripard, Gilad Ben-Yossef, Rob Herring, linux-mediatek,
dri-devel, Fabio Estevam, Matthias Brugger, Daniel Vetter,
Chen-Yu Tsai, Sean Paul, linux-arm-kernel, Ofir Drang,
Dong Aisheng, linux-gpio, Stephen Boyd, Greg Kroah-Hartman,
Giuseppe Cavallaro, linux-stm32, Sandy Huang, linux-iio,
linux-kernel, JC Kuo, Rob Clark, Bjorn Andersson, Kukjin Kim,
Maxime Coquelin, Sudeep Holla, dmaengine, Shawn Guo,
David S. Miller
On Thu, 16 Apr 2020 12:49:03 +0300
Hadar Gat <hadar.gat@arm.com> wrote:
> Both of_platform.h and of_device.h were included each other.
> In of_device.h, removed unneeded #include to of_platform.h
> and added include to of_platform.h in the files that needs it.
>
> Signed-off-by: Hadar Gat <hadar.gat@arm.com>
Hmm. I guess the chances of this causing merge problems are fairly low so
perhaps not worth doing additions of headers via individual subsystems and
actually dropping the header include after another cycle.
So on that basis
Acked-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> #for-iio
> ---
> v2: add include to of_platform.h in more files. (reported due other builds)
>
> arch/sparc/mm/io-unit.c | 1 +
> arch/sparc/mm/iommu.c | 1 +
> drivers/base/platform.c | 1 +
> drivers/bus/imx-weim.c | 1 +
> drivers/bus/vexpress-config.c | 1 +
> drivers/clk/mediatek/clk-mt7622-aud.c | 1 +
> drivers/dma/at_hdmac.c | 1 +
> drivers/dma/stm32-dmamux.c | 1 +
> drivers/dma/ti/dma-crossbar.c | 1 +
> drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 1 +
> drivers/gpu/drm/msm/hdmi/hdmi.c | 1 +
> drivers/gpu/drm/msm/msm_drv.c | 1 +
> drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c | 1 +
> drivers/gpu/drm/sun4i/sun4i_tcon.c | 1 +
> drivers/iio/adc/stm32-adc-core.c | 1 +
> drivers/iio/adc/stm32-dfsdm-adc.c | 1 +
> drivers/iio/adc/stm32-dfsdm-core.c | 1 +
> drivers/iommu/tegra-smmu.c | 1 +
> drivers/memory/atmel-ebi.c | 1 +
> drivers/mfd/palmas.c | 1 +
> drivers/mfd/ssbi.c | 1 +
> drivers/mtd/nand/raw/omap2.c | 1 +
> drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c | 1 +
> drivers/net/ethernet/ti/cpsw.c | 1 +
> drivers/phy/tegra/xusb.c | 1 +
> drivers/pinctrl/freescale/pinctrl-imx1-core.c | 1 +
> drivers/pinctrl/nomadik/pinctrl-nomadik.c | 1 +
> drivers/soc/samsung/exynos-pmu.c | 1 +
> drivers/soc/sunxi/sunxi_sram.c | 1 +
> include/linux/of_device.h | 2 --
> lib/genalloc.c | 1 +
> 31 files changed, 30 insertions(+), 2 deletions(-)
>
> diff --git a/arch/sparc/mm/io-unit.c b/arch/sparc/mm/io-unit.c
> index 289276b..5638399 100644
> --- a/arch/sparc/mm/io-unit.c
> +++ b/arch/sparc/mm/io-unit.c
> @@ -15,6 +15,7 @@
> #include <linux/dma-mapping.h>
> #include <linux/of.h>
> #include <linux/of_device.h>
> +#include <linux/of_platform.h>
>
> #include <asm/pgalloc.h>
> #include <asm/pgtable.h>
> diff --git a/arch/sparc/mm/iommu.c b/arch/sparc/mm/iommu.c
> index b00dde1..9cbb2e7 100644
> --- a/arch/sparc/mm/iommu.c
> +++ b/arch/sparc/mm/iommu.c
> @@ -16,6 +16,7 @@
> #include <linux/dma-mapping.h>
> #include <linux/of.h>
> #include <linux/of_device.h>
> +#include <linux/of_platform.h>
>
> #include <asm/pgalloc.h>
> #include <asm/pgtable.h>
> diff --git a/drivers/base/platform.c b/drivers/base/platform.c
> index 5255550..f549274b 100644
> --- a/drivers/base/platform.c
> +++ b/drivers/base/platform.c
> @@ -12,6 +12,7 @@
> #include <linux/string.h>
> #include <linux/platform_device.h>
> #include <linux/of_device.h>
> +#include <linux/of_platform.h>
> #include <linux/of_irq.h>
> #include <linux/module.h>
> #include <linux/init.h>
> diff --git a/drivers/bus/imx-weim.c b/drivers/bus/imx-weim.c
> index 28bb65a..8c786da 100644
> --- a/drivers/bus/imx-weim.c
> +++ b/drivers/bus/imx-weim.c
> @@ -11,6 +11,7 @@
> #include <linux/clk.h>
> #include <linux/io.h>
> #include <linux/of_device.h>
> +#include <linux/of_platform.h>
> #include <linux/mfd/syscon.h>
> #include <linux/mfd/syscon/imx6q-iomuxc-gpr.h>
> #include <linux/regmap.h>
> diff --git a/drivers/bus/vexpress-config.c b/drivers/bus/vexpress-config.c
> index ff70575..12b8b0b 100644
> --- a/drivers/bus/vexpress-config.c
> +++ b/drivers/bus/vexpress-config.c
> @@ -8,6 +8,7 @@
> #include <linux/init.h>
> #include <linux/of.h>
> #include <linux/of_device.h>
> +#include <linux/of_platform.h>
> #include <linux/vexpress.h>
>
>
> diff --git a/drivers/clk/mediatek/clk-mt7622-aud.c b/drivers/clk/mediatek/clk-mt7622-aud.c
> index 2bd4295..8cbb68f 100644
> --- a/drivers/clk/mediatek/clk-mt7622-aud.c
> +++ b/drivers/clk/mediatek/clk-mt7622-aud.c
> @@ -9,6 +9,7 @@
> #include <linux/of.h>
> #include <linux/of_address.h>
> #include <linux/of_device.h>
> +#include <linux/of_platform.h>
> #include <linux/platform_device.h>
>
> #include "clk-mtk.h"
> diff --git a/drivers/dma/at_hdmac.c b/drivers/dma/at_hdmac.c
> index 73a2078..388f8e10 100644
> --- a/drivers/dma/at_hdmac.c
> +++ b/drivers/dma/at_hdmac.c
> @@ -20,6 +20,7 @@
> #include <linux/slab.h>
> #include <linux/of.h>
> #include <linux/of_device.h>
> +#include <linux/of_platform.h>
> #include <linux/of_dma.h>
>
> #include "at_hdmac_regs.h"
> diff --git a/drivers/dma/stm32-dmamux.c b/drivers/dma/stm32-dmamux.c
> index 12f7637..b704896 100644
> --- a/drivers/dma/stm32-dmamux.c
> +++ b/drivers/dma/stm32-dmamux.c
> @@ -16,6 +16,7 @@
> #include <linux/init.h>
> #include <linux/module.h>
> #include <linux/of_device.h>
> +#include <linux/of_platform.h>
> #include <linux/of_dma.h>
> #include <linux/pm_runtime.h>
> #include <linux/reset.h>
> diff --git a/drivers/dma/ti/dma-crossbar.c b/drivers/dma/ti/dma-crossbar.c
> index 4ba8fa5..2c0fd44 100644
> --- a/drivers/dma/ti/dma-crossbar.c
> +++ b/drivers/dma/ti/dma-crossbar.c
> @@ -10,6 +10,7 @@
> #include <linux/io.h>
> #include <linux/of_address.h>
> #include <linux/of_device.h>
> +#include <linux/of_platform.h>
> #include <linux/of_dma.h>
>
> #define TI_XBAR_DRA7 0
> diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c b/drivers/gpu/drm/msm/adreno/a6xx_gmu.c
> index c4e71ab..f523254 100644
> --- a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c
> +++ b/drivers/gpu/drm/msm/adreno/a6xx_gmu.c
> @@ -6,6 +6,7 @@
> #include <linux/interconnect.h>
> #include <linux/pm_domain.h>
> #include <linux/pm_opp.h>
> +#include <linux/of_platform.h>
> #include <soc/qcom/cmd-db.h>
>
> #include "a6xx_gpu.h"
> diff --git a/drivers/gpu/drm/msm/hdmi/hdmi.c b/drivers/gpu/drm/msm/hdmi/hdmi.c
> index 737453b..5034d40 100644
> --- a/drivers/gpu/drm/msm/hdmi/hdmi.c
> +++ b/drivers/gpu/drm/msm/hdmi/hdmi.c
> @@ -7,6 +7,7 @@
>
> #include <linux/of_irq.h>
> #include <linux/of_gpio.h>
> +#include <linux/of_platform.h>
>
> #include <sound/hdmi-codec.h>
> #include "hdmi.h"
> diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c
> index 29295de..ddc9e85 100644
> --- a/drivers/gpu/drm/msm/msm_drv.c
> +++ b/drivers/gpu/drm/msm/msm_drv.c
> @@ -8,6 +8,7 @@
> #include <linux/dma-mapping.h>
> #include <linux/kthread.h>
> #include <linux/uaccess.h>
> +#include <linux/of_platform.h>
> #include <uapi/linux/sched/types.h>
>
> #include <drm/drm_drv.h>
> diff --git a/drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c b/drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c
> index 6e1270e..d038bae 100644
> --- a/drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c
> +++ b/drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c
> @@ -12,6 +12,7 @@
> #include <linux/mfd/syscon.h>
> #include <linux/module.h>
> #include <linux/of_device.h>
> +#include <linux/of_platform.h>
> #include <linux/phy/phy.h>
> #include <linux/pm_runtime.h>
> #include <linux/regmap.h>
> diff --git a/drivers/gpu/drm/sun4i/sun4i_tcon.c b/drivers/gpu/drm/sun4i/sun4i_tcon.c
> index 624437b..aa35757 100644
> --- a/drivers/gpu/drm/sun4i/sun4i_tcon.c
> +++ b/drivers/gpu/drm/sun4i/sun4i_tcon.c
> @@ -11,6 +11,7 @@
> #include <linux/module.h>
> #include <linux/of_address.h>
> #include <linux/of_device.h>
> +#include <linux/of_platform.h>
> #include <linux/of_irq.h>
> #include <linux/regmap.h>
> #include <linux/reset.h>
> diff --git a/drivers/iio/adc/stm32-adc-core.c b/drivers/iio/adc/stm32-adc-core.c
> index 2df88d2..3dc3453 100644
> --- a/drivers/iio/adc/stm32-adc-core.c
> +++ b/drivers/iio/adc/stm32-adc-core.c
> @@ -17,6 +17,7 @@
> #include <linux/mfd/syscon.h>
> #include <linux/module.h>
> #include <linux/of_device.h>
> +#include <linux/of_platform.h>
> #include <linux/pm_runtime.h>
> #include <linux/regmap.h>
> #include <linux/regulator/consumer.h>
> diff --git a/drivers/iio/adc/stm32-dfsdm-adc.c b/drivers/iio/adc/stm32-dfsdm-adc.c
> index 76a60d9..e83848cb 100644
> --- a/drivers/iio/adc/stm32-dfsdm-adc.c
> +++ b/drivers/iio/adc/stm32-dfsdm-adc.c
> @@ -20,6 +20,7 @@
> #include <linux/interrupt.h>
> #include <linux/module.h>
> #include <linux/of_device.h>
> +#include <linux/of_platform.h>
> #include <linux/platform_device.h>
> #include <linux/regmap.h>
> #include <linux/slab.h>
> diff --git a/drivers/iio/adc/stm32-dfsdm-core.c b/drivers/iio/adc/stm32-dfsdm-core.c
> index 26e2011..f6a53ab 100644
> --- a/drivers/iio/adc/stm32-dfsdm-core.c
> +++ b/drivers/iio/adc/stm32-dfsdm-core.c
> @@ -12,6 +12,7 @@
> #include <linux/interrupt.h>
> #include <linux/module.h>
> #include <linux/of_device.h>
> +#include <linux/of_platform.h>
> #include <linux/pinctrl/consumer.h>
> #include <linux/pm_runtime.h>
> #include <linux/regmap.h>
> diff --git a/drivers/iommu/tegra-smmu.c b/drivers/iommu/tegra-smmu.c
> index 63a147b..3797caa 100644
> --- a/drivers/iommu/tegra-smmu.c
> +++ b/drivers/iommu/tegra-smmu.c
> @@ -10,6 +10,7 @@
> #include <linux/kernel.h>
> #include <linux/of.h>
> #include <linux/of_device.h>
> +#include <linux/of_platform.h>
> #include <linux/platform_device.h>
> #include <linux/slab.h>
> #include <linux/dma-mapping.h>
> diff --git a/drivers/memory/atmel-ebi.c b/drivers/memory/atmel-ebi.c
> index 14386d0..272b1a8 100644
> --- a/drivers/memory/atmel-ebi.c
> +++ b/drivers/memory/atmel-ebi.c
> @@ -13,6 +13,7 @@
> #include <linux/mfd/syscon/atmel-smc.h>
> #include <linux/init.h>
> #include <linux/of_device.h>
> +#include <linux/of_platform.h>
> #include <linux/regmap.h>
> #include <soc/at91/atmel-sfr.h>
>
> diff --git a/drivers/mfd/palmas.c b/drivers/mfd/palmas.c
> index f5b3fa9..cca44bc 100644
> --- a/drivers/mfd/palmas.c
> +++ b/drivers/mfd/palmas.c
> @@ -19,6 +19,7 @@
> #include <linux/mfd/core.h>
> #include <linux/mfd/palmas.h>
> #include <linux/of_device.h>
> +#include <linux/of_platform.h>
>
> static const struct regmap_config palmas_regmap_config[PALMAS_NUM_CLIENTS] = {
> {
> diff --git a/drivers/mfd/ssbi.c b/drivers/mfd/ssbi.c
> index 94f60df..72cd45a 100644
> --- a/drivers/mfd/ssbi.c
> +++ b/drivers/mfd/ssbi.c
> @@ -20,6 +20,7 @@
> #include <linux/module.h>
> #include <linux/of.h>
> #include <linux/of_device.h>
> +#include <linux/of_platform.h>
>
> /* SSBI 2.0 controller registers */
> #define SSBI2_CMD 0x0008
> diff --git a/drivers/mtd/nand/raw/omap2.c b/drivers/mtd/nand/raw/omap2.c
> index ad77c11..d851ec7 100644
> --- a/drivers/mtd/nand/raw/omap2.c
> +++ b/drivers/mtd/nand/raw/omap2.c
> @@ -22,6 +22,7 @@
> #include <linux/slab.h>
> #include <linux/of.h>
> #include <linux/of_device.h>
> +#include <linux/of_platform.h>
>
> #include <linux/mtd/nand_bch.h>
> #include <linux/platform_data/elm.h>
> diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c
> index 58e0511..d704d57 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c
> @@ -12,6 +12,7 @@
> #include <linux/mfd/syscon.h>
> #include <linux/module.h>
> #include <linux/of_device.h>
> +#include <linux/of_platform.h>
> #include <linux/of_mdio.h>
> #include <linux/of_net.h>
> #include <linux/phy.h>
> diff --git a/drivers/net/ethernet/ti/cpsw.c b/drivers/net/ethernet/ti/cpsw.c
> index c2c5bf8..6932945 100644
> --- a/drivers/net/ethernet/ti/cpsw.c
> +++ b/drivers/net/ethernet/ti/cpsw.c
> @@ -28,6 +28,7 @@
> #include <linux/of_mdio.h>
> #include <linux/of_net.h>
> #include <linux/of_device.h>
> +#include <linux/of_platform.h>
> #include <linux/if_vlan.h>
> #include <linux/kmemleak.h>
> #include <linux/sys_soc.h>
> diff --git a/drivers/phy/tegra/xusb.c b/drivers/phy/tegra/xusb.c
> index de4a46f..0eac1b8 100644
> --- a/drivers/phy/tegra/xusb.c
> +++ b/drivers/phy/tegra/xusb.c
> @@ -9,6 +9,7 @@
> #include <linux/module.h>
> #include <linux/of.h>
> #include <linux/of_device.h>
> +#include <linux/of_platform.h>
> #include <linux/phy/phy.h>
> #include <linux/phy/tegra/xusb.h>
> #include <linux/platform_device.h>
> diff --git a/drivers/pinctrl/freescale/pinctrl-imx1-core.c b/drivers/pinctrl/freescale/pinctrl-imx1-core.c
> index c00d002..d1c171e 100644
> --- a/drivers/pinctrl/freescale/pinctrl-imx1-core.c
> +++ b/drivers/pinctrl/freescale/pinctrl-imx1-core.c
> @@ -16,6 +16,7 @@
> #include <linux/io.h>
> #include <linux/of.h>
> #include <linux/of_device.h>
> +#include <linux/of_platform.h>
> #include <linux/pinctrl/machine.h>
> #include <linux/pinctrl/pinconf.h>
> #include <linux/pinctrl/pinctrl.h>
> diff --git a/drivers/pinctrl/nomadik/pinctrl-nomadik.c b/drivers/pinctrl/nomadik/pinctrl-nomadik.c
> index ca7bbe4..44974ac 100644
> --- a/drivers/pinctrl/nomadik/pinctrl-nomadik.c
> +++ b/drivers/pinctrl/nomadik/pinctrl-nomadik.c
> @@ -19,6 +19,7 @@
> #include <linux/interrupt.h>
> #include <linux/slab.h>
> #include <linux/of_device.h>
> +#include <linux/of_platform.h>
> #include <linux/of_address.h>
> #include <linux/bitops.h>
> #include <linux/pinctrl/machine.h>
> diff --git a/drivers/soc/samsung/exynos-pmu.c b/drivers/soc/samsung/exynos-pmu.c
> index 17304fa..25129b0 100644
> --- a/drivers/soc/samsung/exynos-pmu.c
> +++ b/drivers/soc/samsung/exynos-pmu.c
> @@ -8,6 +8,7 @@
> #include <linux/of.h>
> #include <linux/of_address.h>
> #include <linux/of_device.h>
> +#include <linux/of_platform.h>
> #include <linux/mfd/syscon.h>
> #include <linux/platform_device.h>
> #include <linux/delay.h>
> diff --git a/drivers/soc/sunxi/sunxi_sram.c b/drivers/soc/sunxi/sunxi_sram.c
> index 1b0d50f..423cec3 100644
> --- a/drivers/soc/sunxi/sunxi_sram.c
> +++ b/drivers/soc/sunxi/sunxi_sram.c
> @@ -16,6 +16,7 @@
> #include <linux/of.h>
> #include <linux/of_address.h>
> #include <linux/of_device.h>
> +#include <linux/of_platform.h>
> #include <linux/platform_device.h>
> #include <linux/regmap.h>
>
> diff --git a/include/linux/of_device.h b/include/linux/of_device.h
> index 8d31e39..752999b 100644
> --- a/include/linux/of_device.h
> +++ b/include/linux/of_device.h
> @@ -4,8 +4,6 @@
>
> #include <linux/cpu.h>
> #include <linux/platform_device.h>
> -#include <linux/of_platform.h> /* temporary until merge */
> -
> #include <linux/of.h>
> #include <linux/mod_devicetable.h>
>
> diff --git a/lib/genalloc.c b/lib/genalloc.c
> index 7f1244b..08e21eeb 100644
> --- a/lib/genalloc.c
> +++ b/lib/genalloc.c
> @@ -33,6 +33,7 @@
> #include <linux/interrupt.h>
> #include <linux/genalloc.h>
> #include <linux/of_device.h>
> +#include <linux/of_platform.h>
> #include <linux/vmalloc.h>
>
> static inline size_t chunk_size(const struct gen_pool_chunk *chunk)
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH v2] of_device: removed #include that caused a recursion in included headers
2020-04-16 9:49 ` Hadar Gat
(?)
@ 2020-04-19 18:15 ` Stephen Boyd
-1 siblings, 0 replies; 25+ messages in thread
From: Stephen Boyd @ 2020-04-19 18:15 UTC (permalink / raw)
Cc: linux-iio-u79uwXL29TY76Z2rM5mHXA,
dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
sparclinux-u79uwXL29TY76Z2rM5mHXA,
linux-stm32-XDFAJ8BFU24N7RejjzZ/Li2xQDfSxrLKVpNB7YpNyf8,
linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA,
linux-clk-u79uwXL29TY76Z2rM5mHXA,
linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Hadar Gat,
devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-arm-msm-u79uwXL29TY76Z2rM5mHXA,
linux-gpio-u79uwXL29TY76Z2rM5mHXA,
linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-tegra-u79uwXL29TY76Z2rM5mHXA,
linux-omap-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Ofir Drang,
Gilad Ben-Yossef, netdev-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA,
dmaengine-u79uwXL29TY76Z2rM5mHXA,
freedreno-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW
Quoting Hadar Gat (2020-04-16 02:49:03)
> Both of_platform.h and of_device.h were included each other.
> In of_device.h, removed unneeded #include to of_platform.h
> and added include to of_platform.h in the files that needs it.
>
> Signed-off-by: Hadar Gat <hadar.gat-5wv7dgnIgG8@public.gmane.org>
> ---
Acked-by: Stephen Boyd <sboyd-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> # clk
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH v2] of_device: removed #include that caused a recursion in included headers
@ 2020-04-19 18:15 ` Stephen Boyd
0 siblings, 0 replies; 25+ messages in thread
From: Stephen Boyd @ 2020-04-19 18:15 UTC (permalink / raw)
To: Alexandre Belloni, Alexandre Torgue, Andy Gross, Bjorn Andersson,
Chen-Yu Tsai, Daniel Vetter, David Airlie, David S. Miller,
Dong Aisheng, Fabio Estevam, Frank Rowand, Giuseppe Cavallaro,
Greg Kroah-Hartman, Hadar Gat, Heiko Stübner, JC Kuo,
Joerg Roedel, Jonathan Cameron, Jonathan Hunter, Jose Abreu,
Kishon Vijay Abraham I, Krzysztof Kozlowski, Kukjin Kim,
Lee Jones, Linus Walleij, Liviu Dudau, Lorenzo Pieralisi
Cc: linux-iio, dri-devel, linux-mtd, sparclinux, linux-stm32,
linux-samsung-soc, linux-clk, linux-rockchip, Hadar Gat,
devicetree, linux-arm-msm, linux-gpio, linux-mediatek,
linux-tegra, linux-omap, linux-arm-kernel, Ofir Drang,
Gilad Ben-Yossef, netdev, linux-kernel, iommu, dmaengine,
freedreno
Quoting Hadar Gat (2020-04-16 02:49:03)
> Both of_platform.h and of_device.h were included each other.
> In of_device.h, removed unneeded #include to of_platform.h
> and added include to of_platform.h in the files that needs it.
>
> Signed-off-by: Hadar Gat <hadar.gat@arm.com>
> ---
Acked-by: Stephen Boyd <sboyd@kernel.org> # clk
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH v2] of_device: removed #include that caused a recursion in included headers
@ 2020-04-19 18:15 ` Stephen Boyd
0 siblings, 0 replies; 25+ messages in thread
From: Stephen Boyd @ 2020-04-19 18:15 UTC (permalink / raw)
To: Alexandre Belloni, Alexandre Torgue, Andy Gross, Bjorn Andersson,
Chen-Yu Tsai, Daniel Vetter, David Airlie, David S.Miller,
Dong Aisheng, Fabio Estevam, Frank Rowand, Giuseppe Cavallaro,
Greg Kroah-Hartman, Hadar Gat, Heiko Stübner, JC Kuo,
Joerg Roedel, Jonathan Cameron, Jonathan Hunter, Jose Abreu,
Kishon Vijay Abraham I, Krzysztof Kozlowski, Kukjin Kim,
Lee Jones, Linus Walleij, Liviu Dudau, Lorenzo Pierali si,
Ludovic Desroches, Matthias Brugger, Maxime Coquelin,
Maxime Ripard, Michael Turquette, Miquel Raynal, Nicolas Ferre,
Richard Weinberger, Rob Clark, Rob Herring, Sandy Huang,
Sascha Hauer, Sean Paul, Shawn Guo, Stefan Agner, Sudeep Holla,
Thierry Reding, Tony Lindgren, Vignesh Raghavendra, Vinod Koul
Cc: linux-iio, dri-devel, linux-mtd, sparclinux, linux-stm32,
linux-samsung-soc, linux-clk, linux-rockchip, Hadar Gat,
devicetree, linux-arm-msm, linux-gpio, linux-mediatek,
linux-tegra, linux-omap, linux-arm-kernel, Ofir Drang,
Gilad Ben-Yossef, netdev, linux-kernel, iommu, dmaengine,
freedreno
Quoting Hadar Gat (2020-04-16 02:49:03)
> Both of_platform.h and of_device.h were included each other.
> In of_device.h, removed unneeded #include to of_platform.h
> and added include to of_platform.h in the files that needs it.
>
> Signed-off-by: Hadar Gat <hadar.gat@arm.com>
> ---
Acked-by: Stephen Boyd <sboyd@kernel.org> # clk
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH v2] of_device: removed #include that caused a recursion in included headers
[not found] ` <1587030553-5990-1-git-send-email-hadar.gat-5wv7dgnIgG8@public.gmane.org>
` (3 preceding siblings ...)
(?)
@ 2020-04-20 6:37 ` kbuild test robot
1 sibling, 0 replies; 25+ messages in thread
From: kbuild test robot @ 2020-04-20 6:37 UTC (permalink / raw)
To: Hadar Gat, David S. Miller, Greg Kroah-Hartman, Shawn Guo,
Sascha Hauer, Liviu Dudau, Sudeep Holla, Lorenzo Pieralisi,
Michael Turquette, Stephen Boyd, Matthias Brugger,
Ludovic Desroches, Vinod Koul, Maxime Coquelin, Alexandre Torgue,
Rob Clark, Sean Paul, David Airlie, Daniel Vetter, Sandy Huang,
Heiko Stübner, Maxime Ripard, Chen-Yu Tsai,
Jonathan Cameron, Thierry Reding, Joerg Roedel, Jonathan Hunter,
Nicolas Ferre, Alexandre Belloni, Tony Lindgren, Lee Jones,
Andy Gross, Bjorn Andersson, Miquel Raynal, Richard Weinberger,
Vignesh Raghavendra, Giuseppe Cavallaro, Jose Abreu, JC Kuo,
Kishon Vijay Abraham I, Dong Aisheng, Fabio Estevam,
Stefan Agner, Linus Walleij, Kukjin Kim, Krzysztof Kozlowski,
Rob Herring, Frank Rowand, linux-iio, dri-devel, linux-mtd,
sparclinux, linux-stm32, linux-samsung-soc, linux-clk,
linux-rockchip, devicetree, linux-arm-msm, linux-gpio,
linux-mediatek, linux-tegra, linux-omap, linux-arm-kernel,
Ofir Drang, Gilad Ben-Yossef, netdev, linux-kernel, iommu,
dmaengine, freedreno
Cc: linux-samsung-soc, kbuild-all, linux-iio, netdev, dri-devel,
linux-clk, linux-rockchip, linux-mtd, Hadar Gat, sparclinux,
linux-stm32
[-- Attachment #1: Type: text/plain, Size: 5133 bytes --]
Hi Hadar,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on stm32/stm32-next]
[also build test ERROR on sunxi/sunxi/for-next linus/master v5.7-rc1 next-20200416]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Hadar-Gat/of_device-removed-include-that-caused-a-recursion-in-included-headers/20200417-155422
base: https://git.kernel.org/pub/scm/linux/kernel/git/atorgue/stm32.git stm32-next
config: arm-imx_v6_v7_defconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day GCC_VERSION=9.3.0 make.cross ARCH=arm
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
drivers/media/platform/coda/coda-common.c: In function 'coda_get_vdoa_data':
>> drivers/media/platform/coda/coda-common.c:385:14: error: implicit declaration of function 'of_find_device_by_node'; did you mean 'of_find_spi_device_by_node'? [-Werror=implicit-function-declaration]
385 | vdoa_pdev = of_find_device_by_node(vdoa_node);
| ^~~~~~~~~~~~~~~~~~~~~~
| of_find_spi_device_by_node
drivers/media/platform/coda/coda-common.c:385:12: warning: assignment to 'struct platform_device *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
385 | vdoa_pdev = of_find_device_by_node(vdoa_node);
| ^
cc1: some warnings being treated as errors
vim +385 drivers/media/platform/coda/coda-common.c
927933f7b4b213 drivers/media/platform/coda.c Philipp Zabel 2013-09-30 374
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 375 static struct vdoa_data *coda_get_vdoa_data(void)
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 376 {
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 377 struct device_node *vdoa_node;
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 378 struct platform_device *vdoa_pdev;
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 379 struct vdoa_data *vdoa_data = NULL;
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 380
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 381 vdoa_node = of_find_compatible_node(NULL, NULL, "fsl,imx6q-vdoa");
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 382 if (!vdoa_node)
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 383 return NULL;
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 384
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 @385 vdoa_pdev = of_find_device_by_node(vdoa_node);
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 386 if (!vdoa_pdev)
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 387 goto out;
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 388
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 389 vdoa_data = platform_get_drvdata(vdoa_pdev);
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 390 if (!vdoa_data)
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 391 vdoa_data = ERR_PTR(-EPROBE_DEFER);
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 392
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 393 out:
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 394 of_node_put(vdoa_node);
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 395
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 396 return vdoa_data;
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 397 }
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 398
:::::: The code at line 385 was first introduced by commit
:::::: e7f3c54810350827823d241905fb7823eee30c21 [media] coda: use VDOA for un-tiling custom macroblock format
:::::: TO: Michael Tretter <m.tretter@pengutronix.de>
:::::: CC: Mauro Carvalho Chehab <mchehab@s-opensource.com>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 37270 bytes --]
[-- Attachment #3: Type: text/plain, Size: 144 bytes --]
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 25+ messages in thread* Re: [PATCH v2] of_device: removed #include that caused a recursion in included headers
@ 2020-04-20 6:37 ` kbuild test robot
0 siblings, 0 replies; 25+ messages in thread
From: kbuild test robot @ 2020-04-20 6:37 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 5207 bytes --]
Hi Hadar,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on stm32/stm32-next]
[also build test ERROR on sunxi/sunxi/for-next linus/master v5.7-rc1 next-20200416]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Hadar-Gat/of_device-removed-include-that-caused-a-recursion-in-included-headers/20200417-155422
base: https://git.kernel.org/pub/scm/linux/kernel/git/atorgue/stm32.git stm32-next
config: arm-imx_v6_v7_defconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day GCC_VERSION=9.3.0 make.cross ARCH=arm
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
drivers/media/platform/coda/coda-common.c: In function 'coda_get_vdoa_data':
>> drivers/media/platform/coda/coda-common.c:385:14: error: implicit declaration of function 'of_find_device_by_node'; did you mean 'of_find_spi_device_by_node'? [-Werror=implicit-function-declaration]
385 | vdoa_pdev = of_find_device_by_node(vdoa_node);
| ^~~~~~~~~~~~~~~~~~~~~~
| of_find_spi_device_by_node
drivers/media/platform/coda/coda-common.c:385:12: warning: assignment to 'struct platform_device *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
385 | vdoa_pdev = of_find_device_by_node(vdoa_node);
| ^
cc1: some warnings being treated as errors
vim +385 drivers/media/platform/coda/coda-common.c
927933f7b4b213 drivers/media/platform/coda.c Philipp Zabel 2013-09-30 374
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 375 static struct vdoa_data *coda_get_vdoa_data(void)
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 376 {
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 377 struct device_node *vdoa_node;
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 378 struct platform_device *vdoa_pdev;
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 379 struct vdoa_data *vdoa_data = NULL;
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 380
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 381 vdoa_node = of_find_compatible_node(NULL, NULL, "fsl,imx6q-vdoa");
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 382 if (!vdoa_node)
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 383 return NULL;
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 384
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 @385 vdoa_pdev = of_find_device_by_node(vdoa_node);
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 386 if (!vdoa_pdev)
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 387 goto out;
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 388
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 389 vdoa_data = platform_get_drvdata(vdoa_pdev);
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 390 if (!vdoa_data)
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 391 vdoa_data = ERR_PTR(-EPROBE_DEFER);
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 392
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 393 out:
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 394 of_node_put(vdoa_node);
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 395
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 396 return vdoa_data;
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 397 }
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 398
:::::: The code at line 385 was first introduced by commit
:::::: e7f3c54810350827823d241905fb7823eee30c21 [media] coda: use VDOA for un-tiling custom macroblock format
:::::: TO: Michael Tretter <m.tretter@pengutronix.de>
:::::: CC: Mauro Carvalho Chehab <mchehab@s-opensource.com>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 37270 bytes --]
^ permalink raw reply [flat|nested] 25+ messages in thread* Re: [PATCH v2] of_device: removed #include that caused a recursion in included headers
@ 2020-04-20 6:37 ` kbuild test robot
0 siblings, 0 replies; 25+ messages in thread
From: kbuild test robot @ 2020-04-20 6:37 UTC (permalink / raw)
To: Hadar Gat, David S. Miller, Greg Kroah-Hartman, Shawn Guo,
Sascha Hauer, Liviu Dudau, Sudeep Holla, Lorenzo Pieralisi,
Michael Turquette, Stephen Boyd, Matthias Brugger,
Ludovic Desroches, Vinod Koul, Maxime Coquelin, Alexandre Torgue,
Rob Clark, Sean Paul, David Airlie, Daniel Vetter, Sandy Huang,
Heiko Stübner, Maxime Ripard, Chen-Yu Tsai,
Jonathan Cameron, Thierry Reding, Joerg Roedel, Jonathan Hunter,
Nicolas Ferre, Alexandre Belloni, Tony Lindgren, Lee Jones,
Andy Gross, Bjorn Andersson, Miquel Raynal, Richard Weinberger,
Vignesh Raghavendra, Giuseppe Cavallaro, Jose Abreu, JC Kuo,
Kishon Vijay Abraham I, Dong Aisheng, Fabio Estevam,
Stefan Agner, Linus Walleij, Kukjin Kim, Krzysztof Kozlowski,
Rob Herring, Frank Rowand, linux-iio, dri-devel, linux-mtd,
sparclinux, linux-stm32, linux-samsung-soc, linux-clk,
linux-rockchip, devicetree, linux-arm-msm, linux-gpio,
linux-mediatek, linux-tegra, linux-omap, linux-arm-kernel,
Ofir Drang, Gilad Ben-Yossef, netdev, linux-kernel, iommu,
dmaengine, freedreno
Cc: linux-samsung-soc, kbuild-all, linux-iio, netdev, dri-devel,
linux-clk, linux-rockchip, linux-mtd, Hadar Gat, sparclinux,
linux-stm32
[-- Attachment #1: Type: text/plain, Size: 5133 bytes --]
Hi Hadar,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on stm32/stm32-next]
[also build test ERROR on sunxi/sunxi/for-next linus/master v5.7-rc1 next-20200416]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Hadar-Gat/of_device-removed-include-that-caused-a-recursion-in-included-headers/20200417-155422
base: https://git.kernel.org/pub/scm/linux/kernel/git/atorgue/stm32.git stm32-next
config: arm-imx_v6_v7_defconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day GCC_VERSION=9.3.0 make.cross ARCH=arm
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
drivers/media/platform/coda/coda-common.c: In function 'coda_get_vdoa_data':
>> drivers/media/platform/coda/coda-common.c:385:14: error: implicit declaration of function 'of_find_device_by_node'; did you mean 'of_find_spi_device_by_node'? [-Werror=implicit-function-declaration]
385 | vdoa_pdev = of_find_device_by_node(vdoa_node);
| ^~~~~~~~~~~~~~~~~~~~~~
| of_find_spi_device_by_node
drivers/media/platform/coda/coda-common.c:385:12: warning: assignment to 'struct platform_device *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
385 | vdoa_pdev = of_find_device_by_node(vdoa_node);
| ^
cc1: some warnings being treated as errors
vim +385 drivers/media/platform/coda/coda-common.c
927933f7b4b213 drivers/media/platform/coda.c Philipp Zabel 2013-09-30 374
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 375 static struct vdoa_data *coda_get_vdoa_data(void)
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 376 {
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 377 struct device_node *vdoa_node;
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 378 struct platform_device *vdoa_pdev;
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 379 struct vdoa_data *vdoa_data = NULL;
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 380
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 381 vdoa_node = of_find_compatible_node(NULL, NULL, "fsl,imx6q-vdoa");
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 382 if (!vdoa_node)
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 383 return NULL;
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 384
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 @385 vdoa_pdev = of_find_device_by_node(vdoa_node);
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 386 if (!vdoa_pdev)
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 387 goto out;
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 388
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 389 vdoa_data = platform_get_drvdata(vdoa_pdev);
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 390 if (!vdoa_data)
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 391 vdoa_data = ERR_PTR(-EPROBE_DEFER);
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 392
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 393 out:
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 394 of_node_put(vdoa_node);
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 395
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 396 return vdoa_data;
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 397 }
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 398
:::::: The code at line 385 was first introduced by commit
:::::: e7f3c54810350827823d241905fb7823eee30c21 [media] coda: use VDOA for un-tiling custom macroblock format
:::::: TO: Michael Tretter <m.tretter@pengutronix.de>
:::::: CC: Mauro Carvalho Chehab <mchehab@s-opensource.com>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 37270 bytes --]
[-- Attachment #3: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 25+ messages in thread* Re: [PATCH v2] of_device: removed #include that caused a recursion in included headers
@ 2020-04-20 6:37 ` kbuild test robot
0 siblings, 0 replies; 25+ messages in thread
From: kbuild test robot @ 2020-04-20 6:37 UTC (permalink / raw)
To: Hadar Gat, David S. Miller, Greg Kroah-Hartman, Shawn Guo,
Sascha Hauer, Liviu Dudau, Sudeep Holla, Lorenzo Pieralisi,
Michael Turquette, Stephen Boyd, Matthias Brugger,
Ludovic Desroches, Vinod Koul, Maxime Coquelin, Alexandre Torgue,
Rob Clark, Sean Paul, David Airlie, Daniel Vetter, Sandy Huang,
Heiko Stübner, Maxime Ripard, Chen-Yu Tsai,
Jonathan Cameron, Thierry Reding, Joerg Roedel, Jonathan Hunter,
Nicolas Ferre, Alexandre Belloni, Tony Lindgren, Lee Jones,
Andy Gross, Bjorn Andersson, Miquel Raynal, Richard Weinberger,
Vignesh Raghavendra, Giuseppe Cavallaro, Jose Abreu, JC Kuo,
Kishon Vijay Abraham I, Dong Aisheng, Fabio Estevam,
Stefan Agner, Linus Walleij, Kukjin Kim, Krzysztof Kozlowski,
Rob Herring, Frank Rowand, linux-iio, dri-devel, linux-mtd,
sparclinux, linux-stm32, linux-samsung-soc, linux-clk,
linux-rockchip, devicetree, linux-arm-msm, linux-gpio,
linux-mediatek, linux-tegra, linux-omap, linux-arm-kernel,
Ofir Drang, Gilad Ben-Yossef, netdev, linux-kernel, iommu,
dmaengine, freedreno
Cc: linux-samsung-soc, kbuild-all, linux-iio, netdev, dri-devel,
linux-clk, linux-rockchip, linux-mtd, Hadar Gat, sparclinux,
linux-stm32
[-- Attachment #1: Type: text/plain, Size: 5133 bytes --]
Hi Hadar,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on stm32/stm32-next]
[also build test ERROR on sunxi/sunxi/for-next linus/master v5.7-rc1 next-20200416]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Hadar-Gat/of_device-removed-include-that-caused-a-recursion-in-included-headers/20200417-155422
base: https://git.kernel.org/pub/scm/linux/kernel/git/atorgue/stm32.git stm32-next
config: arm-imx_v6_v7_defconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day GCC_VERSION=9.3.0 make.cross ARCH=arm
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
drivers/media/platform/coda/coda-common.c: In function 'coda_get_vdoa_data':
>> drivers/media/platform/coda/coda-common.c:385:14: error: implicit declaration of function 'of_find_device_by_node'; did you mean 'of_find_spi_device_by_node'? [-Werror=implicit-function-declaration]
385 | vdoa_pdev = of_find_device_by_node(vdoa_node);
| ^~~~~~~~~~~~~~~~~~~~~~
| of_find_spi_device_by_node
drivers/media/platform/coda/coda-common.c:385:12: warning: assignment to 'struct platform_device *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
385 | vdoa_pdev = of_find_device_by_node(vdoa_node);
| ^
cc1: some warnings being treated as errors
vim +385 drivers/media/platform/coda/coda-common.c
927933f7b4b213 drivers/media/platform/coda.c Philipp Zabel 2013-09-30 374
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 375 static struct vdoa_data *coda_get_vdoa_data(void)
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 376 {
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 377 struct device_node *vdoa_node;
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 378 struct platform_device *vdoa_pdev;
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 379 struct vdoa_data *vdoa_data = NULL;
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 380
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 381 vdoa_node = of_find_compatible_node(NULL, NULL, "fsl,imx6q-vdoa");
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 382 if (!vdoa_node)
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 383 return NULL;
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 384
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 @385 vdoa_pdev = of_find_device_by_node(vdoa_node);
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 386 if (!vdoa_pdev)
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 387 goto out;
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 388
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 389 vdoa_data = platform_get_drvdata(vdoa_pdev);
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 390 if (!vdoa_data)
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 391 vdoa_data = ERR_PTR(-EPROBE_DEFER);
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 392
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 393 out:
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 394 of_node_put(vdoa_node);
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 395
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 396 return vdoa_data;
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 397 }
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 398
:::::: The code at line 385 was first introduced by commit
:::::: e7f3c54810350827823d241905fb7823eee30c21 [media] coda: use VDOA for un-tiling custom macroblock format
:::::: TO: Michael Tretter <m.tretter@pengutronix.de>
:::::: CC: Mauro Carvalho Chehab <mchehab@s-opensource.com>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 37270 bytes --]
[-- Attachment #3: Type: text/plain, Size: 170 bytes --]
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 25+ messages in thread* Re: [PATCH v2] of_device: removed #include that caused a recursion in included headers
@ 2020-04-20 6:37 ` kbuild test robot
0 siblings, 0 replies; 25+ messages in thread
From: kbuild test robot @ 2020-04-20 6:37 UTC (permalink / raw)
To: Hadar Gat, David S. Miller, Greg Kroah-Hartman, Shawn Guo,
Sascha Hauer, Liviu Dudau, Sudeep Holla, Lorenzo Pieralisi,
Michael Turquette, Stephen Boyd, Matthias Brugger,
Ludovic Desroches, Vinod Koul, Maxime Coquelin, Alexandre Torgue,
Rob Clark, Sean Paul, David Airlie, Daniel Vetter, Sandy Huang,
Heiko Stübner, Maxime Ripard, Chen-Yu Tsai,
Jonathan Cameron, Thierry Reding, Joerg Roedel, Jonathan Hunter,
Nicolas Ferre, Alexandre Belloni, Tony Lindgren, Lee Jones,
Andy Gross, Bjorn Andersson, Miquel Raynal, Richard Weinberger,
Vignesh Raghavendra, Giuseppe Cavallaro, Jose Abreu, JC Kuo,
Kishon Vijay Abraham I, Dong Aisheng, Fabio Estevam,
Stefan Agner, Linus Walleij, Kukjin Kim, Krzysztof Kozlowski,
Rob Herring, Frank Rowand, linux-iio, dri-devel, linux-mtd,
sparclinux, linux-stm32, linux-samsung-soc, linux-clk,
linux-rockchip, devicetree, linux-arm-msm, linux-gpio,
linux-mediatek, linux-tegra, linux-omap, linux-arm-kernel,
Ofir Drang, Gilad Ben-Yossef, netdev, linux-kernel, iommu,
dmaengine, freedreno
Cc: linux-samsung-soc, kbuild-all, linux-iio, netdev, dri-devel,
linux-clk, linux-rockchip, linux-mtd, Hadar Gat, sparclinux,
linux-stm32
[-- Attachment #1: Type: text/plain, Size: 5133 bytes --]
Hi Hadar,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on stm32/stm32-next]
[also build test ERROR on sunxi/sunxi/for-next linus/master v5.7-rc1 next-20200416]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Hadar-Gat/of_device-removed-include-that-caused-a-recursion-in-included-headers/20200417-155422
base: https://git.kernel.org/pub/scm/linux/kernel/git/atorgue/stm32.git stm32-next
config: arm-imx_v6_v7_defconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day GCC_VERSION=9.3.0 make.cross ARCH=arm
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
drivers/media/platform/coda/coda-common.c: In function 'coda_get_vdoa_data':
>> drivers/media/platform/coda/coda-common.c:385:14: error: implicit declaration of function 'of_find_device_by_node'; did you mean 'of_find_spi_device_by_node'? [-Werror=implicit-function-declaration]
385 | vdoa_pdev = of_find_device_by_node(vdoa_node);
| ^~~~~~~~~~~~~~~~~~~~~~
| of_find_spi_device_by_node
drivers/media/platform/coda/coda-common.c:385:12: warning: assignment to 'struct platform_device *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
385 | vdoa_pdev = of_find_device_by_node(vdoa_node);
| ^
cc1: some warnings being treated as errors
vim +385 drivers/media/platform/coda/coda-common.c
927933f7b4b213 drivers/media/platform/coda.c Philipp Zabel 2013-09-30 374
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 375 static struct vdoa_data *coda_get_vdoa_data(void)
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 376 {
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 377 struct device_node *vdoa_node;
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 378 struct platform_device *vdoa_pdev;
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 379 struct vdoa_data *vdoa_data = NULL;
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 380
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 381 vdoa_node = of_find_compatible_node(NULL, NULL, "fsl,imx6q-vdoa");
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 382 if (!vdoa_node)
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 383 return NULL;
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 384
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 @385 vdoa_pdev = of_find_device_by_node(vdoa_node);
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 386 if (!vdoa_pdev)
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 387 goto out;
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 388
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 389 vdoa_data = platform_get_drvdata(vdoa_pdev);
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 390 if (!vdoa_data)
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 391 vdoa_data = ERR_PTR(-EPROBE_DEFER);
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 392
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 393 out:
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 394 of_node_put(vdoa_node);
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 395
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 396 return vdoa_data;
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 397 }
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 398
:::::: The code at line 385 was first introduced by commit
:::::: e7f3c54810350827823d241905fb7823eee30c21 [media] coda: use VDOA for un-tiling custom macroblock format
:::::: TO: Michael Tretter <m.tretter@pengutronix.de>
:::::: CC: Mauro Carvalho Chehab <mchehab@s-opensource.com>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 37270 bytes --]
[-- Attachment #3: Type: text/plain, Size: 156 bytes --]
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
^ permalink raw reply [flat|nested] 25+ messages in thread* Re: [PATCH v2] of_device: removed #include that caused a recursion in included headers
@ 2020-04-20 6:37 ` kbuild test robot
0 siblings, 0 replies; 25+ messages in thread
From: kbuild test robot @ 2020-04-20 6:37 UTC (permalink / raw)
To: David S. Miller, Greg Kroah-Hartman, Shawn Guo, Sascha Hauer,
Liviu Dudau, Sudeep Holla, Lorenzo Pieralisi, Michael Turquette,
Stephen Boyd, Matthias Brugger, Ludovic Desroches, Vinod Koul,
Maxime Coquelin, Alexandre Torgue, Rob Clark, Sean Paul,
David Airlie, Daniel Vetter, Sandy Huang, Heiko Stübner,
Maxime Ripard, Chen-Yu Tsai
Cc: linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA,
kbuild-all-hn68Rpc1hR1g9hUCZPvPmw,
linux-iio-u79uwXL29TY76Z2rM5mHXA, netdev-u79uwXL29TY76Z2rM5mHXA,
dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
linux-clk-u79uwXL29TY76Z2rM5mHXA,
linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Hadar Gat,
sparclinux-u79uwXL29TY76Z2rM5mHXA,
linux-stm32-XDFAJ8BFU24N7RejjzZ/Li2xQDfSxrLKVpNB7YpNyf8
[-- Attachment #1: Type: text/plain, Size: 5238 bytes --]
Hi Hadar,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on stm32/stm32-next]
[also build test ERROR on sunxi/sunxi/for-next linus/master v5.7-rc1 next-20200416]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Hadar-Gat/of_device-removed-include-that-caused-a-recursion-in-included-headers/20200417-155422
base: https://git.kernel.org/pub/scm/linux/kernel/git/atorgue/stm32.git stm32-next
config: arm-imx_v6_v7_defconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day GCC_VERSION=9.3.0 make.cross ARCH=arm
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
All errors (new ones prefixed by >>):
drivers/media/platform/coda/coda-common.c: In function 'coda_get_vdoa_data':
>> drivers/media/platform/coda/coda-common.c:385:14: error: implicit declaration of function 'of_find_device_by_node'; did you mean 'of_find_spi_device_by_node'? [-Werror=implicit-function-declaration]
385 | vdoa_pdev = of_find_device_by_node(vdoa_node);
| ^~~~~~~~~~~~~~~~~~~~~~
| of_find_spi_device_by_node
drivers/media/platform/coda/coda-common.c:385:12: warning: assignment to 'struct platform_device *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
385 | vdoa_pdev = of_find_device_by_node(vdoa_node);
| ^
cc1: some warnings being treated as errors
vim +385 drivers/media/platform/coda/coda-common.c
927933f7b4b213 drivers/media/platform/coda.c Philipp Zabel 2013-09-30 374
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 375 static struct vdoa_data *coda_get_vdoa_data(void)
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 376 {
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 377 struct device_node *vdoa_node;
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 378 struct platform_device *vdoa_pdev;
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 379 struct vdoa_data *vdoa_data = NULL;
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 380
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 381 vdoa_node = of_find_compatible_node(NULL, NULL, "fsl,imx6q-vdoa");
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 382 if (!vdoa_node)
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 383 return NULL;
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 384
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 @385 vdoa_pdev = of_find_device_by_node(vdoa_node);
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 386 if (!vdoa_pdev)
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 387 goto out;
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 388
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 389 vdoa_data = platform_get_drvdata(vdoa_pdev);
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 390 if (!vdoa_data)
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 391 vdoa_data = ERR_PTR(-EPROBE_DEFER);
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 392
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 393 out:
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 394 of_node_put(vdoa_node);
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 395
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 396 return vdoa_data;
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 397 }
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 398
:::::: The code at line 385 was first introduced by commit
:::::: e7f3c54810350827823d241905fb7823eee30c21 [media] coda: use VDOA for un-tiling custom macroblock format
:::::: TO: Michael Tretter <m.tretter-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
:::::: CC: Mauro Carvalho Chehab <mchehab-JsYNTwtnfakRB7SZvlqPiA@public.gmane.org>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 37270 bytes --]
[-- Attachment #3: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH v2] of_device: removed #include that caused a recursion in included headers
[not found] ` <1587030553-5990-1-git-send-email-hadar.gat-5wv7dgnIgG8@public.gmane.org>
` (3 preceding siblings ...)
(?)
@ 2020-04-20 6:39 ` kbuild test robot
1 sibling, 0 replies; 25+ messages in thread
From: kbuild test robot @ 2020-04-20 6:39 UTC (permalink / raw)
To: Hadar Gat, David S. Miller, Greg Kroah-Hartman, Shawn Guo,
Sascha Hauer, Liviu Dudau, Sudeep Holla, Lorenzo Pieralisi,
Michael Turquette, Stephen Boyd, Matthias Brugger,
Ludovic Desroches, Vinod Koul, Maxime Coquelin, Alexandre Torgue,
Rob Clark, Sean Paul, David Airlie, Daniel Vetter, Sandy Huang,
Heiko Stübner, Maxime Ripard, Chen-Yu Tsai,
Jonathan Cameron, Thierry Reding, Joerg Roedel, Jonathan Hunter,
Nicolas Ferre, Alexandre Belloni, Tony Lindgren, Lee Jones,
Andy Gross, Bjorn Andersson, Miquel Raynal, Richard Weinberger,
Vignesh Raghavendra, Giuseppe Cavallaro, Jose Abreu, JC Kuo,
Kishon Vijay Abraham I, Dong Aisheng, Fabio Estevam,
Stefan Agner, Linus Walleij, Kukjin Kim, Krzysztof Kozlowski,
Rob Herring, Frank Rowand, linux-iio, dri-devel, linux-mtd,
sparclinux, linux-stm32, linux-samsung-soc, linux-clk,
linux-rockchip, devicetree, linux-arm-msm, linux-gpio,
linux-mediatek, linux-tegra, linux-omap, linux-arm-kernel,
Ofir Drang, Gilad Ben-Yossef, netdev, linux-kernel, iommu,
dmaengine, freedreno
Cc: linux-samsung-soc, kbuild-all, linux-iio, netdev, dri-devel,
linux-clk, linux-rockchip, linux-mtd, Hadar Gat, sparclinux,
linux-stm32
[-- Attachment #1: Type: text/plain, Size: 6046 bytes --]
Hi Hadar,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on stm32/stm32-next]
[also build test ERROR on sunxi/sunxi/for-next linus/master v5.7-rc1 next-20200416]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Hadar-Gat/of_device-removed-include-that-caused-a-recursion-in-included-headers/20200417-155422
base: https://git.kernel.org/pub/scm/linux/kernel/git/atorgue/stm32.git stm32-next
config: sparc64-defconfig (attached as .config)
compiler: sparc64-linux-gcc (GCC) 9.3.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day GCC_VERSION=9.3.0 make.cross ARCH=sparc64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
arch/sparc/kernel/sbus.c: In function 'sbus_init':
>> arch/sparc/kernel/sbus.c:669:32: error: implicit declaration of function 'of_find_device_by_node'; did you mean 'bus_find_device_by_fwnode'? [-Werror=implicit-function-declaration]
669 | struct platform_device *op = of_find_device_by_node(dp);
| ^~~~~~~~~~~~~~~~~~~~~~
| bus_find_device_by_fwnode
>> arch/sparc/kernel/sbus.c:669:32: error: initialization of 'struct platform_device *' from 'int' makes pointer from integer without a cast [-Werror=int-conversion]
cc1: all warnings being treated as errors
--
arch/sparc/kernel/pci.c: In function 'of_create_pci_dev':
>> arch/sparc/kernel/pci.c:276:7: error: implicit declaration of function 'of_find_device_by_node'; did you mean 'bus_find_device_by_fwnode'? [-Werror=implicit-function-declaration]
276 | op = of_find_device_by_node(node);
| ^~~~~~~~~~~~~~~~~~~~~~
| bus_find_device_by_fwnode
>> arch/sparc/kernel/pci.c:276:5: error: assignment to 'struct platform_device *' from 'int' makes pointer from integer without a cast [-Werror=int-conversion]
276 | op = of_find_device_by_node(node);
| ^
cc1: all warnings being treated as errors
--
arch/sparc/kernel/pci_sabre.c: In function 'sabre_register_error_handlers':
>> arch/sparc/kernel/pci_sabre.c:324:7: error: implicit declaration of function 'of_find_device_by_node'; did you mean 'bus_find_device_by_fwnode'? [-Werror=implicit-function-declaration]
324 | op = of_find_device_by_node(dp);
| ^~~~~~~~~~~~~~~~~~~~~~
| bus_find_device_by_fwnode
arch/sparc/kernel/pci_sabre.c:324:5: error: assignment to 'struct platform_device *' from 'int' makes pointer from integer without a cast [-Werror=int-conversion]
324 | op = of_find_device_by_node(dp);
| ^
cc1: all warnings being treated as errors
--
arch/sparc/kernel/pci_schizo.c: In function 'tomatillo_register_error_handlers':
>> arch/sparc/kernel/pci_schizo.c:850:31: error: implicit declaration of function 'of_find_device_by_node'; did you mean 'bus_find_device_by_fwnode'? [-Werror=implicit-function-declaration]
850 | struct platform_device *op = of_find_device_by_node(pbm->op->dev.of_node);
| ^~~~~~~~~~~~~~~~~~~~~~
| bus_find_device_by_fwnode
arch/sparc/kernel/pci_schizo.c:850:31: error: initialization of 'struct platform_device *' from 'int' makes pointer from integer without a cast [-Werror=int-conversion]
arch/sparc/kernel/pci_schizo.c: In function 'schizo_register_error_handlers':
arch/sparc/kernel/pci_schizo.c:945:31: error: initialization of 'struct platform_device *' from 'int' makes pointer from integer without a cast [-Werror=int-conversion]
945 | struct platform_device *op = of_find_device_by_node(pbm->op->dev.of_node);
| ^~~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
vim +669 arch/sparc/kernel/sbus.c
8fae097debdf8a arch/sparc64/kernel/sbus.c David S. Miller 2006-06-20 663
046e26a8ba10b8 arch/sparc64/kernel/sbus.c David S. Miller 2008-08-27 664 static int __init sbus_init(void)
576c352e89e57c arch/sparc64/kernel/sbus.c David S. Miller 2006-06-23 665 {
046e26a8ba10b8 arch/sparc64/kernel/sbus.c David S. Miller 2008-08-27 666 struct device_node *dp;
046e26a8ba10b8 arch/sparc64/kernel/sbus.c David S. Miller 2008-08-27 667
046e26a8ba10b8 arch/sparc64/kernel/sbus.c David S. Miller 2008-08-27 668 for_each_node_by_name(dp, "sbus") {
cd4cd7306a403f arch/sparc/kernel/sbus.c Grant Likely 2010-07-22 @669 struct platform_device *op = of_find_device_by_node(dp);
046e26a8ba10b8 arch/sparc64/kernel/sbus.c David S. Miller 2008-08-27 670
046e26a8ba10b8 arch/sparc64/kernel/sbus.c David S. Miller 2008-08-27 671 sbus_iommu_init(op);
046e26a8ba10b8 arch/sparc64/kernel/sbus.c David S. Miller 2008-08-27 672 of_propagate_archdata(op);
046e26a8ba10b8 arch/sparc64/kernel/sbus.c David S. Miller 2008-08-27 673 }
576c352e89e57c arch/sparc64/kernel/sbus.c David S. Miller 2006-06-23 674
046e26a8ba10b8 arch/sparc64/kernel/sbus.c David S. Miller 2008-08-27 675 return 0;
576c352e89e57c arch/sparc64/kernel/sbus.c David S. Miller 2006-06-23 676 }
046e26a8ba10b8 arch/sparc64/kernel/sbus.c David S. Miller 2008-08-27 677
:::::: The code at line 669 was first introduced by commit
:::::: cd4cd7306a403f62ef3ca783b9d1cf2a03e595ed sparc: remove references to of_device and to_of_device
:::::: TO: Grant Likely <grant.likely@secretlab.ca>
:::::: CC: Grant Likely <grant.likely@secretlab.ca>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 19174 bytes --]
[-- Attachment #3: Type: text/plain, Size: 144 bytes --]
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 25+ messages in thread* Re: [PATCH v2] of_device: removed #include that caused a recursion in included headers
@ 2020-04-20 6:39 ` kbuild test robot
0 siblings, 0 replies; 25+ messages in thread
From: kbuild test robot @ 2020-04-20 6:39 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 6140 bytes --]
Hi Hadar,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on stm32/stm32-next]
[also build test ERROR on sunxi/sunxi/for-next linus/master v5.7-rc1 next-20200416]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Hadar-Gat/of_device-removed-include-that-caused-a-recursion-in-included-headers/20200417-155422
base: https://git.kernel.org/pub/scm/linux/kernel/git/atorgue/stm32.git stm32-next
config: sparc64-defconfig (attached as .config)
compiler: sparc64-linux-gcc (GCC) 9.3.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day GCC_VERSION=9.3.0 make.cross ARCH=sparc64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
arch/sparc/kernel/sbus.c: In function 'sbus_init':
>> arch/sparc/kernel/sbus.c:669:32: error: implicit declaration of function 'of_find_device_by_node'; did you mean 'bus_find_device_by_fwnode'? [-Werror=implicit-function-declaration]
669 | struct platform_device *op = of_find_device_by_node(dp);
| ^~~~~~~~~~~~~~~~~~~~~~
| bus_find_device_by_fwnode
>> arch/sparc/kernel/sbus.c:669:32: error: initialization of 'struct platform_device *' from 'int' makes pointer from integer without a cast [-Werror=int-conversion]
cc1: all warnings being treated as errors
--
arch/sparc/kernel/pci.c: In function 'of_create_pci_dev':
>> arch/sparc/kernel/pci.c:276:7: error: implicit declaration of function 'of_find_device_by_node'; did you mean 'bus_find_device_by_fwnode'? [-Werror=implicit-function-declaration]
276 | op = of_find_device_by_node(node);
| ^~~~~~~~~~~~~~~~~~~~~~
| bus_find_device_by_fwnode
>> arch/sparc/kernel/pci.c:276:5: error: assignment to 'struct platform_device *' from 'int' makes pointer from integer without a cast [-Werror=int-conversion]
276 | op = of_find_device_by_node(node);
| ^
cc1: all warnings being treated as errors
--
arch/sparc/kernel/pci_sabre.c: In function 'sabre_register_error_handlers':
>> arch/sparc/kernel/pci_sabre.c:324:7: error: implicit declaration of function 'of_find_device_by_node'; did you mean 'bus_find_device_by_fwnode'? [-Werror=implicit-function-declaration]
324 | op = of_find_device_by_node(dp);
| ^~~~~~~~~~~~~~~~~~~~~~
| bus_find_device_by_fwnode
arch/sparc/kernel/pci_sabre.c:324:5: error: assignment to 'struct platform_device *' from 'int' makes pointer from integer without a cast [-Werror=int-conversion]
324 | op = of_find_device_by_node(dp);
| ^
cc1: all warnings being treated as errors
--
arch/sparc/kernel/pci_schizo.c: In function 'tomatillo_register_error_handlers':
>> arch/sparc/kernel/pci_schizo.c:850:31: error: implicit declaration of function 'of_find_device_by_node'; did you mean 'bus_find_device_by_fwnode'? [-Werror=implicit-function-declaration]
850 | struct platform_device *op = of_find_device_by_node(pbm->op->dev.of_node);
| ^~~~~~~~~~~~~~~~~~~~~~
| bus_find_device_by_fwnode
arch/sparc/kernel/pci_schizo.c:850:31: error: initialization of 'struct platform_device *' from 'int' makes pointer from integer without a cast [-Werror=int-conversion]
arch/sparc/kernel/pci_schizo.c: In function 'schizo_register_error_handlers':
arch/sparc/kernel/pci_schizo.c:945:31: error: initialization of 'struct platform_device *' from 'int' makes pointer from integer without a cast [-Werror=int-conversion]
945 | struct platform_device *op = of_find_device_by_node(pbm->op->dev.of_node);
| ^~~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
vim +669 arch/sparc/kernel/sbus.c
8fae097debdf8a arch/sparc64/kernel/sbus.c David S. Miller 2006-06-20 663
046e26a8ba10b8 arch/sparc64/kernel/sbus.c David S. Miller 2008-08-27 664 static int __init sbus_init(void)
576c352e89e57c arch/sparc64/kernel/sbus.c David S. Miller 2006-06-23 665 {
046e26a8ba10b8 arch/sparc64/kernel/sbus.c David S. Miller 2008-08-27 666 struct device_node *dp;
046e26a8ba10b8 arch/sparc64/kernel/sbus.c David S. Miller 2008-08-27 667
046e26a8ba10b8 arch/sparc64/kernel/sbus.c David S. Miller 2008-08-27 668 for_each_node_by_name(dp, "sbus") {
cd4cd7306a403f arch/sparc/kernel/sbus.c Grant Likely 2010-07-22 @669 struct platform_device *op = of_find_device_by_node(dp);
046e26a8ba10b8 arch/sparc64/kernel/sbus.c David S. Miller 2008-08-27 670
046e26a8ba10b8 arch/sparc64/kernel/sbus.c David S. Miller 2008-08-27 671 sbus_iommu_init(op);
046e26a8ba10b8 arch/sparc64/kernel/sbus.c David S. Miller 2008-08-27 672 of_propagate_archdata(op);
046e26a8ba10b8 arch/sparc64/kernel/sbus.c David S. Miller 2008-08-27 673 }
576c352e89e57c arch/sparc64/kernel/sbus.c David S. Miller 2006-06-23 674
046e26a8ba10b8 arch/sparc64/kernel/sbus.c David S. Miller 2008-08-27 675 return 0;
576c352e89e57c arch/sparc64/kernel/sbus.c David S. Miller 2006-06-23 676 }
046e26a8ba10b8 arch/sparc64/kernel/sbus.c David S. Miller 2008-08-27 677
:::::: The code at line 669 was first introduced by commit
:::::: cd4cd7306a403f62ef3ca783b9d1cf2a03e595ed sparc: remove references to of_device and to_of_device
:::::: TO: Grant Likely <grant.likely@secretlab.ca>
:::::: CC: Grant Likely <grant.likely@secretlab.ca>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 19174 bytes --]
^ permalink raw reply [flat|nested] 25+ messages in thread* Re: [PATCH v2] of_device: removed #include that caused a recursion in included headers
@ 2020-04-20 6:39 ` kbuild test robot
0 siblings, 0 replies; 25+ messages in thread
From: kbuild test robot @ 2020-04-20 6:39 UTC (permalink / raw)
To: Hadar Gat, David S. Miller, Greg Kroah-Hartman, Shawn Guo,
Sascha Hauer, Liviu Dudau, Sudeep Holla, Lorenzo Pieralisi,
Michael Turquette, Stephen Boyd, Matthias Brugger,
Ludovic Desroches, Vinod Koul, Maxime Coquelin, Alexandre Torgue,
Rob Clark, Sean Paul, David Airlie, Daniel Vetter, Sandy Huang,
Heiko Stübner, Maxime Ripard, Chen-Yu Tsai,
Jonathan Cameron, Thierry Reding, Joerg Roedel, Jonathan Hunter,
Nicolas Ferre, Alexandre Belloni, Tony Lindgren, Lee Jones,
Andy Gross, Bjorn Andersson, Miquel Raynal, Richard Weinberger,
Vignesh Raghavendra, Giuseppe Cavallaro, Jose Abreu, JC Kuo,
Kishon Vijay Abraham I, Dong Aisheng, Fabio Estevam,
Stefan Agner, Linus Walleij, Kukjin Kim, Krzysztof Kozlowski,
Rob Herring, Frank Rowand, linux-iio, dri-devel, linux-mtd,
sparclinux, linux-stm32, linux-samsung-soc, linux-clk,
linux-rockchip, devicetree, linux-arm-msm, linux-gpio,
linux-mediatek, linux-tegra, linux-omap, linux-arm-kernel,
Ofir Drang, Gilad Ben-Yossef, netdev, linux-kernel, iommu,
dmaengine, freedreno
Cc: linux-samsung-soc, kbuild-all, linux-iio, netdev, dri-devel,
linux-clk, linux-rockchip, linux-mtd, Hadar Gat, sparclinux,
linux-stm32
[-- Attachment #1: Type: text/plain, Size: 6046 bytes --]
Hi Hadar,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on stm32/stm32-next]
[also build test ERROR on sunxi/sunxi/for-next linus/master v5.7-rc1 next-20200416]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Hadar-Gat/of_device-removed-include-that-caused-a-recursion-in-included-headers/20200417-155422
base: https://git.kernel.org/pub/scm/linux/kernel/git/atorgue/stm32.git stm32-next
config: sparc64-defconfig (attached as .config)
compiler: sparc64-linux-gcc (GCC) 9.3.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day GCC_VERSION=9.3.0 make.cross ARCH=sparc64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
arch/sparc/kernel/sbus.c: In function 'sbus_init':
>> arch/sparc/kernel/sbus.c:669:32: error: implicit declaration of function 'of_find_device_by_node'; did you mean 'bus_find_device_by_fwnode'? [-Werror=implicit-function-declaration]
669 | struct platform_device *op = of_find_device_by_node(dp);
| ^~~~~~~~~~~~~~~~~~~~~~
| bus_find_device_by_fwnode
>> arch/sparc/kernel/sbus.c:669:32: error: initialization of 'struct platform_device *' from 'int' makes pointer from integer without a cast [-Werror=int-conversion]
cc1: all warnings being treated as errors
--
arch/sparc/kernel/pci.c: In function 'of_create_pci_dev':
>> arch/sparc/kernel/pci.c:276:7: error: implicit declaration of function 'of_find_device_by_node'; did you mean 'bus_find_device_by_fwnode'? [-Werror=implicit-function-declaration]
276 | op = of_find_device_by_node(node);
| ^~~~~~~~~~~~~~~~~~~~~~
| bus_find_device_by_fwnode
>> arch/sparc/kernel/pci.c:276:5: error: assignment to 'struct platform_device *' from 'int' makes pointer from integer without a cast [-Werror=int-conversion]
276 | op = of_find_device_by_node(node);
| ^
cc1: all warnings being treated as errors
--
arch/sparc/kernel/pci_sabre.c: In function 'sabre_register_error_handlers':
>> arch/sparc/kernel/pci_sabre.c:324:7: error: implicit declaration of function 'of_find_device_by_node'; did you mean 'bus_find_device_by_fwnode'? [-Werror=implicit-function-declaration]
324 | op = of_find_device_by_node(dp);
| ^~~~~~~~~~~~~~~~~~~~~~
| bus_find_device_by_fwnode
arch/sparc/kernel/pci_sabre.c:324:5: error: assignment to 'struct platform_device *' from 'int' makes pointer from integer without a cast [-Werror=int-conversion]
324 | op = of_find_device_by_node(dp);
| ^
cc1: all warnings being treated as errors
--
arch/sparc/kernel/pci_schizo.c: In function 'tomatillo_register_error_handlers':
>> arch/sparc/kernel/pci_schizo.c:850:31: error: implicit declaration of function 'of_find_device_by_node'; did you mean 'bus_find_device_by_fwnode'? [-Werror=implicit-function-declaration]
850 | struct platform_device *op = of_find_device_by_node(pbm->op->dev.of_node);
| ^~~~~~~~~~~~~~~~~~~~~~
| bus_find_device_by_fwnode
arch/sparc/kernel/pci_schizo.c:850:31: error: initialization of 'struct platform_device *' from 'int' makes pointer from integer without a cast [-Werror=int-conversion]
arch/sparc/kernel/pci_schizo.c: In function 'schizo_register_error_handlers':
arch/sparc/kernel/pci_schizo.c:945:31: error: initialization of 'struct platform_device *' from 'int' makes pointer from integer without a cast [-Werror=int-conversion]
945 | struct platform_device *op = of_find_device_by_node(pbm->op->dev.of_node);
| ^~~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
vim +669 arch/sparc/kernel/sbus.c
8fae097debdf8a arch/sparc64/kernel/sbus.c David S. Miller 2006-06-20 663
046e26a8ba10b8 arch/sparc64/kernel/sbus.c David S. Miller 2008-08-27 664 static int __init sbus_init(void)
576c352e89e57c arch/sparc64/kernel/sbus.c David S. Miller 2006-06-23 665 {
046e26a8ba10b8 arch/sparc64/kernel/sbus.c David S. Miller 2008-08-27 666 struct device_node *dp;
046e26a8ba10b8 arch/sparc64/kernel/sbus.c David S. Miller 2008-08-27 667
046e26a8ba10b8 arch/sparc64/kernel/sbus.c David S. Miller 2008-08-27 668 for_each_node_by_name(dp, "sbus") {
cd4cd7306a403f arch/sparc/kernel/sbus.c Grant Likely 2010-07-22 @669 struct platform_device *op = of_find_device_by_node(dp);
046e26a8ba10b8 arch/sparc64/kernel/sbus.c David S. Miller 2008-08-27 670
046e26a8ba10b8 arch/sparc64/kernel/sbus.c David S. Miller 2008-08-27 671 sbus_iommu_init(op);
046e26a8ba10b8 arch/sparc64/kernel/sbus.c David S. Miller 2008-08-27 672 of_propagate_archdata(op);
046e26a8ba10b8 arch/sparc64/kernel/sbus.c David S. Miller 2008-08-27 673 }
576c352e89e57c arch/sparc64/kernel/sbus.c David S. Miller 2006-06-23 674
046e26a8ba10b8 arch/sparc64/kernel/sbus.c David S. Miller 2008-08-27 675 return 0;
576c352e89e57c arch/sparc64/kernel/sbus.c David S. Miller 2006-06-23 676 }
046e26a8ba10b8 arch/sparc64/kernel/sbus.c David S. Miller 2008-08-27 677
:::::: The code at line 669 was first introduced by commit
:::::: cd4cd7306a403f62ef3ca783b9d1cf2a03e595ed sparc: remove references to of_device and to_of_device
:::::: TO: Grant Likely <grant.likely@secretlab.ca>
:::::: CC: Grant Likely <grant.likely@secretlab.ca>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 19174 bytes --]
[-- Attachment #3: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 25+ messages in thread* Re: [PATCH v2] of_device: removed #include that caused a recursion in included headers
@ 2020-04-20 6:39 ` kbuild test robot
0 siblings, 0 replies; 25+ messages in thread
From: kbuild test robot @ 2020-04-20 6:39 UTC (permalink / raw)
To: Hadar Gat, David S. Miller, Greg Kroah-Hartman, Shawn Guo,
Sascha Hauer, Liviu Dudau, Sudeep Holla, Lorenzo Pieralisi,
Michael Turquette, Stephen Boyd, Matthias Brugger,
Ludovic Desroches, Vinod Koul, Maxime Coquelin, Alexandre Torgue,
Rob Clark, Sean Paul, David Airlie, Daniel Vetter, Sandy Huang,
Heiko Stübner, Maxime Ripard, Chen-Yu Tsai,
Jonathan Cameron, Thierry Reding, Joerg Roedel, Jonathan Hunter,
Nicolas Ferre, Alexandre Belloni, Tony Lindgren, Lee Jones,
Andy Gross, Bjorn Andersson, Miquel Raynal, Richard Weinberger,
Vignesh Raghavendra, Giuseppe Cavallaro, Jose Abreu, JC Kuo,
Kishon Vijay Abraham I, Dong Aisheng, Fabio Estevam,
Stefan Agner, Linus Walleij, Kukjin Kim, Krzysztof Kozlowski,
Rob Herring, Frank Rowand, linux-iio, dri-devel, linux-mtd,
sparclinux, linux-stm32, linux-samsung-soc, linux-clk,
linux-rockchip, devicetree, linux-arm-msm, linux-gpio,
linux-mediatek, linux-tegra, linux-omap, linux-arm-kernel,
Ofir Drang, Gilad Ben-Yossef, netdev, linux-kernel, iommu,
dmaengine, freedreno
Cc: linux-samsung-soc, kbuild-all, linux-iio, netdev, dri-devel,
linux-clk, linux-rockchip, linux-mtd, Hadar Gat, sparclinux,
linux-stm32
[-- Attachment #1: Type: text/plain, Size: 6046 bytes --]
Hi Hadar,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on stm32/stm32-next]
[also build test ERROR on sunxi/sunxi/for-next linus/master v5.7-rc1 next-20200416]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Hadar-Gat/of_device-removed-include-that-caused-a-recursion-in-included-headers/20200417-155422
base: https://git.kernel.org/pub/scm/linux/kernel/git/atorgue/stm32.git stm32-next
config: sparc64-defconfig (attached as .config)
compiler: sparc64-linux-gcc (GCC) 9.3.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day GCC_VERSION=9.3.0 make.cross ARCH=sparc64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
arch/sparc/kernel/sbus.c: In function 'sbus_init':
>> arch/sparc/kernel/sbus.c:669:32: error: implicit declaration of function 'of_find_device_by_node'; did you mean 'bus_find_device_by_fwnode'? [-Werror=implicit-function-declaration]
669 | struct platform_device *op = of_find_device_by_node(dp);
| ^~~~~~~~~~~~~~~~~~~~~~
| bus_find_device_by_fwnode
>> arch/sparc/kernel/sbus.c:669:32: error: initialization of 'struct platform_device *' from 'int' makes pointer from integer without a cast [-Werror=int-conversion]
cc1: all warnings being treated as errors
--
arch/sparc/kernel/pci.c: In function 'of_create_pci_dev':
>> arch/sparc/kernel/pci.c:276:7: error: implicit declaration of function 'of_find_device_by_node'; did you mean 'bus_find_device_by_fwnode'? [-Werror=implicit-function-declaration]
276 | op = of_find_device_by_node(node);
| ^~~~~~~~~~~~~~~~~~~~~~
| bus_find_device_by_fwnode
>> arch/sparc/kernel/pci.c:276:5: error: assignment to 'struct platform_device *' from 'int' makes pointer from integer without a cast [-Werror=int-conversion]
276 | op = of_find_device_by_node(node);
| ^
cc1: all warnings being treated as errors
--
arch/sparc/kernel/pci_sabre.c: In function 'sabre_register_error_handlers':
>> arch/sparc/kernel/pci_sabre.c:324:7: error: implicit declaration of function 'of_find_device_by_node'; did you mean 'bus_find_device_by_fwnode'? [-Werror=implicit-function-declaration]
324 | op = of_find_device_by_node(dp);
| ^~~~~~~~~~~~~~~~~~~~~~
| bus_find_device_by_fwnode
arch/sparc/kernel/pci_sabre.c:324:5: error: assignment to 'struct platform_device *' from 'int' makes pointer from integer without a cast [-Werror=int-conversion]
324 | op = of_find_device_by_node(dp);
| ^
cc1: all warnings being treated as errors
--
arch/sparc/kernel/pci_schizo.c: In function 'tomatillo_register_error_handlers':
>> arch/sparc/kernel/pci_schizo.c:850:31: error: implicit declaration of function 'of_find_device_by_node'; did you mean 'bus_find_device_by_fwnode'? [-Werror=implicit-function-declaration]
850 | struct platform_device *op = of_find_device_by_node(pbm->op->dev.of_node);
| ^~~~~~~~~~~~~~~~~~~~~~
| bus_find_device_by_fwnode
arch/sparc/kernel/pci_schizo.c:850:31: error: initialization of 'struct platform_device *' from 'int' makes pointer from integer without a cast [-Werror=int-conversion]
arch/sparc/kernel/pci_schizo.c: In function 'schizo_register_error_handlers':
arch/sparc/kernel/pci_schizo.c:945:31: error: initialization of 'struct platform_device *' from 'int' makes pointer from integer without a cast [-Werror=int-conversion]
945 | struct platform_device *op = of_find_device_by_node(pbm->op->dev.of_node);
| ^~~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
vim +669 arch/sparc/kernel/sbus.c
8fae097debdf8a arch/sparc64/kernel/sbus.c David S. Miller 2006-06-20 663
046e26a8ba10b8 arch/sparc64/kernel/sbus.c David S. Miller 2008-08-27 664 static int __init sbus_init(void)
576c352e89e57c arch/sparc64/kernel/sbus.c David S. Miller 2006-06-23 665 {
046e26a8ba10b8 arch/sparc64/kernel/sbus.c David S. Miller 2008-08-27 666 struct device_node *dp;
046e26a8ba10b8 arch/sparc64/kernel/sbus.c David S. Miller 2008-08-27 667
046e26a8ba10b8 arch/sparc64/kernel/sbus.c David S. Miller 2008-08-27 668 for_each_node_by_name(dp, "sbus") {
cd4cd7306a403f arch/sparc/kernel/sbus.c Grant Likely 2010-07-22 @669 struct platform_device *op = of_find_device_by_node(dp);
046e26a8ba10b8 arch/sparc64/kernel/sbus.c David S. Miller 2008-08-27 670
046e26a8ba10b8 arch/sparc64/kernel/sbus.c David S. Miller 2008-08-27 671 sbus_iommu_init(op);
046e26a8ba10b8 arch/sparc64/kernel/sbus.c David S. Miller 2008-08-27 672 of_propagate_archdata(op);
046e26a8ba10b8 arch/sparc64/kernel/sbus.c David S. Miller 2008-08-27 673 }
576c352e89e57c arch/sparc64/kernel/sbus.c David S. Miller 2006-06-23 674
046e26a8ba10b8 arch/sparc64/kernel/sbus.c David S. Miller 2008-08-27 675 return 0;
576c352e89e57c arch/sparc64/kernel/sbus.c David S. Miller 2006-06-23 676 }
046e26a8ba10b8 arch/sparc64/kernel/sbus.c David S. Miller 2008-08-27 677
:::::: The code at line 669 was first introduced by commit
:::::: cd4cd7306a403f62ef3ca783b9d1cf2a03e595ed sparc: remove references to of_device and to_of_device
:::::: TO: Grant Likely <grant.likely@secretlab.ca>
:::::: CC: Grant Likely <grant.likely@secretlab.ca>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 19174 bytes --]
[-- Attachment #3: Type: text/plain, Size: 170 bytes --]
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 25+ messages in thread* Re: [PATCH v2] of_device: removed #include that caused a recursion in included headers
@ 2020-04-20 6:39 ` kbuild test robot
0 siblings, 0 replies; 25+ messages in thread
From: kbuild test robot @ 2020-04-20 6:39 UTC (permalink / raw)
To: Hadar Gat, David S. Miller, Greg Kroah-Hartman, Shawn Guo,
Sascha Hauer, Liviu Dudau, Sudeep Holla, Lorenzo Pieralisi,
Michael Turquette, Stephen Boyd, Matthias Brugger,
Ludovic Desroches, Vinod Koul, Maxime Coquelin, Alexandre Torgue,
Rob Clark, Sean Paul, David Airlie, Daniel Vetter, Sandy Huang,
Heiko Stübner, Maxime Ripard, Chen-Yu Tsai,
Jonathan Cameron, Thierry Reding, Joerg Roedel, Jonathan Hunter,
Nicolas Ferre, Alexandre Belloni, Tony Lindgren, Lee Jones,
Andy Gross, Bjorn Andersson, Miquel Raynal, Richard Weinberger,
Vignesh Raghavendra, Giuseppe Cavallaro, Jose Abreu, JC Kuo,
Kishon Vijay Abraham I, Dong Aisheng, Fabio Estevam,
Stefan Agner, Linus Walleij, Kukjin Kim, Krzysztof Kozlowski,
Rob Herring, Frank Rowand, linux-iio, dri-devel, linux-mtd,
sparclinux, linux-stm32, linux-samsung-soc, linux-clk,
linux-rockchip, devicetree, linux-arm-msm, linux-gpio,
linux-mediatek, linux-tegra, linux-omap, linux-arm-kernel,
Ofir Drang, Gilad Ben-Yossef, netdev, linux-kernel, iommu,
dmaengine, freedreno
Cc: linux-samsung-soc, kbuild-all, linux-iio, netdev, dri-devel,
linux-clk, linux-rockchip, linux-mtd, Hadar Gat, sparclinux,
linux-stm32
[-- Attachment #1: Type: text/plain, Size: 6046 bytes --]
Hi Hadar,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on stm32/stm32-next]
[also build test ERROR on sunxi/sunxi/for-next linus/master v5.7-rc1 next-20200416]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Hadar-Gat/of_device-removed-include-that-caused-a-recursion-in-included-headers/20200417-155422
base: https://git.kernel.org/pub/scm/linux/kernel/git/atorgue/stm32.git stm32-next
config: sparc64-defconfig (attached as .config)
compiler: sparc64-linux-gcc (GCC) 9.3.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day GCC_VERSION=9.3.0 make.cross ARCH=sparc64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
arch/sparc/kernel/sbus.c: In function 'sbus_init':
>> arch/sparc/kernel/sbus.c:669:32: error: implicit declaration of function 'of_find_device_by_node'; did you mean 'bus_find_device_by_fwnode'? [-Werror=implicit-function-declaration]
669 | struct platform_device *op = of_find_device_by_node(dp);
| ^~~~~~~~~~~~~~~~~~~~~~
| bus_find_device_by_fwnode
>> arch/sparc/kernel/sbus.c:669:32: error: initialization of 'struct platform_device *' from 'int' makes pointer from integer without a cast [-Werror=int-conversion]
cc1: all warnings being treated as errors
--
arch/sparc/kernel/pci.c: In function 'of_create_pci_dev':
>> arch/sparc/kernel/pci.c:276:7: error: implicit declaration of function 'of_find_device_by_node'; did you mean 'bus_find_device_by_fwnode'? [-Werror=implicit-function-declaration]
276 | op = of_find_device_by_node(node);
| ^~~~~~~~~~~~~~~~~~~~~~
| bus_find_device_by_fwnode
>> arch/sparc/kernel/pci.c:276:5: error: assignment to 'struct platform_device *' from 'int' makes pointer from integer without a cast [-Werror=int-conversion]
276 | op = of_find_device_by_node(node);
| ^
cc1: all warnings being treated as errors
--
arch/sparc/kernel/pci_sabre.c: In function 'sabre_register_error_handlers':
>> arch/sparc/kernel/pci_sabre.c:324:7: error: implicit declaration of function 'of_find_device_by_node'; did you mean 'bus_find_device_by_fwnode'? [-Werror=implicit-function-declaration]
324 | op = of_find_device_by_node(dp);
| ^~~~~~~~~~~~~~~~~~~~~~
| bus_find_device_by_fwnode
arch/sparc/kernel/pci_sabre.c:324:5: error: assignment to 'struct platform_device *' from 'int' makes pointer from integer without a cast [-Werror=int-conversion]
324 | op = of_find_device_by_node(dp);
| ^
cc1: all warnings being treated as errors
--
arch/sparc/kernel/pci_schizo.c: In function 'tomatillo_register_error_handlers':
>> arch/sparc/kernel/pci_schizo.c:850:31: error: implicit declaration of function 'of_find_device_by_node'; did you mean 'bus_find_device_by_fwnode'? [-Werror=implicit-function-declaration]
850 | struct platform_device *op = of_find_device_by_node(pbm->op->dev.of_node);
| ^~~~~~~~~~~~~~~~~~~~~~
| bus_find_device_by_fwnode
arch/sparc/kernel/pci_schizo.c:850:31: error: initialization of 'struct platform_device *' from 'int' makes pointer from integer without a cast [-Werror=int-conversion]
arch/sparc/kernel/pci_schizo.c: In function 'schizo_register_error_handlers':
arch/sparc/kernel/pci_schizo.c:945:31: error: initialization of 'struct platform_device *' from 'int' makes pointer from integer without a cast [-Werror=int-conversion]
945 | struct platform_device *op = of_find_device_by_node(pbm->op->dev.of_node);
| ^~~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
vim +669 arch/sparc/kernel/sbus.c
8fae097debdf8a arch/sparc64/kernel/sbus.c David S. Miller 2006-06-20 663
046e26a8ba10b8 arch/sparc64/kernel/sbus.c David S. Miller 2008-08-27 664 static int __init sbus_init(void)
576c352e89e57c arch/sparc64/kernel/sbus.c David S. Miller 2006-06-23 665 {
046e26a8ba10b8 arch/sparc64/kernel/sbus.c David S. Miller 2008-08-27 666 struct device_node *dp;
046e26a8ba10b8 arch/sparc64/kernel/sbus.c David S. Miller 2008-08-27 667
046e26a8ba10b8 arch/sparc64/kernel/sbus.c David S. Miller 2008-08-27 668 for_each_node_by_name(dp, "sbus") {
cd4cd7306a403f arch/sparc/kernel/sbus.c Grant Likely 2010-07-22 @669 struct platform_device *op = of_find_device_by_node(dp);
046e26a8ba10b8 arch/sparc64/kernel/sbus.c David S. Miller 2008-08-27 670
046e26a8ba10b8 arch/sparc64/kernel/sbus.c David S. Miller 2008-08-27 671 sbus_iommu_init(op);
046e26a8ba10b8 arch/sparc64/kernel/sbus.c David S. Miller 2008-08-27 672 of_propagate_archdata(op);
046e26a8ba10b8 arch/sparc64/kernel/sbus.c David S. Miller 2008-08-27 673 }
576c352e89e57c arch/sparc64/kernel/sbus.c David S. Miller 2006-06-23 674
046e26a8ba10b8 arch/sparc64/kernel/sbus.c David S. Miller 2008-08-27 675 return 0;
576c352e89e57c arch/sparc64/kernel/sbus.c David S. Miller 2006-06-23 676 }
046e26a8ba10b8 arch/sparc64/kernel/sbus.c David S. Miller 2008-08-27 677
:::::: The code at line 669 was first introduced by commit
:::::: cd4cd7306a403f62ef3ca783b9d1cf2a03e595ed sparc: remove references to of_device and to_of_device
:::::: TO: Grant Likely <grant.likely@secretlab.ca>
:::::: CC: Grant Likely <grant.likely@secretlab.ca>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 19174 bytes --]
[-- Attachment #3: Type: text/plain, Size: 156 bytes --]
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
^ permalink raw reply [flat|nested] 25+ messages in thread* Re: [PATCH v2] of_device: removed #include that caused a recursion in included headers
@ 2020-04-20 6:39 ` kbuild test robot
0 siblings, 0 replies; 25+ messages in thread
From: kbuild test robot @ 2020-04-20 6:39 UTC (permalink / raw)
To: David S. Miller, Greg Kroah-Hartman, Shawn Guo, Sascha Hauer,
Liviu Dudau, Sudeep Holla, Lorenzo Pieralisi, Michael Turquette,
Stephen Boyd, Matthias Brugger, Ludovic Desroches, Vinod Koul,
Maxime Coquelin, Alexandre Torgue, Rob Clark, Sean Paul,
David Airlie, Daniel Vetter, Sandy Huang, Heiko Stübner,
Maxime Ripard, Chen-Yu Tsai
Cc: linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA,
kbuild-all-hn68Rpc1hR1g9hUCZPvPmw,
linux-iio-u79uwXL29TY76Z2rM5mHXA, netdev-u79uwXL29TY76Z2rM5mHXA,
dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
linux-clk-u79uwXL29TY76Z2rM5mHXA,
linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Hadar Gat,
sparclinux-u79uwXL29TY76Z2rM5mHXA,
linux-stm32-XDFAJ8BFU24N7RejjzZ/Li2xQDfSxrLKVpNB7YpNyf8
[-- Attachment #1: Type: text/plain, Size: 6157 bytes --]
Hi Hadar,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on stm32/stm32-next]
[also build test ERROR on sunxi/sunxi/for-next linus/master v5.7-rc1 next-20200416]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Hadar-Gat/of_device-removed-include-that-caused-a-recursion-in-included-headers/20200417-155422
base: https://git.kernel.org/pub/scm/linux/kernel/git/atorgue/stm32.git stm32-next
config: sparc64-defconfig (attached as .config)
compiler: sparc64-linux-gcc (GCC) 9.3.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day GCC_VERSION=9.3.0 make.cross ARCH=sparc64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
All errors (new ones prefixed by >>):
arch/sparc/kernel/sbus.c: In function 'sbus_init':
>> arch/sparc/kernel/sbus.c:669:32: error: implicit declaration of function 'of_find_device_by_node'; did you mean 'bus_find_device_by_fwnode'? [-Werror=implicit-function-declaration]
669 | struct platform_device *op = of_find_device_by_node(dp);
| ^~~~~~~~~~~~~~~~~~~~~~
| bus_find_device_by_fwnode
>> arch/sparc/kernel/sbus.c:669:32: error: initialization of 'struct platform_device *' from 'int' makes pointer from integer without a cast [-Werror=int-conversion]
cc1: all warnings being treated as errors
--
arch/sparc/kernel/pci.c: In function 'of_create_pci_dev':
>> arch/sparc/kernel/pci.c:276:7: error: implicit declaration of function 'of_find_device_by_node'; did you mean 'bus_find_device_by_fwnode'? [-Werror=implicit-function-declaration]
276 | op = of_find_device_by_node(node);
| ^~~~~~~~~~~~~~~~~~~~~~
| bus_find_device_by_fwnode
>> arch/sparc/kernel/pci.c:276:5: error: assignment to 'struct platform_device *' from 'int' makes pointer from integer without a cast [-Werror=int-conversion]
276 | op = of_find_device_by_node(node);
| ^
cc1: all warnings being treated as errors
--
arch/sparc/kernel/pci_sabre.c: In function 'sabre_register_error_handlers':
>> arch/sparc/kernel/pci_sabre.c:324:7: error: implicit declaration of function 'of_find_device_by_node'; did you mean 'bus_find_device_by_fwnode'? [-Werror=implicit-function-declaration]
324 | op = of_find_device_by_node(dp);
| ^~~~~~~~~~~~~~~~~~~~~~
| bus_find_device_by_fwnode
arch/sparc/kernel/pci_sabre.c:324:5: error: assignment to 'struct platform_device *' from 'int' makes pointer from integer without a cast [-Werror=int-conversion]
324 | op = of_find_device_by_node(dp);
| ^
cc1: all warnings being treated as errors
--
arch/sparc/kernel/pci_schizo.c: In function 'tomatillo_register_error_handlers':
>> arch/sparc/kernel/pci_schizo.c:850:31: error: implicit declaration of function 'of_find_device_by_node'; did you mean 'bus_find_device_by_fwnode'? [-Werror=implicit-function-declaration]
850 | struct platform_device *op = of_find_device_by_node(pbm->op->dev.of_node);
| ^~~~~~~~~~~~~~~~~~~~~~
| bus_find_device_by_fwnode
arch/sparc/kernel/pci_schizo.c:850:31: error: initialization of 'struct platform_device *' from 'int' makes pointer from integer without a cast [-Werror=int-conversion]
arch/sparc/kernel/pci_schizo.c: In function 'schizo_register_error_handlers':
arch/sparc/kernel/pci_schizo.c:945:31: error: initialization of 'struct platform_device *' from 'int' makes pointer from integer without a cast [-Werror=int-conversion]
945 | struct platform_device *op = of_find_device_by_node(pbm->op->dev.of_node);
| ^~~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
vim +669 arch/sparc/kernel/sbus.c
8fae097debdf8a arch/sparc64/kernel/sbus.c David S. Miller 2006-06-20 663
046e26a8ba10b8 arch/sparc64/kernel/sbus.c David S. Miller 2008-08-27 664 static int __init sbus_init(void)
576c352e89e57c arch/sparc64/kernel/sbus.c David S. Miller 2006-06-23 665 {
046e26a8ba10b8 arch/sparc64/kernel/sbus.c David S. Miller 2008-08-27 666 struct device_node *dp;
046e26a8ba10b8 arch/sparc64/kernel/sbus.c David S. Miller 2008-08-27 667
046e26a8ba10b8 arch/sparc64/kernel/sbus.c David S. Miller 2008-08-27 668 for_each_node_by_name(dp, "sbus") {
cd4cd7306a403f arch/sparc/kernel/sbus.c Grant Likely 2010-07-22 @669 struct platform_device *op = of_find_device_by_node(dp);
046e26a8ba10b8 arch/sparc64/kernel/sbus.c David S. Miller 2008-08-27 670
046e26a8ba10b8 arch/sparc64/kernel/sbus.c David S. Miller 2008-08-27 671 sbus_iommu_init(op);
046e26a8ba10b8 arch/sparc64/kernel/sbus.c David S. Miller 2008-08-27 672 of_propagate_archdata(op);
046e26a8ba10b8 arch/sparc64/kernel/sbus.c David S. Miller 2008-08-27 673 }
576c352e89e57c arch/sparc64/kernel/sbus.c David S. Miller 2006-06-23 674
046e26a8ba10b8 arch/sparc64/kernel/sbus.c David S. Miller 2008-08-27 675 return 0;
576c352e89e57c arch/sparc64/kernel/sbus.c David S. Miller 2006-06-23 676 }
046e26a8ba10b8 arch/sparc64/kernel/sbus.c David S. Miller 2008-08-27 677
:::::: The code at line 669 was first introduced by commit
:::::: cd4cd7306a403f62ef3ca783b9d1cf2a03e595ed sparc: remove references to of_device and to_of_device
:::::: TO: Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>
:::::: CC: Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 19174 bytes --]
[-- Attachment #3: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply [flat|nested] 25+ messages in thread