* [PATCH v2] mm/memory: remove unnecessary pte_devmap case in copy_one_pte()
@ 2020-04-20 2:28 qiwuchen55
2020-04-20 15:08 ` Michal Hocko
0 siblings, 1 reply; 2+ messages in thread
From: qiwuchen55 @ 2020-04-20 2:28 UTC (permalink / raw)
To: akpm, willy; +Cc: linux-mm, chenqiwu
From: chenqiwu <chenqiwu@xiaomi.com>
Since commit 25b2995a35b6 ("mm: remove MEMORY_DEVICE_PUBLIC support"),
the assignment to 'page' for pte_devmap case has been unnecessary.
Let's remove it.
Signed-off-by: chenqiwu <chenqiwu@xiaomi.com>
---
Change in v2:
- According to Matthew's suggestion, update commit title and message.
mm/memory.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/mm/memory.c b/mm/memory.c
index f703fe8..2143827 100644
--- a/mm/memory.c
+++ b/mm/memory.c
@@ -802,8 +802,6 @@ struct page *vm_normal_page_pmd(struct vm_area_struct *vma, unsigned long addr,
get_page(page);
page_dup_rmap(page, false);
rss[mm_counter(page)]++;
- } else if (pte_devmap(pte)) {
- page = pte_page(pte);
}
out_set_pte:
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] mm/memory: remove unnecessary pte_devmap case in copy_one_pte()
2020-04-20 2:28 [PATCH v2] mm/memory: remove unnecessary pte_devmap case in copy_one_pte() qiwuchen55
@ 2020-04-20 15:08 ` Michal Hocko
0 siblings, 0 replies; 2+ messages in thread
From: Michal Hocko @ 2020-04-20 15:08 UTC (permalink / raw)
To: qiwuchen55; +Cc: akpm, willy, linux-mm, chenqiwu
It would ve great to keep the cc list if reposting.
On Mon 20-04-20 10:28:05, qiwuchen55@gmail.com wrote:
> From: chenqiwu <chenqiwu@xiaomi.com>
>
> Since commit 25b2995a35b6 ("mm: remove MEMORY_DEVICE_PUBLIC support"),
> the assignment to 'page' for pte_devmap case has been unnecessary.
> Let's remove it.
>
And also
[willy@infradead.org - changelog]
> Signed-off-by: chenqiwu <chenqiwu@xiaomi.com>
Acked-by: Michal Hocko <mhocko@suse.com>
> ---
> Change in v2:
> - According to Matthew's suggestion, update commit title and message.
> mm/memory.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/mm/memory.c b/mm/memory.c
> index f703fe8..2143827 100644
> --- a/mm/memory.c
> +++ b/mm/memory.c
> @@ -802,8 +802,6 @@ struct page *vm_normal_page_pmd(struct vm_area_struct *vma, unsigned long addr,
> get_page(page);
> page_dup_rmap(page, false);
> rss[mm_counter(page)]++;
> - } else if (pte_devmap(pte)) {
> - page = pte_page(pte);
> }
>
> out_set_pte:
> --
> 1.9.1
>
--
Michal Hocko
SUSE Labs
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-04-20 15:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-20 2:28 [PATCH v2] mm/memory: remove unnecessary pte_devmap case in copy_one_pte() qiwuchen55
2020-04-20 15:08 ` Michal Hocko
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.