From: "Theodore Y. Ts'o" <tytso@mit.edu>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Andreas Dilger <adilger.kernel@dilger.ca>,
linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-api@vger.kernel.org, qemu-devel@nongnu.org,
Florian Weimer <fw@deneb.enyo.de>,
Peter Maydell <peter.maydell@linaro.org>,
Andy Lutomirski <luto@kernel.org>
Subject: Re: [PATCH] fcntl: Add 32bit filesystem mode
Date: Mon, 20 Apr 2020 11:13:44 -0400 [thread overview]
Message-ID: <20200420151344.GC1080594@mit.edu> (raw)
In-Reply-To: <20200331133536.3328-1-linus.walleij@linaro.org>
On Tue, Mar 31, 2020 at 03:35:36PM +0200, Linus Walleij wrote:
> It was brought to my attention that this bug from 2018 was
> still unresolved: 32 bit emulators like QEMU were given
> 64 bit hashes when running 32 bit emulation on 64 bit systems.
>
> This adds a fcntl() operation to set the underlying filesystem
> into 32bit mode even if the file hanle was opened using 64bit
> mode without the compat syscalls.
s/hanle/handle/
The API that you've proposed as a way to set the 32-bit mode, but
there is no way to clear the 32-bit mode, nor there is a way to get
the current status mode.
My suggestion is to add a flag bit for F_GETFD and F_SETFD (set and
get file descriptor flags). Currently the only file descriptor flag
is FD_CLOEXEC, so why not add a FD_32BIT_MODE bit?
Cheers,
- Ted
WARNING: multiple messages have this Message-ID (diff)
From: "Theodore Y. Ts'o" <tytso@mit.edu>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Peter Maydell <peter.maydell@linaro.org>,
linux-api@vger.kernel.org, qemu-devel@nongnu.org,
Florian Weimer <fw@deneb.enyo.de>,
Andreas Dilger <adilger.kernel@dilger.ca>,
Andy Lutomirski <luto@kernel.org>,
linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org
Subject: Re: [PATCH] fcntl: Add 32bit filesystem mode
Date: Mon, 20 Apr 2020 11:13:44 -0400 [thread overview]
Message-ID: <20200420151344.GC1080594@mit.edu> (raw)
In-Reply-To: <20200331133536.3328-1-linus.walleij@linaro.org>
On Tue, Mar 31, 2020 at 03:35:36PM +0200, Linus Walleij wrote:
> It was brought to my attention that this bug from 2018 was
> still unresolved: 32 bit emulators like QEMU were given
> 64 bit hashes when running 32 bit emulation on 64 bit systems.
>
> This adds a fcntl() operation to set the underlying filesystem
> into 32bit mode even if the file hanle was opened using 64bit
> mode without the compat syscalls.
s/hanle/handle/
The API that you've proposed as a way to set the 32-bit mode, but
there is no way to clear the 32-bit mode, nor there is a way to get
the current status mode.
My suggestion is to add a flag bit for F_GETFD and F_SETFD (set and
get file descriptor flags). Currently the only file descriptor flag
is FD_CLOEXEC, so why not add a FD_32BIT_MODE bit?
Cheers,
- Ted
next prev parent reply other threads:[~2020-04-20 15:14 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-31 13:35 [PATCH] fcntl: Add 32bit filesystem mode Linus Walleij
2020-03-31 13:35 ` Linus Walleij
2020-04-20 11:19 ` Peter Maydell
2020-04-20 11:19 ` Peter Maydell
2020-04-20 11:23 ` Florian Weimer
2020-04-20 11:23 ` Florian Weimer
2020-04-20 11:38 ` Peter Maydell
2020-04-20 11:38 ` Peter Maydell
2020-04-20 14:16 ` Peter Maydell
2020-04-20 14:16 ` Peter Maydell
2020-04-20 23:51 ` Andreas Dilger
2020-04-20 23:51 ` Andreas Dilger
2020-04-21 13:02 ` Peter Maydell
2020-04-21 13:02 ` Peter Maydell
2020-04-20 15:13 ` Theodore Y. Ts'o [this message]
2020-04-20 15:13 ` Theodore Y. Ts'o
2020-04-20 15:23 ` Eric Blake
2020-04-20 15:29 ` Peter Maydell
2020-04-20 15:29 ` Peter Maydell
2020-04-20 17:01 ` Theodore Y. Ts'o
2020-04-20 17:01 ` Theodore Y. Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200420151344.GC1080594@mit.edu \
--to=tytso@mit.edu \
--cc=adilger.kernel@dilger.ca \
--cc=fw@deneb.enyo.de \
--cc=linus.walleij@linaro.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.