All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/amdgpu: clean up unused variable about ring lru
@ 2020-04-20 15:27 Kevin Wang
  2020-04-20 15:45 ` Christian König
  0 siblings, 1 reply; 3+ messages in thread
From: Kevin Wang @ 2020-04-20 15:27 UTC (permalink / raw)
  To: amd-gfx; +Cc: Alexander.Deucher, Kevin Wang, christian.koenig

clean up unused variable:
1. ring_lru_list
2. ring_lru_list_lock

related-commit:
drm/amdgpu: remove ring lru handling

Signed-off-by: Kevin Wang <kevin1.wang@amd.com>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu.h        | 3 ---
 drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 3 ---
 2 files changed, 6 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu.h b/drivers/gpu/drm/amd/amdgpu/amdgpu.h
index 94dff899248d..e8ab3dde6a66 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu.h
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu.h
@@ -953,9 +953,6 @@ struct amdgpu_device {
 	/* link all shadow bo */
 	struct list_head                shadow_list;
 	struct mutex                    shadow_list_lock;
-	/* keep an lru list of rings by HW IP */
-	struct list_head		ring_lru_list;
-	spinlock_t			ring_lru_list_lock;
 
 	/* record hw reset is performed */
 	bool has_hw_reset;
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
index 71ea56e220ae..38eb736091d0 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
@@ -2990,9 +2990,6 @@ int amdgpu_device_init(struct amdgpu_device *adev,
 	INIT_LIST_HEAD(&adev->shadow_list);
 	mutex_init(&adev->shadow_list_lock);
 
-	INIT_LIST_HEAD(&adev->ring_lru_list);
-	spin_lock_init(&adev->ring_lru_list_lock);
-
 	INIT_DELAYED_WORK(&adev->delayed_init_work,
 			  amdgpu_device_delayed_init_work_handler);
 	INIT_DELAYED_WORK(&adev->gfx.gfx_off_delay_work,
-- 
2.26.1

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply related	[flat|nested] 3+ messages in thread
* Re: [PATCH] drm/amdgpu: clean up unused variable about ring lru
  2020-04-20 15:27 [PATCH] drm/amdgpu: clean up unused variable about ring lru Kevin Wang
@ 2020-04-20 15:45 ` Christian König
  2020-04-21  5:11   ` Wang, Kevin(Yang)
  0 siblings, 1 reply; 3+ messages in thread
From: Christian König @ 2020-04-20 15:45 UTC (permalink / raw)
  To: Kevin Wang, amd-gfx; +Cc: Alexander.Deucher, christian.koenig

Am 20.04.20 um 17:27 schrieb Kevin Wang:
> clean up unused variable:
> 1. ring_lru_list
> 2. ring_lru_list_lock
>
> related-commit:
> drm/amdgpu: remove ring lru handling
>
> Signed-off-by: Kevin Wang <kevin1.wang@amd.com>

Reviewed-by: Christian König <christian.koenig@amd.com>

Found by accident or used some tool? I'm asking because I'm pretty sure 
we have more like those.

Thanks,
Christian.

> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu.h        | 3 ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 3 ---
>   2 files changed, 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu.h b/drivers/gpu/drm/amd/amdgpu/amdgpu.h
> index 94dff899248d..e8ab3dde6a66 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu.h
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu.h
> @@ -953,9 +953,6 @@ struct amdgpu_device {
>   	/* link all shadow bo */
>   	struct list_head                shadow_list;
>   	struct mutex                    shadow_list_lock;
> -	/* keep an lru list of rings by HW IP */
> -	struct list_head		ring_lru_list;
> -	spinlock_t			ring_lru_list_lock;
>   
>   	/* record hw reset is performed */
>   	bool has_hw_reset;
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> index 71ea56e220ae..38eb736091d0 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> @@ -2990,9 +2990,6 @@ int amdgpu_device_init(struct amdgpu_device *adev,
>   	INIT_LIST_HEAD(&adev->shadow_list);
>   	mutex_init(&adev->shadow_list_lock);
>   
> -	INIT_LIST_HEAD(&adev->ring_lru_list);
> -	spin_lock_init(&adev->ring_lru_list_lock);
> -
>   	INIT_DELAYED_WORK(&adev->delayed_init_work,
>   			  amdgpu_device_delayed_init_work_handler);
>   	INIT_DELAYED_WORK(&adev->gfx.gfx_off_delay_work,

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: [PATCH] drm/amdgpu: clean up unused variable about ring lru
  2020-04-20 15:45 ` Christian König
@ 2020-04-21  5:11   ` Wang, Kevin(Yang)
  0 siblings, 0 replies; 3+ messages in thread
From: Wang, Kevin(Yang) @ 2020-04-21  5:11 UTC (permalink / raw)
  To: amd-gfx, Koenig,  Christian; +Cc: Deucher, Alexander


[-- Attachment #1.1: Type: text/plain, Size: 2567 bytes --]

[AMD Official Use Only - Internal Distribution Only]



________________________________
From: Christian König <ckoenig.leichtzumerken@gmail.com>
Sent: Monday, April 20, 2020 11:45 PM
To: Wang, Kevin(Yang) <Kevin1.Wang@amd.com>; amd-gfx@lists.freedesktop.org <amd-gfx@lists.freedesktop.org>
Cc: Deucher, Alexander <Alexander.Deucher@amd.com>; Koenig, Christian <Christian.Koenig@amd.com>
Subject: Re: [PATCH] drm/amdgpu: clean up unused variable about ring lru

Am 20.04.20 um 17:27 schrieb Kevin Wang:
> clean up unused variable:
> 1. ring_lru_list
> 2. ring_lru_list_lock
>
> related-commit:
> drm/amdgpu: remove ring lru handling
>
> Signed-off-by: Kevin Wang <kevin1.wang@amd.com>

Reviewed-by: Christian König <christian.koenig@amd.com>

Found by accident or used some tool? I'm asking because I'm pretty sure
we have more like those.

Thanks,
Christian.

[kevin]:
I found it when I read the driver source code, and then I looked at the git history.
no tools to help.

Best Regards,
Kevin


> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu.h        | 3 ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 3 ---
>   2 files changed, 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu.h b/drivers/gpu/drm/amd/amdgpu/amdgpu.h
> index 94dff899248d..e8ab3dde6a66 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu.h
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu.h
> @@ -953,9 +953,6 @@ struct amdgpu_device {
>        /* link all shadow bo */
>        struct list_head                shadow_list;
>        struct mutex                    shadow_list_lock;
> -     /* keep an lru list of rings by HW IP */
> -     struct list_head                ring_lru_list;
> -     spinlock_t                      ring_lru_list_lock;
>
>        /* record hw reset is performed */
>        bool has_hw_reset;
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> index 71ea56e220ae..38eb736091d0 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> @@ -2990,9 +2990,6 @@ int amdgpu_device_init(struct amdgpu_device *adev,
>        INIT_LIST_HEAD(&adev->shadow_list);
>        mutex_init(&adev->shadow_list_lock);
>
> -     INIT_LIST_HEAD(&adev->ring_lru_list);
> -     spin_lock_init(&adev->ring_lru_list_lock);
> -
>        INIT_DELAYED_WORK(&adev->delayed_init_work,
>                          amdgpu_device_delayed_init_work_handler);
>        INIT_DELAYED_WORK(&adev->gfx.gfx_off_delay_work,


[-- Attachment #1.2: Type: text/html, Size: 5188 bytes --]

[-- Attachment #2: Type: text/plain, Size: 154 bytes --]

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-04-21  5:11 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-20 15:27 [PATCH] drm/amdgpu: clean up unused variable about ring lru Kevin Wang
2020-04-20 15:45 ` Christian König
2020-04-21  5:11   ` Wang, Kevin(Yang)

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.