* [PATCH] mmc: renesas_sdhi: shorten types after refactorization
@ 2020-04-20 17:02 Wolfram Sang
2020-04-21 11:48 ` Niklas Söderlund
2020-04-22 16:03 ` Ulf Hansson
0 siblings, 2 replies; 3+ messages in thread
From: Wolfram Sang @ 2020-04-20 17:02 UTC (permalink / raw)
To: linux-mmc; +Cc: linux-renesas-soc, Wolfram Sang
After TAP refactorization, we can use 'unsigned int' for two more
variables because all the calculations work on this type now.
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
drivers/mmc/host/renesas_sdhi.h | 2 +-
drivers/mmc/host/renesas_sdhi_core.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/mmc/host/renesas_sdhi.h b/drivers/mmc/host/renesas_sdhi.h
index 12d8016672b0..86efa9d5cd6d 100644
--- a/drivers/mmc/host/renesas_sdhi.h
+++ b/drivers/mmc/host/renesas_sdhi.h
@@ -64,7 +64,7 @@ struct renesas_sdhi {
/* Sampling data comparison: 1 for match, 0 for mismatch */
DECLARE_BITMAP(smpcmp, BITS_PER_LONG);
unsigned int tap_num;
- unsigned long tap_set;
+ unsigned int tap_set;
};
#define host_to_priv(host) \
diff --git a/drivers/mmc/host/renesas_sdhi_core.c b/drivers/mmc/host/renesas_sdhi_core.c
index 1dfe6c32280b..28b0830c4251 100644
--- a/drivers/mmc/host/renesas_sdhi_core.c
+++ b/drivers/mmc/host/renesas_sdhi_core.c
@@ -527,7 +527,7 @@ static int renesas_sdhi_execute_tuning(struct tmio_mmc_host *host, u32 opcode)
static bool renesas_sdhi_manual_correction(struct tmio_mmc_host *host, bool use_4tap)
{
struct renesas_sdhi *priv = host_to_priv(host);
- unsigned long new_tap = priv->tap_set;
+ unsigned int new_tap = priv->tap_set;
u32 val;
val = sd_scc_read32(host, priv, SH_MOBILE_SDHI_SCC_RVSREQ);
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] mmc: renesas_sdhi: shorten types after refactorization
2020-04-20 17:02 [PATCH] mmc: renesas_sdhi: shorten types after refactorization Wolfram Sang
@ 2020-04-21 11:48 ` Niklas Söderlund
2020-04-22 16:03 ` Ulf Hansson
1 sibling, 0 replies; 3+ messages in thread
From: Niklas Söderlund @ 2020-04-21 11:48 UTC (permalink / raw)
To: Wolfram Sang; +Cc: linux-mmc, linux-renesas-soc
Hi Wolfram,
Thanks for your patch.
On 2020-04-20 19:02:30 +0200, Wolfram Sang wrote:
> After TAP refactorization, we can use 'unsigned int' for two more
> variables because all the calculations work on this type now.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> ---
> drivers/mmc/host/renesas_sdhi.h | 2 +-
> drivers/mmc/host/renesas_sdhi_core.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mmc/host/renesas_sdhi.h b/drivers/mmc/host/renesas_sdhi.h
> index 12d8016672b0..86efa9d5cd6d 100644
> --- a/drivers/mmc/host/renesas_sdhi.h
> +++ b/drivers/mmc/host/renesas_sdhi.h
> @@ -64,7 +64,7 @@ struct renesas_sdhi {
> /* Sampling data comparison: 1 for match, 0 for mismatch */
> DECLARE_BITMAP(smpcmp, BITS_PER_LONG);
> unsigned int tap_num;
> - unsigned long tap_set;
> + unsigned int tap_set;
> };
>
> #define host_to_priv(host) \
> diff --git a/drivers/mmc/host/renesas_sdhi_core.c b/drivers/mmc/host/renesas_sdhi_core.c
> index 1dfe6c32280b..28b0830c4251 100644
> --- a/drivers/mmc/host/renesas_sdhi_core.c
> +++ b/drivers/mmc/host/renesas_sdhi_core.c
> @@ -527,7 +527,7 @@ static int renesas_sdhi_execute_tuning(struct tmio_mmc_host *host, u32 opcode)
> static bool renesas_sdhi_manual_correction(struct tmio_mmc_host *host, bool use_4tap)
> {
> struct renesas_sdhi *priv = host_to_priv(host);
> - unsigned long new_tap = priv->tap_set;
> + unsigned int new_tap = priv->tap_set;
> u32 val;
>
> val = sd_scc_read32(host, priv, SH_MOBILE_SDHI_SCC_RVSREQ);
> --
> 2.20.1
>
--
Regards,
Niklas Söderlund
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mmc: renesas_sdhi: shorten types after refactorization
2020-04-20 17:02 [PATCH] mmc: renesas_sdhi: shorten types after refactorization Wolfram Sang
2020-04-21 11:48 ` Niklas Söderlund
@ 2020-04-22 16:03 ` Ulf Hansson
1 sibling, 0 replies; 3+ messages in thread
From: Ulf Hansson @ 2020-04-22 16:03 UTC (permalink / raw)
To: Wolfram Sang; +Cc: linux-mmc, Linux-Renesas
On Mon, 20 Apr 2020 at 19:02, Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
>
> After TAP refactorization, we can use 'unsigned int' for two more
> variables because all the calculations work on this type now.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Applied for next, thanks!
Kind regards
Uffe
> ---
> drivers/mmc/host/renesas_sdhi.h | 2 +-
> drivers/mmc/host/renesas_sdhi_core.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mmc/host/renesas_sdhi.h b/drivers/mmc/host/renesas_sdhi.h
> index 12d8016672b0..86efa9d5cd6d 100644
> --- a/drivers/mmc/host/renesas_sdhi.h
> +++ b/drivers/mmc/host/renesas_sdhi.h
> @@ -64,7 +64,7 @@ struct renesas_sdhi {
> /* Sampling data comparison: 1 for match, 0 for mismatch */
> DECLARE_BITMAP(smpcmp, BITS_PER_LONG);
> unsigned int tap_num;
> - unsigned long tap_set;
> + unsigned int tap_set;
> };
>
> #define host_to_priv(host) \
> diff --git a/drivers/mmc/host/renesas_sdhi_core.c b/drivers/mmc/host/renesas_sdhi_core.c
> index 1dfe6c32280b..28b0830c4251 100644
> --- a/drivers/mmc/host/renesas_sdhi_core.c
> +++ b/drivers/mmc/host/renesas_sdhi_core.c
> @@ -527,7 +527,7 @@ static int renesas_sdhi_execute_tuning(struct tmio_mmc_host *host, u32 opcode)
> static bool renesas_sdhi_manual_correction(struct tmio_mmc_host *host, bool use_4tap)
> {
> struct renesas_sdhi *priv = host_to_priv(host);
> - unsigned long new_tap = priv->tap_set;
> + unsigned int new_tap = priv->tap_set;
> u32 val;
>
> val = sd_scc_read32(host, priv, SH_MOBILE_SDHI_SCC_RVSREQ);
> --
> 2.20.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-04-22 16:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-20 17:02 [PATCH] mmc: renesas_sdhi: shorten types after refactorization Wolfram Sang
2020-04-21 11:48 ` Niklas Söderlund
2020-04-22 16:03 ` Ulf Hansson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.