* [PATCH] xfs/126: make blocktrash work reliably on attrleaf blocks
@ 2020-04-21 11:36 Anthony Iliopoulos
2020-04-21 15:26 ` Darrick J. Wong
0 siblings, 1 reply; 2+ messages in thread
From: Anthony Iliopoulos @ 2020-04-21 11:36 UTC (permalink / raw)
To: Eryu Guan; +Cc: fstests, linux-xfs, Darrick J . Wong
Running xfs/126 sometimes fails due to output mismatch. Due to the
randomized nature of the test, periodically the selected bits are not
relevant to the test, or the selected bits are not flipped. Supply an
offset that is close to the start of the metadata block, so that the
test will reliably corrupt the header.
Suggested-by: Darrick J. Wong <darrick.wong@oracle.com>
Link: https://lore.kernel.org/linux-xfs/20200116160323.GC2149943@magnolia
Signed-off-by: Anthony Iliopoulos <ailiop@suse.com>
---
tests/xfs/126 | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/xfs/126 b/tests/xfs/126
index 4f9f8cf9..d01338c9 100755
--- a/tests/xfs/126
+++ b/tests/xfs/126
@@ -72,7 +72,7 @@ echo "+ corrupt xattr"
loff=1
while true; do
_scratch_xfs_db -x -c "inode ${inode}" -c "ablock ${loff}" -c "stack" | grep -q 'file attr block is unmapped' && break
- _scratch_xfs_db -x -c "inode ${inode}" -c "ablock ${loff}" -c "stack" -c "blocktrash -x 32 -y $((blksz * 8)) -z ${FUZZ_ARGS}" >> $seqres.full
+ _scratch_xfs_db -x -c "inode ${inode}" -c "ablock ${loff}" -c "stack" -c "blocktrash -o 4 -x 32 -y $((blksz * 8)) -z ${FUZZ_ARGS}" >> $seqres.full
loff="$((loff + 1))"
done
--
2.26.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] xfs/126: make blocktrash work reliably on attrleaf blocks
2020-04-21 11:36 [PATCH] xfs/126: make blocktrash work reliably on attrleaf blocks Anthony Iliopoulos
@ 2020-04-21 15:26 ` Darrick J. Wong
0 siblings, 0 replies; 2+ messages in thread
From: Darrick J. Wong @ 2020-04-21 15:26 UTC (permalink / raw)
To: Anthony Iliopoulos; +Cc: Eryu Guan, fstests, linux-xfs
On Tue, Apr 21, 2020 at 01:36:43PM +0200, Anthony Iliopoulos wrote:
> Running xfs/126 sometimes fails due to output mismatch. Due to the
> randomized nature of the test, periodically the selected bits are not
> relevant to the test, or the selected bits are not flipped. Supply an
> offset that is close to the start of the metadata block, so that the
> test will reliably corrupt the header.
>
> Suggested-by: Darrick J. Wong <darrick.wong@oracle.com>
> Link: https://lore.kernel.org/linux-xfs/20200116160323.GC2149943@magnolia
> Signed-off-by: Anthony Iliopoulos <ailiop@suse.com>
Seems fine to me...
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
--D
> ---
> tests/xfs/126 | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/xfs/126 b/tests/xfs/126
> index 4f9f8cf9..d01338c9 100755
> --- a/tests/xfs/126
> +++ b/tests/xfs/126
> @@ -72,7 +72,7 @@ echo "+ corrupt xattr"
> loff=1
> while true; do
> _scratch_xfs_db -x -c "inode ${inode}" -c "ablock ${loff}" -c "stack" | grep -q 'file attr block is unmapped' && break
> - _scratch_xfs_db -x -c "inode ${inode}" -c "ablock ${loff}" -c "stack" -c "blocktrash -x 32 -y $((blksz * 8)) -z ${FUZZ_ARGS}" >> $seqres.full
> + _scratch_xfs_db -x -c "inode ${inode}" -c "ablock ${loff}" -c "stack" -c "blocktrash -o 4 -x 32 -y $((blksz * 8)) -z ${FUZZ_ARGS}" >> $seqres.full
> loff="$((loff + 1))"
> done
>
> --
> 2.26.2
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-04-21 15:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-21 11:36 [PATCH] xfs/126: make blocktrash work reliably on attrleaf blocks Anthony Iliopoulos
2020-04-21 15:26 ` Darrick J. Wong
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.