All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Thompson <daniel.thompson@linaro.org>
To: Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: Jingoo Han <jingoohan1@gmail.com>,
	linux-fbdev@vger.kernel.org, Lee Jones <lee.jones@linaro.org>,
	dri-devel@lists.freedesktop.org,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Subject: Re: [PATCHv3 4/4] backlight: led_bl: fix led -> backlight brightness mapping
Date: Wed, 22 Apr 2020 08:30:35 +0000	[thread overview]
Message-ID: <20200422083035.wiujphrt5k7o244v@holly.lan> (raw)
In-Reply-To: <20200422065114.22164-5-tomi.valkeinen@ti.com>

On Wed, Apr 22, 2020 at 09:51:14AM +0300, Tomi Valkeinen wrote:
> The code that maps the LED default brightness to backlight levels has
> two issues: 1) if the default brightness is the first backlight level
> (usually 0), the code fails to find it, and 2) when the code fails to
> find a backlight level, it ends up using max_brightness + 1 as the
> default brightness.
> 
> Fix these two issues.
> 
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>

Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>


Daniel.

WARNING: multiple messages have this Message-ID (diff)
From: Daniel Thompson <daniel.thompson@linaro.org>
To: Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: Jingoo Han <jingoohan1@gmail.com>,
	linux-fbdev@vger.kernel.org, Lee Jones <lee.jones@linaro.org>,
	dri-devel@lists.freedesktop.org,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Subject: Re: [PATCHv3 4/4] backlight: led_bl: fix led -> backlight brightness mapping
Date: Wed, 22 Apr 2020 09:30:35 +0100	[thread overview]
Message-ID: <20200422083035.wiujphrt5k7o244v@holly.lan> (raw)
In-Reply-To: <20200422065114.22164-5-tomi.valkeinen@ti.com>

On Wed, Apr 22, 2020 at 09:51:14AM +0300, Tomi Valkeinen wrote:
> The code that maps the LED default brightness to backlight levels has
> two issues: 1) if the default brightness is the first backlight level
> (usually 0), the code fails to find it, and 2) when the code fails to
> find a backlight level, it ends up using max_brightness + 1 as the
> default brightness.
> 
> Fix these two issues.
> 
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>

Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>


Daniel.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2020-04-22  8:30 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-22  6:51 [PATCHv3 0/4] led-backlight cleanups & fixes Tomi Valkeinen
2020-04-22  6:51 ` Tomi Valkeinen
2020-04-22  6:51 ` [PATCHv3 1/4] backlight: led_bl: fix cosmetic issues Tomi Valkeinen
2020-04-22  6:51   ` Tomi Valkeinen
2020-04-22  6:51 ` [PATCHv3 2/4] backlight: led_bl: drop useless NULL initialization Tomi Valkeinen
2020-04-22  6:51   ` Tomi Valkeinen
2020-04-22  6:51 ` [PATCHv3 3/4] backlight: led_bl: add led_access locking Tomi Valkeinen
2020-04-22  6:51   ` Tomi Valkeinen
2020-04-22  6:51 ` [PATCHv3 4/4] backlight: led_bl: fix led -> backlight brightness mapping Tomi Valkeinen
2020-04-22  6:51   ` Tomi Valkeinen
2020-04-22  8:30   ` Daniel Thompson [this message]
2020-04-22  8:30     ` Daniel Thompson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200422083035.wiujphrt5k7o244v@holly.lan \
    --to=daniel.thompson@linaro.org \
    --cc=b.zolnierkie@samsung.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jingoohan1@gmail.com \
    --cc=lee.jones@linaro.org \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=tomi.valkeinen@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.