All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
To: "Jere Leppänen" <jere.leppanen@nokia.com>
Cc: linux-sctp@vger.kernel.org, netdev@vger.kernel.org,
	Vlad Yasevich <vyasevich@gmail.com>,
	Neil Horman <nhorman@tuxdriver.com>,
	"David S . Miller" <davem@davemloft.net>,
	Xin Long <lucien.xin@gmail.com>
Subject: Re: [PATCH net 2/2] sctp: Fix SHUTDOWN CTSN Ack in the peer restart case
Date: Wed, 22 Apr 2020 22:09:31 -0300	[thread overview]
Message-ID: <20200423010931.GC2688@localhost.localdomain> (raw)
In-Reply-To: <20200421190342.548226-3-jere.leppanen@nokia.com>

On Tue, Apr 21, 2020 at 10:03:42PM +0300, Jere Leppänen wrote:
> When starting shutdown in sctp_sf_do_dupcook_a(), get the value for
> SHUTDOWN Cumulative TSN Ack from the new association, which is
> reconstructed from the cookie, instead of the old association, which
> the peer doesn't have anymore.
> 
> Otherwise the SHUTDOWN is either ignored or replied to with an ABORT
> by the peer because CTSN Ack doesn't match the peer's Initial TSN.
> 
> Fixes: bdf6fa52f01b ("sctp: handle association restarts when the socket is closed.")
> Signed-off-by: Jere Leppänen <jere.leppanen@nokia.com>

Nice patches. Thanks.

Acked-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>

WARNING: multiple messages have this Message-ID (diff)
From: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
To: "Jere Leppänen" <jere.leppanen@nokia.com>
Cc: linux-sctp@vger.kernel.org, netdev@vger.kernel.org,
	Vlad Yasevich <vyasevich@gmail.com>,
	Neil Horman <nhorman@tuxdriver.com>,
	"David S . Miller" <davem@davemloft.net>,
	Xin Long <lucien.xin@gmail.com>
Subject: Re: [PATCH net 2/2] sctp: Fix SHUTDOWN CTSN Ack in the peer restart case
Date: Thu, 23 Apr 2020 01:09:31 +0000	[thread overview]
Message-ID: <20200423010931.GC2688@localhost.localdomain> (raw)
In-Reply-To: <20200421190342.548226-3-jere.leppanen@nokia.com>

On Tue, Apr 21, 2020 at 10:03:42PM +0300, Jere Leppänen wrote:
> When starting shutdown in sctp_sf_do_dupcook_a(), get the value for
> SHUTDOWN Cumulative TSN Ack from the new association, which is
> reconstructed from the cookie, instead of the old association, which
> the peer doesn't have anymore.
> 
> Otherwise the SHUTDOWN is either ignored or replied to with an ABORT
> by the peer because CTSN Ack doesn't match the peer's Initial TSN.
> 
> Fixes: bdf6fa52f01b ("sctp: handle association restarts when the socket is closed.")
> Signed-off-by: Jere Leppänen <jere.leppanen@nokia.com>

Nice patches. Thanks.

Acked-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>

  reply	other threads:[~2020-04-23  1:09 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-21 19:03 [PATCH net 0/2] sctp: Fix problems with peer restart when in SHUTDOWN-PENDING state and socket is closed Jere Leppänen
2020-04-21 19:03 ` [PATCH net 0/2] sctp: Fix problems with peer restart when in SHUTDOWN-PENDING state and socket is cl Jere Leppänen
2020-04-21 19:03 ` [PATCH net 1/2] sctp: Fix bundling of SHUTDOWN with COOKIE-ACK Jere Leppänen
2020-04-21 19:03   ` Jere Leppänen
2020-04-23  1:09   ` Marcelo Ricardo Leitner
2020-04-23  1:09     ` Marcelo Ricardo Leitner
2020-04-21 19:03 ` [PATCH net 2/2] sctp: Fix SHUTDOWN CTSN Ack in the peer restart case Jere Leppänen
2020-04-21 19:03   ` Jere Leppänen
2020-04-23  1:09   ` Marcelo Ricardo Leitner [this message]
2020-04-23  1:09     ` Marcelo Ricardo Leitner
2020-04-23  2:28 ` [PATCH net 0/2] sctp: Fix problems with peer restart when in SHUTDOWN-PENDING state and socket is closed David Miller
2020-04-23  2:28   ` [PATCH net 0/2] sctp: Fix problems with peer restart when in SHUTDOWN-PENDING state and socket i David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200423010931.GC2688@localhost.localdomain \
    --to=marcelo.leitner@gmail.com \
    --cc=davem@davemloft.net \
    --cc=jere.leppanen@nokia.com \
    --cc=linux-sctp@vger.kernel.org \
    --cc=lucien.xin@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=nhorman@tuxdriver.com \
    --cc=vyasevich@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.