All of lore.kernel.org
 help / color / mirror / Atom feed
* [lkundrak-linux-mmp:lr/mmp3-thermal-v1 5/5] drivers/thermal/mmp3_thermal.c:51:1: sparse: sparse: symbol 'mmp3_thermal_sensor_mutex' was not declared. Should it be static?
@ 2020-04-22 19:43 kbuild test robot
  2020-04-22 19:43 ` [RFC PATCH lkundrak-linux-mmp] mmp3_thermal_sensor_mutex can be static kbuild test robot
  0 siblings, 1 reply; 2+ messages in thread
From: kbuild test robot @ 2020-04-22 19:43 UTC (permalink / raw)
  To: kbuild-all

[-- Attachment #1: Type: text/plain, Size: 949 bytes --]

tree:   git://git.kernel.org/pub/scm/linux/kernel/git/lkundrak/linux-mmp.git lr/mmp3-thermal-v1
head:   59d7465ed415ed34a602a9bb07ad1a25aaaf647f
commit: 59d7465ed415ed34a602a9bb07ad1a25aaaf647f [5/5] thermal driver
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.1-191-gc51a0382-dirty
        git checkout 59d7465ed415ed34a602a9bb07ad1a25aaaf647f
        make ARCH=x86_64 allmodconfig
        make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'

If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@intel.com>


sparse warnings: (new ones prefixed by >>)

>> drivers/thermal/mmp3_thermal.c:51:1: sparse: sparse: symbol 'mmp3_thermal_sensor_mutex' was not declared. Should it be static?

Please review and possibly fold the followup patch.

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

^ permalink raw reply	[flat|nested] 2+ messages in thread

* [RFC PATCH lkundrak-linux-mmp] mmp3_thermal_sensor_mutex can be static
  2020-04-22 19:43 [lkundrak-linux-mmp:lr/mmp3-thermal-v1 5/5] drivers/thermal/mmp3_thermal.c:51:1: sparse: sparse: symbol 'mmp3_thermal_sensor_mutex' was not declared. Should it be static? kbuild test robot
@ 2020-04-22 19:43 ` kbuild test robot
  0 siblings, 0 replies; 2+ messages in thread
From: kbuild test robot @ 2020-04-22 19:43 UTC (permalink / raw)
  To: kbuild-all

[-- Attachment #1: Type: text/plain, Size: 697 bytes --]


Fixes: 59d7465ed415 ("thermal driver")
Signed-off-by: kbuild test robot <lkp@intel.com>
---
 mmp3_thermal.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/thermal/mmp3_thermal.c b/drivers/thermal/mmp3_thermal.c
index d0113f3546333f..aba4e15b8d07b4 100644
--- a/drivers/thermal/mmp3_thermal.c
+++ b/drivers/thermal/mmp3_thermal.c
@@ -48,7 +48,7 @@ static unsigned int gray_to_temp[2][16] = {{
           0,  610,  560,  585,  460,  485,  535,  510,
 }};
 
-DEFINE_MUTEX(mmp3_thermal_sensor_mutex);
+static DEFINE_MUTEX(mmp3_thermal_sensor_mutex);
 
 static unsigned long read_temperature_sensor(struct mmp3_thermal *priv, int range, int index)
 {

^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-04-22 19:43 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-22 19:43 [lkundrak-linux-mmp:lr/mmp3-thermal-v1 5/5] drivers/thermal/mmp3_thermal.c:51:1: sparse: sparse: symbol 'mmp3_thermal_sensor_mutex' was not declared. Should it be static? kbuild test robot
2020-04-22 19:43 ` [RFC PATCH lkundrak-linux-mmp] mmp3_thermal_sensor_mutex can be static kbuild test robot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.