All of lore.kernel.org
 help / color / mirror / Atom feed
* drivers/usb/gadget/udc/s3c2410_udc.c:255:11: warning: comparison of address of 'ep->queue' equal to a null pointer is always false
@ 2020-04-23  7:02 ` kbuild test robot
  0 siblings, 0 replies; 3+ messages in thread
From: kbuild test robot @ 2020-04-23  7:02 UTC (permalink / raw)
  To: Nathan Chancellor
  Cc: kbuild-all, clang-built-linux, linux-kernel, Masahiro Yamada

[-- Attachment #1: Type: text/plain, Size: 3285 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   c578ddb39e565139897124e74e5a43e56538cb33
commit: afe956c577b2d5a3d9834e4424587c1ebcf90c4c kbuild: Enable -Wtautological-compare
date:   2 weeks ago
config: arm-tct_hammer_defconfig (attached as .config)
compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project 2de52422acf04662b45599f77c14ce1b2cec2b81)
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install arm cross compiling tool for clang build
        # apt-get install binutils-arm-linux-gnueabi
        git checkout afe956c577b2d5a3d9834e4424587c1ebcf90c4c
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/usb/gadget/udc/s3c2410_udc.c:255:11: warning: comparison of address of 'ep->queue' equal to a null pointer is always false [-Wtautological-pointer-compare]
           if (&ep->queue == NULL)
                ~~~~^~~~~    ~~~~
   1 warning generated.

vim +255 drivers/usb/gadget/udc/s3c2410_udc.c

3fc154b6b8134b drivers/usb/gadget/s3c2410_udc.c Arnaud Patard 2007-06-06  250  
3fc154b6b8134b drivers/usb/gadget/s3c2410_udc.c Arnaud Patard 2007-06-06  251  static void s3c2410_udc_nuke(struct s3c2410_udc *udc,
3fc154b6b8134b drivers/usb/gadget/s3c2410_udc.c Arnaud Patard 2007-06-06  252  		struct s3c2410_ep *ep, int status)
3fc154b6b8134b drivers/usb/gadget/s3c2410_udc.c Arnaud Patard 2007-06-06  253  {
3fc154b6b8134b drivers/usb/gadget/s3c2410_udc.c Arnaud Patard 2007-06-06  254  	/* Sanity check */
3fc154b6b8134b drivers/usb/gadget/s3c2410_udc.c Arnaud Patard 2007-06-06 @255  	if (&ep->queue == NULL)
3fc154b6b8134b drivers/usb/gadget/s3c2410_udc.c Arnaud Patard 2007-06-06  256  		return;
3fc154b6b8134b drivers/usb/gadget/s3c2410_udc.c Arnaud Patard 2007-06-06  257  
3fc154b6b8134b drivers/usb/gadget/s3c2410_udc.c Arnaud Patard 2007-06-06  258  	while (!list_empty(&ep->queue)) {
3fc154b6b8134b drivers/usb/gadget/s3c2410_udc.c Arnaud Patard 2007-06-06  259  		struct s3c2410_request *req;
3fc154b6b8134b drivers/usb/gadget/s3c2410_udc.c Arnaud Patard 2007-06-06  260  		req = list_entry(ep->queue.next, struct s3c2410_request,
3fc154b6b8134b drivers/usb/gadget/s3c2410_udc.c Arnaud Patard 2007-06-06  261  				queue);
3fc154b6b8134b drivers/usb/gadget/s3c2410_udc.c Arnaud Patard 2007-06-06  262  		s3c2410_udc_done(ep, req, status);
3fc154b6b8134b drivers/usb/gadget/s3c2410_udc.c Arnaud Patard 2007-06-06  263  	}
3fc154b6b8134b drivers/usb/gadget/s3c2410_udc.c Arnaud Patard 2007-06-06  264  }
3fc154b6b8134b drivers/usb/gadget/s3c2410_udc.c Arnaud Patard 2007-06-06  265  

:::::: The code at line 255 was first introduced by commit
:::::: 3fc154b6b8134b98bb94d60cad9a46ec1ffbe372 USB Gadget driver for Samsung s3c2410 ARM SoC

:::::: TO: Arnaud Patard <arnaud.patard@rtp-net.org>
:::::: CC: Greg Kroah-Hartman <gregkh@suse.de>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 12049 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread
* drivers/usb/gadget/udc/s3c2410_udc.c:255:11: warning: comparison of address of 'ep->queue' equal to a null pointer is always false
@ 2020-04-23  7:02 ` kbuild test robot
  0 siblings, 0 replies; 3+ messages in thread
From: kbuild test robot @ 2020-04-23  7:02 UTC (permalink / raw)
  To: kbuild-all

[-- Attachment #1: Type: text/plain, Size: 3340 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   c578ddb39e565139897124e74e5a43e56538cb33
commit: afe956c577b2d5a3d9834e4424587c1ebcf90c4c kbuild: Enable -Wtautological-compare
date:   2 weeks ago
config: arm-tct_hammer_defconfig (attached as .config)
compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project 2de52422acf04662b45599f77c14ce1b2cec2b81)
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install arm cross compiling tool for clang build
        # apt-get install binutils-arm-linux-gnueabi
        git checkout afe956c577b2d5a3d9834e4424587c1ebcf90c4c
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/usb/gadget/udc/s3c2410_udc.c:255:11: warning: comparison of address of 'ep->queue' equal to a null pointer is always false [-Wtautological-pointer-compare]
           if (&ep->queue == NULL)
                ~~~~^~~~~    ~~~~
   1 warning generated.

vim +255 drivers/usb/gadget/udc/s3c2410_udc.c

3fc154b6b8134b drivers/usb/gadget/s3c2410_udc.c Arnaud Patard 2007-06-06  250  
3fc154b6b8134b drivers/usb/gadget/s3c2410_udc.c Arnaud Patard 2007-06-06  251  static void s3c2410_udc_nuke(struct s3c2410_udc *udc,
3fc154b6b8134b drivers/usb/gadget/s3c2410_udc.c Arnaud Patard 2007-06-06  252  		struct s3c2410_ep *ep, int status)
3fc154b6b8134b drivers/usb/gadget/s3c2410_udc.c Arnaud Patard 2007-06-06  253  {
3fc154b6b8134b drivers/usb/gadget/s3c2410_udc.c Arnaud Patard 2007-06-06  254  	/* Sanity check */
3fc154b6b8134b drivers/usb/gadget/s3c2410_udc.c Arnaud Patard 2007-06-06 @255  	if (&ep->queue == NULL)
3fc154b6b8134b drivers/usb/gadget/s3c2410_udc.c Arnaud Patard 2007-06-06  256  		return;
3fc154b6b8134b drivers/usb/gadget/s3c2410_udc.c Arnaud Patard 2007-06-06  257  
3fc154b6b8134b drivers/usb/gadget/s3c2410_udc.c Arnaud Patard 2007-06-06  258  	while (!list_empty(&ep->queue)) {
3fc154b6b8134b drivers/usb/gadget/s3c2410_udc.c Arnaud Patard 2007-06-06  259  		struct s3c2410_request *req;
3fc154b6b8134b drivers/usb/gadget/s3c2410_udc.c Arnaud Patard 2007-06-06  260  		req = list_entry(ep->queue.next, struct s3c2410_request,
3fc154b6b8134b drivers/usb/gadget/s3c2410_udc.c Arnaud Patard 2007-06-06  261  				queue);
3fc154b6b8134b drivers/usb/gadget/s3c2410_udc.c Arnaud Patard 2007-06-06  262  		s3c2410_udc_done(ep, req, status);
3fc154b6b8134b drivers/usb/gadget/s3c2410_udc.c Arnaud Patard 2007-06-06  263  	}
3fc154b6b8134b drivers/usb/gadget/s3c2410_udc.c Arnaud Patard 2007-06-06  264  }
3fc154b6b8134b drivers/usb/gadget/s3c2410_udc.c Arnaud Patard 2007-06-06  265  

:::::: The code at line 255 was first introduced by commit
:::::: 3fc154b6b8134b98bb94d60cad9a46ec1ffbe372 USB Gadget driver for Samsung s3c2410 ARM SoC

:::::: TO: Arnaud Patard <arnaud.patard@rtp-net.org>
:::::: CC: Greg Kroah-Hartman <gregkh@suse.de>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 12049 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: drivers/usb/gadget/udc/s3c2410_udc.c:255:11: warning: comparison of address of 'ep->queue' equal to a null pointer is always false
  2020-04-23  7:02 ` kbuild test robot
  (?)
@ 2020-04-23 16:30 ` Nathan Chancellor
  -1 siblings, 0 replies; 3+ messages in thread
From: Nathan Chancellor @ 2020-04-23 16:30 UTC (permalink / raw)
  To: kbuild test robot
  Cc: kbuild-all, clang-built-linux, linux-kernel, Masahiro Yamada

On Thu, Apr 23, 2020 at 03:02:27PM +0800, kbuild test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head:   c578ddb39e565139897124e74e5a43e56538cb33
> commit: afe956c577b2d5a3d9834e4424587c1ebcf90c4c kbuild: Enable -Wtautological-compare
> date:   2 weeks ago
> config: arm-tct_hammer_defconfig (attached as .config)
> compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project 2de52422acf04662b45599f77c14ce1b2cec2b81)
> reproduce:
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # install arm cross compiling tool for clang build
>         # apt-get install binutils-arm-linux-gnueabi
>         git checkout afe956c577b2d5a3d9834e4424587c1ebcf90c4c
>         # save the attached .config to linux build tree
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm 
> 
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kbuild test robot <lkp@intel.com>
> 
> All warnings (new ones prefixed by >>):
> 
> >> drivers/usb/gadget/udc/s3c2410_udc.c:255:11: warning: comparison of address of 'ep->queue' equal to a null pointer is always false [-Wtautological-pointer-compare]
>            if (&ep->queue == NULL)
>                 ~~~~^~~~~    ~~~~
>    1 warning generated.

Thank you, patch sent:

https://lore.kernel.org/lkml/20200423162923.10886-1-natechancellor@gmail.com/

Cheers,
Nathan

^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-04-23 16:31 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-23  7:02 drivers/usb/gadget/udc/s3c2410_udc.c:255:11: warning: comparison of address of 'ep->queue' equal to a null pointer is always false kbuild test robot
2020-04-23  7:02 ` kbuild test robot
2020-04-23 16:30 ` Nathan Chancellor

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.