* [Intel-gfx] [PATCH] drm/i915: Add engine scratch register to live_lrc_fixed
@ 2020-04-23 23:47 Chris Wilson
2020-04-24 1:38 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2020-04-24 3:56 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
0 siblings, 2 replies; 4+ messages in thread
From: Chris Wilson @ 2020-04-23 23:47 UTC (permalink / raw)
To: intel-gfx; +Cc: Chris Wilson
From: Mika Kuoppala <mika.kuoppala@linux.intel.com>
General purpose registers are per engine and
in a fixed location. Add to live_lrc_fixed.
Signed-off-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
drivers/gpu/drm/i915/gt/intel_lrc.c | 12 ++++++++++++
drivers/gpu/drm/i915/gt/selftest_lrc.c | 5 +++++
2 files changed, 17 insertions(+)
diff --git a/drivers/gpu/drm/i915/gt/intel_lrc.c b/drivers/gpu/drm/i915/gt/intel_lrc.c
index 090be5981b55..dba6af7a6fe8 100644
--- a/drivers/gpu/drm/i915/gt/intel_lrc.c
+++ b/drivers/gpu/drm/i915/gt/intel_lrc.c
@@ -250,6 +250,18 @@ static int lrc_ring_mi_mode(const struct intel_engine_cs *engine)
return -1;
}
+static int lrc_ring_gpr0(const struct intel_engine_cs *engine)
+{
+ if (INTEL_GEN(engine->i915) >= 12)
+ return 0x74;
+ else if (INTEL_GEN(engine->i915) >= 9)
+ return 0x68;
+ else if (engine->class == RENDER_CLASS)
+ return 0xd8;
+ else
+ return -1;
+}
+
static int lrc_ring_wa_bb_per_ctx(const struct intel_engine_cs *engine)
{
if (INTEL_GEN(engine->i915) >= 12)
diff --git a/drivers/gpu/drm/i915/gt/selftest_lrc.c b/drivers/gpu/drm/i915/gt/selftest_lrc.c
index ae0a0a692498..6e47c88c4b74 100644
--- a/drivers/gpu/drm/i915/gt/selftest_lrc.c
+++ b/drivers/gpu/drm/i915/gt/selftest_lrc.c
@@ -4613,6 +4613,11 @@ static int live_lrc_fixed(void *arg)
CTX_TIMESTAMP - 1,
"RING_CTX_TIMESTAMP"
},
+ {
+ i915_mmio_reg_offset(GEN8_RING_CS_GPR(engine->mmio_base, 0)),
+ lrc_ring_gpr0(engine),
+ "RING_CS_GPR0"
+ },
{ },
}, *t;
u32 *hw;
--
2.20.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Add engine scratch register to live_lrc_fixed
2020-04-23 23:47 [Intel-gfx] [PATCH] drm/i915: Add engine scratch register to live_lrc_fixed Chris Wilson
@ 2020-04-24 1:38 ` Patchwork
2020-04-24 3:56 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
1 sibling, 0 replies; 4+ messages in thread
From: Patchwork @ 2020-04-24 1:38 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Add engine scratch register to live_lrc_fixed
URL : https://patchwork.freedesktop.org/series/76415/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8357 -> Patchwork_17450
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17450/index.html
Known issues
------------
Here are the changes found in Patchwork_17450 that come from known issues:
### IGT changes ###
#### Possible fixes ####
* {igt@kms_flip@basic-flip-vs-wf_vblank@a-edp1}:
- fi-bsw-kefka: [FAIL][1] ([i915#34]) -> [PASS][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8357/fi-bsw-kefka/igt@kms_flip@basic-flip-vs-wf_vblank@a-edp1.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17450/fi-bsw-kefka/igt@kms_flip@basic-flip-vs-wf_vblank@a-edp1.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[i915#34]: https://gitlab.freedesktop.org/drm/intel/issues/34
Participating hosts (49 -> 43)
------------------------------
Missing (6): fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-byt-clapper fi-bdw-samus
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_8357 -> Patchwork_17450
CI-20190529: 20190529
CI_DRM_8357: 95fef3b4fb9f6c72d65af138cdffb68e0f062910 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5609: c100fe19f7b144538549415e8503093053883ec6 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_17450: a0e635ff729aad8e4b772a2d3753d2d4ee3b2409 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
a0e635ff729a drm/i915: Add engine scratch register to live_lrc_fixed
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17450/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Add engine scratch register to live_lrc_fixed
2020-04-23 23:47 [Intel-gfx] [PATCH] drm/i915: Add engine scratch register to live_lrc_fixed Chris Wilson
2020-04-24 1:38 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
@ 2020-04-24 3:56 ` Patchwork
1 sibling, 0 replies; 4+ messages in thread
From: Patchwork @ 2020-04-24 3:56 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Add engine scratch register to live_lrc_fixed
URL : https://patchwork.freedesktop.org/series/76415/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8357_full -> Patchwork_17450_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Known issues
------------
Here are the changes found in Patchwork_17450_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_pm_rc6_residency@rc6-idle:
- shard-hsw: [PASS][1] -> [WARN][2] ([i915#1519])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8357/shard-hsw6/igt@i915_pm_rc6_residency@rc6-idle.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17450/shard-hsw7/igt@i915_pm_rc6_residency@rc6-idle.html
* igt@i915_suspend@fence-restore-untiled:
- shard-apl: [PASS][3] -> [DMESG-WARN][4] ([i915#180])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8357/shard-apl1/igt@i915_suspend@fence-restore-untiled.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17450/shard-apl6/igt@i915_suspend@fence-restore-untiled.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions:
- shard-skl: [PASS][5] -> [FAIL][6] ([IGT#5])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8357/shard-skl5/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17450/shard-skl2/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
* igt@kms_hdr@bpc-switch:
- shard-skl: [PASS][7] -> [FAIL][8] ([i915#1188])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8357/shard-skl6/igt@kms_hdr@bpc-switch.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17450/shard-skl9/igt@kms_hdr@bpc-switch.html
* igt@kms_hdr@bpc-switch-suspend:
- shard-kbl: [PASS][9] -> [DMESG-WARN][10] ([i915#180]) +1 similar issue
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8357/shard-kbl4/igt@kms_hdr@bpc-switch-suspend.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17450/shard-kbl1/igt@kms_hdr@bpc-switch-suspend.html
* igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min:
- shard-skl: [PASS][11] -> [FAIL][12] ([fdo#108145] / [i915#265])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8357/shard-skl4/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17450/shard-skl1/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min.html
* igt@kms_setmode@basic:
- shard-apl: [PASS][13] -> [FAIL][14] ([i915#31])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8357/shard-apl4/igt@kms_setmode@basic.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17450/shard-apl8/igt@kms_setmode@basic.html
#### Possible fixes ####
* igt@i915_pm_rps@waitboost:
- shard-glk: [FAIL][15] ([i915#39]) -> [PASS][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8357/shard-glk1/igt@i915_pm_rps@waitboost.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17450/shard-glk8/igt@i915_pm_rps@waitboost.html
* igt@kms_cursor_crc@pipe-c-cursor-suspend:
- shard-apl: [DMESG-WARN][17] ([i915#180]) -> [PASS][18] +3 similar issues
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8357/shard-apl1/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17450/shard-apl6/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
* igt@kms_cursor_legacy@2x-long-flip-vs-cursor-legacy:
- shard-glk: [FAIL][19] ([i915#72]) -> [PASS][20]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8357/shard-glk7/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-legacy.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17450/shard-glk2/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-legacy.html
* igt@kms_draw_crc@draw-method-rgb565-blt-xtiled:
- shard-glk: [FAIL][21] ([i915#52] / [i915#54]) -> [PASS][22]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8357/shard-glk7/igt@kms_draw_crc@draw-method-rgb565-blt-xtiled.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17450/shard-glk2/igt@kms_draw_crc@draw-method-rgb565-blt-xtiled.html
* igt@kms_pipe_crc_basic@nonblocking-crc-pipe-c:
- shard-skl: [FAIL][23] ([i915#53]) -> [PASS][24]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8357/shard-skl8/igt@kms_pipe_crc_basic@nonblocking-crc-pipe-c.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17450/shard-skl5/igt@kms_pipe_crc_basic@nonblocking-crc-pipe-c.html
* igt@kms_psr@psr2_cursor_plane_move:
- shard-iclb: [SKIP][25] ([fdo#109441]) -> [PASS][26] +1 similar issue
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8357/shard-iclb7/igt@kms_psr@psr2_cursor_plane_move.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17450/shard-iclb2/igt@kms_psr@psr2_cursor_plane_move.html
* igt@kms_vblank@pipe-b-ts-continuation-suspend:
- shard-apl: [DMESG-WARN][27] ([i915#180] / [i915#95]) -> [PASS][28]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8357/shard-apl1/igt@kms_vblank@pipe-b-ts-continuation-suspend.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17450/shard-apl6/igt@kms_vblank@pipe-b-ts-continuation-suspend.html
#### Warnings ####
* igt@i915_pm_dc@dc3co-vpb-simulation:
- shard-iclb: [SKIP][29] ([i915#588]) -> [SKIP][30] ([i915#658])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8357/shard-iclb2/igt@i915_pm_dc@dc3co-vpb-simulation.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17450/shard-iclb6/igt@i915_pm_dc@dc3co-vpb-simulation.html
* igt@i915_pm_rpm@modeset-lpsp:
- shard-snb: [SKIP][31] ([fdo#109271]) -> [INCOMPLETE][32] ([i915#82])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8357/shard-snb5/igt@i915_pm_rpm@modeset-lpsp.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17450/shard-snb5/igt@i915_pm_rpm@modeset-lpsp.html
* igt@kms_plane_alpha_blend@pipe-a-alpha-basic:
- shard-apl: [FAIL][33] ([fdo#108145] / [i915#265]) -> [FAIL][34] ([fdo#108145] / [i915#265] / [i915#95])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8357/shard-apl4/igt@kms_plane_alpha_blend@pipe-a-alpha-basic.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17450/shard-apl8/igt@kms_plane_alpha_blend@pipe-a-alpha-basic.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[IGT#5]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/5
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188
[i915#1519]: https://gitlab.freedesktop.org/drm/intel/issues/1519
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#198]: https://gitlab.freedesktop.org/drm/intel/issues/198
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#31]: https://gitlab.freedesktop.org/drm/intel/issues/31
[i915#34]: https://gitlab.freedesktop.org/drm/intel/issues/34
[i915#39]: https://gitlab.freedesktop.org/drm/intel/issues/39
[i915#52]: https://gitlab.freedesktop.org/drm/intel/issues/52
[i915#53]: https://gitlab.freedesktop.org/drm/intel/issues/53
[i915#54]: https://gitlab.freedesktop.org/drm/intel/issues/54
[i915#588]: https://gitlab.freedesktop.org/drm/intel/issues/588
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#72]: https://gitlab.freedesktop.org/drm/intel/issues/72
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#82]: https://gitlab.freedesktop.org/drm/intel/issues/82
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
Participating hosts (10 -> 10)
------------------------------
No changes in participating hosts
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_8357 -> Patchwork_17450
CI-20190529: 20190529
CI_DRM_8357: 95fef3b4fb9f6c72d65af138cdffb68e0f062910 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5609: c100fe19f7b144538549415e8503093053883ec6 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_17450: a0e635ff729aad8e4b772a2d3753d2d4ee3b2409 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17450/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Intel-gfx] [PATCH] drm/i915: Add engine scratch register to live_lrc_fixed
2020-04-24 16:01 [Intel-gfx] [PATCH 1/4] " Mika Kuoppala
@ 2020-04-24 16:05 ` Chris Wilson
0 siblings, 0 replies; 4+ messages in thread
From: Chris Wilson @ 2020-04-24 16:05 UTC (permalink / raw)
To: intel-gfx; +Cc: Chris Wilson
From: Mika Kuoppala <mika.kuoppala@linux.intel.com>
General purpose registers are per engine and
in a fixed location. Add to live_lrc_fixed.
Signed-off-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
drivers/gpu/drm/i915/gt/intel_lrc.c | 12 ++++++++++++
drivers/gpu/drm/i915/gt/selftest_lrc.c | 5 +++++
2 files changed, 17 insertions(+)
diff --git a/drivers/gpu/drm/i915/gt/intel_lrc.c b/drivers/gpu/drm/i915/gt/intel_lrc.c
index 214ea2a34693..c1f30fe12d5d 100644
--- a/drivers/gpu/drm/i915/gt/intel_lrc.c
+++ b/drivers/gpu/drm/i915/gt/intel_lrc.c
@@ -250,6 +250,18 @@ static int lrc_ring_mi_mode(const struct intel_engine_cs *engine)
return -1;
}
+static int lrc_ring_gpr0(const struct intel_engine_cs *engine)
+{
+ if (INTEL_GEN(engine->i915) >= 12)
+ return 0x74;
+ else if (INTEL_GEN(engine->i915) >= 9)
+ return 0x68;
+ else if (engine->class == RENDER_CLASS)
+ return 0xd8;
+ else
+ return -1;
+}
+
static int lrc_ring_wa_bb_per_ctx(const struct intel_engine_cs *engine)
{
if (INTEL_GEN(engine->i915) >= 12)
diff --git a/drivers/gpu/drm/i915/gt/selftest_lrc.c b/drivers/gpu/drm/i915/gt/selftest_lrc.c
index e964c1402d29..d10c38aec500 100644
--- a/drivers/gpu/drm/i915/gt/selftest_lrc.c
+++ b/drivers/gpu/drm/i915/gt/selftest_lrc.c
@@ -4613,6 +4613,11 @@ static int live_lrc_fixed(void *arg)
CTX_TIMESTAMP - 1,
"RING_CTX_TIMESTAMP"
},
+ {
+ i915_mmio_reg_offset(GEN8_RING_CS_GPR(engine->mmio_base, 0)),
+ lrc_ring_gpr0(engine),
+ "RING_CS_GPR0"
+ },
{ },
}, *t;
u32 *hw;
--
2.20.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-04-24 16:05 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-23 23:47 [Intel-gfx] [PATCH] drm/i915: Add engine scratch register to live_lrc_fixed Chris Wilson
2020-04-24 1:38 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2020-04-24 3:56 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2020-04-24 16:01 [Intel-gfx] [PATCH 1/4] " Mika Kuoppala
2020-04-24 16:05 ` [Intel-gfx] [PATCH] " Chris Wilson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.