* [PATCH] drm: amdgpu: Move static inline keyword to the front of declarations
@ 2020-04-24 3:13 ChenTao
2020-04-24 7:40 ` Christian König
0 siblings, 1 reply; 2+ messages in thread
From: ChenTao @ 2020-04-24 3:13 UTC (permalink / raw)
To: christian.koenig, David1.Zhou, airlied, daniel
Cc: Hawking.Zhang, evan.quan, andrey.grodzovsky, Monk.Liu,
kent.russell, linux-kernel, chentao107
Fix the following warning:
Move the static inline keyword to the front of declarations
amdgpu_device_wreg_no_kiq, and resolve the following
compiler warnings that can be seen when building
with warnings enabled (W=1):
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:344:1:warning:
‘static’ is not at beginning of declaration
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:344:1:warning:
‘inline’ is not at beginning of declaration
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: ChenTao <chentao107@huawei.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
index ad1c66763dc1..d53a5e3f464b 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
@@ -341,7 +341,7 @@ void amdgpu_mm_wreg8(struct amdgpu_device *adev, uint32_t offset, uint8_t value)
BUG();
}
-void static inline amdgpu_device_wreg_no_kiq(struct amdgpu_device *adev, uint32_t reg,
+static inline void amdgpu_device_wreg_no_kiq(struct amdgpu_device *adev, uint32_t reg,
uint32_t v, uint32_t acc_flags)
{
trace_amdgpu_device_wreg(adev->pdev->device, reg, v);
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm: amdgpu: Move static inline keyword to the front of declarations
2020-04-24 3:13 [PATCH] drm: amdgpu: Move static inline keyword to the front of declarations ChenTao
@ 2020-04-24 7:40 ` Christian König
0 siblings, 0 replies; 2+ messages in thread
From: Christian König @ 2020-04-24 7:40 UTC (permalink / raw)
To: ChenTao, David1.Zhou, airlied, daniel
Cc: Hawking.Zhang, evan.quan, andrey.grodzovsky, Monk.Liu,
kent.russell, linux-kernel
Am 24.04.20 um 05:13 schrieb ChenTao:
> Fix the following warning:
>
> Move the static inline keyword to the front of declarations
> amdgpu_device_wreg_no_kiq, and resolve the following
> compiler warnings that can be seen when building
> with warnings enabled (W=1):
>
> drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:344:1:warning:
> ‘static’ is not at beginning of declaration
> drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:344:1:warning:
> ‘inline’ is not at beginning of declaration
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: ChenTao <chentao107@huawei.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> index ad1c66763dc1..d53a5e3f464b 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> @@ -341,7 +341,7 @@ void amdgpu_mm_wreg8(struct amdgpu_device *adev, uint32_t offset, uint8_t value)
> BUG();
> }
>
> -void static inline amdgpu_device_wreg_no_kiq(struct amdgpu_device *adev, uint32_t reg,
> +static inline void amdgpu_device_wreg_no_kiq(struct amdgpu_device *adev, uint32_t reg,
> uint32_t v, uint32_t acc_flags)
> {
> trace_amdgpu_device_wreg(adev->pdev->device, reg, v);
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-04-24 7:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-24 3:13 [PATCH] drm: amdgpu: Move static inline keyword to the front of declarations ChenTao
2020-04-24 7:40 ` Christian König
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.