* [PATCH] media: rcar-csi2: Fix comment of VCDT/VCDT2 register
@ 2020-04-24 10:39 Wolfram Sang
2020-04-24 13:26 ` Niklas Söderlund
0 siblings, 1 reply; 2+ messages in thread
From: Wolfram Sang @ 2020-04-24 10:39 UTC (permalink / raw)
To: linux-media
Cc: linux-renesas-soc, Niklas Söderlund, Koji Matsuoka, Wolfram Sang
From: Koji Matsuoka <koji.matsuoka.xm@renesas.com>
According to latest H/W manual v1.50, the description of channel
number in the VCDT/VCDT2 register is decremented by one.
Therefore, this patch fixes it about comment.
Signed-off-by: Koji Matsuoka <koji.matsuoka.xm@renesas.com>
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
drivers/media/platform/rcar-vin/rcar-csi2.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/media/platform/rcar-vin/rcar-csi2.c b/drivers/media/platform/rcar-vin/rcar-csi2.c
index faa9fb23a2e9..151e6a90c5fb 100644
--- a/drivers/media/platform/rcar-vin/rcar-csi2.c
+++ b/drivers/media/platform/rcar-vin/rcar-csi2.c
@@ -52,8 +52,8 @@ struct rcar_csi2;
/*
* Channel Data Type Select
- * VCDT[0-15]: Channel 1 VCDT[16-31]: Channel 2
- * VCDT2[0-15]: Channel 3 VCDT2[16-31]: Channel 4
+ * VCDT[0-15]: Channel 0 VCDT[16-31]: Channel 1
+ * VCDT2[0-15]: Channel 2 VCDT2[16-31]: Channel 3
*/
#define VCDT_REG 0x10
#define VCDT2_REG 0x14
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] media: rcar-csi2: Fix comment of VCDT/VCDT2 register
2020-04-24 10:39 [PATCH] media: rcar-csi2: Fix comment of VCDT/VCDT2 register Wolfram Sang
@ 2020-04-24 13:26 ` Niklas Söderlund
0 siblings, 0 replies; 2+ messages in thread
From: Niklas Söderlund @ 2020-04-24 13:26 UTC (permalink / raw)
To: Wolfram Sang; +Cc: linux-media, linux-renesas-soc, Koji Matsuoka
Hi Wolfram and Matsuoka-san,
Thanks for your patch.
On 2020-04-24 12:39:45 +0200, Wolfram Sang wrote:
> From: Koji Matsuoka <koji.matsuoka.xm@renesas.com>
>
> According to latest H/W manual v1.50, the description of channel
> number in the VCDT/VCDT2 register is decremented by one.
> Therefore, this patch fixes it about comment.
>
> Signed-off-by: Koji Matsuoka <koji.matsuoka.xm@renesas.com>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> ---
> drivers/media/platform/rcar-vin/rcar-csi2.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/media/platform/rcar-vin/rcar-csi2.c b/drivers/media/platform/rcar-vin/rcar-csi2.c
> index faa9fb23a2e9..151e6a90c5fb 100644
> --- a/drivers/media/platform/rcar-vin/rcar-csi2.c
> +++ b/drivers/media/platform/rcar-vin/rcar-csi2.c
> @@ -52,8 +52,8 @@ struct rcar_csi2;
>
> /*
> * Channel Data Type Select
> - * VCDT[0-15]: Channel 1 VCDT[16-31]: Channel 2
> - * VCDT2[0-15]: Channel 3 VCDT2[16-31]: Channel 4
> + * VCDT[0-15]: Channel 0 VCDT[16-31]: Channel 1
> + * VCDT2[0-15]: Channel 2 VCDT2[16-31]: Channel 3
> */
> #define VCDT_REG 0x10
> #define VCDT2_REG 0x14
> --
> 2.20.1
>
--
Regards,
Niklas Söderlund
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-04-24 13:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-24 10:39 [PATCH] media: rcar-csi2: Fix comment of VCDT/VCDT2 register Wolfram Sang
2020-04-24 13:26 ` Niklas Söderlund
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.