All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH -next] net/mlxfw: Remove unneeded semicolon
@ 2020-04-24  9:00 Zheng Bin
  2020-04-24 13:03 ` Ido Schimmel
  2020-04-24 23:56 ` David Miller
  0 siblings, 2 replies; 3+ messages in thread
From: Zheng Bin @ 2020-04-24  9:00 UTC (permalink / raw)
  To: mlxsw, davem, netdev; +Cc: zhengbin13

Fixes coccicheck warning:

drivers/net/ethernet/mellanox/mlxfw/mlxfw_fsm.c:79:2-3: Unneeded semicolon
drivers/net/ethernet/mellanox/mlxfw/mlxfw_fsm.c:162:2-3: Unneeded semicolon

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zheng Bin <zhengbin13@huawei.com>
---
 drivers/net/ethernet/mellanox/mlxfw/mlxfw_fsm.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/mellanox/mlxfw/mlxfw_fsm.c b/drivers/net/ethernet/mellanox/mlxfw/mlxfw_fsm.c
index 046a0cb82ed8..7a04c626a2aa 100644
--- a/drivers/net/ethernet/mellanox/mlxfw/mlxfw_fsm.c
+++ b/drivers/net/ethernet/mellanox/mlxfw/mlxfw_fsm.c
@@ -76,7 +76,7 @@ static int mlxfw_fsm_state_err(struct mlxfw_dev *mlxfw_dev,
 	case MLXFW_FSM_STATE_ERR_MAX:
 		MLXFW_ERR_MSG(mlxfw_dev, extack, "unknown error", err);
 		break;
-	};
+	}

 	return mlxfw_fsm_state_errno[fsm_state_err];
 };
@@ -159,7 +159,7 @@ mlxfw_fsm_reactivate_err(struct mlxfw_dev *mlxfw_dev,
 	case MLXFW_FSM_REACTIVATE_STATUS_MAX:
 		MLXFW_REACT_ERR("unexpected error", err);
 		break;
-	};
+	}
 	return -EREMOTEIO;
 };

--
2.26.0.106.g9fadedd


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH -next] net/mlxfw: Remove unneeded semicolon
  2020-04-24  9:00 [PATCH -next] net/mlxfw: Remove unneeded semicolon Zheng Bin
@ 2020-04-24 13:03 ` Ido Schimmel
  2020-04-24 23:56 ` David Miller
  1 sibling, 0 replies; 3+ messages in thread
From: Ido Schimmel @ 2020-04-24 13:03 UTC (permalink / raw)
  To: Zheng Bin; +Cc: mlxsw, davem, netdev

On Fri, Apr 24, 2020 at 05:00:15PM +0800, Zheng Bin wrote:
> Fixes coccicheck warning:
> 
> drivers/net/ethernet/mellanox/mlxfw/mlxfw_fsm.c:79:2-3: Unneeded semicolon
> drivers/net/ethernet/mellanox/mlxfw/mlxfw_fsm.c:162:2-3: Unneeded semicolon
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zheng Bin <zhengbin13@huawei.com>

Reviewed-by: Ido Schimmel <idosch@mellanox.com>

Thanks

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH -next] net/mlxfw: Remove unneeded semicolon
  2020-04-24  9:00 [PATCH -next] net/mlxfw: Remove unneeded semicolon Zheng Bin
  2020-04-24 13:03 ` Ido Schimmel
@ 2020-04-24 23:56 ` David Miller
  1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2020-04-24 23:56 UTC (permalink / raw)
  To: zhengbin13; +Cc: mlxsw, netdev

From: Zheng Bin <zhengbin13@huawei.com>
Date: Fri, 24 Apr 2020 17:00:15 +0800

> Fixes coccicheck warning:
> 
> drivers/net/ethernet/mellanox/mlxfw/mlxfw_fsm.c:79:2-3: Unneeded semicolon
> drivers/net/ethernet/mellanox/mlxfw/mlxfw_fsm.c:162:2-3: Unneeded semicolon
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zheng Bin <zhengbin13@huawei.com>

Applied, thanks.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-04-24 23:56 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-24  9:00 [PATCH -next] net/mlxfw: Remove unneeded semicolon Zheng Bin
2020-04-24 13:03 ` Ido Schimmel
2020-04-24 23:56 ` David Miller

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.