All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Darren Stevens <darren@stevens-zone.net>
Cc: madalin.bacur@nxp.com, netdev@vger.kernel.org, oss@buserror.net,
	chzigotzky@xenosoft.de, linuxppc-dev@lists.ozlabs.org
Subject: Re: [RFC PATCH dpss_eth] Don't initialise ports with no PHY
Date: Sat, 25 Apr 2020 02:10:21 +0200	[thread overview]
Message-ID: <20200425001021.GB1095011@lunn.ch> (raw)
In-Reply-To: <20200424232938.1a85d353@Cyrus.lan>

On Fri, Apr 24, 2020 at 11:29:38PM +0100, Darren Stevens wrote:
> Since cbb961ca271e ("Use random MAC address when none is given")
> Varisys Cyrus P5020 boards have been listing 5 ethernet ports instead of
> the 2 the board has.This is because we were preventing the adding of the
> unused ports by not suppling them a MAC address, which this patch now
> supplies.
> 
> Prevent them from appearing in the net devices list by checking for a
> 'status="disabled"' entry during probe and skipping the port if we find
> it. 

Hi Darren

I'm surprised the core is probing a device which has status disabled.
Are you sure this is the correct explanation?

    Thanks
	Andrew

WARNING: multiple messages have this Message-ID (diff)
From: Andrew Lunn <andrew@lunn.ch>
To: Darren Stevens <darren@stevens-zone.net>
Cc: oss@buserror.net, netdev@vger.kernel.org, madalin.bacur@nxp.com,
	linuxppc-dev@lists.ozlabs.org, chzigotzky@xenosoft.de
Subject: Re: [RFC PATCH dpss_eth] Don't initialise ports with no PHY
Date: Sat, 25 Apr 2020 02:10:21 +0200	[thread overview]
Message-ID: <20200425001021.GB1095011@lunn.ch> (raw)
In-Reply-To: <20200424232938.1a85d353@Cyrus.lan>

On Fri, Apr 24, 2020 at 11:29:38PM +0100, Darren Stevens wrote:
> Since cbb961ca271e ("Use random MAC address when none is given")
> Varisys Cyrus P5020 boards have been listing 5 ethernet ports instead of
> the 2 the board has.This is because we were preventing the adding of the
> unused ports by not suppling them a MAC address, which this patch now
> supplies.
> 
> Prevent them from appearing in the net devices list by checking for a
> 'status="disabled"' entry during probe and skipping the port if we find
> it. 

Hi Darren

I'm surprised the core is probing a device which has status disabled.
Are you sure this is the correct explanation?

    Thanks
	Andrew

  parent reply	other threads:[~2020-04-25  0:10 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-24 22:29 [RFC PATCH dpss_eth] Don't initialise ports with no PHY Darren Stevens
2020-04-24 22:29 ` Darren Stevens
2020-04-24 22:50 ` Florian Fainelli
2020-04-24 22:50   ` Florian Fainelli
2020-04-25  0:10 ` Andrew Lunn [this message]
2020-04-25  0:10   ` Andrew Lunn
2020-04-30 20:45   ` Darren Stevens
2020-04-29  8:26 ` [RFC PATCH dpss_eth] " Christian Zigotzky
2020-04-29  8:26   ` Christian Zigotzky
2020-04-29 13:12   ` Andrew Lunn
2020-04-29 13:12     ` Andrew Lunn
2020-04-29 13:55     ` Christian Zigotzky
2020-04-29 15:22       ` Andrew Lunn
2020-04-29 15:22         ` Andrew Lunn
2020-04-29 15:42         ` Christian Zigotzky
2020-04-29 15:42           ` Christian Zigotzky
2020-04-30 21:32           ` Darren Stevens
2020-05-01  5:35             ` Christian Zigotzky
2020-05-01  5:35               ` Christian Zigotzky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200425001021.GB1095011@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=chzigotzky@xenosoft.de \
    --cc=darren@stevens-zone.net \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=madalin.bacur@nxp.com \
    --cc=netdev@vger.kernel.org \
    --cc=oss@buserror.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.