All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [git commit] package/wireguard-linux-compat: tweak kernel-headers < 5.6 logic
@ 2020-04-25  9:56 Peter Korsgaard
  2020-05-08  9:51 ` Peter Korsgaard
  0 siblings, 1 reply; 2+ messages in thread
From: Peter Korsgaard @ 2020-04-25  9:56 UTC (permalink / raw)
  To: buildroot

commit: https://git.buildroot.net/buildroot/commit/?id=74a865b1fc85352b814d032fa8725ace13f27eca
branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/master

The reason why the external wireguard kernel module is not allowed with
kernel headers >= 5.6 is that wireguard is included in the upstream kernel
since 5.6 rather than some kind of (fixable) incompatibility issue.  Adjust
the comment to make that clear.

While we're at it, drop the redundant !5.6 dependency on the kernel headers
dependency comment.  If headers are older than 3.10, then they are also
older than 5.6, so the statement is redundant.

Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
---
 package/wireguard-linux-compat/Config.in | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/package/wireguard-linux-compat/Config.in b/package/wireguard-linux-compat/Config.in
index 6e41a0951b..5a323a35e5 100644
--- a/package/wireguard-linux-compat/Config.in
+++ b/package/wireguard-linux-compat/Config.in
@@ -3,7 +3,7 @@ config BR2_PACKAGE_WIREGUARD_LINUX_COMPAT
 	depends on BR2_LINUX_KERNEL
 	# kernel module requires 3.10+
 	depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_10
-	# kernel module incompatible with 5.6+
+	# kernel module in upstream linux since 5.6
 	depends on !BR2_TOOLCHAIN_HEADERS_AT_LEAST_5_6
 	help
 	  WireGuard is an extremely simple yet fast and modern VPN
@@ -23,5 +23,4 @@ config BR2_PACKAGE_WIREGUARD_LINUX_COMPAT
 
 comment "wireguard-linux-compat needs a toolchain w/ headers >= 3.10"
 	depends on BR2_LINUX_KERNEL
-	depends on !BR2_TOOLCHAIN_HEADERS_AT_LEAST_5_6
 	depends on !BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_10

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [Buildroot] [git commit] package/wireguard-linux-compat: tweak kernel-headers < 5.6 logic
  2020-04-25  9:56 [Buildroot] [git commit] package/wireguard-linux-compat: tweak kernel-headers < 5.6 logic Peter Korsgaard
@ 2020-05-08  9:51 ` Peter Korsgaard
  0 siblings, 0 replies; 2+ messages in thread
From: Peter Korsgaard @ 2020-05-08  9:51 UTC (permalink / raw)
  To: buildroot

>>>>> "Peter" == Peter Korsgaard <peter@korsgaard.com> writes:

 > commit: https://git.buildroot.net/buildroot/commit/?id=74a865b1fc85352b814d032fa8725ace13f27eca
 > branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/master

 > The reason why the external wireguard kernel module is not allowed with
 > kernel headers >= 5.6 is that wireguard is included in the upstream kernel
 > since 5.6 rather than some kind of (fixable) incompatibility issue.  Adjust
 > the comment to make that clear.

 > While we're at it, drop the redundant !5.6 dependency on the kernel headers
 > dependency comment.  If headers are older than 3.10, then they are also
 > older than 5.6, so the statement is redundant.

 > Signed-off-by: Peter Korsgaard <peter@korsgaard.com>

Committed to 2020.02.x, thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-05-08  9:51 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-25  9:56 [Buildroot] [git commit] package/wireguard-linux-compat: tweak kernel-headers < 5.6 logic Peter Korsgaard
2020-05-08  9:51 ` Peter Korsgaard

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.