Re: [PATCH 2/2] drm/bridge: ps8640: Let panel to set the connector type

From: Sam Ravnborg <sam@ravnborg.org>
To: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Cc: linux-kernel@vger.kernel.org,
	Jernej Skrabec <jernej.skrabec@siol.net>,
	drinkcat@chromium.org, Jonas Karlman <jonas@kwiboo.se>,
	David Airlie <airlied@linux.ie>,
	Neil Armstrong <narmstrong@baylibre.com>,
	dri-devel@lists.freedesktop.org,
	Andrzej Hajda <a.hajda@samsung.com>,
	Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
	hsinyi@chromium.org, matthias.bgg@gmail.com,
	Collabora Kernel ML <kernel@collabora.com>
Subject: Re: [PATCH 2/2] drm/bridge: ps8640: Let panel to set the connector type
Date: Sat, 25 Apr 2020 16:48:11 +0200	[thread overview]
Message-ID: <20200425144811.GD32235@ravnborg.org> (raw)
In-Reply-To: <20200416164404.2418426-2-enric.balletbo@collabora.com>

On Thu, Apr 16, 2020 at 06:44:04PM +0200, Enric Balletbo i Serra wrote:
> The panel connector type should be set by the panel not the bridge, so
> remove the connector_type assignment.
> 
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>

Thanks, applied to drm-misc-next.

	Sam

> ---
> 
>  drivers/gpu/drm/bridge/parade-ps8640.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/bridge/parade-ps8640.c b/drivers/gpu/drm/bridge/parade-ps8640.c
> index 956b76e0a44d..13755d278db6 100644
> --- a/drivers/gpu/drm/bridge/parade-ps8640.c
> +++ b/drivers/gpu/drm/bridge/parade-ps8640.c
> @@ -278,8 +278,6 @@ static int ps8640_probe(struct i2c_client *client)
>  	if (!panel)
>  		return -ENODEV;
>  
> -	panel->connector_type = DRM_MODE_CONNECTOR_eDP;
> -
>  	ps_bridge->panel_bridge = devm_drm_panel_bridge_add(dev, panel);
>  	if (IS_ERR(ps_bridge->panel_bridge))
>  		return PTR_ERR(ps_bridge->panel_bridge);
> -- 
> 2.25.1
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel