* [PATCH] chardev: Add macOS to list of OSes that support -chardev serial
@ 2020-04-26 21:09 Mikhail Gusarov
2020-04-27 10:17 ` Philippe Mathieu-Daudé
2020-05-04 9:48 ` Laurent Vivier
0 siblings, 2 replies; 3+ messages in thread
From: Mikhail Gusarov @ 2020-04-26 21:09 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, Mikhail Gusarov
macOS API for dealing with serial ports/ttys is identical to BSDs.
Signed-off-by: Mikhail Gusarov <dottedmag@dottedmag.net>
---
Note that the same file has a line
> #endif /* linux || sun */
that is severely out of date.
chardev/char-serial.c | 2 +-
include/qemu/osdep.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/chardev/char-serial.c b/chardev/char-serial.c
index 5b833ea077..7c3d84ae24 100644
--- a/chardev/char-serial.c
+++ b/chardev/char-serial.c
@@ -53,7 +53,7 @@ static void qmp_chardev_open_serial(Chardev *chr,
#elif defined(__linux__) || defined(__sun__) || defined(__FreeBSD__) \
|| defined(__NetBSD__) || defined(__OpenBSD__) || defined(__DragonFly__) \
- || defined(__GLIBC__)
+ || defined(__GLIBC__) || defined(__APPLE__)
static void tty_serial_init(int fd, int speed,
int parity, int data_bits, int stop_bits)
diff --git a/include/qemu/osdep.h b/include/qemu/osdep.h
index 20f5c5f197..ff7c17b857 100644
--- a/include/qemu/osdep.h
+++ b/include/qemu/osdep.h
@@ -379,7 +379,7 @@ void qemu_anon_ram_free(void *ptr, size_t size);
#define HAVE_CHARDEV_SERIAL 1
#elif defined(__linux__) || defined(__sun__) || defined(__FreeBSD__) \
|| defined(__NetBSD__) || defined(__OpenBSD__) || defined(__DragonFly__) \
- || defined(__GLIBC__)
+ || defined(__GLIBC__) || defined(__APPLE__)
#define HAVE_CHARDEV_SERIAL 1
#endif
--
2.19.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] chardev: Add macOS to list of OSes that support -chardev serial
2020-04-26 21:09 [PATCH] chardev: Add macOS to list of OSes that support -chardev serial Mikhail Gusarov
@ 2020-04-27 10:17 ` Philippe Mathieu-Daudé
2020-05-04 9:48 ` Laurent Vivier
1 sibling, 0 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-04-27 10:17 UTC (permalink / raw)
To: Mikhail Gusarov, qemu-devel; +Cc: qemu-trivial
On 4/26/20 11:09 PM, Mikhail Gusarov wrote:
> macOS API for dealing with serial ports/ttys is identical to BSDs.
>
> Signed-off-by: Mikhail Gusarov <dottedmag@dottedmag.net>
> ---
>
> Note that the same file has a line
>> #endif /* linux || sun */
> that is severely out of date.
>
> chardev/char-serial.c | 2 +-
> include/qemu/osdep.h | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/chardev/char-serial.c b/chardev/char-serial.c
> index 5b833ea077..7c3d84ae24 100644
> --- a/chardev/char-serial.c
> +++ b/chardev/char-serial.c
> @@ -53,7 +53,7 @@ static void qmp_chardev_open_serial(Chardev *chr,
>
> #elif defined(__linux__) || defined(__sun__) || defined(__FreeBSD__) \
> || defined(__NetBSD__) || defined(__OpenBSD__) || defined(__DragonFly__) \
> - || defined(__GLIBC__)
> + || defined(__GLIBC__) || defined(__APPLE__)
>
> static void tty_serial_init(int fd, int speed,
> int parity, int data_bits, int stop_bits)
> diff --git a/include/qemu/osdep.h b/include/qemu/osdep.h
> index 20f5c5f197..ff7c17b857 100644
> --- a/include/qemu/osdep.h
> +++ b/include/qemu/osdep.h
> @@ -379,7 +379,7 @@ void qemu_anon_ram_free(void *ptr, size_t size);
> #define HAVE_CHARDEV_SERIAL 1
> #elif defined(__linux__) || defined(__sun__) || defined(__FreeBSD__) \
> || defined(__NetBSD__) || defined(__OpenBSD__) || defined(__DragonFly__) \
> - || defined(__GLIBC__)
> + || defined(__GLIBC__) || defined(__APPLE__)
> #define HAVE_CHARDEV_SERIAL 1
> #endif
>
>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Tested-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] chardev: Add macOS to list of OSes that support -chardev serial
2020-04-26 21:09 [PATCH] chardev: Add macOS to list of OSes that support -chardev serial Mikhail Gusarov
2020-04-27 10:17 ` Philippe Mathieu-Daudé
@ 2020-05-04 9:48 ` Laurent Vivier
1 sibling, 0 replies; 3+ messages in thread
From: Laurent Vivier @ 2020-05-04 9:48 UTC (permalink / raw)
To: Mikhail Gusarov, qemu-devel; +Cc: qemu-trivial
Le 26/04/2020 à 23:09, Mikhail Gusarov a écrit :
> macOS API for dealing with serial ports/ttys is identical to BSDs.
>
> Signed-off-by: Mikhail Gusarov <dottedmag@dottedmag.net>
> ---
>
> Note that the same file has a line
>> #endif /* linux || sun */
> that is severely out of date.
>
> chardev/char-serial.c | 2 +-
> include/qemu/osdep.h | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/chardev/char-serial.c b/chardev/char-serial.c
> index 5b833ea077..7c3d84ae24 100644
> --- a/chardev/char-serial.c
> +++ b/chardev/char-serial.c
> @@ -53,7 +53,7 @@ static void qmp_chardev_open_serial(Chardev *chr,
>
> #elif defined(__linux__) || defined(__sun__) || defined(__FreeBSD__) \
> || defined(__NetBSD__) || defined(__OpenBSD__) || defined(__DragonFly__) \
> - || defined(__GLIBC__)
> + || defined(__GLIBC__) || defined(__APPLE__)
>
> static void tty_serial_init(int fd, int speed,
> int parity, int data_bits, int stop_bits)
> diff --git a/include/qemu/osdep.h b/include/qemu/osdep.h
> index 20f5c5f197..ff7c17b857 100644
> --- a/include/qemu/osdep.h
> +++ b/include/qemu/osdep.h
> @@ -379,7 +379,7 @@ void qemu_anon_ram_free(void *ptr, size_t size);
> #define HAVE_CHARDEV_SERIAL 1
> #elif defined(__linux__) || defined(__sun__) || defined(__FreeBSD__) \
> || defined(__NetBSD__) || defined(__OpenBSD__) || defined(__DragonFly__) \
> - || defined(__GLIBC__)
> + || defined(__GLIBC__) || defined(__APPLE__)
> #define HAVE_CHARDEV_SERIAL 1
> #endif
>
>
Applied to my trivial-patches branch.
Thanks,
Laurent
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-05-04 9:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-26 21:09 [PATCH] chardev: Add macOS to list of OSes that support -chardev serial Mikhail Gusarov
2020-04-27 10:17 ` Philippe Mathieu-Daudé
2020-05-04 9:48 ` Laurent Vivier
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.