* [PATCH] qemu-option: pass NULL rather than 0 to the id of qemu_opts_set()
@ 2020-04-27 0:57 Masahiro Yamada
2020-04-29 4:53 ` Markus Armbruster
0 siblings, 1 reply; 2+ messages in thread
From: Masahiro Yamada @ 2020-04-27 0:57 UTC (permalink / raw)
To: qemu-devel, Paolo Bonzini; +Cc: Masahiro Yamada
The second argument 'id' is a pointer. Pass NULL rather than 0.
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
---
softmmu/vl.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/softmmu/vl.c b/softmmu/vl.c
index 32c0047889..afd2615fb3 100644
--- a/softmmu/vl.c
+++ b/softmmu/vl.c
@@ -3059,19 +3059,19 @@ void qemu_init(int argc, char **argv, char **envp)
}
break;
case QEMU_OPTION_kernel:
- qemu_opts_set(qemu_find_opts("machine"), 0, "kernel", optarg,
+ qemu_opts_set(qemu_find_opts("machine"), NULL, "kernel", optarg,
&error_abort);
break;
case QEMU_OPTION_initrd:
- qemu_opts_set(qemu_find_opts("machine"), 0, "initrd", optarg,
+ qemu_opts_set(qemu_find_opts("machine"), NULL, "initrd", optarg,
&error_abort);
break;
case QEMU_OPTION_append:
- qemu_opts_set(qemu_find_opts("machine"), 0, "append", optarg,
+ qemu_opts_set(qemu_find_opts("machine"), NULL, "append", optarg,
&error_abort);
break;
case QEMU_OPTION_dtb:
- qemu_opts_set(qemu_find_opts("machine"), 0, "dtb", optarg,
+ qemu_opts_set(qemu_find_opts("machine"), NULL, "dtb", optarg,
&error_abort);
break;
case QEMU_OPTION_cdrom:
@@ -3182,7 +3182,7 @@ void qemu_init(int argc, char **argv, char **envp)
}
break;
case QEMU_OPTION_bios:
- qemu_opts_set(qemu_find_opts("machine"), 0, "firmware", optarg,
+ qemu_opts_set(qemu_find_opts("machine"), NULL, "firmware", optarg,
&error_abort);
break;
case QEMU_OPTION_singlestep:
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] qemu-option: pass NULL rather than 0 to the id of qemu_opts_set()
2020-04-27 0:57 [PATCH] qemu-option: pass NULL rather than 0 to the id of qemu_opts_set() Masahiro Yamada
@ 2020-04-29 4:53 ` Markus Armbruster
0 siblings, 0 replies; 2+ messages in thread
From: Markus Armbruster @ 2020-04-29 4:53 UTC (permalink / raw)
To: Masahiro Yamada; +Cc: Paolo Bonzini, qemu-devel
Masahiro Yamada <masahiroy@kernel.org> writes:
> The second argument 'id' is a pointer. Pass NULL rather than 0.
>
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
and queued, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-04-29 4:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-27 0:57 [PATCH] qemu-option: pass NULL rather than 0 to the id of qemu_opts_set() Masahiro Yamada
2020-04-29 4:53 ` Markus Armbruster
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.