From: Christoph Hellwig <hch@infradead.org>
To: Ira Weiny <ira.weiny@intel.com>
Cc: Christoph Hellwig <hch@infradead.org>,
linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Dan Williams <dan.j.williams@intel.com>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
"James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>,
Helge Deller <deller@gmx.de>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
"David S. Miller" <davem@davemloft.net>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
Andy Lutomirski <luto@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Chris Zankel <chris@zankel.net>,
Max Filippov <jcmvbkbc@gmail.com>,
linux-snps-arc@lists.infradead.org,
linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org,
linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, sparclinux@vger.kernel.org,
linux-xtensa@linux-xtensa.org
Subject: Re: [PATCH 4/5] arch/kmap_atomic: Consolidate duplicate code
Date: Sun, 26 Apr 2020 23:25:00 -0700 [thread overview]
Message-ID: <20200427062500.GA32152@infradead.org> (raw)
In-Reply-To: <20200427011630.GC135929@iweiny-DESK2.sc.intel.com>
On Sun, Apr 26, 2020 at 06:16:30PM -0700, Ira Weiny wrote:
> > That might require to support
> > kmap_atomic_prot everywhere first, which sounds like a really good
> > idea anyway, and would avoid the need for strange workaround in drm.
>
> Having a kmap_atomic_prot() seems like a good idea. But I'm not exactly sure
> why CONFIG_x86 is being called out specifically in the DRM code?
Probably because it only existed on x86 back then. And drm has a
tendency of working around core problems with hacks instead of doing
the fairly easy fixups.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: Ira Weiny <ira.weiny@intel.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Dave Hansen <dave.hansen@linux.intel.com>,
linux-mips@vger.kernel.org,
"James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>,
Max Filippov <jcmvbkbc@gmail.com>,
Paul Mackerras <paulus@samba.org>,
"H. Peter Anvin" <hpa@zytor.com>,
sparclinux@vger.kernel.org,
Dan Williams <dan.j.williams@intel.com>,
Helge Deller <deller@gmx.de>,
x86@kernel.org, linux-csky@vger.kernel.org,
Christoph Hellwig <hch@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
linux-snps-arc@lists.infradead.org,
linux-xtensa@linux-xtensa.org, Borislav Petkov <bp@alien8.de>,
Andy Lutomirski <luto@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
linux-arm-kernel@lists.infradead.org,
Chris Zankel <chris@zankel.net>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
linux-parisc@vger.kernel.org, linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
linuxppc-dev@lists.ozlabs.org,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH 4/5] arch/kmap_atomic: Consolidate duplicate code
Date: Mon, 27 Apr 2020 06:25:00 +0000 [thread overview]
Message-ID: <20200427062500.GA32152@infradead.org> (raw)
In-Reply-To: <20200427011630.GC135929@iweiny-DESK2.sc.intel.com>
On Sun, Apr 26, 2020 at 06:16:30PM -0700, Ira Weiny wrote:
> > That might require to support
> > kmap_atomic_prot everywhere first, which sounds like a really good
> > idea anyway, and would avoid the need for strange workaround in drm.
>
> Having a kmap_atomic_prot() seems like a good idea. But I'm not exactly sure
> why CONFIG_x86 is being called out specifically in the DRM code?
Probably because it only existed on x86 back then. And drm has a
tendency of working around core problems with hacks instead of doing
the fairly easy fixups.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: Ira Weiny <ira.weiny@intel.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Dave Hansen <dave.hansen@linux.intel.com>,
linux-mips@vger.kernel.org,
"James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>,
Max Filippov <jcmvbkbc@gmail.com>,
Paul Mackerras <paulus@samba.org>,
"H. Peter Anvin" <hpa@zytor.com>,
sparclinux@vger.kernel.org,
Dan Williams <dan.j.williams@intel.com>,
Helge Deller <deller@gmx.de>,
x86@kernel.org, linux-csky@vger.kernel.org,
Christoph Hellwig <hch@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
linux-snps-arc@lists.infradead.org,
linux-xtensa@linux-xtensa.org, Borislav Petkov <bp@alien8.de>,
Andy Lutomirski <luto@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
linux-arm-kernel@lists.infradead.org,
Chris Zankel <chris@zankel.net>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
linux-parisc@vger.kernel.org, linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
linuxppc-dev@lists.ozlabs.org,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH 4/5] arch/kmap_atomic: Consolidate duplicate code
Date: Sun, 26 Apr 2020 23:25:00 -0700 [thread overview]
Message-ID: <20200427062500.GA32152@infradead.org> (raw)
In-Reply-To: <20200427011630.GC135929@iweiny-DESK2.sc.intel.com>
On Sun, Apr 26, 2020 at 06:16:30PM -0700, Ira Weiny wrote:
> > That might require to support
> > kmap_atomic_prot everywhere first, which sounds like a really good
> > idea anyway, and would avoid the need for strange workaround in drm.
>
> Having a kmap_atomic_prot() seems like a good idea. But I'm not exactly sure
> why CONFIG_x86 is being called out specifically in the DRM code?
Probably because it only existed on x86 back then. And drm has a
tendency of working around core problems with hacks instead of doing
the fairly easy fixups.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: Ira Weiny <ira.weiny@intel.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Dave Hansen <dave.hansen@linux.intel.com>,
linux-mips@vger.kernel.org,
"James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>,
Max Filippov <jcmvbkbc@gmail.com>,
Paul Mackerras <paulus@samba.org>,
"H. Peter Anvin" <hpa@zytor.com>,
sparclinux@vger.kernel.org,
Dan Williams <dan.j.williams@intel.com>,
Helge Deller <deller@gmx.de>,
x86@kernel.org, linux-csky@vger.kernel.org,
Christoph Hellwig <hch@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
linux-snps-arc@lists.infradead.org,
linux-xtensa@linux-xtensa.org, Borislav Petkov <bp@alien8.de>,
Andy Lutomirski <luto@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
linux-arm-kernel@lists.infradead.org,
Chris Zankel <chris@zankel.net>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
linux-parisc@vger.kernel.org, linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
linuxppc-dev@lists.ozlabs.org,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH 4/5] arch/kmap_atomic: Consolidate duplicate code
Date: Sun, 26 Apr 2020 23:25:00 -0700 [thread overview]
Message-ID: <20200427062500.GA32152@infradead.org> (raw)
In-Reply-To: <20200427011630.GC135929@iweiny-DESK2.sc.intel.com>
On Sun, Apr 26, 2020 at 06:16:30PM -0700, Ira Weiny wrote:
> > That might require to support
> > kmap_atomic_prot everywhere first, which sounds like a really good
> > idea anyway, and would avoid the need for strange workaround in drm.
>
> Having a kmap_atomic_prot() seems like a good idea. But I'm not exactly sure
> why CONFIG_x86 is being called out specifically in the DRM code?
Probably because it only existed on x86 back then. And drm has a
tendency of working around core problems with hacks instead of doing
the fairly easy fixups.
_______________________________________________
linux-snps-arc mailing list
linux-snps-arc@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-snps-arc
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: Ira Weiny <ira.weiny@intel.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Dave Hansen <dave.hansen@linux.intel.com>,
linux-mips@vger.kernel.org,
"James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>,
Max Filippov <jcmvbkbc@gmail.com>,
Paul Mackerras <paulus@samba.org>,
"H. Peter Anvin" <hpa@zytor.com>,
sparclinux@vger.kernel.org,
Dan Williams <dan.j.williams@intel.com>,
Helge Deller <deller@gmx.de>,
x86@kernel.org, linux-csky@vger.kernel.org,
Christoph Hellwig <hch@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
linux-snps-arc@lists.infradead.org,
linux-xtensa@linux-xtensa.org, Borislav Petkov <bp@alien8.de>,
Andy Lutomirski <luto@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
linux-arm-kernel@lists.infradead.org,
Chris Zankel <chris@zankel.net>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
linux-parisc@vger.kernel.org, linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
linuxppc-dev@lists.ozlabs.org,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH 4/5] arch/kmap_atomic: Consolidate duplicate code
Date: Sun, 26 Apr 2020 23:25:00 -0700 [thread overview]
Message-ID: <20200427062500.GA32152@infradead.org> (raw)
In-Reply-To: <20200427011630.GC135929@iweiny-DESK2.sc.intel.com>
On Sun, Apr 26, 2020 at 06:16:30PM -0700, Ira Weiny wrote:
> > That might require to support
> > kmap_atomic_prot everywhere first, which sounds like a really good
> > idea anyway, and would avoid the need for strange workaround in drm.
>
> Having a kmap_atomic_prot() seems like a good idea. But I'm not exactly sure
> why CONFIG_x86 is being called out specifically in the DRM code?
Probably because it only existed on x86 back then. And drm has a
tendency of working around core problems with hacks instead of doing
the fairly easy fixups.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-04-27 6:25 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-26 5:54 [PATCH 0/5] Remove duplicated kmap code ira.weiny
2020-04-26 5:54 ` ira.weiny
2020-04-26 5:54 ` ira.weiny
2020-04-26 5:54 ` ira.weiny
2020-04-26 5:54 ` ira.weiny
2020-04-26 5:54 ` [PATCH 1/5] arch/kmap: Remove BUG_ON() ira.weiny
2020-04-26 5:54 ` ira.weiny
2020-04-26 5:54 ` ira.weiny
2020-04-26 5:54 ` ira.weiny
2020-04-26 5:54 ` ira.weiny
2020-04-26 5:54 ` [PATCH 2/5] arch/kmap: Remove redundant arch specific kmaps ira.weiny
2020-04-26 5:54 ` ira.weiny
2020-04-26 5:54 ` ira.weiny
2020-04-26 5:54 ` ira.weiny
2020-04-26 5:54 ` ira.weiny
2020-04-26 7:17 ` Christoph Hellwig
2020-04-26 7:17 ` Christoph Hellwig
2020-04-26 7:17 ` Christoph Hellwig
2020-04-26 7:17 ` Christoph Hellwig
2020-04-26 7:17 ` Christoph Hellwig
2020-04-26 22:23 ` Ira Weiny
2020-04-26 22:23 ` Ira Weiny
2020-04-26 22:23 ` Ira Weiny
2020-04-26 22:23 ` Ira Weiny
2020-04-26 22:23 ` Ira Weiny
2020-04-26 5:54 ` [PATCH 3/5] arch/kunmap: Remove duplicate kunmap implementations ira.weiny
2020-04-26 5:54 ` ira.weiny
2020-04-26 5:54 ` ira.weiny
2020-04-26 5:54 ` ira.weiny
2020-04-26 5:54 ` ira.weiny
2020-04-26 5:54 ` [PATCH 4/5] arch/kmap_atomic: Consolidate duplicate code ira.weiny
2020-04-26 5:54 ` ira.weiny
2020-04-26 5:54 ` ira.weiny
2020-04-26 5:54 ` ira.weiny
2020-04-26 5:54 ` ira.weiny
2020-04-26 7:26 ` Christoph Hellwig
2020-04-26 7:26 ` Christoph Hellwig
2020-04-26 7:26 ` Christoph Hellwig
2020-04-26 7:26 ` Christoph Hellwig
2020-04-26 7:26 ` Christoph Hellwig
2020-04-27 1:16 ` Ira Weiny
2020-04-27 1:16 ` Ira Weiny
2020-04-27 1:16 ` Ira Weiny
2020-04-27 1:16 ` Ira Weiny
2020-04-27 1:16 ` Ira Weiny
2020-04-27 6:25 ` Christoph Hellwig [this message]
2020-04-27 6:25 ` Christoph Hellwig
2020-04-27 6:25 ` Christoph Hellwig
2020-04-27 6:25 ` Christoph Hellwig
2020-04-27 6:25 ` Christoph Hellwig
2020-04-26 5:54 ` [PATCH 5/5] arch/kunmap_atomic: " ira.weiny
2020-04-26 5:54 ` ira.weiny
2020-04-26 5:54 ` ira.weiny
2020-04-26 5:54 ` ira.weiny
2020-04-26 5:54 ` ira.weiny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200427062500.GA32152@infradead.org \
--to=hch@infradead.org \
--cc=James.Bottomley@hansenpartnership.com \
--cc=akpm@linux-foundation.org \
--cc=benh@kernel.crashing.org \
--cc=bp@alien8.de \
--cc=chris@zankel.net \
--cc=dan.j.williams@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=davem@davemloft.net \
--cc=deller@gmx.de \
--cc=hpa@zytor.com \
--cc=ira.weiny@intel.com \
--cc=jcmvbkbc@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-csky@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=linux-snps-arc@lists.infradead.org \
--cc=linux-xtensa@linux-xtensa.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
--cc=sparclinux@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=tsbogend@alpha.franken.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.