All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drivers/video: cleanup coding style in video a bit
@ 2020-04-27  8:05   ` Bernard Zhao
  0 siblings, 0 replies; 12+ messages in thread
From: Bernard Zhao @ 2020-04-27  8:05 UTC (permalink / raw)
  To: Bartlomiej Zolnierkiewicz, Uma Shankar, Ville Syrjälä,
	Shashank Sharma, Laurent Pinchart, Daniel Vetter, Bernard Zhao,
	dri-devel, linux-fbdev, linux-kernel
  Cc: opensource.kernel

Eliminate the magic numbers, add vender infoframe size macro
like other hdmi modules.

Signed-off-by: Bernard Zhao <bernard@vivo.com>
---
 drivers/video/hdmi.c | 2 +-
 include/linux/hdmi.h | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/video/hdmi.c b/drivers/video/hdmi.c
index 856a8c4e84a2..f693076f2e5f 100644
--- a/drivers/video/hdmi.c
+++ b/drivers/video/hdmi.c
@@ -495,7 +495,7 @@ int hdmi_vendor_infoframe_init(struct hdmi_vendor_infoframe *frame)
 	 * value
 	 */
 	frame->s3d_struct = HDMI_3D_STRUCTURE_INVALID;
-	frame->length = 4;
+	frame->length = HDMI_VENDOR_INFOFRAME_SIZE;
 
 	return 0;
 }
diff --git a/include/linux/hdmi.h b/include/linux/hdmi.h
index 9613d796cfb1..ff25aeb95ee4 100644
--- a/include/linux/hdmi.h
+++ b/include/linux/hdmi.h
@@ -57,6 +57,7 @@ enum hdmi_infoframe_type {
 #define HDMI_SPD_INFOFRAME_SIZE    25
 #define HDMI_AUDIO_INFOFRAME_SIZE  10
 #define HDMI_DRM_INFOFRAME_SIZE    26
+#define HDMI_VENDOR_INFOFRAME_SIZE  4
 
 #define HDMI_INFOFRAME_SIZE(type)	\
 	(HDMI_INFOFRAME_HEADER_SIZE + HDMI_ ## type ## _INFOFRAME_SIZE)
-- 
2.26.2


^ permalink raw reply related	[flat|nested] 12+ messages in thread
* [PATCH] drivers/video: cleanup coding style in video a bit
@ 2020-04-27  8:05   ` Bernard Zhao
  0 siblings, 0 replies; 12+ messages in thread
From: Bernard Zhao @ 2020-04-27  8:05 UTC (permalink / raw)
  To: Bartlomiej Zolnierkiewicz, Uma Shankar, Ville Syrjälä,
	Shashank Sharma, Laurent Pinchart, Daniel Vetter, Bernard Zhao,
	dri-devel, linux-fbdev, linux-kernel
  Cc: opensource.kernel

Eliminate the magic numbers, add vender infoframe size macro
like other hdmi modules.

Signed-off-by: Bernard Zhao <bernard@vivo.com>
---
 drivers/video/hdmi.c | 2 +-
 include/linux/hdmi.h | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/video/hdmi.c b/drivers/video/hdmi.c
index 856a8c4e84a2..f693076f2e5f 100644
--- a/drivers/video/hdmi.c
+++ b/drivers/video/hdmi.c
@@ -495,7 +495,7 @@ int hdmi_vendor_infoframe_init(struct hdmi_vendor_infoframe *frame)
 	 * value
 	 */
 	frame->s3d_struct = HDMI_3D_STRUCTURE_INVALID;
-	frame->length = 4;
+	frame->length = HDMI_VENDOR_INFOFRAME_SIZE;
 
 	return 0;
 }
diff --git a/include/linux/hdmi.h b/include/linux/hdmi.h
index 9613d796cfb1..ff25aeb95ee4 100644
--- a/include/linux/hdmi.h
+++ b/include/linux/hdmi.h
@@ -57,6 +57,7 @@ enum hdmi_infoframe_type {
 #define HDMI_SPD_INFOFRAME_SIZE    25
 #define HDMI_AUDIO_INFOFRAME_SIZE  10
 #define HDMI_DRM_INFOFRAME_SIZE    26
+#define HDMI_VENDOR_INFOFRAME_SIZE  4
 
 #define HDMI_INFOFRAME_SIZE(type)	\
 	(HDMI_INFOFRAME_HEADER_SIZE + HDMI_ ## type ## _INFOFRAME_SIZE)
-- 
2.26.2

^ permalink raw reply related	[flat|nested] 12+ messages in thread
* [PATCH] drivers/video: cleanup coding style in video a bit
@ 2020-04-27  8:05   ` Bernard Zhao
  0 siblings, 0 replies; 12+ messages in thread
From: Bernard Zhao @ 2020-04-27  8:05 UTC (permalink / raw)
  To: Bartlomiej Zolnierkiewicz, Uma Shankar, Ville Syrjälä,
	Shashank Sharma, Laurent Pinchart, Daniel Vetter, Bernard Zhao,
	dri-devel, linux-fbdev, linux-kernel
  Cc: opensource.kernel

Eliminate the magic numbers, add vender infoframe size macro
like other hdmi modules.

Signed-off-by: Bernard Zhao <bernard@vivo.com>
---
 drivers/video/hdmi.c | 2 +-
 include/linux/hdmi.h | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/video/hdmi.c b/drivers/video/hdmi.c
index 856a8c4e84a2..f693076f2e5f 100644
--- a/drivers/video/hdmi.c
+++ b/drivers/video/hdmi.c
@@ -495,7 +495,7 @@ int hdmi_vendor_infoframe_init(struct hdmi_vendor_infoframe *frame)
 	 * value
 	 */
 	frame->s3d_struct = HDMI_3D_STRUCTURE_INVALID;
-	frame->length = 4;
+	frame->length = HDMI_VENDOR_INFOFRAME_SIZE;
 
 	return 0;
 }
diff --git a/include/linux/hdmi.h b/include/linux/hdmi.h
index 9613d796cfb1..ff25aeb95ee4 100644
--- a/include/linux/hdmi.h
+++ b/include/linux/hdmi.h
@@ -57,6 +57,7 @@ enum hdmi_infoframe_type {
 #define HDMI_SPD_INFOFRAME_SIZE    25
 #define HDMI_AUDIO_INFOFRAME_SIZE  10
 #define HDMI_DRM_INFOFRAME_SIZE    26
+#define HDMI_VENDOR_INFOFRAME_SIZE  4
 
 #define HDMI_INFOFRAME_SIZE(type)	\
 	(HDMI_INFOFRAME_HEADER_SIZE + HDMI_ ## type ## _INFOFRAME_SIZE)
-- 
2.26.2

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply related	[flat|nested] 12+ messages in thread
* Re: [PATCH] drivers/video: cleanup coding style in video a bit
  2020-04-27  8:05   ` Bernard Zhao
  (?)
@ 2020-04-27  8:36 ` Markus Elfring
  -1 siblings, 0 replies; 12+ messages in thread
From: Markus Elfring @ 2020-04-27  8:36 UTC (permalink / raw)
  To: Bernard Zhao, dri-devel, linux-fbdev
  Cc: linux-kernel, opensource.kernel, Bartlomiej Zolnierkiewicz,
	Daniel Vetter, Laurent Pinchart, Shashank Sharma, Uma Shankar,
	Ville Syrjälä

> Eliminate the magic numbers, add vender infoframe size macro
> like other hdmi modules.

How do you think about a wording variant like the following?

   Subject:
   [PATCH v2] video/hdmi: Use “HDMI_VENDOR_INFOFRAME_SIZE” in hdmi_vendor_infoframe_init()

   Change description:
   Adjust the usage of a “magic” number here by adding a macro for
   the vendor info frame size (similar to other video modules).


Regards,
Markus

^ permalink raw reply	[flat|nested] 12+ messages in thread
* Re: [PATCH] drivers/video: cleanup coding style in video a bit
@ 2020-04-27  8:36 ` Markus Elfring
  0 siblings, 0 replies; 12+ messages in thread
From: Markus Elfring @ 2020-04-27  8:36 UTC (permalink / raw)
  To: Bernard Zhao, dri-devel, linux-fbdev
  Cc: opensource.kernel, Bartlomiej Zolnierkiewicz, Daniel Vetter,
	linux-kernel, Uma Shankar, Laurent Pinchart, Shashank Sharma

> Eliminate the magic numbers, add vender infoframe size macro
> like other hdmi modules.

How do you think about a wording variant like the following?

   Subject:
   [PATCH v2] video/hdmi: Use “HDMI_VENDOR_INFOFRAME_SIZE” in hdmi_vendor_infoframe_init()

   Change description:
   Adjust the usage of a “magic” number here by adding a macro for
   the vendor info frame size (similar to other video modules).


Regards,
Markus

^ permalink raw reply	[flat|nested] 12+ messages in thread
* Re: [PATCH] drivers/video: cleanup coding style in video a bit
@ 2020-04-27  8:36 ` Markus Elfring
  0 siblings, 0 replies; 12+ messages in thread
From: Markus Elfring @ 2020-04-27  8:36 UTC (permalink / raw)
  To: Bernard Zhao, dri-devel, linux-fbdev
  Cc: opensource.kernel, Bartlomiej Zolnierkiewicz, Daniel Vetter,
	linux-kernel, Uma Shankar, Laurent Pinchart, Shashank Sharma

> Eliminate the magic numbers, add vender infoframe size macro
> like other hdmi modules.

How do you think about a wording variant like the following?

   Subject:
   [PATCH v2] video/hdmi: Use “HDMI_VENDOR_INFOFRAME_SIZE” in hdmi_vendor_infoframe_init()

   Change description:
   Adjust the usage of a “magic” number here by adding a macro for
   the vendor info frame size (similar to other video modules).


Regards,
Markus
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 12+ messages in thread
* Re:[PATCH] drivers/video: cleanup coding style in video a bit
  2020-04-27  8:05   ` Bernard Zhao
  (?)
@ 2020-05-08  1:53     ` Bernard
  -1 siblings, 0 replies; 12+ messages in thread
From: Bernard @ 2020-05-08  1:53 UTC (permalink / raw)
  To: Bernard Zhao
  Cc: Bartlomiej Zolnierkiewicz, Uma Shankar, Ville Syrjälä,
	Shashank Sharma, Laurent Pinchart, Daniel Vetter, dri-devel,
	linux-fbdev, linux-kernel, opensource.kernel


From: Bernard Zhao <bernard@vivo.com>
Date: 2020-04-27 16:05:23
To:  Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,Uma Shankar <uma.shankar@intel.com>,"Ville Syrjälä" <ville.syrjala@linux.intel.com>,Shashank Sharma <shashank.sharma@intel.com>,Laurent Pinchart <laurent.pinchart@ideasonboard.com>,Daniel Vetter <daniel.vetter@ffwll.ch>,Bernard Zhao <bernard@vivo.com>,dri-devel@lists.freedesktop.org,linux-fbdev@vger.kernel.org,linux-kernel@vger.kernel.org
Cc:  opensource.kernel@vivo.com
Subject: [PATCH] drivers/video: cleanup coding style in video a bit>Eliminate the magic numbers, add vender infoframe size macro
>like other hdmi modules.
>
>Signed-off-by: Bernard Zhao <bernard@vivo.com>
>---
> drivers/video/hdmi.c | 2 +-
> include/linux/hdmi.h | 1 +
> 2 files changed, 2 insertions(+), 1 deletion(-)
>
>diff --git a/drivers/video/hdmi.c b/drivers/video/hdmi.c
>index 856a8c4e84a2..f693076f2e5f 100644
>--- a/drivers/video/hdmi.c
>+++ b/drivers/video/hdmi.c
>@@ -495,7 +495,7 @@ int hdmi_vendor_infoframe_init(struct hdmi_vendor_infoframe *frame)
> 	 * value
> 	 */
> 	frame->s3d_struct = HDMI_3D_STRUCTURE_INVALID;
>-	frame->length = 4;
>+	frame->length = HDMI_VENDOR_INFOFRAME_SIZE;
> 
> 	return 0;
> }
>diff --git a/include/linux/hdmi.h b/include/linux/hdmi.h
>index 9613d796cfb1..ff25aeb95ee4 100644
>--- a/include/linux/hdmi.h
>+++ b/include/linux/hdmi.h
>@@ -57,6 +57,7 @@ enum hdmi_infoframe_type {
> #define HDMI_SPD_INFOFRAME_SIZE    25
> #define HDMI_AUDIO_INFOFRAME_SIZE  10
> #define HDMI_DRM_INFOFRAME_SIZE    26
>+#define HDMI_VENDOR_INFOFRAME_SIZE  4
> 
> #define HDMI_INFOFRAME_SIZE(type)	\
> 	(HDMI_INFOFRAME_HEADER_SIZE + HDMI_ ## type ## _INFOFRAME_SIZE)
>-- 
>2.26.2
>



^ permalink raw reply	[flat|nested] 12+ messages in thread
* Re:[PATCH] drivers/video: cleanup coding style in video a bit
@ 2020-05-08  1:53     ` Bernard
  0 siblings, 0 replies; 12+ messages in thread
From: Bernard @ 2020-05-08  1:53 UTC (permalink / raw)
  To: Bernard Zhao
  Cc: opensource.kernel, linux-fbdev, Bartlomiej Zolnierkiewicz,
	Daniel Vetter, linux-kernel, dri-devel, Uma Shankar,
	Laurent Pinchart, Shashank Sharma

CkZyb206IEJlcm5hcmQgWmhhbyA8YmVybmFyZEB2aXZvLmNvbT4KRGF0ZTogMjAyMC0wNC0yNyAx
NjowNToyMwpUbzogIEJhcnRsb21pZWogWm9sbmllcmtpZXdpY3ogPGIuem9sbmllcmtpZUBzYW1z
dW5nLmNvbT4sVW1hIFNoYW5rYXIgPHVtYS5zaGFua2FyQGludGVsLmNvbT4sIlZpbGxlIFN5cmrD
pGzDpCIgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPixTaGFzaGFuayBTaGFybWEgPHNo
YXNoYW5rLnNoYXJtYUBpbnRlbC5jb20+LExhdXJlbnQgUGluY2hhcnQgPGxhdXJlbnQucGluY2hh
cnRAaWRlYXNvbmJvYXJkLmNvbT4sRGFuaWVsIFZldHRlciA8ZGFuaWVsLnZldHRlckBmZndsbC5j
aD4sQmVybmFyZCBaaGFvIDxiZXJuYXJkQHZpdm8uY29tPixkcmktZGV2ZWxAbGlzdHMuZnJlZWRl
c2t0b3Aub3JnLGxpbnV4LWZiZGV2QHZnZXIua2VybmVsLm9yZyxsaW51eC1rZXJuZWxAdmdlci5r
ZXJuZWwub3JnCkNjOiAgb3BlbnNvdXJjZS5rZXJuZWxAdml2by5jb20KU3ViamVjdDogW1BBVENI
XSBkcml2ZXJzL3ZpZGVvOiBjbGVhbnVwIGNvZGluZyBzdHlsZSBpbiB2aWRlbyBhIGJpdD5FbGlt
aW5hdGUgdGhlIG1hZ2ljIG51bWJlcnMsIGFkZCB2ZW5kZXIgaW5mb2ZyYW1lIHNpemUgbWFjcm8K
Pmxpa2Ugb3RoZXIgaGRtaSBtb2R1bGVzLgo+Cj5TaWduZWQtb2ZmLWJ5OiBCZXJuYXJkIFpoYW8g
PGJlcm5hcmRAdml2by5jb20+Cj4tLS0KPiBkcml2ZXJzL3ZpZGVvL2hkbWkuYyB8IDIgKy0KPiBp
bmNsdWRlL2xpbnV4L2hkbWkuaCB8IDEgKwo+IDIgZmlsZXMgY2hhbmdlZCwgMiBpbnNlcnRpb25z
KCspLCAxIGRlbGV0aW9uKC0pCj4KPmRpZmYgLS1naXQgYS9kcml2ZXJzL3ZpZGVvL2hkbWkuYyBi
L2RyaXZlcnMvdmlkZW8vaGRtaS5jCj5pbmRleCA4NTZhOGM0ZTg0YTIuLmY2OTMwNzZmMmU1ZiAx
MDA2NDQKPi0tLSBhL2RyaXZlcnMvdmlkZW8vaGRtaS5jCj4rKysgYi9kcml2ZXJzL3ZpZGVvL2hk
bWkuYwo+QEAgLTQ5NSw3ICs0OTUsNyBAQCBpbnQgaGRtaV92ZW5kb3JfaW5mb2ZyYW1lX2luaXQo
c3RydWN0IGhkbWlfdmVuZG9yX2luZm9mcmFtZSAqZnJhbWUpCj4gCSAqIHZhbHVlCj4gCSAqLwo+
IAlmcmFtZS0+czNkX3N0cnVjdCA9IEhETUlfM0RfU1RSVUNUVVJFX0lOVkFMSUQ7Cj4tCWZyYW1l
LT5sZW5ndGggPSA0Owo+KwlmcmFtZS0+bGVuZ3RoID0gSERNSV9WRU5ET1JfSU5GT0ZSQU1FX1NJ
WkU7Cj4gCj4gCXJldHVybiAwOwo+IH0KPmRpZmYgLS1naXQgYS9pbmNsdWRlL2xpbnV4L2hkbWku
aCBiL2luY2x1ZGUvbGludXgvaGRtaS5oCj5pbmRleCA5NjEzZDc5NmNmYjEuLmZmMjVhZWI5NWVl
NCAxMDA2NDQKPi0tLSBhL2luY2x1ZGUvbGludXgvaGRtaS5oCj4rKysgYi9pbmNsdWRlL2xpbnV4
L2hkbWkuaAo+QEAgLTU3LDYgKzU3LDcgQEAgZW51bSBoZG1pX2luZm9mcmFtZV90eXBlIHsKPiAj
ZGVmaW5lIEhETUlfU1BEX0lORk9GUkFNRV9TSVpFICAgIDI1Cj4gI2RlZmluZSBIRE1JX0FVRElP
X0lORk9GUkFNRV9TSVpFICAxMAo+ICNkZWZpbmUgSERNSV9EUk1fSU5GT0ZSQU1FX1NJWkUgICAg
MjYKPisjZGVmaW5lIEhETUlfVkVORE9SX0lORk9GUkFNRV9TSVpFICA0Cj4gCj4gI2RlZmluZSBI
RE1JX0lORk9GUkFNRV9TSVpFKHR5cGUpCVwKPiAJKEhETUlfSU5GT0ZSQU1FX0hFQURFUl9TSVpF
ICsgSERNSV8gIyMgdHlwZSAjIyBfSU5GT0ZSQU1FX1NJWkUpCj4tLSAKPjIuMjYuMgo+Cg0KDQo

^ permalink raw reply	[flat|nested] 12+ messages in thread
* Re:[PATCH] drivers/video: cleanup coding style in video a bit
@ 2020-05-08  1:53     ` Bernard
  0 siblings, 0 replies; 12+ messages in thread
From: Bernard @ 2020-05-08  1:53 UTC (permalink / raw)
  To: Bernard Zhao
  Cc: opensource.kernel, linux-fbdev, Bartlomiej Zolnierkiewicz,
	Daniel Vetter, linux-kernel, dri-devel, Uma Shankar,
	Laurent Pinchart, Shashank Sharma


From: Bernard Zhao <bernard@vivo.com>
Date: 2020-04-27 16:05:23
To:  Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,Uma Shankar <uma.shankar@intel.com>,"Ville Syrjälä" <ville.syrjala@linux.intel.com>,Shashank Sharma <shashank.sharma@intel.com>,Laurent Pinchart <laurent.pinchart@ideasonboard.com>,Daniel Vetter <daniel.vetter@ffwll.ch>,Bernard Zhao <bernard@vivo.com>,dri-devel@lists.freedesktop.org,linux-fbdev@vger.kernel.org,linux-kernel@vger.kernel.org
Cc:  opensource.kernel@vivo.com
Subject: [PATCH] drivers/video: cleanup coding style in video a bit>Eliminate the magic numbers, add vender infoframe size macro
>like other hdmi modules.
>
>Signed-off-by: Bernard Zhao <bernard@vivo.com>
>---
> drivers/video/hdmi.c | 2 +-
> include/linux/hdmi.h | 1 +
> 2 files changed, 2 insertions(+), 1 deletion(-)
>
>diff --git a/drivers/video/hdmi.c b/drivers/video/hdmi.c
>index 856a8c4e84a2..f693076f2e5f 100644
>--- a/drivers/video/hdmi.c
>+++ b/drivers/video/hdmi.c
>@@ -495,7 +495,7 @@ int hdmi_vendor_infoframe_init(struct hdmi_vendor_infoframe *frame)
> 	 * value
> 	 */
> 	frame->s3d_struct = HDMI_3D_STRUCTURE_INVALID;
>-	frame->length = 4;
>+	frame->length = HDMI_VENDOR_INFOFRAME_SIZE;
> 
> 	return 0;
> }
>diff --git a/include/linux/hdmi.h b/include/linux/hdmi.h
>index 9613d796cfb1..ff25aeb95ee4 100644
>--- a/include/linux/hdmi.h
>+++ b/include/linux/hdmi.h
>@@ -57,6 +57,7 @@ enum hdmi_infoframe_type {
> #define HDMI_SPD_INFOFRAME_SIZE    25
> #define HDMI_AUDIO_INFOFRAME_SIZE  10
> #define HDMI_DRM_INFOFRAME_SIZE    26
>+#define HDMI_VENDOR_INFOFRAME_SIZE  4
> 
> #define HDMI_INFOFRAME_SIZE(type)	\
> 	(HDMI_INFOFRAME_HEADER_SIZE + HDMI_ ## type ## _INFOFRAME_SIZE)
>-- 
>2.26.2
>


_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 12+ messages in thread
* Re: [PATCH] drivers/video: cleanup coding style in video a bit
  2020-04-27  8:05   ` Bernard Zhao
  (?)
@ 2020-06-01 13:25     ` Bartlomiej Zolnierkiewicz
  -1 siblings, 0 replies; 12+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2020-06-01 13:25 UTC (permalink / raw)
  To: Bernard Zhao
  Cc: Uma Shankar, Ville Syrjälä,
	Shashank Sharma, Laurent Pinchart, Daniel Vetter, dri-devel,
	linux-fbdev, linux-kernel, opensource.kernel


On 4/27/20 10:05 AM, Bernard Zhao wrote:
> Eliminate the magic numbers, add vender infoframe size macro
> like other hdmi modules.
> 
> Signed-off-by: Bernard Zhao <bernard@vivo.com>

Applied to drm-misc-next tree (patch should show up in v5.9), thanks.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

> ---
>  drivers/video/hdmi.c | 2 +-
>  include/linux/hdmi.h | 1 +
>  2 files changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/video/hdmi.c b/drivers/video/hdmi.c
> index 856a8c4e84a2..f693076f2e5f 100644
> --- a/drivers/video/hdmi.c
> +++ b/drivers/video/hdmi.c
> @@ -495,7 +495,7 @@ int hdmi_vendor_infoframe_init(struct hdmi_vendor_infoframe *frame)
>  	 * value
>  	 */
>  	frame->s3d_struct = HDMI_3D_STRUCTURE_INVALID;
> -	frame->length = 4;
> +	frame->length = HDMI_VENDOR_INFOFRAME_SIZE;
>  
>  	return 0;
>  }
> diff --git a/include/linux/hdmi.h b/include/linux/hdmi.h
> index 9613d796cfb1..ff25aeb95ee4 100644
> --- a/include/linux/hdmi.h
> +++ b/include/linux/hdmi.h
> @@ -57,6 +57,7 @@ enum hdmi_infoframe_type {
>  #define HDMI_SPD_INFOFRAME_SIZE    25
>  #define HDMI_AUDIO_INFOFRAME_SIZE  10
>  #define HDMI_DRM_INFOFRAME_SIZE    26
> +#define HDMI_VENDOR_INFOFRAME_SIZE  4
>  
>  #define HDMI_INFOFRAME_SIZE(type)	\
>  	(HDMI_INFOFRAME_HEADER_SIZE + HDMI_ ## type ## _INFOFRAME_SIZE)
> 

^ permalink raw reply	[flat|nested] 12+ messages in thread
* Re: [PATCH] drivers/video: cleanup coding style in video a bit
@ 2020-06-01 13:25     ` Bartlomiej Zolnierkiewicz
  0 siblings, 0 replies; 12+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2020-06-01 13:25 UTC (permalink / raw)
  To: Bernard Zhao
  Cc: opensource.kernel, linux-fbdev, Daniel Vetter, linux-kernel,
	dri-devel, Uma Shankar, Laurent Pinchart, Shashank Sharma


On 4/27/20 10:05 AM, Bernard Zhao wrote:
> Eliminate the magic numbers, add vender infoframe size macro
> like other hdmi modules.
> 
> Signed-off-by: Bernard Zhao <bernard@vivo.com>

Applied to drm-misc-next tree (patch should show up in v5.9), thanks.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

> ---
>  drivers/video/hdmi.c | 2 +-
>  include/linux/hdmi.h | 1 +
>  2 files changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/video/hdmi.c b/drivers/video/hdmi.c
> index 856a8c4e84a2..f693076f2e5f 100644
> --- a/drivers/video/hdmi.c
> +++ b/drivers/video/hdmi.c
> @@ -495,7 +495,7 @@ int hdmi_vendor_infoframe_init(struct hdmi_vendor_infoframe *frame)
>  	 * value
>  	 */
>  	frame->s3d_struct = HDMI_3D_STRUCTURE_INVALID;
> -	frame->length = 4;
> +	frame->length = HDMI_VENDOR_INFOFRAME_SIZE;
>  
>  	return 0;
>  }
> diff --git a/include/linux/hdmi.h b/include/linux/hdmi.h
> index 9613d796cfb1..ff25aeb95ee4 100644
> --- a/include/linux/hdmi.h
> +++ b/include/linux/hdmi.h
> @@ -57,6 +57,7 @@ enum hdmi_infoframe_type {
>  #define HDMI_SPD_INFOFRAME_SIZE    25
>  #define HDMI_AUDIO_INFOFRAME_SIZE  10
>  #define HDMI_DRM_INFOFRAME_SIZE    26
> +#define HDMI_VENDOR_INFOFRAME_SIZE  4
>  
>  #define HDMI_INFOFRAME_SIZE(type)	\
>  	(HDMI_INFOFRAME_HEADER_SIZE + HDMI_ ## type ## _INFOFRAME_SIZE)
> 

^ permalink raw reply	[flat|nested] 12+ messages in thread
* Re: [PATCH] drivers/video: cleanup coding style in video a bit
@ 2020-06-01 13:25     ` Bartlomiej Zolnierkiewicz
  0 siblings, 0 replies; 12+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2020-06-01 13:25 UTC (permalink / raw)
  To: Bernard Zhao
  Cc: opensource.kernel, linux-fbdev, Daniel Vetter, linux-kernel,
	dri-devel, Uma Shankar, Laurent Pinchart, Shashank Sharma


On 4/27/20 10:05 AM, Bernard Zhao wrote:
> Eliminate the magic numbers, add vender infoframe size macro
> like other hdmi modules.
> 
> Signed-off-by: Bernard Zhao <bernard@vivo.com>

Applied to drm-misc-next tree (patch should show up in v5.9), thanks.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

> ---
>  drivers/video/hdmi.c | 2 +-
>  include/linux/hdmi.h | 1 +
>  2 files changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/video/hdmi.c b/drivers/video/hdmi.c
> index 856a8c4e84a2..f693076f2e5f 100644
> --- a/drivers/video/hdmi.c
> +++ b/drivers/video/hdmi.c
> @@ -495,7 +495,7 @@ int hdmi_vendor_infoframe_init(struct hdmi_vendor_infoframe *frame)
>  	 * value
>  	 */
>  	frame->s3d_struct = HDMI_3D_STRUCTURE_INVALID;
> -	frame->length = 4;
> +	frame->length = HDMI_VENDOR_INFOFRAME_SIZE;
>  
>  	return 0;
>  }
> diff --git a/include/linux/hdmi.h b/include/linux/hdmi.h
> index 9613d796cfb1..ff25aeb95ee4 100644
> --- a/include/linux/hdmi.h
> +++ b/include/linux/hdmi.h
> @@ -57,6 +57,7 @@ enum hdmi_infoframe_type {
>  #define HDMI_SPD_INFOFRAME_SIZE    25
>  #define HDMI_AUDIO_INFOFRAME_SIZE  10
>  #define HDMI_DRM_INFOFRAME_SIZE    26
> +#define HDMI_VENDOR_INFOFRAME_SIZE  4
>  
>  #define HDMI_INFOFRAME_SIZE(type)	\
>  	(HDMI_INFOFRAME_HEADER_SIZE + HDMI_ ## type ## _INFOFRAME_SIZE)
> 
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 12+ messages in thread
end of thread, other threads:[~2020-06-01 13:25 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <CGME20200427080542eucas1p172bdcfd22affc288ec1ceaadf0dad2b0@eucas1p1.samsung.com>
2020-04-27  8:05 ` [PATCH] drivers/video: cleanup coding style in video a bit Bernard Zhao
2020-04-27  8:05   ` Bernard Zhao
2020-04-27  8:05   ` Bernard Zhao
2020-05-08  1:53   ` Bernard
2020-05-08  1:53     ` Bernard
2020-05-08  1:53     ` Bernard
2020-06-01 13:25   ` [PATCH] " Bartlomiej Zolnierkiewicz
2020-06-01 13:25     ` Bartlomiej Zolnierkiewicz
2020-06-01 13:25     ` Bartlomiej Zolnierkiewicz
2020-04-27  8:36 Markus Elfring
2020-04-27  8:36 ` Markus Elfring
2020-04-27  8:36 ` Markus Elfring

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.