* [Buildroot] [PATCH 1/1] toolchain/toolchain-external: install ldd on the target
@ 2020-04-22 15:34 Sébastien Szymanski
2020-04-24 12:02 ` Yann E. MORIN
2020-04-27 20:55 ` Yann E. MORIN
0 siblings, 2 replies; 4+ messages in thread
From: Sébastien Szymanski @ 2020-04-22 15:34 UTC (permalink / raw)
To: buildroot
From: Julien Boibessot <julien.boibessot@armadeus.com>
From: Julien Boibessot <julien.boibessot@armadeus.com>
It could be usefull to have ldd on the target so install it.
Signed-off-by: Julien Boibessot <julien.boibessot@armadeus.com>
[S?bastien: add commit message]
Signed-off-by: S?bastien Szymanski <sebastien.szymanski@armadeus.com>
---
toolchain/toolchain-external/pkg-toolchain-external.mk | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/toolchain/toolchain-external/pkg-toolchain-external.mk b/toolchain/toolchain-external/pkg-toolchain-external.mk
index 8667d7ddf6..6d91cb5d1e 100644
--- a/toolchain/toolchain-external/pkg-toolchain-external.mk
+++ b/toolchain/toolchain-external/pkg-toolchain-external.mk
@@ -499,6 +499,12 @@ define TOOLCHAIN_EXTERNAL_FIXUP_UCLIBCNG_LDSO
fi
endef
+define TOOLCHAIN_EXTERNAL_INSTALL_TARGET_LDD
+ $(Q)if test -f $(STAGING_DIR)/usr/bin/ldd ; then \
+ $(INSTALL) -D $(STAGING_DIR)/usr/bin/ldd $(TARGET_DIR)/usr/bin/ldd ; \
+ $(SED) 's:.*/bin/bash:#!/bin/sh:' $(TARGET_DIR)/usr/bin/ldd ; \
+ fi
+endef
################################################################################
# inner-toolchain-external-package -- defines the generic installation rules
@@ -593,6 +599,7 @@ define $(2)_INSTALL_TARGET_CMDS
$$(TOOLCHAIN_EXTERNAL_INSTALL_TARGET_LIBS)
$$(TOOLCHAIN_EXTERNAL_INSTALL_TARGET_GDBSERVER)
$$(TOOLCHAIN_EXTERNAL_FIXUP_UCLIBCNG_LDSO)
+ $$(TOOLCHAIN_EXTERNAL_INSTALL_TARGET_LDD)
endef
# Call the generic package infrastructure to generate the necessary
--
2.25.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH 1/1] toolchain/toolchain-external: install ldd on the target
2020-04-22 15:34 [Buildroot] [PATCH 1/1] toolchain/toolchain-external: install ldd on the target Sébastien Szymanski
@ 2020-04-24 12:02 ` Yann E. MORIN
2020-04-24 12:16 ` Thomas Petazzoni
2020-04-27 20:55 ` Yann E. MORIN
1 sibling, 1 reply; 4+ messages in thread
From: Yann E. MORIN @ 2020-04-24 12:02 UTC (permalink / raw)
To: buildroot
S?bastien, Julien, All,
On 2020-04-22 17:34 +0200, S?bastien Szymanski spake thusly:
> From: Julien Boibessot <julien.boibessot@armadeus.com>
>
> From: Julien Boibessot <julien.boibessot@armadeus.com>
>
> It could be usefull to have ldd on the target so install it.
What does ldd bring that can't be already achieved? For example on my
host system:
$ ldd /bin/bash
linux-vdso.so.1 (0x00007ffea5be0000)
libtinfo.so.6 => /lib/x86_64-linux-gnu/libtinfo.so.6 (0x00007f2ea6fa0000)
libdl.so.2 => /lib/x86_64-linux-gnu/libdl.so.2 (0x00007f2ea6f9a000)
libc.so.6 => /lib/x86_64-linux-gnu/libc.so.6 (0x00007f2ea6da9000)
/lib64/ld-linux-x86-64.so.2 (0x00007f2ea7114000)
$ LD_TRACE_LOADED_OBJECTS=1 /bin/bash
linux-vdso.so.1 (0x00007ffd3d3a7000)
libtinfo.so.6 => /lib/x86_64-linux-gnu/libtinfo.so.6 (0x00007f46883cd000)
libdl.so.2 => /lib/x86_64-linux-gnu/libdl.so.2 (0x00007f46883c7000)
libc.so.6 => /lib/x86_64-linux-gnu/libc.so.6 (0x00007f46881d6000)
/lib64/ld-linux-x86-64.so.2 (0x00007f4688419000)
(yes, that's shorter to type, I guess?)
Regards,
Yann E. MORIN.
> Signed-off-by: Julien Boibessot <julien.boibessot@armadeus.com>
> [S?bastien: add commit message]
> Signed-off-by: S?bastien Szymanski <sebastien.szymanski@armadeus.com>
> ---
> toolchain/toolchain-external/pkg-toolchain-external.mk | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/toolchain/toolchain-external/pkg-toolchain-external.mk b/toolchain/toolchain-external/pkg-toolchain-external.mk
> index 8667d7ddf6..6d91cb5d1e 100644
> --- a/toolchain/toolchain-external/pkg-toolchain-external.mk
> +++ b/toolchain/toolchain-external/pkg-toolchain-external.mk
> @@ -499,6 +499,12 @@ define TOOLCHAIN_EXTERNAL_FIXUP_UCLIBCNG_LDSO
> fi
> endef
>
> +define TOOLCHAIN_EXTERNAL_INSTALL_TARGET_LDD
> + $(Q)if test -f $(STAGING_DIR)/usr/bin/ldd ; then \
> + $(INSTALL) -D $(STAGING_DIR)/usr/bin/ldd $(TARGET_DIR)/usr/bin/ldd ; \
> + $(SED) 's:.*/bin/bash:#!/bin/sh:' $(TARGET_DIR)/usr/bin/ldd ; \
> + fi
> +endef
>
> ################################################################################
> # inner-toolchain-external-package -- defines the generic installation rules
> @@ -593,6 +599,7 @@ define $(2)_INSTALL_TARGET_CMDS
> $$(TOOLCHAIN_EXTERNAL_INSTALL_TARGET_LIBS)
> $$(TOOLCHAIN_EXTERNAL_INSTALL_TARGET_GDBSERVER)
> $$(TOOLCHAIN_EXTERNAL_FIXUP_UCLIBCNG_LDSO)
> + $$(TOOLCHAIN_EXTERNAL_INSTALL_TARGET_LDD)
> endef
>
> # Call the generic package infrastructure to generate the necessary
> --
> 2.25.3
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 4+ messages in thread* [Buildroot] [PATCH 1/1] toolchain/toolchain-external: install ldd on the target
2020-04-24 12:02 ` Yann E. MORIN
@ 2020-04-24 12:16 ` Thomas Petazzoni
0 siblings, 0 replies; 4+ messages in thread
From: Thomas Petazzoni @ 2020-04-24 12:16 UTC (permalink / raw)
To: buildroot
On Fri, 24 Apr 2020 14:02:46 +0200
"Yann E. MORIN" <yann.morin.1998@free.fr> wrote:
> What does ldd bring that can't be already achieved? For example on my
> host system:
>
> $ ldd /bin/bash
> linux-vdso.so.1 (0x00007ffea5be0000)
> libtinfo.so.6 => /lib/x86_64-linux-gnu/libtinfo.so.6 (0x00007f2ea6fa0000)
> libdl.so.2 => /lib/x86_64-linux-gnu/libdl.so.2 (0x00007f2ea6f9a000)
> libc.so.6 => /lib/x86_64-linux-gnu/libc.so.6 (0x00007f2ea6da9000)
> /lib64/ld-linux-x86-64.so.2 (0x00007f2ea7114000)
>
> $ LD_TRACE_LOADED_OBJECTS=1 /bin/bash
> linux-vdso.so.1 (0x00007ffd3d3a7000)
> libtinfo.so.6 => /lib/x86_64-linux-gnu/libtinfo.so.6 (0x00007f46883cd000)
> libdl.so.2 => /lib/x86_64-linux-gnu/libdl.so.2 (0x00007f46883c7000)
> libc.so.6 => /lib/x86_64-linux-gnu/libc.so.6 (0x00007f46881d6000)
> /lib64/ld-linux-x86-64.so.2 (0x00007f4688419000)
I guess the main thing that it brings is that people know about "ldd"
in general, while nobody knows about LD_TRACE_LOADED_OBJECTS :)
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH 1/1] toolchain/toolchain-external: install ldd on the target
2020-04-22 15:34 [Buildroot] [PATCH 1/1] toolchain/toolchain-external: install ldd on the target Sébastien Szymanski
2020-04-24 12:02 ` Yann E. MORIN
@ 2020-04-27 20:55 ` Yann E. MORIN
1 sibling, 0 replies; 4+ messages in thread
From: Yann E. MORIN @ 2020-04-27 20:55 UTC (permalink / raw)
To: buildroot
S?bastien, All,
On 2020-04-22 17:34 +0200, S?bastien Szymanski spake thusly:
> From: Julien Boibessot <julien.boibessot@armadeus.com>
>
> From: Julien Boibessot <julien.boibessot@armadeus.com>
>
> It could be usefull to have ldd on the target so install it.
>
> Signed-off-by: Julien Boibessot <julien.boibessot@armadeus.com>
> [S?bastien: add commit message]
> Signed-off-by: S?bastien Szymanski <sebastien.szymanski@armadeus.com>
I was not too fond of it, but it looks like we do install it for an
internal glibc-based toolchain, so meh...
Applied to master, thanks.
Regards,
Yann E. MORIN.
> ---
> toolchain/toolchain-external/pkg-toolchain-external.mk | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/toolchain/toolchain-external/pkg-toolchain-external.mk b/toolchain/toolchain-external/pkg-toolchain-external.mk
> index 8667d7ddf6..6d91cb5d1e 100644
> --- a/toolchain/toolchain-external/pkg-toolchain-external.mk
> +++ b/toolchain/toolchain-external/pkg-toolchain-external.mk
> @@ -499,6 +499,12 @@ define TOOLCHAIN_EXTERNAL_FIXUP_UCLIBCNG_LDSO
> fi
> endef
>
> +define TOOLCHAIN_EXTERNAL_INSTALL_TARGET_LDD
> + $(Q)if test -f $(STAGING_DIR)/usr/bin/ldd ; then \
> + $(INSTALL) -D $(STAGING_DIR)/usr/bin/ldd $(TARGET_DIR)/usr/bin/ldd ; \
> + $(SED) 's:.*/bin/bash:#!/bin/sh:' $(TARGET_DIR)/usr/bin/ldd ; \
> + fi
> +endef
>
> ################################################################################
> # inner-toolchain-external-package -- defines the generic installation rules
> @@ -593,6 +599,7 @@ define $(2)_INSTALL_TARGET_CMDS
> $$(TOOLCHAIN_EXTERNAL_INSTALL_TARGET_LIBS)
> $$(TOOLCHAIN_EXTERNAL_INSTALL_TARGET_GDBSERVER)
> $$(TOOLCHAIN_EXTERNAL_FIXUP_UCLIBCNG_LDSO)
> + $$(TOOLCHAIN_EXTERNAL_INSTALL_TARGET_LDD)
> endef
>
> # Call the generic package infrastructure to generate the necessary
> --
> 2.25.3
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-04-27 20:55 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-22 15:34 [Buildroot] [PATCH 1/1] toolchain/toolchain-external: install ldd on the target Sébastien Szymanski
2020-04-24 12:02 ` Yann E. MORIN
2020-04-24 12:16 ` Thomas Petazzoni
2020-04-27 20:55 ` Yann E. MORIN
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.