* [PATCH ipsec-next] xfrm interface: don't take extra reference to netdev
@ 2020-04-23 9:39 Nicolas Dichtel
2020-04-28 9:27 ` Steffen Klassert
0 siblings, 1 reply; 2+ messages in thread
From: Nicolas Dichtel @ 2020-04-23 9:39 UTC (permalink / raw)
To: steffen.klassert; +Cc: netdev, Nicolas Dichtel
I don't see any reason to do this. Maybe needed before
commit 56c5ee1a5823 ("xfrm interface: fix memory leak on creation").
Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
---
net/xfrm/xfrm_interface.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/net/xfrm/xfrm_interface.c b/net/xfrm/xfrm_interface.c
index 3361e3ac5714..eb9928c0a87c 100644
--- a/net/xfrm/xfrm_interface.c
+++ b/net/xfrm/xfrm_interface.c
@@ -145,7 +145,6 @@ static int xfrmi_create(struct net_device *dev)
if (err < 0)
goto out;
- dev_hold(dev);
xfrmi_link(xfrmn, xi);
return 0;
@@ -175,7 +174,6 @@ static void xfrmi_dev_uninit(struct net_device *dev)
struct xfrmi_net *xfrmn = net_generic(xi->net, xfrmi_net_id);
xfrmi_unlink(xfrmn, xi);
- dev_put(dev);
}
static void xfrmi_scrub_packet(struct sk_buff *skb, bool xnet)
--
2.24.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH ipsec-next] xfrm interface: don't take extra reference to netdev
2020-04-23 9:39 [PATCH ipsec-next] xfrm interface: don't take extra reference to netdev Nicolas Dichtel
@ 2020-04-28 9:27 ` Steffen Klassert
0 siblings, 0 replies; 2+ messages in thread
From: Steffen Klassert @ 2020-04-28 9:27 UTC (permalink / raw)
To: Nicolas Dichtel; +Cc: netdev
On Thu, Apr 23, 2020 at 11:39:20AM +0200, Nicolas Dichtel wrote:
> I don't see any reason to do this. Maybe needed before
> commit 56c5ee1a5823 ("xfrm interface: fix memory leak on creation").
>
> Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Applied, thanks Nicolas!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-04-28 9:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-23 9:39 [PATCH ipsec-next] xfrm interface: don't take extra reference to netdev Nicolas Dichtel
2020-04-28 9:27 ` Steffen Klassert
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.