* [PATCH net-next] ath11k: remove redundant dev_err call in ath11k_ahb_probe()
@ 2020-04-27 10:44 ` Wei Yongjun
0 siblings, 0 replies; 6+ messages in thread
From: Wei Yongjun @ 2020-04-27 10:44 UTC (permalink / raw)
To: Kalle Valo; +Cc: Wei Yongjun, ath11k, linux-wireless, kernel-janitors
There is a error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/net/wireless/ath/ath11k/ahb.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/net/wireless/ath/ath11k/ahb.c b/drivers/net/wireless/ath/ath11k/ahb.c
index e7e3e64c07aa..7d3d1cc6f39f 100644
--- a/drivers/net/wireless/ath/ath11k/ahb.c
+++ b/drivers/net/wireless/ath/ath11k/ahb.c
@@ -897,10 +897,8 @@ static int ath11k_ahb_probe(struct platform_device *pdev)
}
mem = devm_ioremap_resource(&pdev->dev, mem_res);
- if (IS_ERR(mem)) {
- dev_err(&pdev->dev, "ioremap error\n");
+ if (IS_ERR(mem))
return PTR_ERR(mem);
- }
ret = dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32));
if (ret) {
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH net-next] ath11k: remove redundant dev_err call in ath11k_ahb_probe()
@ 2020-04-27 10:44 ` Wei Yongjun
0 siblings, 0 replies; 6+ messages in thread
From: Wei Yongjun @ 2020-04-27 10:44 UTC (permalink / raw)
To: Kalle Valo; +Cc: linux-wireless, kernel-janitors, Wei Yongjun, ath11k
There is a error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/net/wireless/ath/ath11k/ahb.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/net/wireless/ath/ath11k/ahb.c b/drivers/net/wireless/ath/ath11k/ahb.c
index e7e3e64c07aa..7d3d1cc6f39f 100644
--- a/drivers/net/wireless/ath/ath11k/ahb.c
+++ b/drivers/net/wireless/ath/ath11k/ahb.c
@@ -897,10 +897,8 @@ static int ath11k_ahb_probe(struct platform_device *pdev)
}
mem = devm_ioremap_resource(&pdev->dev, mem_res);
- if (IS_ERR(mem)) {
- dev_err(&pdev->dev, "ioremap error\n");
+ if (IS_ERR(mem))
return PTR_ERR(mem);
- }
ret = dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32));
if (ret) {
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH net-next] ath11k: remove redundant dev_err call in ath11k_ahb_probe()
@ 2020-04-27 10:44 ` Wei Yongjun
0 siblings, 0 replies; 6+ messages in thread
From: Wei Yongjun @ 2020-04-27 10:44 UTC (permalink / raw)
To: Kalle Valo; +Cc: linux-wireless, kernel-janitors, Wei Yongjun, ath11k
There is a error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/net/wireless/ath/ath11k/ahb.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/net/wireless/ath/ath11k/ahb.c b/drivers/net/wireless/ath/ath11k/ahb.c
index e7e3e64c07aa..7d3d1cc6f39f 100644
--- a/drivers/net/wireless/ath/ath11k/ahb.c
+++ b/drivers/net/wireless/ath/ath11k/ahb.c
@@ -897,10 +897,8 @@ static int ath11k_ahb_probe(struct platform_device *pdev)
}
mem = devm_ioremap_resource(&pdev->dev, mem_res);
- if (IS_ERR(mem)) {
- dev_err(&pdev->dev, "ioremap error\n");
+ if (IS_ERR(mem))
return PTR_ERR(mem);
- }
ret = dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32));
if (ret) {
_______________________________________________
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH net-next] ath11k: remove redundant dev_err call in ath11k_ahb_probe()
2020-04-27 10:44 ` Wei Yongjun
@ 2020-04-28 9:28 ` Kalle Valo
-1 siblings, 0 replies; 6+ messages in thread
From: Kalle Valo @ 2020-04-28 9:28 UTC (permalink / raw)
To: Wei Yongjun; +Cc: Wei Yongjun, ath11k, linux-wireless, kernel-janitors
Wei Yongjun <weiyongjun1@huawei.com> wrote:
> There is a error message within devm_ioremap_resource
> already, so remove the dev_err call to avoid redundant
> error message.
>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
I don't see harm having two error messages and having an error message
within ath11k makes it easier to find the exact location, so I'm
dropping this.
--
https://patchwork.kernel.org/patch/11511845/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH net-next] ath11k: remove redundant dev_err call in ath11k_ahb_probe()
@ 2020-04-28 9:28 ` Kalle Valo
0 siblings, 0 replies; 6+ messages in thread
From: Kalle Valo @ 2020-04-28 9:28 UTC (permalink / raw)
To: Wei Yongjun; +Cc: ath11k, linux-wireless, kernel-janitors
Wei Yongjun <weiyongjun1@huawei.com> wrote:
> There is a error message within devm_ioremap_resource
> already, so remove the dev_err call to avoid redundant
> error message.
>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
I don't see harm having two error messages and having an error message
within ath11k makes it easier to find the exact location, so I'm
dropping this.
--
https://patchwork.kernel.org/patch/11511845/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH net-next] ath11k: remove redundant dev_err call in ath11k_ahb_probe()
2020-04-27 10:44 ` Wei Yongjun
` (2 preceding siblings ...)
(?)
@ 2020-04-28 9:28 ` Kalle Valo
-1 siblings, 0 replies; 6+ messages in thread
From: Kalle Valo @ 2020-04-28 9:28 UTC (permalink / raw)
To: Wei Yongjun; +Cc: linux-wireless, kernel-janitors, ath11k
Wei Yongjun <weiyongjun1@huawei.com> wrote:
> There is a error message within devm_ioremap_resource
> already, so remove the dev_err call to avoid redundant
> error message.
>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
I don't see harm having two error messages and having an error message
within ath11k makes it easier to find the exact location, so I'm
dropping this.
--
https://patchwork.kernel.org/patch/11511845/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
_______________________________________________
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-04-28 9:28 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-27 10:44 [PATCH net-next] ath11k: remove redundant dev_err call in ath11k_ahb_probe() Wei Yongjun
2020-04-27 10:44 ` Wei Yongjun
2020-04-27 10:44 ` Wei Yongjun
2020-04-28 9:28 ` Kalle Valo
2020-04-28 9:28 ` Kalle Valo
2020-04-28 9:28 ` Kalle Valo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.