From: Cornelia Huck <cohuck@redhat.com>
To: Eric Auger <eric.auger@redhat.com>
Cc: peter.maydell@linaro.org, drjones@redhat.com,
qemu-devel@nongnu.org, qemu-arm@nongnu.org,
eric.auger.pro@gmail.com, stefanb@linux.ibm.com
Subject: Re: [PATCH 1/2] tpm: tpm-tis-device: set PPI to false by default
Date: Tue, 28 Apr 2020 12:34:36 +0200 [thread overview]
Message-ID: <20200428123436.75432a8e.cohuck@redhat.com> (raw)
In-Reply-To: <20200427143145.16251-2-eric.auger@redhat.com>
On Mon, 27 Apr 2020 16:31:44 +0200
Eric Auger <eric.auger@redhat.com> wrote:
> The tpm-tis-device device does not support PPI. Let's
> change the default value for the corresponding property
> instead of tricking this latter in the mach-virt machine.
>
> Signed-off-by: Eric Auger <eric.auger@redhat.com>
> ---
> hw/tpm/tpm_tis_sysbus.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/tpm/tpm_tis_sysbus.c b/hw/tpm/tpm_tis_sysbus.c
> index 18c02aed67..eced1fc843 100644
> --- a/hw/tpm/tpm_tis_sysbus.c
> +++ b/hw/tpm/tpm_tis_sysbus.c
> @@ -91,7 +91,7 @@ static void tpm_tis_sysbus_reset(DeviceState *dev)
> static Property tpm_tis_sysbus_properties[] = {
> DEFINE_PROP_UINT32("irq", TPMStateSysBus, state.irq_num, TPM_TIS_IRQ),
> DEFINE_PROP_TPMBE("tpmdev", TPMStateSysBus, state.be_driver),
> - DEFINE_PROP_BOOL("ppi", TPMStateSysBus, state.ppi_enabled, true),
> + DEFINE_PROP_BOOL("ppi", TPMStateSysBus, state.ppi_enabled, false),
> DEFINE_PROP_END_OF_LIST(),
> };
>
This looks like a better place to do this than in the virt compat
machines, and should get us the same result, leaving compatibility
intact.
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
next prev parent reply other threads:[~2020-04-28 10:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-27 14:31 [PATCH 0/2] virt: Set tpm-tis-device ppi property to off by default Eric Auger
2020-04-27 14:31 ` [PATCH 1/2] tpm: tpm-tis-device: set PPI to false " Eric Auger
2020-04-28 10:34 ` Cornelia Huck [this message]
2020-04-28 20:13 ` Stefan Berger
2020-04-27 14:31 ` [PATCH 2/2] hw/arm/virt: Remove the compat forcing tpm-tis-device PPI to off Eric Auger
2020-04-28 10:36 ` Cornelia Huck
2020-04-28 20:14 ` Stefan Berger
2020-04-27 20:21 ` [PATCH 0/2] virt: Set tpm-tis-device ppi property to off by default Stefan Berger
2020-04-28 11:01 ` Auger Eric
2020-04-28 10:38 ` Cornelia Huck
2020-04-28 20:13 ` Stefan Berger
2020-04-29 6:11 ` Cornelia Huck
2020-04-29 11:53 ` Stefan Berger
2020-05-01 9:40 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200428123436.75432a8e.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=drjones@redhat.com \
--cc=eric.auger.pro@gmail.com \
--cc=eric.auger@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanb@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.