All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Berger <stefanb@linux.ibm.com>
To: Cornelia Huck <cohuck@redhat.com>, Eric Auger <eric.auger@redhat.com>
Cc: peter.maydell@linaro.org, drjones@redhat.com,
	qemu-arm@nongnu.org, qemu-devel@nongnu.org,
	eric.auger.pro@gmail.com
Subject: Re: [PATCH 2/2] hw/arm/virt: Remove the compat forcing tpm-tis-device PPI to off
Date: Tue, 28 Apr 2020 16:14:13 -0400	[thread overview]
Message-ID: <d859295c-4cbe-ed65-25db-69a3ae92ede6@linux.ibm.com> (raw)
In-Reply-To: <20200428123639.5cd403c6.cohuck@redhat.com>

On 4/28/20 6:36 AM, Cornelia Huck wrote:
> On Mon, 27 Apr 2020 16:31:45 +0200
> Eric Auger <eric.auger@redhat.com> wrote:
>
>> Now that the tpm-tis-device device PPI property is off by default,
>> we can remove the compat used for the same goal.
>>
>> Signed-off-by: Eric Auger <eric.auger@redhat.com>
>> ---
>>   hw/arm/virt.c | 5 -----
>>   1 file changed, 5 deletions(-)
>>
>> diff --git a/hw/arm/virt.c b/hw/arm/virt.c
>> index 7dc96abf72..2a68306f28 100644
>> --- a/hw/arm/virt.c
>> +++ b/hw/arm/virt.c
>> @@ -2311,11 +2311,6 @@ type_init(machvirt_machine_init);
>>   
>>   static void virt_machine_5_0_options(MachineClass *mc)
>>   {
>> -    static GlobalProperty compat[] = {
>> -        { TYPE_TPM_TIS_SYSBUS, "ppi", "false" },
>> -    };
>> -
>> -    compat_props_add(mc->compat_props, compat, G_N_ELEMENTS(compat));
>>   }
>>   DEFINE_VIRT_MACHINE_AS_LATEST(5, 0)
>>   
> Reviewed-by: Cornelia Huck <cohuck@redhat.com>
>
Reviewed-by: Stefan Berger <stefanb@linux.ibm.com>




  reply	other threads:[~2020-04-28 20:25 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-27 14:31 [PATCH 0/2] virt: Set tpm-tis-device ppi property to off by default Eric Auger
2020-04-27 14:31 ` [PATCH 1/2] tpm: tpm-tis-device: set PPI to false " Eric Auger
2020-04-28 10:34   ` Cornelia Huck
2020-04-28 20:13     ` Stefan Berger
2020-04-27 14:31 ` [PATCH 2/2] hw/arm/virt: Remove the compat forcing tpm-tis-device PPI to off Eric Auger
2020-04-28 10:36   ` Cornelia Huck
2020-04-28 20:14     ` Stefan Berger [this message]
2020-04-27 20:21 ` [PATCH 0/2] virt: Set tpm-tis-device ppi property to off by default Stefan Berger
2020-04-28 11:01   ` Auger Eric
2020-04-28 10:38 ` Cornelia Huck
2020-04-28 20:13   ` Stefan Berger
2020-04-29  6:11     ` Cornelia Huck
2020-04-29 11:53       ` Stefan Berger
2020-05-01  9:40 ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d859295c-4cbe-ed65-25db-69a3ae92ede6@linux.ibm.com \
    --to=stefanb@linux.ibm.com \
    --cc=cohuck@redhat.com \
    --cc=drjones@redhat.com \
    --cc=eric.auger.pro@gmail.com \
    --cc=eric.auger@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.