* [PATCH] drm: make drm_file use keyed wakeups
@ 2020-04-24 14:51 ` Kenny Levinsen
0 siblings, 0 replies; 7+ messages in thread
From: Kenny Levinsen @ 2020-04-24 14:51 UTC (permalink / raw)
To: intel-gfx, dri-devel
Cc: daniel, airlied, tzimmermann, mripard, maarten.lankhorst,
linux-kernel, Kenny Levinsen
Some processes, such as systemd, are only polling for EPOLLERR|EPOLLHUP.
As drm_file uses unkeyed wakeups, such a poll receives many spurious
wakeups from uninteresting events.
Use keyed wakeups to allow the wakeup target to more efficiently discard
these uninteresting events.
Signed-off-by: Kenny Levinsen <kl@kl.wtf>
---
drivers/gpu/drm/drm_file.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/drm_file.c b/drivers/gpu/drm/drm_file.c
index c4c704e01961..ec25b3d979d9 100644
--- a/drivers/gpu/drm/drm_file.c
+++ b/drivers/gpu/drm/drm_file.c
@@ -608,7 +608,8 @@ ssize_t drm_read(struct file *filp, char __user *buffer,
file_priv->event_space -= length;
list_add(&e->link, &file_priv->event_list);
spin_unlock_irq(&dev->event_lock);
- wake_up_interruptible(&file_priv->event_wait);
+ wake_up_interruptible_poll(&file_priv->event_wait,
+ EPOLLIN | EPOLLRDNORM);
break;
}
@@ -804,7 +805,8 @@ void drm_send_event_locked(struct drm_device *dev, struct drm_pending_event *e)
list_del(&e->pending_link);
list_add_tail(&e->link,
&e->file_priv->event_list);
- wake_up_interruptible(&e->file_priv->event_wait);
+ wake_up_interruptible_poll(&e->file_priv->event_wait,
+ EPOLLIN | EPOLLRDNORM);
}
EXPORT_SYMBOL(drm_send_event_locked);
--
2.26.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [Intel-gfx] [PATCH] drm: make drm_file use keyed wakeups
@ 2020-04-24 14:51 ` Kenny Levinsen
0 siblings, 0 replies; 7+ messages in thread
From: Kenny Levinsen @ 2020-04-24 14:51 UTC (permalink / raw)
To: intel-gfx, dri-devel
Cc: airlied, linux-kernel, mripard, Kenny Levinsen, tzimmermann
Some processes, such as systemd, are only polling for EPOLLERR|EPOLLHUP.
As drm_file uses unkeyed wakeups, such a poll receives many spurious
wakeups from uninteresting events.
Use keyed wakeups to allow the wakeup target to more efficiently discard
these uninteresting events.
Signed-off-by: Kenny Levinsen <kl@kl.wtf>
---
drivers/gpu/drm/drm_file.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/drm_file.c b/drivers/gpu/drm/drm_file.c
index c4c704e01961..ec25b3d979d9 100644
--- a/drivers/gpu/drm/drm_file.c
+++ b/drivers/gpu/drm/drm_file.c
@@ -608,7 +608,8 @@ ssize_t drm_read(struct file *filp, char __user *buffer,
file_priv->event_space -= length;
list_add(&e->link, &file_priv->event_list);
spin_unlock_irq(&dev->event_lock);
- wake_up_interruptible(&file_priv->event_wait);
+ wake_up_interruptible_poll(&file_priv->event_wait,
+ EPOLLIN | EPOLLRDNORM);
break;
}
@@ -804,7 +805,8 @@ void drm_send_event_locked(struct drm_device *dev, struct drm_pending_event *e)
list_del(&e->pending_link);
list_add_tail(&e->link,
&e->file_priv->event_list);
- wake_up_interruptible(&e->file_priv->event_wait);
+ wake_up_interruptible_poll(&e->file_priv->event_wait,
+ EPOLLIN | EPOLLRDNORM);
}
EXPORT_SYMBOL(drm_send_event_locked);
--
2.26.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] drm: make drm_file use keyed wakeups
2020-04-24 14:51 ` [Intel-gfx] " Kenny Levinsen
(?)
@ 2020-04-28 15:11 ` Daniel Vetter
-1 siblings, 0 replies; 7+ messages in thread
From: Daniel Vetter @ 2020-04-28 15:11 UTC (permalink / raw)
To: Kenny Levinsen
Cc: intel-gfx, dri-devel, daniel, airlied, tzimmermann, mripard,
maarten.lankhorst, linux-kernel
On Fri, Apr 24, 2020 at 04:51:03PM +0200, Kenny Levinsen wrote:
> Some processes, such as systemd, are only polling for EPOLLERR|EPOLLHUP.
> As drm_file uses unkeyed wakeups, such a poll receives many spurious
> wakeups from uninteresting events.
>
> Use keyed wakeups to allow the wakeup target to more efficiently discard
> these uninteresting events.
>
> Signed-off-by: Kenny Levinsen <kl@kl.wtf>
intel-gfx CI is happy, I'm living with the illusion that this seems to
loook correct (linux kernel poll code is too much magic for me). Thanks
for your patch, queued up in drm-misc-next for 5.8.
Cheers, Daniel
> ---
> drivers/gpu/drm/drm_file.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_file.c b/drivers/gpu/drm/drm_file.c
> index c4c704e01961..ec25b3d979d9 100644
> --- a/drivers/gpu/drm/drm_file.c
> +++ b/drivers/gpu/drm/drm_file.c
> @@ -608,7 +608,8 @@ ssize_t drm_read(struct file *filp, char __user *buffer,
> file_priv->event_space -= length;
> list_add(&e->link, &file_priv->event_list);
> spin_unlock_irq(&dev->event_lock);
> - wake_up_interruptible(&file_priv->event_wait);
> + wake_up_interruptible_poll(&file_priv->event_wait,
> + EPOLLIN | EPOLLRDNORM);
> break;
> }
>
> @@ -804,7 +805,8 @@ void drm_send_event_locked(struct drm_device *dev, struct drm_pending_event *e)
> list_del(&e->pending_link);
> list_add_tail(&e->link,
> &e->file_priv->event_list);
> - wake_up_interruptible(&e->file_priv->event_wait);
> + wake_up_interruptible_poll(&e->file_priv->event_wait,
> + EPOLLIN | EPOLLRDNORM);
> }
> EXPORT_SYMBOL(drm_send_event_locked);
>
> --
> 2.26.1
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] drm: make drm_file use keyed wakeups
@ 2020-04-28 15:11 ` Daniel Vetter
0 siblings, 0 replies; 7+ messages in thread
From: Daniel Vetter @ 2020-04-28 15:11 UTC (permalink / raw)
To: Kenny Levinsen; +Cc: airlied, intel-gfx, linux-kernel, dri-devel, tzimmermann
On Fri, Apr 24, 2020 at 04:51:03PM +0200, Kenny Levinsen wrote:
> Some processes, such as systemd, are only polling for EPOLLERR|EPOLLHUP.
> As drm_file uses unkeyed wakeups, such a poll receives many spurious
> wakeups from uninteresting events.
>
> Use keyed wakeups to allow the wakeup target to more efficiently discard
> these uninteresting events.
>
> Signed-off-by: Kenny Levinsen <kl@kl.wtf>
intel-gfx CI is happy, I'm living with the illusion that this seems to
loook correct (linux kernel poll code is too much magic for me). Thanks
for your patch, queued up in drm-misc-next for 5.8.
Cheers, Daniel
> ---
> drivers/gpu/drm/drm_file.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_file.c b/drivers/gpu/drm/drm_file.c
> index c4c704e01961..ec25b3d979d9 100644
> --- a/drivers/gpu/drm/drm_file.c
> +++ b/drivers/gpu/drm/drm_file.c
> @@ -608,7 +608,8 @@ ssize_t drm_read(struct file *filp, char __user *buffer,
> file_priv->event_space -= length;
> list_add(&e->link, &file_priv->event_list);
> spin_unlock_irq(&dev->event_lock);
> - wake_up_interruptible(&file_priv->event_wait);
> + wake_up_interruptible_poll(&file_priv->event_wait,
> + EPOLLIN | EPOLLRDNORM);
> break;
> }
>
> @@ -804,7 +805,8 @@ void drm_send_event_locked(struct drm_device *dev, struct drm_pending_event *e)
> list_del(&e->pending_link);
> list_add_tail(&e->link,
> &e->file_priv->event_list);
> - wake_up_interruptible(&e->file_priv->event_wait);
> + wake_up_interruptible_poll(&e->file_priv->event_wait,
> + EPOLLIN | EPOLLRDNORM);
> }
> EXPORT_SYMBOL(drm_send_event_locked);
>
> --
> 2.26.1
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Intel-gfx] [PATCH] drm: make drm_file use keyed wakeups
@ 2020-04-28 15:11 ` Daniel Vetter
0 siblings, 0 replies; 7+ messages in thread
From: Daniel Vetter @ 2020-04-28 15:11 UTC (permalink / raw)
To: Kenny Levinsen
Cc: airlied, intel-gfx, linux-kernel, dri-devel, mripard, tzimmermann
On Fri, Apr 24, 2020 at 04:51:03PM +0200, Kenny Levinsen wrote:
> Some processes, such as systemd, are only polling for EPOLLERR|EPOLLHUP.
> As drm_file uses unkeyed wakeups, such a poll receives many spurious
> wakeups from uninteresting events.
>
> Use keyed wakeups to allow the wakeup target to more efficiently discard
> these uninteresting events.
>
> Signed-off-by: Kenny Levinsen <kl@kl.wtf>
intel-gfx CI is happy, I'm living with the illusion that this seems to
loook correct (linux kernel poll code is too much magic for me). Thanks
for your patch, queued up in drm-misc-next for 5.8.
Cheers, Daniel
> ---
> drivers/gpu/drm/drm_file.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_file.c b/drivers/gpu/drm/drm_file.c
> index c4c704e01961..ec25b3d979d9 100644
> --- a/drivers/gpu/drm/drm_file.c
> +++ b/drivers/gpu/drm/drm_file.c
> @@ -608,7 +608,8 @@ ssize_t drm_read(struct file *filp, char __user *buffer,
> file_priv->event_space -= length;
> list_add(&e->link, &file_priv->event_list);
> spin_unlock_irq(&dev->event_lock);
> - wake_up_interruptible(&file_priv->event_wait);
> + wake_up_interruptible_poll(&file_priv->event_wait,
> + EPOLLIN | EPOLLRDNORM);
> break;
> }
>
> @@ -804,7 +805,8 @@ void drm_send_event_locked(struct drm_device *dev, struct drm_pending_event *e)
> list_del(&e->pending_link);
> list_add_tail(&e->link,
> &e->file_priv->event_list);
> - wake_up_interruptible(&e->file_priv->event_wait);
> + wake_up_interruptible_poll(&e->file_priv->event_wait,
> + EPOLLIN | EPOLLRDNORM);
> }
> EXPORT_SYMBOL(drm_send_event_locked);
>
> --
> 2.26.1
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] drm: make drm_file use keyed wakeups
@ 2020-04-12 17:41 ` Kenny Levinsen
0 siblings, 0 replies; 7+ messages in thread
From: Kenny Levinsen @ 2020-04-12 17:41 UTC (permalink / raw)
To: dri-devel
Cc: maarten.lankhorst, mripard, tzimmermann, linux-kernel, Kenny Levinsen
Some processes, such as systemd, are only polling for EPOLLERR|EPOLLHUP.
As drm_file uses unkeyed wakeups, such a poll receives many spurious
wakeups from uninteresting events.
Use keyed wakeups to allow the wakeup target to more efficiently discard
these uninteresting events.
Signed-off-by: Kenny Levinsen <kl@kl.wtf>
---
drivers/gpu/drm/drm_file.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/drm_file.c b/drivers/gpu/drm/drm_file.c
index c4c704e01961..ec25b3d979d9 100644
--- a/drivers/gpu/drm/drm_file.c
+++ b/drivers/gpu/drm/drm_file.c
@@ -608,7 +608,8 @@ ssize_t drm_read(struct file *filp, char __user *buffer,
file_priv->event_space -= length;
list_add(&e->link, &file_priv->event_list);
spin_unlock_irq(&dev->event_lock);
- wake_up_interruptible(&file_priv->event_wait);
+ wake_up_interruptible_poll(&file_priv->event_wait,
+ EPOLLIN | EPOLLRDNORM);
break;
}
@@ -804,7 +805,8 @@ void drm_send_event_locked(struct drm_device *dev, struct drm_pending_event *e)
list_del(&e->pending_link);
list_add_tail(&e->link,
&e->file_priv->event_list);
- wake_up_interruptible(&e->file_priv->event_wait);
+ wake_up_interruptible_poll(&e->file_priv->event_wait,
+ EPOLLIN | EPOLLRDNORM);
}
EXPORT_SYMBOL(drm_send_event_locked);
--
2.26.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH] drm: make drm_file use keyed wakeups
@ 2020-04-12 17:41 ` Kenny Levinsen
0 siblings, 0 replies; 7+ messages in thread
From: Kenny Levinsen @ 2020-04-12 17:41 UTC (permalink / raw)
To: dri-devel; +Cc: Kenny Levinsen, tzimmermann, linux-kernel
Some processes, such as systemd, are only polling for EPOLLERR|EPOLLHUP.
As drm_file uses unkeyed wakeups, such a poll receives many spurious
wakeups from uninteresting events.
Use keyed wakeups to allow the wakeup target to more efficiently discard
these uninteresting events.
Signed-off-by: Kenny Levinsen <kl@kl.wtf>
---
drivers/gpu/drm/drm_file.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/drm_file.c b/drivers/gpu/drm/drm_file.c
index c4c704e01961..ec25b3d979d9 100644
--- a/drivers/gpu/drm/drm_file.c
+++ b/drivers/gpu/drm/drm_file.c
@@ -608,7 +608,8 @@ ssize_t drm_read(struct file *filp, char __user *buffer,
file_priv->event_space -= length;
list_add(&e->link, &file_priv->event_list);
spin_unlock_irq(&dev->event_lock);
- wake_up_interruptible(&file_priv->event_wait);
+ wake_up_interruptible_poll(&file_priv->event_wait,
+ EPOLLIN | EPOLLRDNORM);
break;
}
@@ -804,7 +805,8 @@ void drm_send_event_locked(struct drm_device *dev, struct drm_pending_event *e)
list_del(&e->pending_link);
list_add_tail(&e->link,
&e->file_priv->event_list);
- wake_up_interruptible(&e->file_priv->event_wait);
+ wake_up_interruptible_poll(&e->file_priv->event_wait,
+ EPOLLIN | EPOLLRDNORM);
}
EXPORT_SYMBOL(drm_send_event_locked);
--
2.26.0
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 7+ messages in thread
end of thread, other threads:[~2020-04-28 15:11 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-24 14:51 [PATCH] drm: make drm_file use keyed wakeups Kenny Levinsen
2020-04-24 14:51 ` [Intel-gfx] " Kenny Levinsen
2020-04-28 15:11 ` Daniel Vetter
2020-04-28 15:11 ` [Intel-gfx] " Daniel Vetter
2020-04-28 15:11 ` Daniel Vetter
-- strict thread matches above, loose matches on Subject: below --
2020-04-12 17:41 Kenny Levinsen
2020-04-12 17:41 ` Kenny Levinsen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.