* [PATCH] dm: core: Reorder include files in read.c @ 2020-04-29 7:08 Stefan Roese 2020-04-29 18:04 ` Simon Glass 0 siblings, 1 reply; 5+ messages in thread From: Stefan Roese @ 2020-04-29 7:08 UTC (permalink / raw) To: u-boot Including the assembler headers before including common.h etc leads to compilation errors upon MIPS64 based platforms using OF_LIVE. This patch reorders the include files to the "correct" oder. Signed-off-by: Stefan Roese <sr@denx.de> Cc: Simon Glass <sjg@chromium.org> --- drivers/core/read.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/core/read.c b/drivers/core/read.c index 47b8e03446..8e65dd2d50 100644 --- a/drivers/core/read.c +++ b/drivers/core/read.c @@ -4,12 +4,12 @@ * Written by Simon Glass <sjg@chromium.org> */ -#include <asm/types.h> -#include <asm/io.h> #include <common.h> #include <dm.h> -#include <mapmem.h> #include <dm/of_access.h> +#include <mapmem.h> +#include <asm/types.h> +#include <asm/io.h> int dev_read_u32(const struct udevice *dev, const char *propname, u32 *outp) { -- 2.26.2 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH] dm: core: Reorder include files in read.c 2020-04-29 7:08 [PATCH] dm: core: Reorder include files in read.c Stefan Roese @ 2020-04-29 18:04 ` Simon Glass 2020-05-14 9:28 ` Stefan Roese 0 siblings, 1 reply; 5+ messages in thread From: Simon Glass @ 2020-04-29 18:04 UTC (permalink / raw) To: u-boot On Wed, 29 Apr 2020 at 01:08, Stefan Roese <sr@denx.de> wrote: > > Including the assembler headers before including common.h etc leads to > compilation errors upon MIPS64 based platforms using OF_LIVE. This > patch reorders the include files to the "correct" oder. > > Signed-off-by: Stefan Roese <sr@denx.de> > Cc: Simon Glass <sjg@chromium.org> > --- > drivers/core/read.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) Reviewed-by: Simon Glass <sjg@chromium.org> ^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] dm: core: Reorder include files in read.c 2020-04-29 18:04 ` Simon Glass @ 2020-05-14 9:28 ` Stefan Roese 2020-05-14 12:49 ` Simon Glass 0 siblings, 1 reply; 5+ messages in thread From: Stefan Roese @ 2020-05-14 9:28 UTC (permalink / raw) To: u-boot Hi Simon, On 29.04.20 20:04, Simon Glass wrote: > On Wed, 29 Apr 2020 at 01:08, Stefan Roese <sr@denx.de> wrote: >> >> Including the assembler headers before including common.h etc leads to >> compilation errors upon MIPS64 based platforms using OF_LIVE. This >> patch reorders the include files to the "correct" oder. >> >> Signed-off-by: Stefan Roese <sr@denx.de> >> Cc: Simon Glass <sjg@chromium.org> >> --- >> drivers/core/read.c | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) > > Reviewed-by: Simon Glass <sjg@chromium.org> > Just a short reminder about this patch, as its needed for the base Octeon (MIPS) support, I'm currently working on. Otherwise, usage of OF_LIVE is not possible. Thanks, Stefan ^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] dm: core: Reorder include files in read.c 2020-05-14 9:28 ` Stefan Roese @ 2020-05-14 12:49 ` Simon Glass 2020-05-14 12:55 ` Stefan Roese 0 siblings, 1 reply; 5+ messages in thread From: Simon Glass @ 2020-05-14 12:49 UTC (permalink / raw) To: u-boot Hi Stefan, OK. Feel free to pull it in if you like as you have my review tag. Regards, SImon On Thu, 14 May 2020 at 03:30, Stefan Roese <sr@denx.de> wrote: > > Hi Simon, > > On 29.04.20 20:04, Simon Glass wrote: > > On Wed, 29 Apr 2020 at 01:08, Stefan Roese <sr@denx.de> wrote: > >> > >> Including the assembler headers before including common.h etc leads to > >> compilation errors upon MIPS64 based platforms using OF_LIVE. This > >> patch reorders the include files to the "correct" oder. > >> > >> Signed-off-by: Stefan Roese <sr@denx.de> > >> Cc: Simon Glass <sjg@chromium.org> > >> --- > >> drivers/core/read.c | 6 +++--- > >> 1 file changed, 3 insertions(+), 3 deletions(-) > > > > Reviewed-by: Simon Glass <sjg@chromium.org> > > > > Just a short reminder about this patch, as its needed for the base > Octeon (MIPS) support, I'm currently working on. Otherwise, usage of > OF_LIVE is not possible. > > Thanks, > Stefan > ^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] dm: core: Reorder include files in read.c 2020-05-14 12:49 ` Simon Glass @ 2020-05-14 12:55 ` Stefan Roese 0 siblings, 0 replies; 5+ messages in thread From: Stefan Roese @ 2020-05-14 12:55 UTC (permalink / raw) To: u-boot Hi Simon, On 14.05.20 14:49, Simon Glass wrote: > OK. Feel free to pull it in if you like as you have my review tag. Thanks Simon. Since Daniel will be the one pulling the Octeon patchset once we've reached the necessary ack's, he now knows that he can pull this one as well. But this will take a few more versions most likely. Perhaps this patch has landed in mainline until then. Thanks, Stefan > Regards, > SImon > > On Thu, 14 May 2020 at 03:30, Stefan Roese <sr@denx.de> wrote: >> >> Hi Simon, >> >> On 29.04.20 20:04, Simon Glass wrote: >>> On Wed, 29 Apr 2020 at 01:08, Stefan Roese <sr@denx.de> wrote: >>>> >>>> Including the assembler headers before including common.h etc leads to >>>> compilation errors upon MIPS64 based platforms using OF_LIVE. This >>>> patch reorders the include files to the "correct" oder. >>>> >>>> Signed-off-by: Stefan Roese <sr@denx.de> >>>> Cc: Simon Glass <sjg@chromium.org> >>>> --- >>>> drivers/core/read.c | 6 +++--- >>>> 1 file changed, 3 insertions(+), 3 deletions(-) >>> >>> Reviewed-by: Simon Glass <sjg@chromium.org> >>> >> >> Just a short reminder about this patch, as its needed for the base >> Octeon (MIPS) support, I'm currently working on. Otherwise, usage of >> OF_LIVE is not possible. >> >> Thanks, >> Stefan >> Viele Gr??e, Stefan -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr at denx.de ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-05-14 12:55 UTC | newest] Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2020-04-29 7:08 [PATCH] dm: core: Reorder include files in read.c Stefan Roese 2020-04-29 18:04 ` Simon Glass 2020-05-14 9:28 ` Stefan Roese 2020-05-14 12:49 ` Simon Glass 2020-05-14 12:55 ` Stefan Roese
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.