From: kbuild test robot <lkp@intel.com> To: Andrey Konovalov <andreyknvl@google.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Felipe Balbi <balbi@kernel.org>, Alan Stern <stern@rowland.harvard.edu>, Dmitry Vyukov <dvyukov@google.com> Cc: kbuild-all@lists.01.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Felipe Balbi <balbi@kernel.org>, Alan Stern <stern@rowland.harvard.edu>, Dmitry Vyukov <dvyukov@google.com> Subject: Re: [PATCH] usb: raw-gadget: fix gadget endpoint selection Date: Wed, 29 Apr 2020 08:22:09 +0800 [thread overview] Message-ID: <202004290812.LW8GyPdy%lkp@intel.com> (raw) In-Reply-To: <e7920e1960ed65410f00c3400bdeccb27553c736.1588103144.git.andreyknvl@google.com> [-- Attachment #1: Type: text/plain, Size: 2891 bytes --] Hi Andrey, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on usb/usb-testing] [also build test WARNING on linus/master v5.7-rc3 next-20200428] [cannot apply to balbi-usb/next peter.chen-usb/ci-for-usb-next] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Andrey-Konovalov/usb-raw-gadget-fix-gadget-endpoint-selection/20200429-060106 base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing config: c6x-allyesconfig (attached as .config) compiler: c6x-elf-gcc (GCC) 9.3.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day GCC_VERSION=9.3.0 make.cross ARCH=c6x If you fix the issue, kindly add following tag as appropriate Reported-by: kbuild test robot <lkp@intel.com> All warnings (new ones prefixed by >>): drivers/usb/gadget/legacy/raw_gadget.c: In function 'raw_ioctl_eps_info': >> drivers/usb/gadget/legacy/raw_gadget.c:1079:1: warning: the frame size of 1096 bytes is larger than 1024 bytes [-Wframe-larger-than=] 1079 | } | ^ vim +1079 drivers/usb/gadget/legacy/raw_gadget.c 1040 1041 static int raw_ioctl_eps_info(struct raw_dev *dev, unsigned long value) 1042 { 1043 int ret = 0, i; 1044 unsigned long flags; 1045 struct usb_raw_eps_info info; 1046 struct raw_ep *ep; 1047 1048 spin_lock_irqsave(&dev->lock, flags); 1049 if (dev->state != STATE_DEV_RUNNING) { 1050 dev_dbg(dev->dev, "fail, device is not running\n"); 1051 ret = -EINVAL; 1052 spin_unlock_irqrestore(&dev->lock, flags); 1053 goto out; 1054 } 1055 if (!dev->gadget) { 1056 dev_dbg(dev->dev, "fail, gadget is not bound\n"); 1057 ret = -EBUSY; 1058 spin_unlock_irqrestore(&dev->lock, flags); 1059 goto out; 1060 } 1061 1062 memset(&info, 0, sizeof(info)); 1063 for (i = 0; i < dev->eps_num; i++) { 1064 ep = &dev->eps[i]; 1065 strscpy(&info.eps[i].name[0], ep->ep->name, 1066 USB_RAW_EP_NAME_MAX); 1067 info.eps[i].addr = ep->addr; 1068 fill_ep_caps(&ep->ep->caps, &info.eps[i].caps); 1069 fill_ep_limits(ep->ep, &info.eps[i].limits); 1070 } 1071 ret = dev->eps_num; 1072 spin_unlock_irqrestore(&dev->lock, flags); 1073 1074 if (copy_to_user((void __user *)value, &info, sizeof(info))) 1075 ret = -EFAULT; 1076 1077 out: 1078 return ret; > 1079 } 1080 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org [-- Attachment #2: .config.gz --] [-- Type: application/gzip, Size: 52557 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: kbuild test robot <lkp@intel.com> To: kbuild-all@lists.01.org Subject: Re: [PATCH] usb: raw-gadget: fix gadget endpoint selection Date: Wed, 29 Apr 2020 08:22:09 +0800 [thread overview] Message-ID: <202004290812.LW8GyPdy%lkp@intel.com> (raw) In-Reply-To: <e7920e1960ed65410f00c3400bdeccb27553c736.1588103144.git.andreyknvl@google.com> [-- Attachment #1: Type: text/plain, Size: 2971 bytes --] Hi Andrey, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on usb/usb-testing] [also build test WARNING on linus/master v5.7-rc3 next-20200428] [cannot apply to balbi-usb/next peter.chen-usb/ci-for-usb-next] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Andrey-Konovalov/usb-raw-gadget-fix-gadget-endpoint-selection/20200429-060106 base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing config: c6x-allyesconfig (attached as .config) compiler: c6x-elf-gcc (GCC) 9.3.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day GCC_VERSION=9.3.0 make.cross ARCH=c6x If you fix the issue, kindly add following tag as appropriate Reported-by: kbuild test robot <lkp@intel.com> All warnings (new ones prefixed by >>): drivers/usb/gadget/legacy/raw_gadget.c: In function 'raw_ioctl_eps_info': >> drivers/usb/gadget/legacy/raw_gadget.c:1079:1: warning: the frame size of 1096 bytes is larger than 1024 bytes [-Wframe-larger-than=] 1079 | } | ^ vim +1079 drivers/usb/gadget/legacy/raw_gadget.c 1040 1041 static int raw_ioctl_eps_info(struct raw_dev *dev, unsigned long value) 1042 { 1043 int ret = 0, i; 1044 unsigned long flags; 1045 struct usb_raw_eps_info info; 1046 struct raw_ep *ep; 1047 1048 spin_lock_irqsave(&dev->lock, flags); 1049 if (dev->state != STATE_DEV_RUNNING) { 1050 dev_dbg(dev->dev, "fail, device is not running\n"); 1051 ret = -EINVAL; 1052 spin_unlock_irqrestore(&dev->lock, flags); 1053 goto out; 1054 } 1055 if (!dev->gadget) { 1056 dev_dbg(dev->dev, "fail, gadget is not bound\n"); 1057 ret = -EBUSY; 1058 spin_unlock_irqrestore(&dev->lock, flags); 1059 goto out; 1060 } 1061 1062 memset(&info, 0, sizeof(info)); 1063 for (i = 0; i < dev->eps_num; i++) { 1064 ep = &dev->eps[i]; 1065 strscpy(&info.eps[i].name[0], ep->ep->name, 1066 USB_RAW_EP_NAME_MAX); 1067 info.eps[i].addr = ep->addr; 1068 fill_ep_caps(&ep->ep->caps, &info.eps[i].caps); 1069 fill_ep_limits(ep->ep, &info.eps[i].limits); 1070 } 1071 ret = dev->eps_num; 1072 spin_unlock_irqrestore(&dev->lock, flags); 1073 1074 if (copy_to_user((void __user *)value, &info, sizeof(info))) 1075 ret = -EFAULT; 1076 1077 out: 1078 return ret; > 1079 } 1080 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org [-- Attachment #2: config.gz --] [-- Type: application/gzip, Size: 52557 bytes --]
next prev parent reply other threads:[~2020-04-29 0:23 UTC|newest] Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-04-28 19:46 [PATCH] usb: raw-gadget: fix gadget endpoint selection Andrey Konovalov 2020-04-28 19:48 ` Andrey Konovalov 2020-04-28 19:53 ` Andrey Konovalov 2020-04-29 1:14 ` Alan Stern 2020-04-29 1:42 ` Andrey Konovalov 2020-04-29 14:08 ` Alan Stern 2020-04-29 0:22 ` kbuild test robot [this message] 2020-04-29 0:22 ` kbuild test robot
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=202004290812.LW8GyPdy%lkp@intel.com \ --to=lkp@intel.com \ --cc=andreyknvl@google.com \ --cc=balbi@kernel.org \ --cc=dvyukov@google.com \ --cc=gregkh@linuxfoundation.org \ --cc=kbuild-all@lists.01.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-usb@vger.kernel.org \ --cc=stern@rowland.harvard.edu \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.