[PATCH] UAS: add quirk for LaCie 2Big Quadra

[PATCH] UAS: add quirk for LaCie 2Big Quadra

[Oliver Neukum]

This device needs US_FL_NO_REPORT_OPCODES to avoid going
through prolonged error handling on enumeration.

Signed-off-by: Oliver Neukum <oneukum@suse.com>
Reported-by: Julian Groß <julian.g@posteo.de>
---
 drivers/usb/storage/unusual_uas.h | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/usb/storage/unusual_uas.h b/drivers/usb/storage/unusual_uas.h
index cfdec74e0f4a..d6c54b5bde75 100644
--- a/drivers/usb/storage/unusual_uas.h
+++ b/drivers/usb/storage/unusual_uas.h
@@ -73,6 +73,13 @@ UNUSUAL_DEV(0x152d, 0x0578, 0x0000, 0x9999,
 		USB_SC_DEVICE, USB_PR_DEVICE, NULL,
 		US_FL_BROKEN_FUA),
 
+/* Reported-by: Julian Groß <julian.g@posteo.de> */
+UNUSUAL_DEV(0x059f, 0x105f, 0x0000, 0x9999,
+		"LaCie",
+		"2Big Quadra USB3",
+		USB_SC_DEVICE, USB_PR_DEVICE, NULL,
+		US_FL_NO_REPORT_OPCODES),
+
 /* Reported-by: Hans de Goede <hdegoede@redhat.com> */
 UNUSUAL_DEV(0x2109, 0x0711, 0x0000, 0x9999,
 		"VIA",
-- 
2.16.4

Re: [PATCH] UAS: add quirk for LaCie 2Big Quadra

[Greg KH]

On Wed, Apr 29, 2020 at 10:32:04AM +0200, Oliver Neukum wrote:
> This device needs US_FL_NO_REPORT_OPCODES to avoid going
> through prolonged error handling on enumeration.
> 
> Signed-off-by: Oliver Neukum <oneukum@suse.com>
> Cc: stable <stable@vger.kernel.org>
> Reported-by: Julian Groß <julian.g@posteo.de>
> ---
>  drivers/usb/storage/unusual_uas.h | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/usb/storage/unusual_uas.h b/drivers/usb/storage/unusual_uas.h
> index cfdec74e0f4a..d6c54b5bde75 100644
> --- a/drivers/usb/storage/unusual_uas.h
> +++ b/drivers/usb/storage/unusual_uas.h
> @@ -73,6 +73,13 @@ UNUSUAL_DEV(0x152d, 0x0578, 0x0000, 0x9999,
>  		USB_SC_DEVICE, USB_PR_DEVICE, NULL,
>  		US_FL_BROKEN_FUA),
>  
> +/* Reported-by: Julian Groß <julian.g@posteo.de> */
> +UNUSUAL_DEV(0x059f, 0x105f, 0x0000, 0x9999,
> +		"LaCie",
> +		"2Big Quadra USB3",
> +		USB_SC_DEVICE, USB_PR_DEVICE, NULL,
> +		US_FL_NO_REPORT_OPCODES),
> +

Can you please keep these in sorted order by vendor/product id as the
comment in the file suggests to do so?

thanks,

greg k-h

Re: [PATCH] UAS: add quirk for LaCie 2Big Quadra

[Oliver Neukum]

Am Mittwoch, den 29.04.2020, 11:33 +0200 schrieb Greg KH:
> On Wed, Apr 29, 2020 at 10:32:04AM +0200, Oliver Neukum wrote:
> > This device needs US_FL_NO_REPORT_OPCODES to avoid going
> > through prolonged error handling on enumeration.
> > 
> > Signed-off-by: Oliver Neukum <oneukum@suse.com>
> > Cc: stable <stable@vger.kernel.org>
> > Reported-by: Julian Groß <julian.g@posteo.de>
> > ---
> >  drivers/usb/storage/unusual_uas.h | 7 +++++++
> >  1 file changed, 7 insertions(+)
> > 
> > diff --git a/drivers/usb/storage/unusual_uas.h b/drivers/usb/storage/unusual_uas.h
> > index cfdec74e0f4a..d6c54b5bde75 100644
> > --- a/drivers/usb/storage/unusual_uas.h
> > +++ b/drivers/usb/storage/unusual_uas.h
> > @@ -73,6 +73,13 @@ UNUSUAL_DEV(0x152d, 0x0578, 0x0000, 0x9999,
> >  		USB_SC_DEVICE, USB_PR_DEVICE, NULL,
> >  		US_FL_BROKEN_FUA),
> >  
> > +/* Reported-by: Julian Groß <julian.g@posteo.de> */
> > +UNUSUAL_DEV(0x059f, 0x105f, 0x0000, 0x9999,
> > +		"LaCie",
> > +		"2Big Quadra USB3",
> > +		USB_SC_DEVICE, USB_PR_DEVICE, NULL,
> > +		US_FL_NO_REPORT_OPCODES),
> > +
> 
> Can you please keep these in sorted order by vendor/product id as the
> comment in the file suggests to do so?

Sorry, skipped a position. Resending.

	Regards
		Oliver