All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: idosch@idosch.org
Cc: netdev@vger.kernel.org, bridge@lists.linux-foundation.org,
	kuba@kernel.org, nikolay@cumulusnetworks.com,
	roopa@cumulusnetworks.com, s.priebe@profihost.ag,
	mlxsw@mellanox.com, idosch@mellanox.com
Subject: Re: [PATCH net] net: bridge: vlan: Add a schedule point during VLAN processing
Date: Thu, 30 Apr 2020 17:46:29 -0700 (PDT)	[thread overview]
Message-ID: <20200430.174629.548555772744348705.davem@davemloft.net> (raw)
In-Reply-To: <20200430193845.4087868-1-idosch@idosch.org>

From: Ido Schimmel <idosch@idosch.org>
Date: Thu, 30 Apr 2020 22:38:45 +0300

> From: Ido Schimmel <idosch@mellanox.com>
> 
> User space can request to delete a range of VLANs from a bridge slave in
> one netlink request. For each deleted VLAN the FDB needs to be traversed
> in order to flush all the affected entries.
> 
> If a large range of VLANs is deleted and the number of FDB entries is
> large or the FDB lock is contented, it is possible for the kernel to
> loop through the deleted VLANs for a long time. In case preemption is
> disabled, this can result in a soft lockup.
> 
> Fix this by adding a schedule point after each VLAN is deleted to yield
> the CPU, if needed. This is safe because the VLANs are traversed in
> process context.
> 
> Fixes: bdced7ef7838 ("bridge: support for multiple vlans and vlan ranges in setlink and dellink requests")
> Signed-off-by: Ido Schimmel <idosch@mellanox.com>
> Reported-by: Stefan Priebe - Profihost AG <s.priebe@profihost.ag>
> Tested-by: Stefan Priebe - Profihost AG <s.priebe@profihost.ag>

Applied and queued up for -stable.

WARNING: multiple messages have this Message-ID (diff)
From: David Miller <davem@davemloft.net>
To: idosch@idosch.org
Cc: mlxsw@mellanox.com, s.priebe@profihost.ag,
	nikolay@cumulusnetworks.com, netdev@vger.kernel.org,
	roopa@cumulusnetworks.com, bridge@lists.linux-foundation.org,
	idosch@mellanox.com, kuba@kernel.org
Subject: Re: [Bridge] [PATCH net] net: bridge: vlan: Add a schedule point during VLAN processing
Date: Thu, 30 Apr 2020 17:46:29 -0700 (PDT)	[thread overview]
Message-ID: <20200430.174629.548555772744348705.davem@davemloft.net> (raw)
In-Reply-To: <20200430193845.4087868-1-idosch@idosch.org>

From: Ido Schimmel <idosch@idosch.org>
Date: Thu, 30 Apr 2020 22:38:45 +0300

> From: Ido Schimmel <idosch@mellanox.com>
> 
> User space can request to delete a range of VLANs from a bridge slave in
> one netlink request. For each deleted VLAN the FDB needs to be traversed
> in order to flush all the affected entries.
> 
> If a large range of VLANs is deleted and the number of FDB entries is
> large or the FDB lock is contented, it is possible for the kernel to
> loop through the deleted VLANs for a long time. In case preemption is
> disabled, this can result in a soft lockup.
> 
> Fix this by adding a schedule point after each VLAN is deleted to yield
> the CPU, if needed. This is safe because the VLANs are traversed in
> process context.
> 
> Fixes: bdced7ef7838 ("bridge: support for multiple vlans and vlan ranges in setlink and dellink requests")
> Signed-off-by: Ido Schimmel <idosch@mellanox.com>
> Reported-by: Stefan Priebe - Profihost AG <s.priebe@profihost.ag>
> Tested-by: Stefan Priebe - Profihost AG <s.priebe@profihost.ag>

Applied and queued up for -stable.

  parent reply	other threads:[~2020-05-01  0:46 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-30 19:38 [PATCH net] net: bridge: vlan: Add a schedule point during VLAN processing Ido Schimmel
2020-04-30 19:38 ` [Bridge] " Ido Schimmel
2020-04-30 20:25 ` Nikolay Aleksandrov
2020-04-30 20:25   ` [Bridge] " Nikolay Aleksandrov
2020-05-01  0:46 ` David Miller [this message]
2020-05-01  0:46   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200430.174629.548555772744348705.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=bridge@lists.linux-foundation.org \
    --cc=idosch@idosch.org \
    --cc=idosch@mellanox.com \
    --cc=kuba@kernel.org \
    --cc=mlxsw@mellanox.com \
    --cc=netdev@vger.kernel.org \
    --cc=nikolay@cumulusnetworks.com \
    --cc=roopa@cumulusnetworks.com \
    --cc=s.priebe@profihost.ag \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.