* [PATCH 0/4] drm/amd/display: remove set but not used variables
@ 2020-04-30 3:40 ` Zheng Bin
0 siblings, 0 replies; 12+ messages in thread
From: Zheng Bin @ 2020-04-30 3:40 UTC (permalink / raw)
To: alexander.deucher, harry.wentland, sunpeng.li, airlied, daniel,
amd-gfx, dri-devel
Cc: zhengbin13
Zheng Bin (4):
drm/amd/display: remove set but not used variable 'dc'
drm/amd/display: remove set but not used variable 'pixel_width'
drm/amd/display: remove set but not used variable 'speakers' in
dce_stream_encoder.c
drm/amd/display: remove set but not used variable 'speakers' in
dcn10_stream_encoder.c
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 --
drivers/gpu/drm/amd/display/dc/dce/dce_stream_encoder.c | 2 --
drivers/gpu/drm/amd/display/dc/dcn10/dcn10_dpp.c | 7 -------
.../gpu/drm/amd/display/dc/dcn10/dcn10_stream_encoder.c | 2 --
4 files changed, 13 deletions(-)
--
2.26.0.106.g9fadedd
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 12+ messages in thread* [PATCH 1/4] drm/amd/display: remove set but not used variable 'dc'
2020-04-30 3:40 ` Zheng Bin
@ 2020-04-30 3:40 ` Zheng Bin
-1 siblings, 0 replies; 12+ messages in thread
From: Zheng Bin @ 2020-04-30 3:40 UTC (permalink / raw)
To: alexander.deucher, harry.wentland, sunpeng.li, airlied, daniel,
amd-gfx, dri-devel
Cc: zhengbin13
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c:8665:13: warning: variable ‘dc’ set but not used [-Wunused-but-set-variable]
It is not used since commit d1ebfdd8d0fc ("drm/amd/display:
Unify psr feature flags")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zheng Bin <zhengbin13@huawei.com>
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
index 98f39db81c7b..8e46524e67a9 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
@@ -8662,14 +8662,12 @@ static bool amdgpu_dm_link_setup_psr(struct dc_stream_state *stream)
struct dc_link *link = NULL;
struct psr_config psr_config = {0};
struct psr_context psr_context = {0};
- struct dc *dc = NULL;
bool ret = false;
if (stream == NULL)
return false;
link = stream->link;
- dc = link->ctx->dc;
psr_config.psr_version = link->dpcd_caps.psr_caps.psr_version;
--
2.26.0.106.g9fadedd
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 12+ messages in thread* [PATCH 1/4] drm/amd/display: remove set but not used variable 'dc'
@ 2020-04-30 3:40 ` Zheng Bin
0 siblings, 0 replies; 12+ messages in thread
From: Zheng Bin @ 2020-04-30 3:40 UTC (permalink / raw)
To: alexander.deucher, harry.wentland, sunpeng.li, airlied, daniel,
amd-gfx, dri-devel
Cc: zhengbin13
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c:8665:13: warning: variable ‘dc’ set but not used [-Wunused-but-set-variable]
It is not used since commit d1ebfdd8d0fc ("drm/amd/display:
Unify psr feature flags")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zheng Bin <zhengbin13@huawei.com>
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
index 98f39db81c7b..8e46524e67a9 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
@@ -8662,14 +8662,12 @@ static bool amdgpu_dm_link_setup_psr(struct dc_stream_state *stream)
struct dc_link *link = NULL;
struct psr_config psr_config = {0};
struct psr_context psr_context = {0};
- struct dc *dc = NULL;
bool ret = false;
if (stream == NULL)
return false;
link = stream->link;
- dc = link->ctx->dc;
psr_config.psr_version = link->dpcd_caps.psr_caps.psr_version;
--
2.26.0.106.g9fadedd
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH 2/4] drm/amd/display: remove set but not used variable 'pixel_width'
2020-04-30 3:40 ` Zheng Bin
@ 2020-04-30 3:40 ` Zheng Bin
-1 siblings, 0 replies; 12+ messages in thread
From: Zheng Bin @ 2020-04-30 3:40 UTC (permalink / raw)
To: alexander.deucher, harry.wentland, sunpeng.li, airlied, daniel,
amd-gfx, dri-devel
Cc: zhengbin13
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/gpu/drm/amd/display/dc/dcn10/dcn10_dpp.c:137:11: warning: variable ‘pixel_width’ set but not used [-Wunused-but-set-variable]
It is introduced by commit 70ccab604049 ("drm/amdgpu/display:
Add core dc support for DCN"), but never used, so remove it.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zheng Bin <zhengbin13@huawei.com>
---
drivers/gpu/drm/amd/display/dc/dcn10/dcn10_dpp.c | 7 -------
1 file changed, 7 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_dpp.c b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_dpp.c
index 0e682b5aa3eb..7f8456b9988b 100644
--- a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_dpp.c
+++ b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_dpp.c
@@ -134,13 +134,6 @@ bool dpp1_get_optimal_number_of_taps(
struct scaler_data *scl_data,
const struct scaling_taps *in_taps)
{
- uint32_t pixel_width;
-
- if (scl_data->viewport.width > scl_data->recout.width)
- pixel_width = scl_data->recout.width;
- else
- pixel_width = scl_data->viewport.width;
-
/* Some ASICs does not support FP16 scaling, so we reject modes require this*/
if (scl_data->format == PIXEL_FORMAT_FP16 &&
dpp->caps->dscl_data_proc_format == DSCL_DATA_PRCESSING_FIXED_FORMAT &&
--
2.26.0.106.g9fadedd
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 12+ messages in thread* [PATCH 2/4] drm/amd/display: remove set but not used variable 'pixel_width'
@ 2020-04-30 3:40 ` Zheng Bin
0 siblings, 0 replies; 12+ messages in thread
From: Zheng Bin @ 2020-04-30 3:40 UTC (permalink / raw)
To: alexander.deucher, harry.wentland, sunpeng.li, airlied, daniel,
amd-gfx, dri-devel
Cc: zhengbin13
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/gpu/drm/amd/display/dc/dcn10/dcn10_dpp.c:137:11: warning: variable ‘pixel_width’ set but not used [-Wunused-but-set-variable]
It is introduced by commit 70ccab604049 ("drm/amdgpu/display:
Add core dc support for DCN"), but never used, so remove it.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zheng Bin <zhengbin13@huawei.com>
---
drivers/gpu/drm/amd/display/dc/dcn10/dcn10_dpp.c | 7 -------
1 file changed, 7 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_dpp.c b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_dpp.c
index 0e682b5aa3eb..7f8456b9988b 100644
--- a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_dpp.c
+++ b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_dpp.c
@@ -134,13 +134,6 @@ bool dpp1_get_optimal_number_of_taps(
struct scaler_data *scl_data,
const struct scaling_taps *in_taps)
{
- uint32_t pixel_width;
-
- if (scl_data->viewport.width > scl_data->recout.width)
- pixel_width = scl_data->recout.width;
- else
- pixel_width = scl_data->viewport.width;
-
/* Some ASICs does not support FP16 scaling, so we reject modes require this*/
if (scl_data->format == PIXEL_FORMAT_FP16 &&
dpp->caps->dscl_data_proc_format == DSCL_DATA_PRCESSING_FIXED_FORMAT &&
--
2.26.0.106.g9fadedd
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH 3/4] drm/amd/display: remove set but not used variable 'speakers' in dce_stream_encoder.c
2020-04-30 3:40 ` Zheng Bin
@ 2020-04-30 3:40 ` Zheng Bin
-1 siblings, 0 replies; 12+ messages in thread
From: Zheng Bin @ 2020-04-30 3:40 UTC (permalink / raw)
To: alexander.deucher, harry.wentland, sunpeng.li, airlied, daniel,
amd-gfx, dri-devel
Cc: zhengbin13
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/gpu/drm/amd/display/dc/dce/dce_stream_encoder.c:1339:11: warning: variable ‘speakers’ set but not used [-Wunused-but-set-variable]
It is introduced by commit 4562236b3bc0 ("drm/amd/dc:
Add dc display driver (v2)"), but never used, so remove it.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zheng Bin <zhengbin13@huawei.com>
---
drivers/gpu/drm/amd/display/dc/dce/dce_stream_encoder.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/dc/dce/dce_stream_encoder.c b/drivers/gpu/drm/amd/display/dc/dce/dce_stream_encoder.c
index 451574971b96..4cdaaf4d881c 100644
--- a/drivers/gpu/drm/amd/display/dc/dce/dce_stream_encoder.c
+++ b/drivers/gpu/drm/amd/display/dc/dce/dce_stream_encoder.c
@@ -1336,7 +1336,6 @@ static void dce110_se_audio_setup(
{
struct dce110_stream_encoder *enc110 = DCE110STRENC_FROM_STRENC(enc);
- uint32_t speakers = 0;
uint32_t channels = 0;
ASSERT(audio_info);
@@ -1344,7 +1343,6 @@ static void dce110_se_audio_setup(
/* This should not happen.it does so we don't get BSOD*/
return;
- speakers = audio_info->flags.info.ALLSPEAKERS;
channels = speakers_to_channels(audio_info->flags.speaker_flags).all;
/* setup the audio stream source select (audio -> dig mapping) */
--
2.26.0.106.g9fadedd
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 12+ messages in thread* [PATCH 3/4] drm/amd/display: remove set but not used variable 'speakers' in dce_stream_encoder.c
@ 2020-04-30 3:40 ` Zheng Bin
0 siblings, 0 replies; 12+ messages in thread
From: Zheng Bin @ 2020-04-30 3:40 UTC (permalink / raw)
To: alexander.deucher, harry.wentland, sunpeng.li, airlied, daniel,
amd-gfx, dri-devel
Cc: zhengbin13
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/gpu/drm/amd/display/dc/dce/dce_stream_encoder.c:1339:11: warning: variable ‘speakers’ set but not used [-Wunused-but-set-variable]
It is introduced by commit 4562236b3bc0 ("drm/amd/dc:
Add dc display driver (v2)"), but never used, so remove it.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zheng Bin <zhengbin13@huawei.com>
---
drivers/gpu/drm/amd/display/dc/dce/dce_stream_encoder.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/dc/dce/dce_stream_encoder.c b/drivers/gpu/drm/amd/display/dc/dce/dce_stream_encoder.c
index 451574971b96..4cdaaf4d881c 100644
--- a/drivers/gpu/drm/amd/display/dc/dce/dce_stream_encoder.c
+++ b/drivers/gpu/drm/amd/display/dc/dce/dce_stream_encoder.c
@@ -1336,7 +1336,6 @@ static void dce110_se_audio_setup(
{
struct dce110_stream_encoder *enc110 = DCE110STRENC_FROM_STRENC(enc);
- uint32_t speakers = 0;
uint32_t channels = 0;
ASSERT(audio_info);
@@ -1344,7 +1343,6 @@ static void dce110_se_audio_setup(
/* This should not happen.it does so we don't get BSOD*/
return;
- speakers = audio_info->flags.info.ALLSPEAKERS;
channels = speakers_to_channels(audio_info->flags.speaker_flags).all;
/* setup the audio stream source select (audio -> dig mapping) */
--
2.26.0.106.g9fadedd
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH 4/4] drm/amd/display: remove set but not used variable 'speakers' in dcn10_stream_encoder.c
2020-04-30 3:40 ` Zheng Bin
@ 2020-04-30 3:40 ` Zheng Bin
-1 siblings, 0 replies; 12+ messages in thread
From: Zheng Bin @ 2020-04-30 3:40 UTC (permalink / raw)
To: alexander.deucher, harry.wentland, sunpeng.li, airlied, daniel,
amd-gfx, dri-devel
Cc: zhengbin13
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/gpu/drm/amd/display/dc/dcn10/dcn10_stream_encoder.c:1277:11: warning: variable ‘speakers’ set but not used [-Wunused-but-set-variable]
It is introduced by commit 0c41891c81c0 ("drm/amd/display:
Refactor stream encoder for HW review"), but never used, so remove it.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zheng Bin <zhengbin13@huawei.com>
---
drivers/gpu/drm/amd/display/dc/dcn10/dcn10_stream_encoder.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_stream_encoder.c b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_stream_encoder.c
index 7eba9333c328..07b2f9399671 100644
--- a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_stream_encoder.c
+++ b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_stream_encoder.c
@@ -1274,7 +1274,6 @@ static void enc1_se_audio_setup(
{
struct dcn10_stream_encoder *enc1 = DCN10STRENC_FROM_STRENC(enc);
- uint32_t speakers = 0;
uint32_t channels = 0;
ASSERT(audio_info);
@@ -1282,7 +1281,6 @@ static void enc1_se_audio_setup(
/* This should not happen.it does so we don't get BSOD*/
return;
- speakers = audio_info->flags.info.ALLSPEAKERS;
channels = speakers_to_channels(audio_info->flags.speaker_flags).all;
/* setup the audio stream source select (audio -> dig mapping) */
--
2.26.0.106.g9fadedd
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 12+ messages in thread* [PATCH 4/4] drm/amd/display: remove set but not used variable 'speakers' in dcn10_stream_encoder.c
@ 2020-04-30 3:40 ` Zheng Bin
0 siblings, 0 replies; 12+ messages in thread
From: Zheng Bin @ 2020-04-30 3:40 UTC (permalink / raw)
To: alexander.deucher, harry.wentland, sunpeng.li, airlied, daniel,
amd-gfx, dri-devel
Cc: zhengbin13
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/gpu/drm/amd/display/dc/dcn10/dcn10_stream_encoder.c:1277:11: warning: variable ‘speakers’ set but not used [-Wunused-but-set-variable]
It is introduced by commit 0c41891c81c0 ("drm/amd/display:
Refactor stream encoder for HW review"), but never used, so remove it.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zheng Bin <zhengbin13@huawei.com>
---
drivers/gpu/drm/amd/display/dc/dcn10/dcn10_stream_encoder.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_stream_encoder.c b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_stream_encoder.c
index 7eba9333c328..07b2f9399671 100644
--- a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_stream_encoder.c
+++ b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_stream_encoder.c
@@ -1274,7 +1274,6 @@ static void enc1_se_audio_setup(
{
struct dcn10_stream_encoder *enc1 = DCN10STRENC_FROM_STRENC(enc);
- uint32_t speakers = 0;
uint32_t channels = 0;
ASSERT(audio_info);
@@ -1282,7 +1281,6 @@ static void enc1_se_audio_setup(
/* This should not happen.it does so we don't get BSOD*/
return;
- speakers = audio_info->flags.info.ALLSPEAKERS;
channels = speakers_to_channels(audio_info->flags.speaker_flags).all;
/* setup the audio stream source select (audio -> dig mapping) */
--
2.26.0.106.g9fadedd
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH 0/4] drm/amd/display: remove set but not used variables
2020-04-30 3:40 ` Zheng Bin
@ 2020-04-30 16:23 ` Alex Deucher
-1 siblings, 0 replies; 12+ messages in thread
From: Alex Deucher @ 2020-04-30 16:23 UTC (permalink / raw)
To: Zheng Bin
Cc: Leo (Sunpeng) Li, amd-gfx list, Dave Airlie,
Maling list - DRI developers, Deucher, Alexander
Applied. Thanks!
Alex
On Thu, Apr 30, 2020 at 3:32 AM Zheng Bin <zhengbin13@huawei.com> wrote:
>
> Zheng Bin (4):
> drm/amd/display: remove set but not used variable 'dc'
> drm/amd/display: remove set but not used variable 'pixel_width'
> drm/amd/display: remove set but not used variable 'speakers' in
> dce_stream_encoder.c
> drm/amd/display: remove set but not used variable 'speakers' in
> dcn10_stream_encoder.c
>
> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 --
> drivers/gpu/drm/amd/display/dc/dce/dce_stream_encoder.c | 2 --
> drivers/gpu/drm/amd/display/dc/dcn10/dcn10_dpp.c | 7 -------
> .../gpu/drm/amd/display/dc/dcn10/dcn10_stream_encoder.c | 2 --
> 4 files changed, 13 deletions(-)
>
> --
> 2.26.0.106.g9fadedd
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 0/4] drm/amd/display: remove set but not used variables
@ 2020-04-30 16:23 ` Alex Deucher
0 siblings, 0 replies; 12+ messages in thread
From: Alex Deucher @ 2020-04-30 16:23 UTC (permalink / raw)
To: Zheng Bin
Cc: Leo (Sunpeng) Li, amd-gfx list, Dave Airlie,
Maling list - DRI developers, Daniel Vetter, Deucher, Alexander,
Wentland, Harry
Applied. Thanks!
Alex
On Thu, Apr 30, 2020 at 3:32 AM Zheng Bin <zhengbin13@huawei.com> wrote:
>
> Zheng Bin (4):
> drm/amd/display: remove set but not used variable 'dc'
> drm/amd/display: remove set but not used variable 'pixel_width'
> drm/amd/display: remove set but not used variable 'speakers' in
> dce_stream_encoder.c
> drm/amd/display: remove set but not used variable 'speakers' in
> dcn10_stream_encoder.c
>
> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 --
> drivers/gpu/drm/amd/display/dc/dce/dce_stream_encoder.c | 2 --
> drivers/gpu/drm/amd/display/dc/dcn10/dcn10_dpp.c | 7 -------
> .../gpu/drm/amd/display/dc/dcn10/dcn10_stream_encoder.c | 2 --
> 4 files changed, 13 deletions(-)
>
> --
> 2.26.0.106.g9fadedd
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 12+ messages in thread